47564 2010-10-12 17:24:34 -0700 AX: accessibilityIsIgnored not respected on ARIA tables 2011-03-30 09:04:37 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cfleizach cfleizach bdakin hayato mario oldest_to_newest 293214 0 cfleizach 2010-10-12 17:24:34 -0700 If you have an ARIA table, but your platform doesn't want to include column headers, there you're out of luck right now AccessibilityTable.cpp filters out those elements, but AccessibilityARIAGrid.cpp does not. This affects GTK and iOS 293702 1 70658 cfleizach 2010-10-13 14:09:07 -0700 Created attachment 70658 patch 293782 2 cfleizach 2010-10-13 15:53:55 -0700 http://trac.webkit.org/changeset/69707 293804 3 cfleizach 2010-10-13 16:29:23 -0700 So it looks like GTK has erroneous code which is causing the results from the layout test to not be what should be there. i will file a bug 293809 4 cfleizach 2010-10-13 16:32:47 -0700 Filed https://bugs.webkit.org/show_bug.cgi?id=47636 to look into this 294013 5 hayato 2010-10-14 01:43:40 -0700 It seems that http://trac.webkit.org/changeset/69707 contains a test that doesn't have an expected result. Therefore I've added that test to a gtk's 'Skipped' file as in http://trac.webkit.org/changeset/69751 to fix a build. 294039 6 hayato 2010-10-14 04:05:51 -0700 The previous patch lacked 'platform/gtk' prefix. I landed another patch: http://trac.webkit.org/changeset/69756. 294086 7 hayato 2010-10-14 06:46:56 -0700 It seems buildbots still complains about that test. I am not sure how to skip platform/gtk/accessibility/aria-table-hierarchy.html. I think it might be better to add an expected text rather than skipping that. (In reply to comment #6) > The previous patch lacked 'platform/gtk' prefix. > I landed another patch: http://trac.webkit.org/changeset/69756. 294147 8 cfleizach 2010-10-14 09:17:06 -0700 it should be pretty straight forward to add a skipped test. i was hoping GTK folks would fix the bug, then we could generate the right results and move on. still haven't heard any response on the bug i filed for them, so i'll add this to the skip list 376370 9 mario 2011-03-30 09:04:37 -0700 The patch and the test looks ok to me but it seems there's another bug in GTK that is preventing the (now skipped) test from passing, and it's that the ARIA table declares not to have any children: PASS table1.role is 'AXRole: table' FAIL table1.rowCount should be 1. Was 0. FAIL table1.columnCount should be 2. Was 0. PASS table2.role is 'AXRole: table' FAIL table2.rowCount should be 3. Was 0. FAIL table2.columnCount should be 2. Was 0. PASS table3.role is 'AXRole: table' FAIL table3.rowCount should be 1. Was 0. FAIL table3.columnCount should be 2. Was 0. PASS table4.role is 'AXRole: table' FAIL table4.rowCount should be 3. Was 0. FAIL table4.columnCount should be 2. Was 0. FAIL children should be 2. Was 0. FAIL children should be 6. Was 0. FAIL children should be 2. Was 0. FAIL children should be 6. Was 0. PASS successfullyParsed is true Looks like theres another bug then, will file it rightaway... 70658 2010-10-13 14:09:07 -0700 2010-10-13 14:55:23 -0700 patch p.txt text/plain 4890 cfleizach SW5kZXg6IFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5QVJJQUdyaWQuY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5QVJJQUdyaWQu Y3BwCShyZXZpc2lvbiA2OTUwOSkKKysrIFdlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmls aXR5QVJJQUdyaWQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTgsMTEgKzExOCwxMiBAQCB2b2lk IEFjY2Vzc2liaWxpdHlBUklBR3JpZDo6YWRkQ2hpbGRyZW4oCiAgICAgICAgIGNvbHVtbi0+c2V0 Q29sdW1uSW5kZXgoKGludClpKTsKICAgICAgICAgY29sdW1uLT5zZXRQYXJlbnRUYWJsZSh0aGlz KTsKICAgICAgICAgbV9jb2x1bW5zLmFwcGVuZChjb2x1bW4pOwotICAgICAgICBtX2NoaWxkcmVu LmFwcGVuZChjb2x1bW4pOworICAgICAgICBpZiAoIWNvbHVtbi0+YWNjZXNzaWJpbGl0eUlzSWdu b3JlZCgpKQorICAgICAgICAgICAgbV9jaGlsZHJlbi5hcHBlbmQoY29sdW1uKTsKICAgICB9CiAg ICAgCiAgICAgQWNjZXNzaWJpbGl0eU9iamVjdCogaGVhZGVyQ29udGFpbmVyT2JqZWN0ID0gaGVh ZGVyQ29udGFpbmVyKCk7Ci0gICAgaWYgKGhlYWRlckNvbnRhaW5lck9iamVjdCkKKyAgICBpZiAo aGVhZGVyQ29udGFpbmVyT2JqZWN0ICYmICFoZWFkZXJDb250YWluZXJPYmplY3QtPmFjY2Vzc2li aWxpdHlJc0lnbm9yZWQoKSkKICAgICAgICAgbV9jaGlsZHJlbi5hcHBlbmQoaGVhZGVyQ29udGFp bmVyT2JqZWN0KTsKIH0KICAgICAKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDY5Njk2KQorKysgTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAt MTMgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBWDogYWNjZXNzaWJpbGl0eUlzSWdu b3JlZCBub3QgcmVzcGVjdGVkIG9uIEFSSUEgdGFibGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzU2NAorCisgICAgICAgICogcGxhdGZvcm0vZ3Rr L2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS1oaWVyYXJjaHkuaHRtbDogQWRkZWQuCisKIDIwMTAt MTAtMTMgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJ1YmJl ci1zdGFtcGVkIGJ5IENzYWJhIE9zenRyb2dvbmFjLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZv cm0vZ3RrL2FjY2Vzc2liaWxpdHkvYXJpYS10YWJsZS1oaWVyYXJjaHkuaHRtbAo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvYWNjZXNzaWJpbGl0eS9hcmlhLXRhYmxlLWhp ZXJhcmNoeS5odG1sCShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL2Fj Y2Vzc2liaWxpdHkvYXJpYS10YWJsZS1oaWVyYXJjaHkuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAs MCArMSw3OCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQgSFRNTC8vRU4i PgorPGh0bWw+Cis8aGVhZD4KKzxsaW5rIHJlbD0ic3R5bGVzaGVldCIgaHJlZj0iLi4vZmFzdC9q cy9yZXNvdXJjZXMvanMtdGVzdC1zdHlsZS5jc3MiPgorPHNjcmlwdD4KK3ZhciBzdWNjZXNzZnVs bHlQYXJzZWQgPSBmYWxzZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uLy4uLy4uL2Zhc3Qv anMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5IGlk PSJib2R5Ij4KKzxkaXYgcm9sZT0iZ3JpZCI+Cis8ZGl2IHJvbGU9InJvdyI+PGRpdiByb2xlPSJn cmlkY2VsbCI+Zm9vPC9kaXY+PGRpdiByb2xlPSJncmlkY2VsbCI+YmFyPC9kaXY+PC9kaXY+Cis8 L2Rpdj4KKzxkaXYgcm9sZT0iZ3JpZCI+Cis8ZGl2IHJvbGU9InJvdyI+PGRpdiByb2xlPSJjb2x1 bW5oZWFkZXIiPk9kZDwvZGl2PjxkaXYgcm9sZT0iY29sdW1uaGVhZGVyIj5FdmVuPC9kaXY+PC9k aXY+Cis8ZGl2IHJvbGU9InJvdyI+PGRpdiByb2xlPSJncmlkY2VsbCI+MTwvZGl2PjxkaXYgcm9s ZT0iZ3JpZGNlbGwiPjI8L2Rpdj48L2Rpdj4KKzxkaXYgcm9sZT0icm93Ij48ZGl2IHJvbGU9Imdy aWRjZWxsIj4zPC9kaXY+PGRpdiByb2xlPSJncmlkY2VsbCI+NDwvZGl2PjwvZGl2PgorPC9kaXY+ Cis8ZGl2IHJvbGU9ImdyaWQiPgorPGRpdiByb2xlPSJyb3ciPjxkaXYgcm9sZT0iZ3JpZGNlbGwi PmhlbGxvPC9kaXY+PGRpdiByb2xlPSJncmlkY2VsbCI+d29ybGQ8L2Rpdj48L2Rpdj4KKzwvZGl2 PgorPGRpdiByb2xlPSJncmlkIj4KKzxkaXYgcm9sZT0icm93Ij48ZGl2IHJvbGU9ImNvbHVtbmhl YWRlciI+T2RkPC9kaXY+PGRpdiByb2xlPSJjb2x1bW5oZWFkZXIiPkV2ZW48L2Rpdj48L2Rpdj4K KzxkaXYgcm9sZT0icm93Ij48ZGl2IHJvbGU9ImdyaWRjZWxsIj48cD4xPC9wPjwvZGl2PjxkaXYg cm9sZT0iZ3JpZGNlbGwiPjxwPjI8L3A+PC9kaXY+PC9kaXY+Cis8ZGl2IHJvbGU9InJvdyI+PGRp diByb2xlPSJncmlkY2VsbCI+PHA+MzwvcD48L2Rpdj48ZGl2IHJvbGU9ImdyaWRjZWxsIj48cD40 PC9wPjwvZGl2PjwvZGl2PgorPC9kaXY+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwvcD4KKzxkaXYg aWQ9ImNvbnNvbGUiPjwvZGl2PgorPHNjcmlwdD4KKyAgICBkZXNjcmlwdGlvbigiVGhpcyB0ZXN0 cyB0aGUgQXRrIHRhYmxlIGhpZXJhcmh5IGZvciBhbiBBUklBIHRhYmxlLiIpOworICAgIGlmICh3 aW5kb3cuYWNjZXNzaWJpbGl0eUNvbnRyb2xsZXIpIHsKKyAgICAgICAgbGF5b3V0VGVzdENvbnRy b2xsZXIuZHVtcEFzVGV4dCgpOworICAgICAgICBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgiYm9k eSIpLmZvY3VzKCk7CisgICAgICAgIHZhciB3ZWJBcmVhID0gYWNjZXNzaWJpbGl0eUNvbnRyb2xs ZXIuZm9jdXNlZEVsZW1lbnQ7CisKKyAgICAgICAgdmFyIHRhYmxlMSA9IHdlYkFyZWEuY2hpbGRB dEluZGV4KDApOworICAgICAgICBzaG91bGRCZSgidGFibGUxLnJvbGUiLCAiJ0FYUm9sZTogdGFi bGUnIik7CisgICAgICAgIHNob3VsZEJlKCJ0YWJsZTEucm93Q291bnQiLCAiMSIpOworICAgICAg ICBzaG91bGRCZSgidGFibGUxLmNvbHVtbkNvdW50IiwgIjIiKTsKKyAgICAgICAgdmFyIHRhYmxl MiA9IHdlYkFyZWEuY2hpbGRBdEluZGV4KDEpOworICAgICAgICBzaG91bGRCZSgidGFibGUyLnJv bGUiLCAiJ0FYUm9sZTogdGFibGUnIik7CisgICAgICAgIHNob3VsZEJlKCJ0YWJsZTIucm93Q291 bnQiLCAiMyIpOworICAgICAgICBzaG91bGRCZSgidGFibGUyLmNvbHVtbkNvdW50IiwgIjIiKTsK KyAgICAgICAgdmFyIHRhYmxlMyA9IHdlYkFyZWEuY2hpbGRBdEluZGV4KDIpOworICAgICAgICBz aG91bGRCZSgidGFibGUzLnJvbGUiLCAiJ0FYUm9sZTogdGFibGUnIik7CisgICAgICAgIHNob3Vs ZEJlKCJ0YWJsZTMucm93Q291bnQiLCAiMSIpOworICAgICAgICBzaG91bGRCZSgidGFibGUzLmNv bHVtbkNvdW50IiwgIjIiKTsKKyAgICAgICAgdmFyIHRhYmxlNCA9IHdlYkFyZWEuY2hpbGRBdElu ZGV4KDMpOworICAgICAgICBzaG91bGRCZSgidGFibGU0LnJvbGUiLCAiJ0FYUm9sZTogdGFibGUn Iik7CisgICAgICAgIHNob3VsZEJlKCJ0YWJsZTQucm93Q291bnQiLCAiMyIpOworICAgICAgICBz aG91bGRCZSgidGFibGU0LmNvbHVtbkNvdW50IiwgIjIiKTsKKworICAgICAgICB2YXIgY2hpbGRy ZW4gPSB0YWJsZTEuY2hpbGRyZW5Db3VudDsKKyAgICAgICAgc2hvdWxkQmUoImNoaWxkcmVuIiwg IjIiKTsKKyAgICAgICAgZm9yIChpID0gMDsgaSA8IGNoaWxkcmVuOyArK2kpIHsKKyAgICAgICAg ICAgIHNob3VsZEJlKCJ0YWJsZTEuY2hpbGRBdEluZGV4KGkpLnJvbGUiLCAiJ0FYUm9sZTogdGFi bGUgY2VsbCciKTsKKyAgICAgICAgfQorICAgICAgICBjaGlsZHJlbiA9IHRhYmxlMi5jaGlsZHJl bkNvdW50OworICAgICAgICBzaG91bGRCZSgiY2hpbGRyZW4iLCAiNiIpOworICAgICAgICBmb3Ig KGkgPSAwOyBpIDwgY2hpbGRyZW47ICsraSkgeworICAgICAgICAgICAgc2hvdWxkQmUoInRhYmxl Mi5jaGlsZEF0SW5kZXgoaSkucm9sZSIsICInQVhSb2xlOiB0YWJsZSBjZWxsJyIpOworICAgICAg ICB9CisgICAgICAgIGNoaWxkcmVuID0gdGFibGUzLmNoaWxkcmVuQ291bnQ7CisgICAgICAgIHNo b3VsZEJlKCJjaGlsZHJlbiIsICIyIik7CisgICAgICAgIGZvciAoaSA9IDA7IGkgPCBjaGlsZHJl bjsgKytpKSB7CisgICAgICAgICAgICBzaG91bGRCZSgidGFibGUzLmNoaWxkQXRJbmRleChpKS5y b2xlIiwgIidBWFJvbGU6IHRhYmxlIGNlbGwnIik7CisgICAgICAgIH0KKyAgICAgICAgY2hpbGRy ZW4gPSB0YWJsZTQuY2hpbGRyZW5Db3VudDsKKyAgICAgICAgc2hvdWxkQmUoImNoaWxkcmVuIiwg IjYiKTsKKyAgICAgICAgZm9yIChpID0gMDsgaSA8IGNoaWxkcmVuOyArK2kpIHsKKyAgICAgICAg ICAgIHNob3VsZEJlKCJ0YWJsZTQuY2hpbGRBdEluZGV4KGkpLnJvbGUiLCAiJ0FYUm9sZTogdGFi bGUgY2VsbCciKTsKKyAgICAgICAgfQorICAgIH0KKyAgICBzdWNjZXNzZnVsbHlQYXJzZWQgPSB0 cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vZmFzdC9qcy9yZXNvdXJjZXMv anMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKzwvYm9keT4KKzwvaHRtbD4K