47563 2010-10-12 17:24:31 -0700 Pass platform path (rather than virtual path) when creating File from FileEntry 2010-10-12 19:27:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 kinuko webkit-unassigned ericu jianli oldest_to_newest 293213 0 kinuko 2010-10-12 17:24:31 -0700 Pass platform path (irather than virtual path) when creating File from FileEntry. 293218 1 70575 kinuko 2010-10-12 17:39:51 -0700 Created attachment 70575 Patch 293223 2 70576 kinuko 2010-10-12 17:45:50 -0700 Created attachment 70576 Patch Sorry I sent an wrong one. 293230 3 70576 ericu 2010-10-12 17:56:31 -0700 Comment on attachment 70576 Patch LGTM. 293232 4 jianli 2010-10-12 18:02:49 -0700 One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h. 293242 5 kinuko 2010-10-12 18:40:43 -0700 (In reply to comment #4) > One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h. Thanks, I'll make a separate patch to rename all. 293247 6 kinuko 2010-10-12 18:59:44 -0700 (In reply to comment #5) > (In reply to comment #4) > > One suggestion. Consider renaming m_fullPath in EntryBase to m_virtualPath or m_fullVirtualPath to improve reability and avoid future mistake. Or at least you can add the comment in EntryBase.h. > > Thanks, I'll make a separate patch to rename all. Hmm, on the second thought m_fullPath was named after FileEntry.fullPath attribute. I'm going to put the comment to indicate it's virtual path. 293250 7 kinuko 2010-10-12 19:27:04 -0700 Committed r69634: <http://trac.webkit.org/changeset/69634> 70575 2010-10-12 17:39:51 -0700 2010-10-12 17:45:47 -0700 Patch bug-47563-20101012173949.patch text/plain 1334 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWQwNWJlMmVmNjJkZTMxNWZjNWE1YTBlNDU2M2Q2MGMzNzg3YTgxMi4uYTdiMThmOWEyMjQxNWUx NDQ3MDBiNTg2MTdhNzI4M2MxZGU5ODE3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0xMiAgS2lu dWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFzcyBwbGF0Zm9ybSBwYXRoIChyYXRoZXIgdGhh biB2aXJ0dWFsIHBhdGgpIHdoZW4gY3JlYXRpbmcgRmlsZSBmcm9tIEZpbGVFbnRyeQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc1NjMKKworICAgICAg ICBObyBuZXcgdGVzdHMsIHRoZSBuZXcgdGVzdCBmb3IgRmlsZVdyaXRlciB3aWxsIGJlIHZlcmlm eWluZyB0aGlzLgorCisgICAgICAgICogZmlsZWFwaS9GaWxlRW50cnkuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RmlsZUVudHJ5OjpmaWxlKToKKwogMjAxMC0xMC0xMiAgQ2hyaXMgTWFycmluICA8 Y21hcnJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2ZpbGVhcGkvRmlsZUVudHJ5LmNwcCBiL1dlYkNvcmUvZmlsZWFw aS9GaWxlRW50cnkuY3BwCmluZGV4IGM3NDc4ZmJlMDFjZDU3YzViYmFlNGM3MWZhZTM2MzAzZDM1 YWQ2OTguLjgzMTgzNmY4OGVjYzI3NzFhNjQzZDY4NDk4NDkxNWY5ODEyZjgyNWIgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvZmlsZWFwaS9GaWxlRW50cnkuY3BwCisrKyBiL1dlYkNvcmUvZmlsZWFwaS9G aWxlRW50cnkuY3BwCkBAIC01Myw3ICs1Myw3IEBAIHZvaWQgRmlsZUVudHJ5OjpjcmVhdGVXcml0 ZXIoUGFzc1JlZlB0cjxGaWxlV3JpdGVyQ2FsbGJhY2s+IHN1Y2Nlc3NDYWxsYmFjaywgUGFzCiAK IHZvaWQgRmlsZUVudHJ5OjpmaWxlKFBhc3NSZWZQdHI8RmlsZUNhbGxiYWNrPiBzdWNjZXNzQ2Fs bGJhY2ssIFBhc3NSZWZQdHI8RXJyb3JDYWxsYmFjaz4pCiB7Ci0gICAgZmlsZXN5c3RlbSgpLT5z Y2hlZHVsZUNhbGxiYWNrKHN1Y2Nlc3NDYWxsYmFjaywgRmlsZTo6Y3JlYXRlKG1fZnVsbFBhdGgp KTsKKyAgICBmaWxlc3lzdGVtKCktPnNjaGVkdWxlQ2FsbGJhY2soc3VjY2Vzc0NhbGxiYWNrLCBG aWxlOjpjcmVhdGUoZmlsZXN5c3RlbSgpLT5hc3luY0ZpbGVTeXN0ZW0oKS0+bV9mdWxsUGF0aCkp OwogfQogCiB9IC8vIG5hbWVzcGFjZQo= 70576 2010-10-12 17:45:50 -0700 2010-10-12 17:58:17 -0700 Patch bug-47563-20101012174548.patch text/plain 1357 kinuko ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YWQwNWJlMmVmNjJkZTMxNWZjNWE1YTBlNDU2M2Q2MGMzNzg3YTgxMi4uYTdiMThmOWEyMjQxNWUx NDQ3MDBiNTg2MTdhNzI4M2MxZGU5ODE3ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0xMiAgS2lu dWtvIFlhc3VkYSAgPGtpbnVrb0BjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFzcyBwbGF0Zm9ybSBwYXRoIChyYXRoZXIgdGhh biB2aXJ0dWFsIHBhdGgpIHdoZW4gY3JlYXRpbmcgRmlsZSBmcm9tIEZpbGVFbnRyeQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc1NjMKKworICAgICAg ICBObyBuZXcgdGVzdHMsIHRoZSBuZXcgdGVzdCBmb3IgRmlsZVdyaXRlciB3aWxsIGJlIHZlcmlm eWluZyB0aGlzLgorCisgICAgICAgICogZmlsZWFwaS9GaWxlRW50cnkuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RmlsZUVudHJ5OjpmaWxlKToKKwogMjAxMC0xMC0xMiAgQ2hyaXMgTWFycmluICA8 Y21hcnJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2ZpbGVhcGkvRmlsZUVudHJ5LmNwcCBiL1dlYkNvcmUvZmlsZWFw aS9GaWxlRW50cnkuY3BwCmluZGV4IGM3NDc4ZmJlMDFjZDU3YzViYmFlNGM3MWZhZTM2MzAzZDM1 YWQ2OTguLjgwYWUwZDBhMWZiM2RjOWE1YjdhZjc1ZDk1OWE3NTE1MzdlMjUyMjQgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvZmlsZWFwaS9GaWxlRW50cnkuY3BwCisrKyBiL1dlYkNvcmUvZmlsZWFwaS9G aWxlRW50cnkuY3BwCkBAIC01Myw3ICs1Myw3IEBAIHZvaWQgRmlsZUVudHJ5OjpjcmVhdGVXcml0 ZXIoUGFzc1JlZlB0cjxGaWxlV3JpdGVyQ2FsbGJhY2s+IHN1Y2Nlc3NDYWxsYmFjaywgUGFzCiAK IHZvaWQgRmlsZUVudHJ5OjpmaWxlKFBhc3NSZWZQdHI8RmlsZUNhbGxiYWNrPiBzdWNjZXNzQ2Fs bGJhY2ssIFBhc3NSZWZQdHI8RXJyb3JDYWxsYmFjaz4pCiB7Ci0gICAgZmlsZXN5c3RlbSgpLT5z Y2hlZHVsZUNhbGxiYWNrKHN1Y2Nlc3NDYWxsYmFjaywgRmlsZTo6Y3JlYXRlKG1fZnVsbFBhdGgp KTsKKyAgICBmaWxlc3lzdGVtKCktPnNjaGVkdWxlQ2FsbGJhY2soc3VjY2Vzc0NhbGxiYWNrLCBG aWxlOjpjcmVhdGUoZmlsZXN5c3RlbSgpLT5hc3luY0ZpbGVTeXN0ZW0oKS0+dmlydHVhbFRvUGxh dGZvcm1QYXRoKG1fZnVsbFBhdGgpKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlCg==