47548 2010-10-12 11:47:01 -0700 [Qt] editing/input/emacs-ctrl-o.html 2010-10-12 13:46:34 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 robert webkit-unassigned commit-queue oldest_to_newest 293017 0 robert 2010-10-12 11:47:01 -0700 Qt is missing a couple of editing delegate messages from the Mac expected results: EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 0 of DIV > DIV > BODY > HTML > #document to 0 of DIV > DIV > BODY > HTML > #document toDOMRange:range from 9 of #text > DIV > DIV > BODY > HTML > #document to 9 of #text > DIV > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification Qt is missing these because ctrl-o is bound to a sequence of commands on Mac, namely: insertParagraphSeparator then moveUp. In the DRT, we just interepret ctrl-o in EventSenderQt as '\n', i.e. insertParagraphSeparator. As a result we only issue one command, so don't generate the change in caret position that results in the above editing delegate messages. Since we are only passing an insertParagraphSeparator to mimic other DRTs and Qt clients are free to re-implement whatever key binding they like to perform whatever editing actions they like there is no point in bending over backwards to get DRT, or even EditorClientQt to mimic Mac here by repositioning the caret. So just add our own expected results and unskip. 293060 1 70556 robert 2010-10-12 12:38:22 -0700 Created attachment 70556 Patch 293099 2 70556 commit-queue 2010-10-12 13:46:28 -0700 Comment on attachment 70556 Patch Clearing flags on attachment: 70556 Committed r69597: <http://trac.webkit.org/changeset/69597> 293100 3 commit-queue 2010-10-12 13:46:34 -0700 All reviewed patches have been landed. Closing bug. 70556 2010-10-12 12:38:22 -0700 2010-10-12 13:46:28 -0700 Patch bug-47548-20101012203819.patch text/plain 3838 robert ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjYzljOGI1M2YwYjJjZjI3OGE2ZTg5NTQ0MjNhYjRmY2UxYTVmNDJjLi5iZDU5ZDMw OTczY2YzNzkxNTliMDU4NDcyYzNkZjQ1NmJmYjA3NDZjIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMTAtMTIgIFJvYmVydCBIb2dhbiAgPHJvYmVydEB3ZWJraXQub3JnPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gZWRpdGluZy9pbnB1 dC9lbWFjcy1jdHJsLW8uaHRtbAorCisgICAgICAgIFVuc2tpcCBlZGl0aW5nL2lucHV0L2VtYWNz LWN0cmwtby5odG1sCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTQ3NTQ4CisKKyAgICAgICAgKiBwbGF0Zm9ybS9xdC9Ta2lwcGVkOgorCiAyMDEwLTEw LTEyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlhLmNvbT4KIAogICAgICAgICBS ZWJhc2VsaW5lZCBhIGZhaWxpbmcgdGVzdHMuIFVuc2tpcHBlZCBlZGl0aW5nIHRlc3RzIHRoYXQg YXJlIHBhc3NpbmcgYW5kCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lw cGVkIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZAppbmRleCBhOWI1OGU0ZjA3MjE1 MGMyZjQyZTY2ZWE1NWUzNGUyMjk0MzhmZGY2Li42MjNkNjNkYzQzNzgxMGE3NjBhOWQ5MzgwOWJl ZmVmZjkwZGU3MTk3IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVk CisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKQEAgLTc5OCwxMiArNzk4LDYg QEAgZmFzdC9ydWJ5L3J1YnlET00tcmVtb3ZlLXRleHQxLmh0bWwKIGZhc3QvcnVieS9ydWJ5RE9N LXJlbW92ZS10ZXh0Mi5odG1sCiAKICMgPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0gIwotIyAtLS0tLS0t IGZhaWxpbmcgZWRpdGluZy9pbnB1dCB0ZXN0cwotIyA9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PSAjCi0K LWVkaXRpbmcvaW5wdXQvZW1hY3MtY3RybC1vLmh0bWwKLQotIyA9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PSAjCiAjIEZhaWxpbmcgU1ZHIHRlc3RzCiAjID09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ICMKIApkaWZm IC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCmlu ZGV4IDUzZjZkZWYzZjVmYzZiYTI5NzRiMTBmNzViZDU0N2JmYzE0YjdhMzUuLjlmMmYyN2E2MmUz NGU1N2U0YWQ5ODMzY2VlMjRlY2NkMjVkODFlOTYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0No YW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMyBAQAorMjAx MC0xMC0xMiAgUm9iZXJ0IEhvZ2FuICA8cm9iZXJ0QHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBlZGl0aW5nL2lucHV0L2Vt YWNzLWN0cmwtby5odG1sCisKKyAgICAgICAgY3RybC1vIGlzIGJvdW5kIHRvIGEgc2VxdWVuY2Ug b2YgY29tbWFuZHMgb24gTWFjLCBuYW1lbHk6CisgICAgICAgIGluc2VydFBhcmFncmFwaFNlcGFy YXRvciB0aGVuIG1vdmVMZWZ0LiBJbiB0aGUgRFJULCB3ZSBqdXN0IGludGVycHJldAorICAgICAg ICBjdHJsLW8gaW4gRXZlbnRTZW5kZXJRdCBhcyAnXG4nLCBpLmUuIGluc2VydFBhcmFncmFwaFNl cGFyYXRvci4gQXMgYQorICAgICAgICByZXN1bHQgd2Ugb25seSBpc3N1ZSBvbmUgY29tbWFuZCwg c28gZG9uJ3QgZ2VuZXJhdGUgdGhlIGNoYW5nZSBpbiBjYXJldAorICAgICAgICBwb3NpdGlvbiB0 aGF0IHJlc3VsdHMgaW4gdGhlIGV4dHJhIGVkaXRpbmcgZGVsZWdhdGUgbWVzc2FnZXMuCisKKyAg ICAgICAgU28gZm9yIHRoZSBzYWtlIG9mIG5vdCBtYW5hZ2luZyBzdXNwaWNpb3VzLWxvb2tpbmcg ZGlmZmVyZW5jZXMsIGp1c3QKKyAgICAgICAgbWFrZSBEUlQgaXNzdWUgdGhlIGFwcHJvcHJpYXRl IGVkaXQgY29tbWFuZHMgdG8gcGFzcyB0aGUgdGVzdC4KKworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc1NDgKKworICAgICAgICAqIER1bXBSZW5kZXJU cmVlL3F0L0V2ZW50U2VuZGVyUXQuY3BwOgorICAgICAgICAoRXZlbnRTZW5kZXI6OmtleURvd24p OgorCiAyMDEwLTEwLTEyICBUb255IENoYW5nICA8dG9ueUBjaHJvbWl1bS5vcmc+CiAKICAgICAg ICAgVW5yZXZpZXdlZCwgZml4aW5nIERSVCBjb21waWxlIG9uIFdpbmRvd3MgYWZ0ZXIgcjY5NTg2 LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvcXQvRXZlbnRTZW5kZXJR dC5jcHAgYi9XZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcApp bmRleCBmZDdjOTI1OGUwMjEwY2FjYTIyNjAwNmE0MzhmZGUwOTE3MDI4ZjhhLi42ZmI3NWE1OGY4 OTlkZDk2ZmJiNmQ5NDA5MmRiNmFkZWMwNzZiYTMzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcAorKysgYi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9xdC9FdmVudFNlbmRlclF0LmNwcApAQCAtMjU0LDkgKzI1NCwxOCBAQCB2b2lk IEV2ZW50U2VuZGVyOjprZXlEb3duKGNvbnN0IFFTdHJpbmcmIHN0cmluZywgY29uc3QgUVN0cmlu Z0xpc3QmIG1vZGlmaWVycywgdQogICAgICAgICAgICAgICAgIG1vZGlmcyA9IFF0OjpDb250cm9s TW9kaWZpZXI7CiAgICAgICAgICAgICBzID0gUVN0cmluZygpOwogICAgICAgICB9IGVsc2UgaWYg KGNvZGUgPT0gJ28nICYmIG1vZGlmcyA9PSBRdDo6Q29udHJvbE1vZGlmaWVyKSB7CisgICAgICAg ICAgICAvLyBNaW1pYyB0aGUgZW1hY3MgY3RybC1vIGJpbmRpbmcgb24gTWFjIGJ5IGluc2VydGlu ZyBhIHBhcmFncmFwaAorICAgICAgICAgICAgLy8gc2VwYXJhdG9yIGFuZCB0aGVuIHB1dHRpbmcg dGhlIGN1cnNvciBiYWNrIHRvIGl0cyBvcmlnaW5hbAorICAgICAgICAgICAgLy8gcG9zaXRpb24u IEFsbG93cyB1cyB0byBwYXNzIGVtYWNzLWN0cmwtby5odG1sCiAgICAgICAgICAgICBzID0gUUxh dGluMVN0cmluZygiXG4iKTsKICAgICAgICAgICAgIGNvZGUgPSAnXG4nOwogICAgICAgICAgICAg bW9kaWZzID0gMDsKKyAgICAgICAgICAgIFFLZXlFdmVudCBldmVudChRRXZlbnQ6OktleVByZXNz LCBjb2RlLCBtb2RpZnMsIHMpOworICAgICAgICAgICAgc2VuZEV2ZW50KG1fcGFnZSwgJmV2ZW50 KTsKKyAgICAgICAgICAgIFFLZXlFdmVudCBldmVudDIoUUV2ZW50OjpLZXlSZWxlYXNlLCBjb2Rl LCBtb2RpZnMsIHMpOworICAgICAgICAgICAgc2VuZEV2ZW50KG1fcGFnZSwgJmV2ZW50Mik7Cisg ICAgICAgICAgICBzID0gUVN0cmluZygpOworICAgICAgICAgICAgY29kZSA9IFF0OjpLZXlfTGVm dDsKICAgICAgICAgfSBlbHNlIGlmIChjb2RlID09ICd5JyAmJiBtb2RpZnMgPT0gUXQ6OkNvbnRy b2xNb2RpZmllcikgewogICAgICAgICAgICAgcyA9IFFMYXRpbjFTdHJpbmcoImMiKTsKICAgICAg ICAgICAgIGNvZGUgPSAnYyc7Cg==