47545 2010-10-12 09:54:29 -0700 [Qt] Right clicking on Flash in windowless mode crashes 2011-09-29 21:31:23 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) PC Linux RESOLVED FIXED Qt P2 Normal --- 69123 1 girish webkit-unassigned ademar ariya.hidayat robert oldest_to_newest 292976 0 girish 2010-10-12 09:54:29 -0700 Right clicking on Flash in windowless mode crashes on Linux. 292987 1 70541 girish 2010-10-12 10:16:39 -0700 Created attachment 70541 Ignore right click in windowless mode 293020 2 ariya.hidayat 2010-10-12 11:51:56 -0700 Will there be a negative effect, i.e. some plugins will not work? 293039 3 girish 2010-10-12 12:13:48 -0700 (In reply to comment #2) > Will there be a negative effect, i.e. some plugins will not work? There will be no negative effect. The quirk is enabled only for Flash (and only on linux) and Flash's context menu is primarily used for settings. Chrome appears to do the same btw - http://www.communitymx.com/content/source/E5141/wmodetrans.htm. Firefox crashes. 293042 4 70541 ariya.hidayat 2010-10-12 12:16:19 -0700 Comment on attachment 70541 Ignore right click in windowless mode > The quirk is enabled only for Flash (and only on linux) .. Maybe useful to add this in the ChangeLog? otherwise, LGTM. 293044 5 robert 2010-10-12 12:19:42 -0700 I think we should establish why it crashes and, if this change is the only way of fixing it, explain why in the changelog. To my limited knowledge plugins on Linux are generally windowed so would it be possible to point to a test cases where the crash can be reproduced or to provide a backtrace? 293048 6 robert 2010-10-12 12:26:05 -0700 (In reply to comment #3) > (In reply to comment #2) > > Will there be a negative effect, i.e. some plugins will not work? > > http://www.communitymx.com/content/source/E5141/wmodetrans.htm. Firefox crashes. It doesn't for me! (Mozilla Firefox 3.6.10) 293051 7 girish 2010-10-12 12:29:21 -0700 (In reply to comment #5) > I think we should establish why it crashes and, if this change is the only way of fixing it, explain why in the changelog. > > To my limited knowledge plugins on Linux are generally windowed so would it be possible to point to a test cases where the crash can be reproduced or to provide a backtrace? The crash is in Flash and there is nothing we can do. gdb output is not meaninful since it just shows some ??? in flash code. In essence, we give Flash the right-click event and it just locks up. strace seems to suggest that it's waiting in a select() call. The behavior is easily reproducible - Goto www.communitymx.com/content/source/E5141/wmodetrans.htm. Right click on the ball. Chrome disables right click. Firefox 3.6.10 (64-bit) crashes. As for windowed/windowless, we force all Flash to windowless mode with QGraphicsWebView. So, right now, if you right click on Flash on QGraphicsWebView, you will crash. 293052 8 girish 2010-10-12 12:29:58 -0700 (In reply to comment #6) > (In reply to comment #3) > > (In reply to comment #2) > > > Will there be a negative effect, i.e. some plugins will not work? > > > > http://www.communitymx.com/content/source/E5141/wmodetrans.htm. Firefox crashes. > > It doesn't for me! (Mozilla Firefox 3.6.10) 32-bit or 64-bit? 293063 9 girish 2010-10-12 12:42:34 -0700 Here's the backtrace. 64-bit linux and Shockwave Flash 10.1 r85 #0 0x00007ffff42702c3 in select () at ../sysdeps/unix/syscall-template.S:82 #1 0x00007fffdd654cc1 in ?? () from /var/lib/flashplugin-installer/npwrapper.libflashplayer.so #2 0x00007fffdd655f99 in ?? () from /var/lib/flashplugin-installer/npwrapper.libflashplayer.so #3 0x00007fffdd656f39 in ?? () from /var/lib/flashplugin-installer/npwrapper.libflashplayer.so #4 0x00007fffdd65736e in ?? () from /var/lib/flashplugin-installer/npwrapper.libflashplayer.so #5 0x00007fffdd6575d7 in ?? () from /var/lib/flashplugin-installer/npwrapper.libflashplayer.so #6 0x00007fffdd64f5b5 in ?? () from /var/lib/flashplugin-installer/npwrapper.libflashplayer.so #7 0x00007ffff756fc37 in WebCore::PluginView::dispatchNPEvent(_XEvent&) () from /home/girish/Qt/qtwebkit/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 #8 0x00007ffff7572279 in WebCore::PluginView::handleMouseEvent(WebCore::MouseEvent*) () from /home/girish/Qt/qtwebkit/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 #9 0x00007ffff73e0b50 in WebCore::PluginView::handleEvent(WebCore::Event*) () from /home/girish/Qt/qtwebkit/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 #10 0x00007ffff711bd0f in WebCore::Node::dispatchGenericEvent(WTF::PassRefPtr<WebCore::Event>) () from /home/girish/Qt/qtwebkit/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 #11 0x00007ffff711c0fa in WebCore::Node::dispatchEvent(WTF::PassRefPtr<WebCore::Event>) () from /home/girish/Qt/qtwebkit/WebKitBuild/Release/bin/../lib/libQtWebKit.so.4 293077 10 robert 2010-10-12 13:07:12 -0700 (In reply to comment #9) > Here's the backtrace. > > 64-bit linux and Shockwave Flash 10.1 r85 > I'm on 32 bit. I wonder does it crash at all there? Here is the chromium bug: http://code.google.com/p/chromium/issues/detail?id=42883 The bug is now marked as invalid because they can no longer recreate it. Maybe a recent minor version of flash fixed it. (The last poster gives details) If we could confirm that the issue is fixed in the version of flash the last poster quotes we could special-case this quirk to a given version. I agree this is safe to commit but it would be ideal if we could version-control the quirk. 293088 11 girish 2010-10-12 13:21:22 -0700 (In reply to comment #10) > (In reply to comment #9) > > Here's the backtrace. > > > > 64-bit linux and Shockwave Flash 10.1 r85 > > > > I'm on 32 bit. I wonder does it crash at all there? > > Here is the chromium bug: > > http://code.google.com/p/chromium/issues/detail?id=42883 > > The bug is now marked as invalid because they can no longer recreate it. Maybe a recent minor version of flash fixed it. (The last poster gives details) > > If we could confirm that the issue is fixed in the version of flash the last poster quotes we could special-case this quirk to a given version. > > I agree this is safe to commit but it would be ideal if we could version-control the quirk. Ok, I will go ahead and add the quirk only for 64-bit. I will a. check and commit 32-bit behavior. b. check and version control the quirk if it's fixed in latest flash version in 64-bit. 293112 12 girish 2010-10-12 14:12:41 -0700 Fix for 64-bit landed in r69602 293269 13 girish 2010-10-12 21:51:55 -0700 On further investigation: 1. This bug happens with nspluginwrapper. With the latest Shockwave Flash 10.2 d161 32-bit on my 64-bit linux, I am able to reproduce the problem. So quirk is required for this case. 2. With the latest Shockwave Flash 10.2 d161 64-bit, it does not freeeze. Nothing happens. It shows no context menu either. IMO, let's just leave the quirk turned on. There's no major problem with the absence of the context menu AFAIK. (Besides, differentiating between above cases just adds to code complexity). If anyone is experiencing this problem on 32-bit, please let me know and we can remove the special case for the 64-bit check. 297928 14 ademar 2010-10-22 05:43:33 -0700 Revision r69602 cherry-picked into qtwebkit-2.1 with commit e273313 <http://gitorious.org/webkit/qtwebkit/commit/e273313> 70541 2010-10-12 10:16:39 -0700 2010-10-12 12:16:19 -0700 Ignore right click in windowless mode ignorerc text/plain 3335 girish Y29tbWl0IDkzNzkwZWNhNDdhOTJjNTBmZmNlY2E4MTlhNTk2YWU1NDYyYTE2Y2IKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVHVlIE9j dCAxMiAyMjo0NDozNSAyMDEwICswNTMwCgogICAgMjAxMC0xMC0xMiAgR2lyaXNoIFJhbWFrcmlz aG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAgICAgICAgICBbUXRdIFdpbmRvd2xlc3MgbW9kZSBG bGFzaC9YMTEgZnJlZXplcyB3aGVuIHJpZ2h0LWNsaWNrIGlzIHNlbnQuCiAgICAKICAgICAgICAg ICAgQWRkcyBhIG5ldyBxdWlyayBQbHVnaW5RdWlya0lnbm9yZVJpZ2h0Q2xpY2tJbldpbmRvd2xl c3NNb2RlLgogICAgCiAgICAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NzU0NQogICAgCiAgICAgICAgICAgICogcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNw cDoKICAgICAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyk6 CiAgICAgICAgICAgICogcGx1Z2lucy9QbHVnaW5RdWlya1NldC5oOgogICAgICAgICAgICAqIHBs dWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcDoKICAgICAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZp ZXc6OmhhbmRsZU1vdXNlRXZlbnQpOgoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIv V2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTRhY2YxMS4uNWY3OTI2MiAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAor MjAxMC0xMC0xMiAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbUXRdIFdp bmRvd2xlc3MgbW9kZSBGbGFzaC9YMTEgZnJlZXplcyB3aGVuIHJpZ2h0LWNsaWNrIGlzIHNlbnQu CisKKyAgICAgICAgQWRkcyBhIG5ldyBxdWlyayBQbHVnaW5RdWlya0lnbm9yZVJpZ2h0Q2xpY2tJ bldpbmRvd2xlc3NNb2RlLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD00NzU0NQorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblBhY2thZ2U6OmRldGVybWluZVF1aXJrcyk6CisgICAg ICAgICogcGx1Z2lucy9QbHVnaW5RdWlya1NldC5oOgorICAgICAgICAqIHBsdWdpbnMvcXQvUGx1 Z2luVmlld1F0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXc6OmhhbmRsZU1vdXNl RXZlbnQpOgorCiAyMDEwLTEwLTExICBHaXJpc2ggUmFtYWtyaXNobmFuICA8Z2lyaXNoQGZvcndh cmRiaWFzLmluPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2UuY3BwIGIvV2ViQ29yZS9wbHVnaW5z L1BsdWdpblBhY2thZ2UuY3BwCmluZGV4IDM5YzVmMmEuLmIyODYzZGYgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGx1Z2lucy9QbHVnaW5QYWNrYWdlLmNwcAorKysgYi9XZWJDb3JlL3BsdWdpbnMvUGx1 Z2luUGFja2FnZS5jcHAKQEAgLTIwOSw2ICsyMDksOCBAQCB2b2lkIFBsdWdpblBhY2thZ2U6OmRl dGVybWluZVF1aXJrcyhjb25zdCBTdHJpbmcmIG1pbWVUeXBlKQogI2lmIFBMQVRGT1JNKFFUKQog ICAgICAgICAvLyBGbGFzaCB3aWxsIGNyYXNoIG9uIHJlcGVhdGVkIGNhbGxzIHRvIFNldFdpbmRv dyBpbiB3aW5kb3dlZCBtb2RlCiAgICAgICAgIG1fcXVpcmtzLmFkZChQbHVnaW5RdWlya0RvbnRD YWxsU2V0V2luZG93TW9yZVRoYW5PbmNlKTsKKyAgICAgICAgLy8gRmxhc2ggZnJlZXplcyBpZiBy aWdodC1jbGljayBpcyBzZW50IGluIHdpbmRvd2xlc3MgbW9kZQorICAgICAgICBtX3F1aXJrcy5h ZGQoUGx1Z2luUXVpcmtJZ25vcmVSaWdodENsaWNrSW5XaW5kb3dsZXNzTW9kZSk7CiAjZW5kaWYK IAogICAgICAgICBtX3F1aXJrcy5hZGQoUGx1Z2luUXVpcmtSZXF1aXJlc0RlZmF1bHRTY3JlZW5E ZXB0aCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luUXVpcmtTZXQuaCBiL1dl YkNvcmUvcGx1Z2lucy9QbHVnaW5RdWlya1NldC5oCmluZGV4IDdmNTJmNmEuLjFhNjg0ZmUgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5RdWlya1NldC5oCisrKyBiL1dlYkNvcmUv cGx1Z2lucy9QbHVnaW5RdWlya1NldC5oCkBAIC00Nyw3ICs0Nyw4IEBAIG5hbWVzcGFjZSBXZWJD b3JlIHsKICAgICAgICAgUGx1Z2luUXVpcmtEb250QWxsb3dNdWx0aXBsZUluc3RhbmNlcyA9IDEg PDwgMTEsCiAgICAgICAgIFBsdWdpblF1aXJrUmVxdWlyZXNHdGtUb29sS2l0ID0gMSA8PCAxMiwK ICAgICAgICAgUGx1Z2luUXVpcmtSZXF1aXJlc0RlZmF1bHRTY3JlZW5EZXB0aCA9IDEgPDwgMTMs Ci0gICAgICAgIFBsdWdpblF1aXJrRG9udENhbGxTZXRXaW5kb3dNb3JlVGhhbk9uY2UgPSAxIDw8 IDE0CisgICAgICAgIFBsdWdpblF1aXJrRG9udENhbGxTZXRXaW5kb3dNb3JlVGhhbk9uY2UgPSAx IDw8IDE0LAorICAgICAgICBQbHVnaW5RdWlya0lnbm9yZVJpZ2h0Q2xpY2tJbldpbmRvd2xlc3NN b2RlID0gMSA8PCAxNQogICAgIH07CiAKICAgICBjbGFzcyBQbHVnaW5RdWlya1NldCB7CmRpZmYg LS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvcXQvUGx1Z2luVmlld1F0LmNwcCBiL1dlYkNvcmUvcGx1 Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCmluZGV4IDVhMzAxNGMuLjFmYzYzYWMgMTAwNjQ0Ci0t LSBhL1dlYkNvcmUvcGx1Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCisrKyBiL1dlYkNvcmUvcGx1 Z2lucy9xdC9QbHVnaW5WaWV3UXQuY3BwCkBAIC01MzYsNiArNTM2LDkgQEAgdm9pZCBQbHVnaW5W aWV3OjpoYW5kbGVNb3VzZUV2ZW50KE1vdXNlRXZlbnQqIGV2ZW50KQogICAgIGlmIChtX2lzV2lu ZG93ZWQpCiAgICAgICAgIHJldHVybjsKIAorICAgIGlmIChldmVudC0+YnV0dG9uKCkgPT0gUmln aHRCdXR0b24gJiYgbV9wbHVnaW4tPnF1aXJrcygpLmNvbnRhaW5zKFBsdWdpblF1aXJrSWdub3Jl UmlnaHRDbGlja0luV2luZG93bGVzc01vZGUpKQorICAgICAgICByZXR1cm47CisKICAgICBpZiAo ZXZlbnQtPnR5cGUoKSA9PSBldmVudE5hbWVzKCkubW91c2Vkb3duRXZlbnQpIHsKICAgICAgICAg Ly8gR2l2ZSBmb2N1cyB0byB0aGUgcGx1Z2luIG9uIGNsaWNrCiAgICAgICAgIGlmIChQYWdlKiBw YWdlID0gbV9wYXJlbnRGcmFtZS0+cGFnZSgpKQo=