47519 2010-10-11 17:03:39 -0700 [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem. 2010-10-12 16:56:07 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kkanetkar webkit-unassigned abarth commit-queue dumi ericu eric kinuko michaeln webkit.review.bot oldest_to_newest 292766 0 kkanetkar 2010-10-11 17:03:39 -0700 Currently FileSyetem will create root path of the file system if one does not exist. There are cases such as Inspector opening the file system. In these cases we do not want to create the file system root paths. 292814 1 70508 kkanetkar 2010-10-11 18:29:56 -0700 Created attachment 70508 patch 292997 2 70508 dumi 2010-10-12 11:02:55 -0700 Comment on attachment 70508 patch View in context: https://bugs.webkit.org/attachment.cgi?id=70508&action=review > WebKit/chromium/src/LocalFileSystemChromium.cpp:71 > + webWorker->openFileSystem(static_cast<WebFileSystem::Type>(type), size, create, new WebFileSystemCallbacksImpl(callbacks, context, synchronous), create, synchronous); why do we need to pass the 'create' arg twice? 293126 3 70565 kkanetkar 2010-10-12 14:48:25 -0700 Created attachment 70565 patch2 Simplified this. Added new method so that chromium uses them. Will upload another patch for WebCore to use new method signatures. Thanks for the review. 293127 4 70565 dumi 2010-10-12 14:49:38 -0700 Comment on attachment 70565 patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=70565&action=review r=me. > WebKit/chromium/ChangeLog:5 > + [FileSystem] Add ability to pass a bool to create or not create root path while opening filesystem. please update description. 293128 5 70565 dumi 2010-10-12 14:51:27 -0700 Comment on attachment 70565 patch2 oops, ignore my comment. cq+'ing. 293131 6 70565 commit-queue 2010-10-12 15:06:05 -0700 Comment on attachment 70565 patch2 Clearing flags on attachment: 70565 Committed r69609: <http://trac.webkit.org/changeset/69609> 293132 7 commit-queue 2010-10-12 15:06:10 -0700 All reviewed patches have been landed. Closing bug. 293160 8 webkit.review.bot 2010-10-12 16:09:28 -0700 http://trac.webkit.org/changeset/69609 might have broken Chromium Win Release 293195 9 eric 2010-10-12 16:56:07 -0700 enums are always better than bools. 70508 2010-10-11 18:29:56 -0700 2010-10-12 14:48:25 -0700 patch bool3.txt text/plain 9008 kkanetkar SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvTG9jYWxGaWxlU3lzdGVtQ2hyb21pdW0uY3BwCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvTG9jYWxGaWxlU3lzdGVtQ2hyb21pdW0u Y3BwCShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYktpdC9jaHJvbWl1bS9zcmMvTG9jYWxGaWxlU3lz dGVtQ2hyb21pdW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NywxOCArNTcsMTggQEAKICAgICBy ZXR1cm4gKmxvY2FsRmlsZVN5c3RlbTsKIH0KIAotdm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJlcXVl c3RGaWxlU3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEFzeW5jRmlsZVN5 c3RlbTo6VHlwZSB0eXBlLCBsb25nIGxvbmcgc2l6ZSwgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0 ZW1DYWxsYmFja3M+IGNhbGxiYWNrcywgYm9vbCBzeW5jaHJvbm91cykKK3ZvaWQgTG9jYWxGaWxl U3lzdGVtOjpyZXF1ZXN0RmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiBjb250ZXh0 LCBBc3luY0ZpbGVTeXN0ZW06OlR5cGUgdHlwZSwgbG9uZyBsb25nIHNpemUsIFBhc3NPd25QdHI8 QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiBjYWxsYmFja3MsIGJvb2wgY3JlYXRlLCBib29sIHN5 bmNocm9ub3VzKQogewogICAgIEFTU0VSVChjb250ZXh0KTsKICAgICBpZiAoY29udGV4dC0+aXNE b2N1bWVudCgpKSB7CiAgICAgICAgIERvY3VtZW50KiBkb2N1bWVudCA9IHN0YXRpY19jYXN0PERv Y3VtZW50Kj4oY29udGV4dCk7CiAgICAgICAgIFdlYkZyYW1lSW1wbCogd2ViRnJhbWUgPSBXZWJG cmFtZUltcGw6OmZyb21GcmFtZShkb2N1bWVudC0+ZnJhbWUoKSk7Ci0gICAgICAgIHdlYkZyYW1l LT5jbGllbnQoKS0+b3BlbkZpbGVTeXN0ZW0od2ViRnJhbWUsIHN0YXRpY19jYXN0PFdlYkZpbGVT eXN0ZW06OlR5cGU+KHR5cGUpLCBzaXplLCBuZXcgV2ViRmlsZVN5c3RlbUNhbGxiYWNrc0ltcGwo Y2FsbGJhY2tzKSk7CisgICAgICAgIHdlYkZyYW1lLT5jbGllbnQoKS0+b3BlbkZpbGVTeXN0ZW0o d2ViRnJhbWUsIHN0YXRpY19jYXN0PFdlYkZpbGVTeXN0ZW06OlR5cGU+KHR5cGUpLCBzaXplLCBj cmVhdGUsIG5ldyBXZWJGaWxlU3lzdGVtQ2FsbGJhY2tzSW1wbChjYWxsYmFja3MpKTsKICAgICB9 IGVsc2UgewogICAgICAgICBXb3JrZXJDb250ZXh0KiB3b3JrZXJDb250ZXh0ID0gc3RhdGljX2Nh c3Q8V29ya2VyQ29udGV4dCo+KGNvbnRleHQpOwogICAgICAgICBXb3JrZXJMb2FkZXJQcm94eSog d29ya2VyTG9hZGVyUHJveHkgPSAmd29ya2VyQ29udGV4dC0+dGhyZWFkKCktPndvcmtlckxvYWRl clByb3h5KCk7CiAgICAgICAgIFdlYldvcmtlckJhc2UqIHdlYldvcmtlciA9IHN0YXRpY19jYXN0 PFdlYldvcmtlckJhc2UqPih3b3JrZXJMb2FkZXJQcm94eSk7Ci0gICAgICAgIHdlYldvcmtlci0+ b3BlbkZpbGVTeXN0ZW0oc3RhdGljX2Nhc3Q8V2ViRmlsZVN5c3RlbTo6VHlwZT4odHlwZSksIHNp emUsIG5ldyBXZWJGaWxlU3lzdGVtQ2FsbGJhY2tzSW1wbChjYWxsYmFja3MsIGNvbnRleHQsIHN5 bmNocm9ub3VzKSwgc3luY2hyb25vdXMpOworICAgICAgICB3ZWJXb3JrZXItPm9wZW5GaWxlU3lz dGVtKHN0YXRpY19jYXN0PFdlYkZpbGVTeXN0ZW06OlR5cGU+KHR5cGUpLCBzaXplLCBjcmVhdGUs IG5ldyBXZWJGaWxlU3lzdGVtQ2FsbGJhY2tzSW1wbChjYWxsYmFja3MsIGNvbnRleHQsIHN5bmNo cm9ub3VzKSwgY3JlYXRlLCBzeW5jaHJvbm91cyk7CiAgICAgfQogfQogCkluZGV4OiBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY5NTQ3KQorKysgV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkod29ya2lu ZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDEwLTEwLTExICBLYXZpdGEgS2FuZXRrYXIgIDxr a2FuZXRrYXJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtGaWxlU3lzdGVtXSBBZGQgYWJpbGl0eSB0byBwYXNzIGEgYm9vbCB0 byBjcmVhdGUgb3Igbm90IGNyZWF0ZSByb290IHBhdGggd2hpbGUgb3BlbmluZyBmaWxlc3lzdGVt LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc1MTkK KworICAgICAgICAqIHB1YmxpYy9XZWJDb21tb25Xb3JrZXJDbGllbnQuaDoKKyAgICAgICAgKFdl YktpdDo6V2ViQ29tbW9uV29ya2VyQ2xpZW50OjpvcGVuRmlsZVN5c3RlbSk6CisgICAgICAgICog cHVibGljL1dlYkZyYW1lQ2xpZW50Lmg6CisgICAgICAgIChXZWJLaXQ6OldlYkZyYW1lQ2xpZW50 OjpvcGVuRmlsZVN5c3RlbSk6CisgICAgICAgICogc3JjL0xvY2FsRmlsZVN5c3RlbUNocm9taXVt LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxvY2FsRmlsZVN5c3RlbTo6cmVxdWVzdEZpbGVTeXN0 ZW0pOgorCiAyMDEwLTEwLTExICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUgQ2hhcGluLgpJbmRleDogV2ViS2l0L2Nocm9taXVt L3B1YmxpYy9XZWJDb21tb25Xb3JrZXJDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkNvbW1vbldvcmtlckNsaWVudC5oCShyZXZpc2lvbiA2OTQ2MikKKysr IFdlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViQ29tbW9uV29ya2VyQ2xpZW50LmgJKHdvcmtpbmcg Y29weSkKQEAgLTg3LDYgKzg3LDEyIEBACiAgICAgdmlydHVhbCBib29sIGFsbG93RGF0YWJhc2Uo V2ViRnJhbWUqLCBjb25zdCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYgZGlzcGxh eU5hbWUsIHVuc2lnbmVkIGxvbmcgZXN0aW1hdGVkU2l6ZSkgPSAwOwogCiAgICAgLy8gQ2FsbGVk IG9uIHRoZSBtYWluIHdlYmtpdCB0aHJlYWQgYmVmb3JlIG9wZW5pbmcgYSBmaWxlIHN5c3RlbS4K KyAgICB2aXJ0dWFsIHZvaWQgb3BlbkZpbGVTeXN0ZW0oV2ViRmlsZVN5c3RlbTo6VHlwZSwgbG9u ZyBsb25nIHNpemUsIGJvb2wgY3JlYXRlLCBXZWJGaWxlU3lzdGVtQ2FsbGJhY2tzKikKKyAgICB7 CisgICAgICAgIFdFQktJVF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICB9CisKKyAgICAvLyBU aGlzIHdpbGwgYmUgcmVtb3ZlZCBvbmNlIGNoYW5nZXMgaW4gY2hyb21pdW0gdXNlIHRoZSBuZXcg bWV0aG9kIGFib3ZlLgogICAgIHZpcnR1YWwgdm9pZCBvcGVuRmlsZVN5c3RlbShXZWJGaWxlU3lz dGVtOjpUeXBlLCBsb25nIGxvbmcgc2l6ZSwgV2ViRmlsZVN5c3RlbUNhbGxiYWNrcyopCiAgICAg ewogICAgICAgICBXRUJLSVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7CkluZGV4OiBXZWJLaXQvY2hy b21pdW0vcHVibGljL1dlYkZyYW1lQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9t aXVtL3B1YmxpYy9XZWJGcmFtZUNsaWVudC5oCShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViRnJhbWVDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzQ5LDkg KzM0OSwxNSBAQAogICAgIC8vIFdlYkZpbGVTeXN0ZW1DYWxsYmFja3M6OmRpZE9wZW5GaWxlU3lz dGVtKCkgbXVzdCBiZSBjYWxsZWQgd2l0aAogICAgIC8vIGEgbmFtZSBhbmQgcm9vdCBwYXRoIGZv ciB0aGUgcmVxdWVzdGVkIEZpbGVTeXN0ZW0gd2hlbiB0aGUgb3BlcmF0aW9uCiAgICAgLy8gaXMg Y29tcGxldGVkIHN1Y2Nlc3NmdWxseS4gV2ViRmlsZVN5c3RlbUNhbGxiYWNrczo6ZGlkRmFpbCgp IG11c3QgYmUKLSAgICAvLyBjYWxsZWQgb3RoZXJ3aXNlLgorICAgIC8vIGNhbGxlZCBvdGhlcndp c2UuIFRoZSBjcmVhdGUgYm9vbCBpcyBmb3IgaW5kaWNhdGluZyB3aGV0aGVyIG9yIG5vdCB0bwor ICAgIC8vIGNyZWF0ZSByb290IHBhdGggZm9yIGZpbGUgc3lzdGVtcyBpZiBpdCBkbyBub3QgZXhp c3QuCiAgICAgdmlydHVhbCB2b2lkIG9wZW5GaWxlU3lzdGVtKAogICAgICAgICBXZWJGcmFtZSos IFdlYkZpbGVTeXN0ZW06OlR5cGUsIGxvbmcgbG9uZyBzaXplLAorICAgICAgICBib29sIGNyZWF0 ZSwgV2ViRmlsZVN5c3RlbUNhbGxiYWNrcyopIHsgfQorCisgICAgLy8gVGhpcyBtZXRob2Qgd2ls bCBiZSBkZWxldGVkIG9uY2UgY2hyb21pdW0gdXNlcyB0aGUgbmV3IG1ldGhvZCBhYm92ZS4KKyAg ICB2aXJ0dWFsIHZvaWQgb3BlbkZpbGVTeXN0ZW0oCisgICAgICAgIFdlYkZyYW1lKiwgV2ViRmls ZVN5c3RlbTo6VHlwZSwgbG9uZyBsb25nIHNpemUsCiAgICAgICAgIFdlYkZpbGVTeXN0ZW1DYWxs YmFja3MqKSB7IH0KIAogcHJvdGVjdGVkOgpJbmRleDogV2ViQ29yZS9maWxlYXBpL0xvY2FsRmls ZVN5c3RlbS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZmlsZWFwaS9Mb2NhbEZpbGVTeXN0ZW0u aAkocmV2aXNpb24gNjk0NjIpCisrKyBXZWJDb3JlL2ZpbGVhcGkvTG9jYWxGaWxlU3lzdGVtLmgJ KHdvcmtpbmcgY29weSkKQEAgLTUyLDcgKzUyLDcgQEAKICAgICAvLyBjYWxsaW5nIHRoaXMgb25l LgogICAgIHN0YXRpYyBMb2NhbEZpbGVTeXN0ZW0mIGxvY2FsRmlsZVN5c3RlbSgpOwogCi0gICAg dm9pZCByZXF1ZXN0RmlsZVN5c3RlbShTY3JpcHRFeGVjdXRpb25Db250ZXh0KiwgQXN5bmNGaWxl U3lzdGVtOjpUeXBlLCBsb25nIGxvbmcgc2l6ZSwgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW1D YWxsYmFja3M+LCBib29sIHN5bmNocm9ub3VzID0gZmFsc2UpOworICAgIHZvaWQgcmVxdWVzdEZp bGVTeXN0ZW0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCosIEFzeW5jRmlsZVN5c3RlbTo6VHlwZSwg bG9uZyBsb25nIHNpemUsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tzPiwgYm9v bCBjcmVhdGUsIGJvb2wgc3luY2hyb25vdXMgPSBmYWxzZSk7CiAKICNpZiAhUExBVEZPUk0oQ0hS T01JVU0pCiAgICAgLy8gVGhpcyBjYWxsIGlzIG5vdCB0aHJlYWQtc2FmZTsgbXVzdCBiZSBjYWxs ZWQgYmVmb3JlIGFueSB3b3JrZXIgdGhyZWFkcyBhcmUgY3JlYXRlZC4KSW5kZXg6IFdlYkNvcmUv ZmlsZWFwaS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZmlsZWFw aS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYkNvcmUvZmlsZWFw aS9Mb2NhbEZpbGVTeXN0ZW0uY3BwCSh3b3JraW5nIGNvcHkpCkBAIC04MSw3ICs4MSw3IEBACiAg ICAgQXN5bmNGaWxlU3lzdGVtOjpvcGVuRmlsZVN5c3RlbShiYXNlUGF0aCwgaWRlbnRpZmllciwg dHlwZSwgY2FsbGJhY2tzKTsKIH0KIAotdm9pZCBMb2NhbEZpbGVTeXN0ZW06OnJlcXVlc3RGaWxl U3lzdGVtKFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQsIEFzeW5jRmlsZVN5c3RlbTo6 VHlwZSB0eXBlLCBsb25nIGxvbmcsIFBhc3NPd25QdHI8QXN5bmNGaWxlU3lzdGVtQ2FsbGJhY2tz PiBjYWxsYmFja3MsIGJvb2wpCit2b2lkIExvY2FsRmlsZVN5c3RlbTo6cmVxdWVzdEZpbGVTeXN0 ZW0oU2NyaXB0RXhlY3V0aW9uQ29udGV4dCogY29udGV4dCwgQXN5bmNGaWxlU3lzdGVtOjpUeXBl IHR5cGUsIGxvbmcgbG9uZywgUGFzc093blB0cjxBc3luY0ZpbGVTeXN0ZW1DYWxsYmFja3M+IGNh bGxiYWNrcywgYm9vbCwgYm9vbCkKIHsKICAgICAvLyBBc3luY0ZpbGVTeXN0ZW06Om9wZW5GaWxl U3lzdGVtIGNhbGxzIGNhbGxiYWNrcyBzeW5jaHJvbm91c2x5LCBzbyB0aGUgbWV0aG9kIG5lZWRz IHRvIGJlIGNhbGxlZCBhc3luY2hyb25vdXNseS4KICAgICBjb250ZXh0LT5wb3N0VGFzayhjcmVh dGVDYWxsYmFja1Rhc2soJm9wZW5GaWxlU3lzdGVtLCBmaWxlU3lzdGVtQmFzZVBhdGgoKSwgY29u dGV4dC0+c2VjdXJpdHlPcmlnaW4oKS0+ZGF0YWJhc2VJZGVudGlmaWVyKCksIHR5cGUsIGNhbGxi YWNrcykpOwpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDY5NTQ3KQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcg Y29weSkKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0xMSAgS2F2aXRhIEthbmV0a2FyICA8a2th bmV0a2FyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBbRmlsZVN5c3RlbV0gQWRkIGFiaWxpdHkgdG8gcGFzcyBhIGJvb2wgdG8g Y3JlYXRlIG9yIG5vdCBjcmVhdGUgcm9vdCBwYXRoIHdoaWxlIG9wZW5pbmcgZmlsZXN5c3RlbS4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NTE5CisK KyAgICAgICAgKiBmaWxlYXBpL0xvY2FsRmlsZVN5c3RlbS5jcHA6CisgICAgICAgIChXZWJDb3Jl OjpMb2NhbEZpbGVTeXN0ZW06OnJlcXVlc3RGaWxlU3lzdGVtKToKKyAgICAgICAgKiBmaWxlYXBp L0xvY2FsRmlsZVN5c3RlbS5oOgorICAgICAgICAqIHBhZ2UvRE9NV2luZG93LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkRPTVdpbmRvdzo6cmVxdWVzdEZpbGVTeXN0ZW0pOgorICAgICAgICAqIHdv cmtlcnMvV29ya2VyQ29udGV4dC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0 OjpyZXF1ZXN0RmlsZVN5c3RlbSk6CisgICAgICAgIChXZWJDb3JlOjpXb3JrZXJDb250ZXh0Ojpy ZXF1ZXN0RmlsZVN5c3RlbVN5bmMpOgorCiAyMDEwLTEwLTExICBPbGl2ZXIgSHVudCAgPG9saXZl ckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IFdl YkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9ET01X aW5kb3cuY3BwCShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC03NDAsNyArNzQwLDcgQEAKICAgICAgICAgcmV0dXJuOwogICAg IH0KIAotICAgIExvY2FsRmlsZVN5c3RlbTo6bG9jYWxGaWxlU3lzdGVtKCkucmVxdWVzdEZpbGVT eXN0ZW0oZG9jdW1lbnQsIGZpbGVTeXN0ZW1UeXBlLCBzaXplLCBGaWxlU3lzdGVtQ2FsbGJhY2tz OjpjcmVhdGUoc3VjY2Vzc0NhbGxiYWNrLCBlcnJvckNhbGxiYWNrLCBkb2N1bWVudCksIGZhbHNl KTsKKyAgICBMb2NhbEZpbGVTeXN0ZW06OmxvY2FsRmlsZVN5c3RlbSgpLnJlcXVlc3RGaWxlU3lz dGVtKGRvY3VtZW50LCBmaWxlU3lzdGVtVHlwZSwgc2l6ZSwgRmlsZVN5c3RlbUNhbGxiYWNrczo6 Y3JlYXRlKHN1Y2Nlc3NDYWxsYmFjaywgZXJyb3JDYWxsYmFjaywgZG9jdW1lbnQpLCB0cnVlLCBm YWxzZSk7CiB9CiAKIENPTVBJTEVfQVNTRVJUKHN0YXRpY19jYXN0PGludD4oRE9NV2luZG93OjpU RU1QT1JBUlkpID09IHN0YXRpY19jYXN0PGludD4oQXN5bmNGaWxlU3lzdGVtOjpUZW1wb3Jhcnkp LCBlbnVtX21pc21hdGNoKTsKSW5kZXg6IFdlYkNvcmUvd29ya2Vycy9Xb3JrZXJDb250ZXh0LmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dvcmtlcnMvV29ya2VyQ29udGV4dC5jcHAJKHJldmlz aW9uIDY5NDYyKQorKysgV2ViQ29yZS93b3JrZXJzL1dvcmtlckNvbnRleHQuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC0zNjUsNyArMzY1LDcgQEAKICAgICAgICAgcmV0dXJuOwogICAgIH0KIAotICAg IExvY2FsRmlsZVN5c3RlbTo6bG9jYWxGaWxlU3lzdGVtKCkucmVxdWVzdEZpbGVTeXN0ZW0odGhp cywgZmlsZVN5c3RlbVR5cGUsIHNpemUsIEZpbGVTeXN0ZW1DYWxsYmFja3M6OmNyZWF0ZShzdWNj ZXNzQ2FsbGJhY2ssIGVycm9yQ2FsbGJhY2ssIHRoaXMpLCBmYWxzZSk7CisgICAgTG9jYWxGaWxl U3lzdGVtOjpsb2NhbEZpbGVTeXN0ZW0oKS5yZXF1ZXN0RmlsZVN5c3RlbSh0aGlzLCBmaWxlU3lz dGVtVHlwZSwgc2l6ZSwgRmlsZVN5c3RlbUNhbGxiYWNrczo6Y3JlYXRlKHN1Y2Nlc3NDYWxsYmFj aywgZXJyb3JDYWxsYmFjaywgdGhpcyksIHRydWUsIGZhbHNlKTsKIH0KIAogUGFzc1JlZlB0cjxE T01GaWxlU3lzdGVtU3luYz4gV29ya2VyQ29udGV4dDo6cmVxdWVzdEZpbGVTeXN0ZW1TeW5jKGlu dCB0eXBlLCBsb25nIGxvbmcgc2l6ZSwgRXhjZXB0aW9uQ29kZSYgZWMpCkBAIC0zODMsNyArMzgz LDcgQEAKICAgICB9CiAKICAgICBGaWxlU3lzdGVtU3luY0NhbGxiYWNrSGVscGVyIGhlbHBlcjsK LSAgICBMb2NhbEZpbGVTeXN0ZW06OmxvY2FsRmlsZVN5c3RlbSgpLnJlcXVlc3RGaWxlU3lzdGVt KHRoaXMsIGZpbGVTeXN0ZW1UeXBlLCBzaXplLCBGaWxlU3lzdGVtQ2FsbGJhY2tzOjpjcmVhdGUo aGVscGVyLnN1Y2Nlc3NDYWxsYmFjaygpLCBoZWxwZXIuZXJyb3JDYWxsYmFjaygpLCB0aGlzKSwg dHJ1ZSk7CisgICAgTG9jYWxGaWxlU3lzdGVtOjpsb2NhbEZpbGVTeXN0ZW0oKS5yZXF1ZXN0Rmls ZVN5c3RlbSh0aGlzLCBmaWxlU3lzdGVtVHlwZSwgc2l6ZSwgRmlsZVN5c3RlbUNhbGxiYWNrczo6 Y3JlYXRlKGhlbHBlci5zdWNjZXNzQ2FsbGJhY2soKSwgaGVscGVyLmVycm9yQ2FsbGJhY2soKSwg dGhpcyksIHRydWUsIHRydWUpOwogICAgIHJldHVybiBoZWxwZXIuZ2V0UmVzdWx0KGVjKTsKIH0K IAo= 70565 2010-10-12 14:48:25 -0700 2010-10-12 15:06:05 -0700 patch2 bool4.txt text/plain 2633 kkanetkar SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjk2MDUpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMTIgIEthdml0 YSBLYW5ldGthciAgPGtrYW5ldGthckBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0ZpbGVTeXN0ZW1dIEFkZCBhYmlsaXR5IHRv IHBhc3MgYSBib29sIHRvIGNyZWF0ZSBvciBub3QgY3JlYXRlIHJvb3QgcGF0aCB3aGlsZSBvcGVu aW5nIGZpbGVzeXN0ZW0uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NzUxOQorCisgICAgICAgICogcHVibGljL1dlYkNvbW1vbldvcmtlckNsaWVudC5o OgorICAgICAgICAoV2ViS2l0OjpXZWJDb21tb25Xb3JrZXJDbGllbnQ6Om9wZW5GaWxlU3lzdGVt KToKKyAgICAgICAgKiBwdWJsaWMvV2ViRnJhbWVDbGllbnQuaDoKKyAgICAgICAgKFdlYktpdDo6 V2ViRnJhbWVDbGllbnQ6Om9wZW5GaWxlU3lzdGVtKToKKwogMjAxMC0xMC0xMiAgSmFtZXMgUm9i aW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5hdGUg Q2hhcGluIChpbiBwZXJzb24pLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJDb21t b25Xb3JrZXJDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkNvbW1vbldvcmtlckNsaWVudC5oCShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYktpdC9jaHJvbWl1 bS9wdWJsaWMvV2ViQ29tbW9uV29ya2VyQ2xpZW50LmgJKHdvcmtpbmcgY29weSkKQEAgLTg3LDYg Kzg3LDEyIEBACiAgICAgdmlydHVhbCBib29sIGFsbG93RGF0YWJhc2UoV2ViRnJhbWUqLCBjb25z dCBXZWJTdHJpbmcmIG5hbWUsIGNvbnN0IFdlYlN0cmluZyYgZGlzcGxheU5hbWUsIHVuc2lnbmVk IGxvbmcgZXN0aW1hdGVkU2l6ZSkgPSAwOwogCiAgICAgLy8gQ2FsbGVkIG9uIHRoZSBtYWluIHdl YmtpdCB0aHJlYWQgYmVmb3JlIG9wZW5pbmcgYSBmaWxlIHN5c3RlbS4KKyAgICB2aXJ0dWFsIHZv aWQgb3BlbkZpbGVTeXN0ZW0oV2ViRmlsZVN5c3RlbTo6VHlwZSwgbG9uZyBsb25nIHNpemUsIGJv b2wgY3JlYXRlLCBXZWJGaWxlU3lzdGVtQ2FsbGJhY2tzKikKKyAgICB7CisgICAgICAgIFdFQktJ VF9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICB9CisKKyAgICAvLyBUaGlzIHdpbGwgYmUgcmVt b3ZlZCBvbmNlIGNoYW5nZXMgaW4gY2hyb21pdW0gdXNlIHRoZSBuZXcgbWV0aG9kIGFib3ZlLgog ICAgIHZpcnR1YWwgdm9pZCBvcGVuRmlsZVN5c3RlbShXZWJGaWxlU3lzdGVtOjpUeXBlLCBsb25n IGxvbmcgc2l6ZSwgV2ViRmlsZVN5c3RlbUNhbGxiYWNrcyopCiAgICAgewogICAgICAgICBXRUJL SVRfQVNTRVJUX05PVF9SRUFDSEVEKCk7CkluZGV4OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dl YkZyYW1lQ2xpZW50LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3B1YmxpYy9XZWJG cmFtZUNsaWVudC5oCShyZXZpc2lvbiA2OTQ2MikKKysrIFdlYktpdC9jaHJvbWl1bS9wdWJsaWMv V2ViRnJhbWVDbGllbnQuaAkod29ya2luZyBjb3B5KQpAQCAtMzQ5LDkgKzM0OSwxNSBAQAogICAg IC8vIFdlYkZpbGVTeXN0ZW1DYWxsYmFja3M6OmRpZE9wZW5GaWxlU3lzdGVtKCkgbXVzdCBiZSBj YWxsZWQgd2l0aAogICAgIC8vIGEgbmFtZSBhbmQgcm9vdCBwYXRoIGZvciB0aGUgcmVxdWVzdGVk IEZpbGVTeXN0ZW0gd2hlbiB0aGUgb3BlcmF0aW9uCiAgICAgLy8gaXMgY29tcGxldGVkIHN1Y2Nl c3NmdWxseS4gV2ViRmlsZVN5c3RlbUNhbGxiYWNrczo6ZGlkRmFpbCgpIG11c3QgYmUKLSAgICAv LyBjYWxsZWQgb3RoZXJ3aXNlLgorICAgIC8vIGNhbGxlZCBvdGhlcndpc2UuIFRoZSBjcmVhdGUg Ym9vbCBpcyBmb3IgaW5kaWNhdGluZyB3aGV0aGVyIG9yIG5vdCB0bworICAgIC8vIGNyZWF0ZSBy b290IHBhdGggZm9yIGZpbGUgc3lzdGVtcyBpZiBpdCBkbyBub3QgZXhpc3QuCiAgICAgdmlydHVh bCB2b2lkIG9wZW5GaWxlU3lzdGVtKAogICAgICAgICBXZWJGcmFtZSosIFdlYkZpbGVTeXN0ZW06 OlR5cGUsIGxvbmcgbG9uZyBzaXplLAorICAgICAgICBib29sIGNyZWF0ZSwgV2ViRmlsZVN5c3Rl bUNhbGxiYWNrcyopIHsgfQorCisgICAgLy8gVGhpcyBtZXRob2Qgd2lsbCBiZSBkZWxldGVkIG9u Y2UgY2hyb21pdW0gdXNlcyB0aGUgbmV3IG1ldGhvZCBhYm92ZS4KKyAgICB2aXJ0dWFsIHZvaWQg b3BlbkZpbGVTeXN0ZW0oCisgICAgICAgIFdlYkZyYW1lKiwgV2ViRmlsZVN5c3RlbTo6VHlwZSwg bG9uZyBsb25nIHNpemUsCiAgICAgICAgIFdlYkZpbGVTeXN0ZW1DYWxsYmFja3MqKSB7IH0KIAog cHJvdGVjdGVkOgo=