47517 2010-10-11 16:48:09 -0700 Add DelayProcessor files 2010-10-26 20:21:59 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 crogers webkit-unassigned cmarrin commit-queue dglazkov eric.carlson jamesr jer.noble kbr simon.fraser oldest_to_newest 292760 0 crogers 2010-10-11 16:48:09 -0700 Add DelayProcessor files 292761 1 70494 crogers 2010-10-11 16:49:26 -0700 Created attachment 70494 Patch 293296 2 70494 cfleizach 2010-10-13 00:53:15 -0700 Comment on attachment 70494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70494&action=review > WebCore/webaudio/DelayProcessor.h:34 > +namespace WebCore { don't you want an #if ENABLE(WEB_AUDIO) in the header file too? > WebCore/webaudio/DelayProcessor.h:45 > + AudioParam* delayTime() { return m_delayTime.get(); } this should be const > WebCore/webaudio/DelayProcessor.h:48 > + RefPtr<AudioParam> m_delayTime; why this is protected instead of private 293551 3 70494 crogers 2010-10-13 11:26:39 -0700 Comment on attachment 70494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70494&action=review Hi Chris, thanks for the review. I'm uploading a new patch with the fixes. >> WebCore/webaudio/DelayProcessor.h:34 >> +namespace WebCore { > > don't you want an #if ENABLE(WEB_AUDIO) in the header file too? I think it's only supposed to go into the .cpp file. This is how the other feature enables work, like 3D_CANVAS in WebCore/html/canvas >> WebCore/webaudio/DelayProcessor.h:45 >> + AudioParam* delayTime() { return m_delayTime.get(); } > > this should be const FIXED >> WebCore/webaudio/DelayProcessor.h:48 >> + RefPtr<AudioParam> m_delayTime; > > why this is protected instead of private FIXED 293555 4 70637 crogers 2010-10-13 11:28:50 -0700 Created attachment 70637 Patch 299928 5 70637 kbr 2010-10-26 18:41:07 -0700 Comment on attachment 70637 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70637&action=review Looks okay; r+'ing, but with one comment. Feel free to upload a revised patch. > WebCore/webaudio/DelayProcessor.cpp:44 > + uninitialize(); Looking at this afresh, this block of code looks like something that should be in the base class's destructor. Also, given that uninitialize() checks the isInitialized() flag it doesn't seem necessary to have the "if" test. 299944 6 70637 commit-queue 2010-10-26 20:21:53 -0700 Comment on attachment 70637 Patch Clearing flags on attachment: 70637 Committed r70603: <http://trac.webkit.org/changeset/70603> 299945 7 commit-queue 2010-10-26 20:21:59 -0700 All reviewed patches have been landed. Closing bug. 70494 2010-10-11 16:49:26 -0700 2010-10-13 11:28:46 -0700 Patch bug-47517-20101011164924.patch text/plain 5284 crogers SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTUzNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMTEgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgRGVsYXlQcm9jZXNzb3IgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ3NTE3CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGF1ZGlv IEFQSSBpcyBub3QgeWV0IGltcGxlbWVudGVkLgorCisgICAgICAgICogd2ViYXVkaW8vRGVsYXlQ cm9jZXNzb3IuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkRlbGF5UHJvY2Vzc29yOjpE ZWxheVByb2Nlc3Nvcik6CisgICAgICAgIChXZWJDb3JlOjpEZWxheVByb2Nlc3Nvcjo6fkRlbGF5 UHJvY2Vzc29yKToKKyAgICAgICAgKFdlYkNvcmU6OkRlbGF5UHJvY2Vzc29yOjpjcmVhdGVLZXJu ZWwpOgorICAgICAgICAqIHdlYmF1ZGlvL0RlbGF5UHJvY2Vzc29yLmg6IEFkZGVkLgorICAgICAg ICAoV2ViQ29yZTo6RGVsYXlQcm9jZXNzb3I6OmRlbGF5VGltZSk6CisKIDIwMTAtMTAtMTEgIE1h cnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFRvbnkgQ2hhbmcuCkluZGV4OiBXZWJDb3JlL3dlYmF1ZGlvL0RlbGF5UHJvY2Vzc29yLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dlYmF1ZGlvL0RlbGF5UHJvY2Vzc29yLmNwcAkocmV2 aXNpb24gMCkKKysrIFdlYkNvcmUvd2ViYXVkaW8vRGVsYXlQcm9jZXNzb3IuY3BwCShyZXZpc2lv biAwKQpAQCAtMCwwICsxLDU0IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwLCBHb29nbGUg SW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0 aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25z CisgKiBhcmUgbWV0OgorICogMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0 IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBj b25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiAgUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK KyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZUV0FS RSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMgSVMn JyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNIQU5U QUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBESVND TEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRPUlMg QkUgTElBQkxFIEZPUiBBTlkKKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJ QUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5HLCBC VVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1IgU0VS VklDRVM7CisgKiBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1MgSU5U RVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyAqIEFOWSBUSEVPUlkgT0YgTElBQklM SVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisgKiAo SU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkgT1VU IE9GIFRIRSBVU0UgT0YgVEhJUworICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBUSEUg UE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5oIgor CisjaWYgRU5BQkxFKFdFQl9BVURJTykKKworI2luY2x1ZGUgIkRlbGF5UHJvY2Vzc29yLmgiCisg CisjaW5jbHVkZSAiRGVsYXlEU1BLZXJuZWwuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgeworCitE ZWxheVByb2Nlc3Nvcjo6RGVsYXlQcm9jZXNzb3IoZG91YmxlIHNhbXBsZVJhdGUsIHVuc2lnbmVk IG51bWJlck9mQ2hhbm5lbHMpCisgICAgOiBBdWRpb0RTUEtlcm5lbFByb2Nlc3NvcihzYW1wbGVS YXRlLCBudW1iZXJPZkNoYW5uZWxzKQoreworICAgIG1fZGVsYXlUaW1lID0gQXVkaW9QYXJhbTo6 Y3JlYXRlKCJkZWxheVRpbWUiLCAwLjAsIDAuMCwgMS4wKTsKK30KKworRGVsYXlQcm9jZXNzb3I6 On5EZWxheVByb2Nlc3NvcigpCit7CisgICAgaWYgKGlzSW5pdGlhbGl6ZWQoKSkKKyAgICAgICAg dW5pbml0aWFsaXplKCk7Cit9CisKK1Bhc3NPd25QdHI8QXVkaW9EU1BLZXJuZWw+IERlbGF5UHJv Y2Vzc29yOjpjcmVhdGVLZXJuZWwoKQoreworICAgIHJldHVybiBhZG9wdFB0cihuZXcgRGVsYXlE U1BLZXJuZWwodGhpcykpOworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKKyNlbmRpZiAv LyBFTkFCTEUoV0VCX0FVRElPKQpJbmRleDogV2ViQ29yZS93ZWJhdWRpby9EZWxheVByb2Nlc3Nv ci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd2ViYXVkaW8vRGVsYXlQcm9jZXNzb3IuaAkocmV2 aXNpb24gMCkKKysrIFdlYkNvcmUvd2ViYXVkaW8vRGVsYXlQcm9jZXNzb3IuaAkocmV2aXNpb24g MCkKQEAgLTAsMCArMSw1MyBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCwgR29vZ2xlIElu Yy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNlIGlu IHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNhdGlv biwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9ucwor ICogYXJlIG1ldDoKKyAqIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCBy ZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29u ZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gIFJlZGlzdHJpYnV0 aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0Cisg KiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRp c2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlh bHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUg SVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycg QU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorICogV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFC SUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorICogRElTQ0xB SU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTIEJF IExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFM LCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywgQlVU IE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJ Q0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVS UlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCisgKiBBTlkgVEhFT1JZIE9GIExJQUJJTElU WSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICogKElO Q0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBP RiBUSEUgVVNFIE9GIFRISVMKKyAqIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBP U1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpZm5kZWYgRGVsYXlQcm9jZXNzb3Jf aAorI2RlZmluZSBEZWxheVByb2Nlc3Nvcl9oCisKKyNpbmNsdWRlICJBdWRpb0RTUEtlcm5lbFBy b2Nlc3Nvci5oIgorI2luY2x1ZGUgIkF1ZGlvUGFyYW0uaCIKKworI2luY2x1ZGUgPHd0Zi9QYXNz T3duUHRyLmg+CisjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgorCituYW1lc3BhY2UgV2ViQ29yZSB7 CisKK2NsYXNzIEF1ZGlvRFNQS2VybmVsOworICAgIAorY2xhc3MgRGVsYXlQcm9jZXNzb3IgOiBw dWJsaWMgQXVkaW9EU1BLZXJuZWxQcm9jZXNzb3IgeworcHVibGljOgorICAgIERlbGF5UHJvY2Vz c29yKGRvdWJsZSBzYW1wbGVSYXRlLCB1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzKTsKKyAgICB2 aXJ0dWFsIH5EZWxheVByb2Nlc3NvcigpOworICAgIAorICAgIHZpcnR1YWwgUGFzc093blB0cjxB dWRpb0RTUEtlcm5lbD4gY3JlYXRlS2VybmVsKCk7CisgICAgICAgIAorICAgIEF1ZGlvUGFyYW0q IGRlbGF5VGltZSgpIHsgcmV0dXJuIG1fZGVsYXlUaW1lLmdldCgpOyB9CisKK3Byb3RlY3RlZDoK KyAgICBSZWZQdHI8QXVkaW9QYXJhbT4gbV9kZWxheVRpbWU7Cit9OworCit9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCisKKyNlbmRpZiAvLyBEZWxheVByb2Nlc3Nvcl9oCg== 70637 2010-10-13 11:28:50 -0700 2010-10-26 20:21:53 -0700 Patch bug-47517-20101013112849.patch text/plain 5291 crogers SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTY3NSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMTMgIENocmlzIFJvZ2VycyAgPGNyb2dlcnNAZ29vZ2xl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgRGVsYXlQcm9jZXNzb3IgZmlsZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ3NTE3CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIGF1ZGlv IEFQSSBpcyBub3QgeWV0IGltcGxlbWVudGVkLgorCisgICAgICAgICogd2ViYXVkaW8vRGVsYXlQ cm9jZXNzb3IuY3BwOiBBZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OkRlbGF5UHJvY2Vzc29yOjpE ZWxheVByb2Nlc3Nvcik6CisgICAgICAgIChXZWJDb3JlOjpEZWxheVByb2Nlc3Nvcjo6fkRlbGF5 UHJvY2Vzc29yKToKKyAgICAgICAgKFdlYkNvcmU6OkRlbGF5UHJvY2Vzc29yOjpjcmVhdGVLZXJu ZWwpOgorICAgICAgICAqIHdlYmF1ZGlvL0RlbGF5UHJvY2Vzc29yLmg6IEFkZGVkLgorICAgICAg ICAoV2ViQ29yZTo6RGVsYXlQcm9jZXNzb3I6OmRlbGF5VGltZSk6CisKIDIwMTAtMTAtMTMgIEpv aG4gS25vdHRlbmJlbHQgIDxqa25vdHRlbkBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgU3RldmUgQmxvY2suCkluZGV4OiBXZWJDb3JlL3dlYmF1ZGlvL0RlbGF5UHJvY2Vzc29y LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3dlYmF1ZGlvL0RlbGF5UHJvY2Vzc29yLmNwcAko cmV2aXNpb24gMCkKKysrIFdlYkNvcmUvd2ViYXVkaW8vRGVsYXlQcm9jZXNzb3IuY3BwCShyZXZp c2lvbiAwKQpAQCAtMCwwICsxLDU0IEBACisvKgorICogQ29weXJpZ2h0IChDKSAyMDEwLCBHb29n bGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1 c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZp Y2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRp b25zCisgKiBhcmUgbWV0OgorICogMS4gIFJlZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBt dXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBv ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIuCisgKiAyLiAgUmVkaXN0 cmlidXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmln aHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lciBpbiB0aGUKKyAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1h dGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCisgKgorICogVEhJUyBTT0ZU V0FSRSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIEFORCBJVFMgQ09OVFJJQlVUT1JTIGBgQVMg SVMnJyBBTkQgQU5ZCisgKiBFWFBSRVNTIE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5H LCBCVVQgTk9UIExJTUlURUQgVE8sIFRIRSBJTVBMSUVECisgKiBXQVJSQU5USUVTIE9GIE1FUkNI QU5UQUJJTElUWSBBTkQgRklUTkVTUyBGT1IgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFCisgKiBE SVNDTEFJTUVELiBJTiBOTyBFVkVOVCBTSEFMTCBBUFBMRSBJTkMuIE9SIElUUyBDT05UUklCVVRP UlMgQkUgTElBQkxFIEZPUiBBTlkKKyAqIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQ RUNJQUwsIEVYRU1QTEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTCisgKiAoSU5DTFVESU5H LCBCVVQgTk9UIExJTUlURUQgVE8sIFBST0NVUkVNRU5UIE9GIFNVQlNUSVRVVEUgR09PRFMgT1Ig U0VSVklDRVM7CisgKiBMT1NTIE9GIFVTRSwgREFUQSwgT1IgUFJPRklUUzsgT1IgQlVTSU5FU1Mg SU5URVJSVVBUSU9OKSBIT1dFVkVSIENBVVNFRCBBTkQgT04KKyAqIEFOWSBUSEVPUlkgT0YgTElB QklMSVRZLCBXSEVUSEVSIElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisg KiAoSU5DTFVESU5HIE5FR0xJR0VOQ0UgT1IgT1RIRVJXSVNFKSBBUklTSU5HIElOIEFOWSBXQVkg T1VUIE9GIFRIRSBVU0UgT0YgVEhJUworICogU09GVFdBUkUsIEVWRU4gSUYgQURWSVNFRCBPRiBU SEUgUE9TU0lCSUxJVFkgT0YgU1VDSCBEQU1BR0UuCisgKi8KKworI2luY2x1ZGUgImNvbmZpZy5o IgorCisjaWYgRU5BQkxFKFdFQl9BVURJTykKKworI2luY2x1ZGUgIkRlbGF5UHJvY2Vzc29yLmgi CisgCisjaW5jbHVkZSAiRGVsYXlEU1BLZXJuZWwuaCIKKworbmFtZXNwYWNlIFdlYkNvcmUgewor CitEZWxheVByb2Nlc3Nvcjo6RGVsYXlQcm9jZXNzb3IoZG91YmxlIHNhbXBsZVJhdGUsIHVuc2ln bmVkIG51bWJlck9mQ2hhbm5lbHMpCisgICAgOiBBdWRpb0RTUEtlcm5lbFByb2Nlc3NvcihzYW1w bGVSYXRlLCBudW1iZXJPZkNoYW5uZWxzKQoreworICAgIG1fZGVsYXlUaW1lID0gQXVkaW9QYXJh bTo6Y3JlYXRlKCJkZWxheVRpbWUiLCAwLjAsIDAuMCwgMS4wKTsKK30KKworRGVsYXlQcm9jZXNz b3I6On5EZWxheVByb2Nlc3NvcigpCit7CisgICAgaWYgKGlzSW5pdGlhbGl6ZWQoKSkKKyAgICAg ICAgdW5pbml0aWFsaXplKCk7Cit9CisKK1Bhc3NPd25QdHI8QXVkaW9EU1BLZXJuZWw+IERlbGF5 UHJvY2Vzc29yOjpjcmVhdGVLZXJuZWwoKQoreworICAgIHJldHVybiBhZG9wdFB0cihuZXcgRGVs YXlEU1BLZXJuZWwodGhpcykpOworfQorCit9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCisKKyNlbmRp ZiAvLyBFTkFCTEUoV0VCX0FVRElPKQpJbmRleDogV2ViQ29yZS93ZWJhdWRpby9EZWxheVByb2Nl c3Nvci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd2ViYXVkaW8vRGVsYXlQcm9jZXNzb3IuaAko cmV2aXNpb24gMCkKKysrIFdlYkNvcmUvd2ViYXVkaW8vRGVsYXlQcm9jZXNzb3IuaAkocmV2aXNp b24gMCkKQEAgLTAsMCArMSw1MyBAQAorLyoKKyAqIENvcHlyaWdodCAoQykgMjAxMCwgR29vZ2xl IEluYy4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KKyAqCisgKiBSZWRpc3RyaWJ1dGlvbiBhbmQgdXNl IGluIHNvdXJjZSBhbmQgYmluYXJ5IGZvcm1zLCB3aXRoIG9yIHdpdGhvdXQKKyAqIG1vZGlmaWNh dGlvbiwgYXJlIHBlcm1pdHRlZCBwcm92aWRlZCB0aGF0IHRoZSBmb2xsb3dpbmcgY29uZGl0aW9u cworICogYXJlIG1ldDoKKyAqIDEuICBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAorICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgorICogMi4gIFJlZGlzdHJp YnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0 CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBkb2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRl cmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlzdHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdB UkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5DLiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElT JycgQU5EIEFOWQorICogRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBUSEUgSU1QTElFRAorICogV0FSUkFOVElFUyBPRiBNRVJDSEFO VEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEgUEFSVElDVUxBUiBQVVJQT1NFIEFSRQorICogRElT Q0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgQVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JT IEJFIExJQUJMRSBGT1IgQU5ZCisgKiBESVJFQ1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVD SUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUworICogKElOQ0xVRElORywg QlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNF UlZJQ0VTOworICogTE9TUyBPRiBVU0UsIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElO VEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OCisgKiBBTlkgVEhFT1JZIE9GIExJQUJJ TElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAorICog KElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9V VCBPRiBUSEUgVVNFIE9GIFRISVMKKyAqIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhF IFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpZm5kZWYgRGVsYXlQcm9jZXNz b3JfaAorI2RlZmluZSBEZWxheVByb2Nlc3Nvcl9oCisKKyNpbmNsdWRlICJBdWRpb0RTUEtlcm5l bFByb2Nlc3Nvci5oIgorI2luY2x1ZGUgIkF1ZGlvUGFyYW0uaCIKKworI2luY2x1ZGUgPHd0Zi9Q YXNzT3duUHRyLmg+CisjaW5jbHVkZSA8d3RmL1JlZlB0ci5oPgorCituYW1lc3BhY2UgV2ViQ29y ZSB7CisKK2NsYXNzIEF1ZGlvRFNQS2VybmVsOworICAgIAorY2xhc3MgRGVsYXlQcm9jZXNzb3Ig OiBwdWJsaWMgQXVkaW9EU1BLZXJuZWxQcm9jZXNzb3IgeworcHVibGljOgorICAgIERlbGF5UHJv Y2Vzc29yKGRvdWJsZSBzYW1wbGVSYXRlLCB1bnNpZ25lZCBudW1iZXJPZkNoYW5uZWxzKTsKKyAg ICB2aXJ0dWFsIH5EZWxheVByb2Nlc3NvcigpOworICAgIAorICAgIHZpcnR1YWwgUGFzc093blB0 cjxBdWRpb0RTUEtlcm5lbD4gY3JlYXRlS2VybmVsKCk7CisgICAgICAgIAorICAgIEF1ZGlvUGFy YW0qIGRlbGF5VGltZSgpIGNvbnN0IHsgcmV0dXJuIG1fZGVsYXlUaW1lLmdldCgpOyB9CisKK3By aXZhdGU6CisgICAgUmVmUHRyPEF1ZGlvUGFyYW0+IG1fZGVsYXlUaW1lOworfTsKKworfSAvLyBu YW1lc3BhY2UgV2ViQ29yZQorCisjZW5kaWYgLy8gRGVsYXlQcm9jZXNzb3JfaAo=