47489 2010-10-11 07:34:06 -0700 WebProcess ASSERTs with a null application cache dir creation parameter 2010-10-11 10:08:11 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned ossy oldest_to_newest 292472 0 kbalazs 2010-10-11 07:34:06 -0700 The app cache dir path we get from the UI side should be chekced and ignored if it is a null or empty string. 292474 1 70434 kbalazs 2010-10-11 07:36:40 -0700 Created attachment 70434 Patch 292475 2 70434 ossy 2010-10-11 07:38:29 -0700 Comment on attachment 70434 Patch LGTM, r=me 292477 3 70434 kbalazs 2010-10-11 07:40:55 -0700 Comment on attachment 70434 Patch wrong, does not tests the value just the pointer 292478 4 70434 kbalazs 2010-10-11 07:42:27 -0700 Comment on attachment 70434 Patch :) 292509 5 70440 kbalazs 2010-10-11 09:52:22 -0700 Created attachment 70440 Patch 292519 6 70440 kbalazs 2010-10-11 10:08:03 -0700 Comment on attachment 70440 Patch Clearing flags on attachment: 70440 Committed r69503: <http://trac.webkit.org/changeset/69503> 292521 7 kbalazs 2010-10-11 10:08:11 -0700 All reviewed patches have been landed. Closing bug. 70434 2010-10-11 07:36:40 -0700 2010-10-11 09:52:16 -0700 Patch bug-47489-20101011163638.patch text/plain 1357 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Njg3MmRiMGNhZjQ1YWNiZTQzZmI5Y2E5ZjQxZjc3YzJhOTA5NWEzZi4uYjhjOWIzYjg0N2UyYTRh ZDI5NjlkMjc1ODhiMzFkOWJjOTU2ZTZmOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0xMSAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUHJvY2VzcyBBU1NFUlRzIHdpdGggYSBudWxs IGFwcGxpY2F0aW9uIGNhY2hlIGRpciBjcmVhdGlvbiBwYXJhbWV0ZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDg5CisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0 aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTAtMTAtMDkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlByb2Nlc3MuY3BwCmluZGV4IDlkZDg2YWViMjFiMmNkNjBiMzNkM2FkN2ViZGJiMThkNDVhZmM4 NzEuLjFiNTJkYjJhOWE1MzMyMmE4NmU2NDg3ZmMxNmM4Mjk4ZTUxNzQwOTggMTAwNjQ0Ci0tLSBh L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUHJvY2Vzcy5jcHAKQEAgLTExNiw3ICsxMTYsOCBAQCB2b2lkIFdlYlByb2Nlc3M6Omlu aXRpYWxpemVXZWJQcm9jZXNzKGNvbnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBh cmFtZQogewogICAgIEFTU0VSVChtX3BhZ2VNYXAuaXNFbXB0eSgpKTsKIAotICAgIGNhY2hlU3Rv cmFnZSgpLnNldENhY2hlRGlyZWN0b3J5KHBhcmFtZXRlcnMuYXBwbGljYXRpb25DYWNoZURpcmVj dG9yeSk7CisgICAgaWYgKCFwYXJhbWV0ZXJzLmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkpCisg ICAgICAgIGNhY2hlU3RvcmFnZSgpLnNldENhY2hlRGlyZWN0b3J5KHBhcmFtZXRlcnMuYXBwbGlj YXRpb25DYWNoZURpcmVjdG9yeSk7CiAKICAgICBpZiAoIXBhcmFtZXRlcnMuaW5qZWN0ZWRCdW5k bGVQYXRoLmlzRW1wdHkoKSkgewogICAgICAgICBtX2luamVjdGVkQnVuZGxlID0gSW5qZWN0ZWRC dW5kbGU6OmNyZWF0ZShwYXJhbWV0ZXJzLmluamVjdGVkQnVuZGxlUGF0aCk7Cg== 70440 2010-10-11 09:52:22 -0700 2010-10-11 10:08:02 -0700 Patch bug-47489-20101011185220.patch text/plain 1367 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Njg3MmRiMGNhZjQ1YWNiZTQzZmI5Y2E5ZjQxZjc3YzJhOTA5NWEzZi4uYjhjOWIzYjg0N2UyYTRh ZDI5NjlkMjc1ODhiMzFkOWJjOTU2ZTZmOCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0xMC0xMSAgQmFs YXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViUHJvY2VzcyBBU1NFUlRzIHdpdGggYSBudWxs IGFwcGxpY2F0aW9uIGNhY2hlIGRpciBjcmVhdGlvbiBwYXJhbWV0ZXIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDg5CisKKyAgICAgICAgKiBXZWJQ cm9jZXNzL1dlYlByb2Nlc3MuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQcm9jZXNzOjppbml0 aWFsaXplV2ViUHJvY2Vzcyk6CisKIDIwMTAtMTAtMDkgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0 Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluLgpkaWZmIC0tZ2l0IGEv V2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlByb2Nlc3MuY3BwIGIvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlByb2Nlc3MuY3BwCmluZGV4IDlkZDg2YWViMjFiMmNkNjBiMzNkM2FkN2ViZGJiMThkNDVhZmM4 NzEuLjkwNTUyOGI3MDg3Yzg3NzFlMzYwODYwMGM3NWZjZjM2NDVkMjY3YTIgMTAwNjQ0Ci0tLSBh L1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQcm9jZXNzLmNwcAorKysgYi9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUHJvY2Vzcy5jcHAKQEAgLTExNiw3ICsxMTYsOCBAQCB2b2lkIFdlYlByb2Nlc3M6Omlu aXRpYWxpemVXZWJQcm9jZXNzKGNvbnN0IFdlYlByb2Nlc3NDcmVhdGlvblBhcmFtZXRlcnMmIHBh cmFtZQogewogICAgIEFTU0VSVChtX3BhZ2VNYXAuaXNFbXB0eSgpKTsKIAotICAgIGNhY2hlU3Rv cmFnZSgpLnNldENhY2hlRGlyZWN0b3J5KHBhcmFtZXRlcnMuYXBwbGljYXRpb25DYWNoZURpcmVj dG9yeSk7CisgICAgaWYgKCFwYXJhbWV0ZXJzLmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkuaXNF bXB0eSgpKQorICAgICAgICBjYWNoZVN0b3JhZ2UoKS5zZXRDYWNoZURpcmVjdG9yeShwYXJhbWV0 ZXJzLmFwcGxpY2F0aW9uQ2FjaGVEaXJlY3RvcnkpOwogCiAgICAgaWYgKCFwYXJhbWV0ZXJzLmlu amVjdGVkQnVuZGxlUGF0aC5pc0VtcHR5KCkpIHsKICAgICAgICAgbV9pbmplY3RlZEJ1bmRsZSA9 IEluamVjdGVkQnVuZGxlOjpjcmVhdGUocGFyYW1ldGVycy5pbmplY3RlZEJ1bmRsZVBhdGgpOwo=