47485 2010-10-11 01:52:02 -0700 SubframeLoader should call setNeedsStyleRecalc() after creating plugin 2010-10-11 08:07:44 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED INVALID P2 Normal --- 35524 1 girish webkit-unassigned noam simon.fraser oldest_to_newest 292443 0 girish 2010-10-11 01:52:02 -0700 RenderLayerCompositor uses setNeedsStyleRecalc() to trigger acclerated compositing layers. This change is a precursor to adding accelerated compositing support for NPAPI plugins. See 35524 for AC support for NPAPI plugins in Qt. 292444 1 70428 girish 2010-10-11 01:54:31 -0700 Created attachment 70428 Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING) 292476 2 70428 simon.fraser 2010-10-11 07:40:48 -0700 Comment on attachment 70428 Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING) View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review > WebCore/loader/SubframeLoader.cpp:371 > pluginElement->setNeedsStyleRecalc(SyntheticStyleChange); Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same? 292485 3 girish 2010-10-11 08:06:50 -0700 (In reply to comment #2) > (From update of attachment 70428 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70428&action=review > > > WebCore/loader/SubframeLoader.cpp:371 > > pluginElement->setNeedsStyleRecalc(SyntheticStyleChange); > > Mac does this via [self element]->setNeedsStyleRecalc(SyntheticStyleChange); in the PluginView code. Why not do the same? Indeed. It is indeed better to make this platform specific since one needs to let the compositor know only if AC is supported by the Chrome and WebKit port supports AC for plugins in that chrome. 70428 2010-10-11 01:54:31 -0700 2010-10-11 08:07:44 -0700 Call setNeedsStyleRecalc if USE(ACCELERATED_COMPOSITING) subframe-patch text/plain 1877 girish Y29tbWl0IDc5MGRiY2ZiOTU4OGY5MTAyNjRkNjYyNmNlMmI4MjlkYzUyY2U1NDUKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgTW9uIE9j dCAxMSAxNDoxNzowOCAyMDEwICswNTMwCgogICAgMjAxMC0xMC0xMSAgR2lyaXNoIFJhbWFrcmlz aG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KICAgIAogICAgICAgICAgICBSZW5kZXJMYXll ckNvbXBvc2l0b3IgdXNlcyBzZXROZWVkc1N0eWxlUmVjYWxjKCkgdG8gdHJpZ2dlciBhY2NsZXJh dGVkIGNvbXBvc2l0aW5nCiAgICAgICAgICAgIGxheWVycy4gVGhpcyBjaGFuZ2UgaXMgYSBwcmVj dXJzb3IgdG8gYWRkaW5nIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIHN1cHBvcnQKICAgICAgICAg ICAgZm9yIE5QQVBJIHBsdWdpbnMuCiAgICAKICAgICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCiAgICAKICAgICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTQ3NDg1CiAgICAKICAgICAgICAgICAgKiBsb2FkZXIvU3ViZnJhbWVMb2FkZXIu Y3BwOgogICAgICAgICAgICAoV2ViQ29yZTo6U3ViZnJhbWVMb2FkZXI6OmxvYWRQbHVnaW4pOgoK ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTk5OTBiYS4uNDM4MzkxMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0xMC0xMSAgR2lyaXNoIFJhbWFr cmlzaG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KKworICAgICAgICBSZW5kZXJMYXllckNv bXBvc2l0b3IgdXNlcyBzZXROZWVkc1N0eWxlUmVjYWxjKCkgdG8gdHJpZ2dlciBhY2NsZXJhdGVk IGNvbXBvc2l0aW5nIAorICAgICAgICBsYXllcnMuIFRoaXMgY2hhbmdlIGlzIGEgcHJlY3Vyc29y IHRvIGFkZGluZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBzdXBwb3J0CisgICAgICAgIGZvciBO UEFQSSBwbHVnaW5zLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQ4NQorCisg ICAgICAgICogbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN1 YmZyYW1lTG9hZGVyOjpsb2FkUGx1Z2luKToKKwogMjAxMC0xMC0wOCAgR2lyaXNoIFJhbWFrcmlz aG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNw cCBiL1dlYkNvcmUvbG9hZGVyL1N1YmZyYW1lTG9hZGVyLmNwcAppbmRleCBkNWQwZTQ2Li42ZTIy YzcyIDEwMDY0NAotLS0gYS9XZWJDb3JlL2xvYWRlci9TdWJmcmFtZUxvYWRlci5jcHAKKysrIGIv V2ViQ29yZS9sb2FkZXIvU3ViZnJhbWVMb2FkZXIuY3BwCkBAIC0zNjcsNyArMzY3LDcgQEAgYm9v bCBTdWJmcmFtZUxvYWRlcjo6bG9hZFBsdWdpbihIVE1MUGx1Z0luSW1hZ2VFbGVtZW50KiBwbHVn aW5FbGVtZW50LCBjb25zdCBLVVIKICAgICByZW5kZXJlci0+c2V0V2lkZ2V0KHdpZGdldCk7CiAg ICAgbV9jb250YWluc1BsdWdpbnMgPSB0cnVlOwogCi0jaWYgRU5BQkxFKFBMVUdJTl9QUk9YWV9G T1JfVklERU8pCisjaWYgRU5BQkxFKFBMVUdJTl9QUk9YWV9GT1JfVklERU8pIHx8IFVTRShBQ0NF TEVSQVRFRF9DT01QT1NJVElORykKICAgICBwbHVnaW5FbGVtZW50LT5zZXROZWVkc1N0eWxlUmVj YWxjKFN5bnRoZXRpY1N0eWxlQ2hhbmdlKTsKICNlbmRpZgogICAgIHJldHVybiB0cnVlOwo=