47481 2010-10-10 23:43:40 -0700 fast/viewport/viewport-45.html fails in GTK+/Qt 2011-06-06 10:21:09 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Linux RESOLVED FIXED LayoutTestFailure, Qt, QtTriaged P2 Normal --- 1 joone webkit-unassigned ademar benjamin cmarcelo commit-queue igor.oliveira kenneth webkit.review.bot xan.lopez oldest_to_newest 292428 0 joone 2010-10-10 23:43:40 -0700 ./run-webkit-tests --gtk fast/viewport/viewport-45.html Running build-dumprendertree Running tests from /home/joone/git/WebKit/LayoutTests Testing 1 test cases. fast/viewport . fast/viewport/viewport-45.html -> failed 0.23s total testing time 1 test case (100%) had incorrect layout Starting webkit launcher. /tmp/layout-test-results/fast/viewport/viewport-45-actual.txt 1 viewport size 3200x3520 scale 0.100000 with limits [0.100000, 0.100000] 1 viewport size 3199x3519 scale 0.100000 with limits [0.100000, 0.100000] 2 2 QWebKit also seems to have the same problem as follows, LayoutTests/platform/qt/Skipped # viewport meta tag tests that fail on the bot for yet unknown reasons fast/viewport/viewport-6.html fast/viewport/viewport-45.html fast/viewport/viewport-58.html 294198 1 kenneth 2010-10-14 10:55:08 -0700 Here are the expected results from Opera. fast/viewport/viewport-6.html Expected values: width=200, height=220, initial-scale=1.6 fast/viewport/viewport-45.html Expected values: width=3200, height=3520, initial-scale=0.1 fast/viewport/viewport-58.html Expected values: width=3200, height=3520, initial-scale=0.1 356216 2 cmarcelo 2011-02-23 11:05:56 -0800 Reproduced with r79438 and Qt 4.7.1 in the tester virtual machine http://webkit.sed.hu/blog/20101028/qtwebkit-builder-and-tester-virtual-machine Curiously, in my Linux 64bits and Qt 4.7.x the three tests pass. 356217 3 cmarcelo 2011-02-23 11:06:47 -0800 ...my Linux 64bits and Qt 4.7.x and QtWebKit from trunk... 413694 4 95670 igor.oliveira 2011-06-01 14:59:52 -0700 Created attachment 95670 Patch Proposed patch. 413699 5 95670 kenneth 2011-06-01 15:12:01 -0700 Comment on attachment 95670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=95670&action=review > LayoutTests/fast/viewport/viewport-86-expected.txt:1 > -viewport size 457x502 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 > +viewport size 457x503 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 Is this correct in comparison with other platforms? 414056 6 igor.oliveira 2011-06-02 05:50:17 -0700 Yeah, Just gtk is testing viewport tag and it works with the new expected result. (In reply to comment #5) > (From update of attachment 95670 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=95670&action=review > > > LayoutTests/fast/viewport/viewport-86-expected.txt:1 > > -viewport size 457x502 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 > > +viewport size 457x503 scale 0.700000 with limits [0.700000, 5.000000] and userScalable -1.000000 > > Is this correct in comparison with other platforms? 415628 7 95670 commit-queue 2011-06-05 11:34:20 -0700 Comment on attachment 95670 Patch Clearing flags on attachment: 95670 Committed r88134: <http://trac.webkit.org/changeset/88134> 415629 8 commit-queue 2011-06-05 11:34:25 -0700 All reviewed patches have been landed. Closing bug. 415880 9 ademar 2011-06-06 10:21:09 -0700 Revision r88134 cherry-picked into qtwebkit-2.2 with commit b1708ec <http://gitorious.org/webkit/qtwebkit/commit/b1708ec> 95670 2011-06-01 14:59:52 -0700 2011-06-05 11:34:19 -0700 Patch 0001-fast-viewport-viewport-45.html-fails-in-GTK-Qt.patch text/plain 4405 igor.oliveira RnJvbSA1OTY5YTNlOWI0ZDE0ZTc0ZDljODZkZjMzNTNlNjdjYzJhOTc0NTY2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBJZ29yIE9saXZlaXJhIDxpZ29yLm9saXZlaXJhQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IFdlZCwgMSBKdW4gMjAxMSAxNzoxODo0MCAtMDQwMApTdWJqZWN0OiBbUEFU Q0hdIGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtNDUuaHRtbCBmYWlscyBpbiBHVEsrL1F0CgotLS0K IExheW91dFRlc3RzL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAx MyArKysrKysrKysrKysrCiBMYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LTQ1LWV4 cGVjdGVkLnR4dCB8ICAgIDIgKy0KIExheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQt ODYtZXhwZWN0ZWQudHh0IHwgICAgMiArLQogTGF5b3V0VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBl ZCAgICAgICAgICAgICAgICAgICAgfCAgICAxIC0KIFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiBTb3VyY2UvV2Vi Q29yZS9kb20vVmlld3BvcnRBcmd1bWVudHMuY3BwICAgICAgICAgICB8ICAgIDQgKystLQogNiBm aWxlcyBjaGFuZ2VkLCAzMCBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA4 ZWY4MTI0Li41NzExOTc2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTEtMDYtMDEgIElnb3Ig T2xpdmVpcmEgIDxpZ29yLm9saXZlaXJhQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgZmFzdC92aWV3cG9ydC92aWV3cG9ydC00 NS5odG1sIGZhaWxzIGluIEdUSysvUXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTQ3NDgxCisKKyAgICAgICAgUmViYXNlbGluZSB0ZXN0cy4KKworICAg ICAgICAqIGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtNDUtZXhwZWN0ZWQudHh0OgorICAgICAgICAq IGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtODYtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRm b3JtL3F0L1NraXBwZWQ6CisKIDIwMTEtMDYtMDEgIFNoaXNoaXIgQWdyYXdhbCAgPHNoaXNoaXJA Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFRvbnkgR2VudGlsY29yZS4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qvdmlld3BvcnQvdmlld3BvcnQtNDUtZXhwZWN0ZWQu dHh0IGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9ydC00NS1leHBlY3RlZC50eHQK aW5kZXggMjQxY2YwOS4uMTU1NTdhNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC92aWV3 cG9ydC92aWV3cG9ydC00NS1leHBlY3RlZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC92aWV3 cG9ydC92aWV3cG9ydC00NS1leHBlY3RlZC50eHQKQEAgLTEsMiArMSwyIEBACi12aWV3cG9ydCBz aXplIDMyMDB4MzUyMCBzY2FsZSAwLjEwMDAwMCB3aXRoIGxpbWl0cyBbMC4xMDAwMDAsIDAuMTAw MDAwXQordmlld3BvcnQgc2l6ZSAzMjAweDM1MjAgc2NhbGUgMC4xMDAwMDAgd2l0aCBsaW1pdHMg WzAuMTAwMDAwLCAwLjEwMDAwMF0gYW5kIHVzZXJTY2FsYWJsZSAtMS4wMDAwMDAKIApkaWZmIC0t Z2l0IGEvTGF5b3V0VGVzdHMvZmFzdC92aWV3cG9ydC92aWV3cG9ydC04Ni1leHBlY3RlZC50eHQg Yi9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0L3ZpZXdwb3J0LTg2LWV4cGVjdGVkLnR4dAppbmRl eCAzMzI4ZGViLi5lY2Y5MjY1IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0 L3ZpZXdwb3J0LTg2LWV4cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3ZpZXdwb3J0 L3ZpZXdwb3J0LTg2LWV4cGVjdGVkLnR4dApAQCAtMSwyICsxLDIgQEAKLXZpZXdwb3J0IHNpemUg NDU3eDUwMiBzY2FsZSAwLjcwMDAwMCB3aXRoIGxpbWl0cyBbMC43MDAwMDAsIDUuMDAwMDAwXSBh bmQgdXNlclNjYWxhYmxlIC0xLjAwMDAwMAordmlld3BvcnQgc2l6ZSA0NTd4NTAzIHNjYWxlIDAu NzAwMDAwIHdpdGggbGltaXRzIFswLjcwMDAwMCwgNS4wMDAwMDBdIGFuZCB1c2VyU2NhbGFibGUg LTEuMDAwMDAwCiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQg Yi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9xdC9Ta2lwcGVkCmluZGV4IDEyMTM0NzEuLjdmOWI4MDIg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL3F0L1NraXBwZWQKKysrIGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vcXQvU2tpcHBlZApAQCAtMjA0NSw3ICsyMDQ1LDYgQEAgZmFzdC92aWV3 cG9ydC92aWV3cG9ydC0xMjcuaHRtbAogCiAjIHZpZXdwb3J0IG1ldGEgdGFnIHRlc3RzIHRoYXQg ZmFpbCBvbiB0aGUgYm90IGZvciB5ZXQgdW5rbm93biByZWFzb25zCiBmYXN0L3ZpZXdwb3J0L3Zp ZXdwb3J0LTYuaHRtbAotZmFzdC92aWV3cG9ydC92aWV3cG9ydC00NS5odG1sCiBmYXN0L3ZpZXdw b3J0L3ZpZXdwb3J0LTU4Lmh0bWwKIAogIyBbUXRdUkVHUkVTU0lPTj8gKHI2Nzc2Mik6IDIzIGxh eW91dCB0ZXN0cyBmYWlsCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjIxNzA0My4uYTQ2MGRiMiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTA2LTAxICBJZ29yIE9saXZlaXJhICA8aWdvci5vbGl2 ZWlyYUBvcGVuYm9zc2Eub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIGZhc3Qvdmlld3BvcnQvdmlld3BvcnQtNDUuaHRtbCBmYWlscyBpbiBHVEsr L1F0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQ4 MQorCisgICAgICAgIGNvbXB1dGVWaWV3cG9ydEF0dHJpYnV0ZXMgZG9lcyBtYW55IG1hdGggb3Bl cmF0aW9ucyB3aXRoIGZsb2F0IHBvaW50IGFyaXRobWV0aWMKKyAgICAgICAgYW5kIGluIHNvbWUg Y2FzZXMgdGhlcmUgaXMgbG9zcyBvZiBwcmVjaXNpb24gbWFraW5nIHRlc3RzIGhhdmUgaW5jb3Jy ZWN0IHZhbHVlcy4KKworICAgICAgICAqIGRvbS9WaWV3cG9ydEFyZ3VtZW50cy5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpjb21wdXRlVmlld3BvcnRBdHRyaWJ1dGVzKToKKwogMjAxMS0wNi0wMSAg WXVyeSBTZW1pa2hhdHNreSAgPHl1cnlzQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBQYXZlbCBGZWxkbWFuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL1ZpZXdw b3J0QXJndW1lbnRzLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9WaWV3cG9ydEFyZ3VtZW50cy5j cHAKaW5kZXggNDljOTRkNy4uNzFmMTY4MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9t L1ZpZXdwb3J0QXJndW1lbnRzLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vVmlld3BvcnRB cmd1bWVudHMuY3BwCkBAIC0xNjQsOCArMTY0LDggQEAgVmlld3BvcnRBdHRyaWJ1dGVzIGNvbXB1 dGVWaWV3cG9ydEF0dHJpYnV0ZXMoVmlld3BvcnRBcmd1bWVudHMgYXJncywgaW50IGRlc2t0b3AK ICAgICAvLyBFeHRlbmQgd2lkdGggYW5kIGhlaWdodCB0byBmaWxsIHRoZSB2aXN1YWwgdmlld3Bv cnQgZm9yIHRoZSByZXNvbHZlZCBpbml0aWFsLXNjYWxlLgogICAgIHdpZHRoID0gbWF4KHdpZHRo LCBhdmFpbGFibGVXaWR0aCAvIHJlc3VsdC5pbml0aWFsU2NhbGUpOwogICAgIGhlaWdodCA9IG1h eChoZWlnaHQsIGF2YWlsYWJsZUhlaWdodCAvIHJlc3VsdC5pbml0aWFsU2NhbGUpOwotICAgIHJl c3VsdC5sYXlvdXRTaXplLnNldFdpZHRoKHdpZHRoKTsKLSAgICByZXN1bHQubGF5b3V0U2l6ZS5z ZXRIZWlnaHQoaGVpZ2h0KTsKKyAgICByZXN1bHQubGF5b3V0U2l6ZS5zZXRXaWR0aChzdGF0aWNf Y2FzdDxpbnQ+KHJvdW5kZih3aWR0aCkpKTsKKyAgICByZXN1bHQubGF5b3V0U2l6ZS5zZXRIZWln aHQoc3RhdGljX2Nhc3Q8aW50Pihyb3VuZGYoaGVpZ2h0KSkpOwogCiAgICAgLy8gVXBkYXRlIG1p bmltdW0gc2NhbGUgZmFjdG9yLCB0byBuZXZlciBhbGxvdyB6b29taW5nIG91dCBtb3JlIHRoYW4g dmlld3BvcnQKICAgICByZXN1bHQubWluaW11bVNjYWxlID0gbWF4KHJlc3VsdC5taW5pbXVtU2Nh bGUsIG1heChhdmFpbGFibGVXaWR0aCAvIHdpZHRoLCBhdmFpbGFibGVIZWlnaHQgLyBoZWlnaHQp KTsKLS0gCjEuNy40LjEKCg==