47470 2010-10-10 10:12:59 -0700 [cairo] Typo in determining fixed width fonts 2010-10-14 10:25:01 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zecke zecke eric mrobinson oldest_to_newest 292320 0 zecke 2010-10-10 10:12:59 -0700 FontPlatformDataFreeType.cpp appears to have a thinko. It is mostly meant to use a '&' instead of a '&&' or otherwise the the whole '&& Constant' is not needed. 292321 1 70408 zecke 2010-10-10 10:17:14 -0700 Created attachment 70408 Attempt to fix it... The patch most likely requires fixes to the test results. 293582 2 mrobinson 2010-10-13 12:03:42 -0700 This fix does not seem to change any test results which is somewhat worrying. The fix is obvious right to me, so I'm going to r+ it, but in the future it might be good to check if this code can be removed. I notice that isFixedPitch is notImplemented in Chromium. 293584 3 70408 mrobinson 2010-10-13 12:04:06 -0700 Comment on attachment 70408 Attempt to fix it... Thanks for finding this. 293620 4 eric 2010-10-13 12:27:58 -0700 Attachment 70408 was posted by a committer and has review+, assigning to Holger Freyther for commit. 294177 5 zecke 2010-10-14 10:25:01 -0700 Landed in r69776. 70408 2010-10-10 10:17:14 -0700 2010-10-13 12:04:06 -0700 Attempt to fix it... 0001-cairo-Typo-in-determining-fixed-width-fonts.patch text/plain 2113 zecke RnJvbSBmNDY3ZWNiNmM4YmUyZTk0NjM3MDQ5MTgzNTA1NzU4NjA1NjU5OTIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBIb2xnZXIgSGFucyBQZXRlciBGcmV5dGhlciA8aG9sZ2VyQG1v aWppLW1vYmlsZS5jb20+CkRhdGU6IFN1biwgMTAgT2N0IDIwMTAgMTk6MTU6MTggKzAyMDAKU3Vi amVjdDogW1BBVENIXSBbY2Fpcm9dIFR5cG8gaW4gZGV0ZXJtaW5pbmcgZml4ZWQgd2lkdGggZm9u dHMKIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQ3MAoKSXQgbXVz dCBiZSBhIHNpbmdsZSBhbXBlcnNhbmQgb3RoZXJ3aXNlIHRoZQomJiBGVF9GQUNFX0ZMQUdfRklY RURfV0lEVEggd2lsbCBhbHdheXMgYmUgdHJ1ZS4KCiogcGxhdGZvcm0vZ3JhcGhpY3MvY2Fpcm8v Rm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcDoKKFdlYkNvcmU6OkZvbnRQbGF0Zm9ybURhdGE6 OkZvbnRQbGF0Zm9ybURhdGEpOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxMyArKysrKysrKysrKysrCiAuLi4vZ3JhcGhpY3MvY2Fp cm8vRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcCAgICB8ICAgIDIgKy0KIDIgZmlsZXMgY2hh bmdlZCwgMTQgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJD b3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDliMzcyZmIuLjI2NGRhYmUg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMTAgIEhvbGdlciBIYW5zIFBldGVyIEZyZXl0aGVyICA8 aG9sZ2VyQG1vaWppLW1vYmlsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgW2NhaXJvXSBUeXBvIGluIGRldGVybWluaW5nIGZpeGVkIHdpZHRo IGZvbnRzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NzQ3MAorCisgICAgICAgIEl0IG11c3QgYmUgYSBzaW5nbGUgYW1wZXJzYW5kIG90aGVyd2lzZSB0 aGUKKyAgICAgICAgJiYgRlRfRkFDRV9GTEFHX0ZJWEVEX1dJRFRIIHdpbGwgYWx3YXlzIGJlIHRy dWUuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxhdGZvcm1EYXRh RnJlZVR5cGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Rm9udFBsYXRmb3JtRGF0YTo6Rm9udFBs YXRmb3JtRGF0YSk6CisKIDIwMTAtMTAtMDkgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxhdGZvcm1EYXRhRnJlZVR5cGUu Y3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jYWlyby9Gb250UGxhdGZvcm1EYXRhRnJl ZVR5cGUuY3BwCmluZGV4IDZhNGI4OTYuLmQwOWNhNzQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2Fpcm8vRm9udFBsYXRmb3JtRGF0YUZyZWVUeXBlLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2NhaXJvL0ZvbnRQbGF0Zm9ybURhdGFGcmVlVHlwZS5j cHAKQEAgLTEzNSw3ICsxMzUsNyBAQCBGb250UGxhdGZvcm1EYXRhOjpGb250UGxhdGZvcm1EYXRh KGNhaXJvX2ZvbnRfZmFjZV90KiBmb250RmFjZSwgZmxvYXQgc2l6ZSwgYm9vbAogCiAgICAgRlRf RmFjZSBmb250Q29uZmlnRmFjZSA9IGNhaXJvX2Z0X3NjYWxlZF9mb250X2xvY2tfZmFjZShtX3Nj YWxlZEZvbnQuZ2V0KCkpOwogICAgIGlmIChmb250Q29uZmlnRmFjZSkgewotICAgICAgICBtX2Zp eGVkV2lkdGggPSBmb250Q29uZmlnRmFjZS0+ZmFjZV9mbGFncyAmJiBGVF9GQUNFX0ZMQUdfRklY RURfV0lEVEg7CisgICAgICAgIG1fZml4ZWRXaWR0aCA9IGZvbnRDb25maWdGYWNlLT5mYWNlX2Zs YWdzICYgRlRfRkFDRV9GTEFHX0ZJWEVEX1dJRFRIOwogICAgICAgICBjYWlyb19mdF9zY2FsZWRf Zm9udF91bmxvY2tfZmFjZShtX3NjYWxlZEZvbnQuZ2V0KCkpOwogICAgIH0KIH0KLS0gCjEuNy4z LjEKCg==