47463 2010-10-09 22:02:16 -0700 autocomplete=off prevents refilling form fields on back/forward navigation 2011-02-23 20:37:58 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap webkit-unassigned abarth arv beidson jhawkins ojan sullivan tkent tony oldest_to_newest 292255 0 ap 2010-10-09 22:02:16 -0700 Steps to reproduce: 1. Go to https://bugs.webkit.org/query.cgi 2. Enter an e-mail address in "Email Addresses and Bug Numbers", e.g. in "assigned to" field. 3. Press Enter. 4. Press Back. Results: there is no e-mail address there any more. I think that this regressed when e-mail address autocompletion was added. 325117 1 ap 2010-12-21 11:50:56 -0800 This is still causing trouble for me, almost daily. 325415 2 abarth 2010-12-22 00:38:04 -0800 Maybe Ojan has some insight into this issue? 327559 3 ojan 2010-12-29 07:31:13 -0800 When you focus an email input field, the JS code sets autocomplete=off to avoid getting the browser built-in dropdown. I just did a quick test, apparently that disables the autofill behavior on back. So, that's certainly the cause. Is there another way to disable the browser dropdown? Can't preventDefault because that would also prevent inserting the character. 334105 4 ap 2011-01-13 21:38:41 -0800 I don't know the answer to your question. However, - is it a bug that autocomplete=off disables restoring form state on back/forward? - why doesn't the Bugzilla advanced search page go into b/f cache at least? 334334 5 ojan 2011-01-14 09:01:50 -0800 Erik, do you know if there's a way to make this work, i.e., to avoid the browser dropdown when typing in an input, but keep the autofill behavior when going back? 335944 6 arv 2011-01-18 11:13:49 -0800 (In reply to comment #5) > Erik, do you know if there's a way to make this work, i.e., to avoid the browser dropdown when typing in an input, but keep the autofill behavior when going back? I don't know if there is another way to prevent the drop down but it seems wrong to not restore the input states when going back to a page. I don't see why autofill should be related to that behavior. 335953 7 ojan 2011-01-18 11:22:59 -0800 Sounds like that's the bug to me. Who knows about form filling that we can CC here to confirm? 336194 8 tkent 2011-01-18 16:23:54 -0800 This behavior for autocomplete is a part of fixing Bug 23346. I don't remember the specific reason for autocomplete... 350724 9 ap 2011-02-14 09:57:43 -0800 Could we perhaps remove autocomplete from these fields as a temporary measure? 350731 10 beidson 2011-02-14 10:08:05 -0800 (In reply to comment #4) > I don't know the answer to your question. However, > - is it a bug that autocomplete=off disables restoring form state on back/forward? No, it is not a bug. It is intentional. Banks require that autocomplete=off means no form restoration on back/forward. 352647 11 ojan 2011-02-17 00:37:26 -0800 (In reply to comment #9) > Could we perhaps remove autocomplete from these fields as a temporary measure? You mean turn off email autocomplete entirely or remove the autocomplete property? If you mean the latter, then it doesn't work very well because both the custom autocomplete and the browser's autocomplete menus show up. When the browser's menu is up, the custom menu doesn't function. I see a few options: 1. Go back to using browser extensions to enable autocomplete. 2. Use browser extensions to disable the custom autocomplete. 3. Add a new attribute that disables to browser autocomplete dropdown, but not formfill on page load. If someone is willing to do the work, 3 seems best since this it's likely other web developers will want it. 352683 12 ap 2011-02-17 01:38:17 -0800 I've been thinking of returning to built-in Bugzilla behavior for these two fields only. Personally, I see huge benefit from the new autocomplete when adding people to CC list. In advanced search, I'm more likely to know e-mail address (or a sufficient part of it) for the person upfront. 353388 13 ojan 2011-02-17 21:02:20 -0800 (In reply to comment #12) > I've been thinking of returning to built-in Bugzilla behavior for these two fields only. Personally, I see huge benefit from the new autocomplete when adding people to CC list. In advanced search, I'm more likely to know e-mail address (or a sufficient part of it) for the person upfront. That certainly doesn't match my experience, but I don't feel strongly either way. 355372 14 tony 2011-02-22 10:26:14 -0800 Can we just re-enable autocomplete on form submit? Here's an example that turns off autocomplete on focus, but re-enables it on submit. It seems to remember the form contents when I press back. http://ponderer.org/tests/form-autocomplete.html 355912 15 ojan 2011-02-23 00:14:24 -0800 Yeah. That seems to work. So really, we just need to add the following to where we set autocomplete="off": input.form.addEventListener("submit", function() { input.setAttribute("autocomplete", "on"); }, false); 355913 16 83454 ojan 2011-02-23 00:21:38 -0800 Created attachment 83454 Patch 356646 17 ojan 2011-02-23 20:22:17 -0800 Committed r79515: <http://trac.webkit.org/changeset/79515> 356649 18 ojan 2011-02-23 20:33:26 -0800 Yay, it works! 356651 19 ap 2011-02-23 20:37:58 -0800 Thank you thank you thank you!!! 83454 2011-02-23 00:21:38 -0800 2011-02-23 09:46:57 -0800 Patch bug-47463-20110223192135.patch text/plain 2062 ojan U3VidmVyc2lvbiBSZXZpc2lvbjogNzkzOTkKZGlmZiAtLWdpdCBhL1dlYnNpdGVzL2J1Z3Mud2Vi a2l0Lm9yZy9DaGFuZ2VMb2cgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5vcmcvQ2hhbmdlTG9nCmlu ZGV4IGYyODVkN2IzZjk0OTMxYjQ1ZWY5NGY4ODk0NDM5MDIxZjQyN2ZmMDguLjdhZjM1MTU4Y2Rh YmU5MDhiYjBmM2YwZjNiMmE3ZTlhY2ZmZGI5ZTggMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mu d2Via2l0Lm9yZy9DaGFuZ2VMb2cKKysrIGIvV2Vic2l0ZXMvYnVncy53ZWJraXQub3JnL0NoYW5n ZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDExLTAyLTIzICBPamFuIFZhZmFpICA8b2phbkBjaHJv bWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgYXV0b2NvbXBsZXRlPW9mZiBwcmV2ZW50cyByZWZpbGxpbmcgZm9ybSBmaWVsZHMgb24gYmFj ay9mb3J3YXJkIG5hdmlnYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTQ3NDYzCisKKyAgICAgICAgSSBoYXZlbid0IGFjdHVhbGx5IHJ1biB0aGlz IHBhdGNoIGR1ZSB0byB0aGUgZGlmZmljdWx0eSBvZiBnZXR0aW5nCisgICAgICAgIGEgYnVnemls bGEgaW5zdGFuY2UgcnVubmluZy4gSXQncyBzaW1wbGUgZW5vdWdoIGNvZGUgdGhhdCBJJ20gbm90 IHRvbyB3b3JyaWVkCisgICAgICAgIGFib3V0IGl0LgorCisgICAgICAgICogY29tbWl0dGVycy1h dXRvY29tcGxldGUuanM6CisKIDIwMTEtMDItMjEgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVt Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2Vi c2l0ZXMvYnVncy53ZWJraXQub3JnL2NvbW1pdHRlcnMtYXV0b2NvbXBsZXRlLmpzIGIvV2Vic2l0 ZXMvYnVncy53ZWJraXQub3JnL2NvbW1pdHRlcnMtYXV0b2NvbXBsZXRlLmpzCmluZGV4IGVhOTQ3 YTQxMmEyNmFjODRjZWNiZjI3NTU5Nzg3NDcwODNiYzJkMmUuLjhkMDcxYWFiNjY2YzJkNTc4NTJi MWYyYTE2NGY0YmFjNzk4OTcwMTMgMTAwNjQ0Ci0tLSBhL1dlYnNpdGVzL2J1Z3Mud2Via2l0Lm9y Zy9jb21taXR0ZXJzLWF1dG9jb21wbGV0ZS5qcworKysgYi9XZWJzaXRlcy9idWdzLndlYmtpdC5v cmcvY29tbWl0dGVycy1hdXRvY29tcGxldGUuanMKQEAgLTM3MSw2ICszNzEsNyBAQCBXZWJLaXRD b21taXR0ZXJzID0gKGZ1bmN0aW9uKCkgewogCiAgICAgICAgIGlmICghZ2V0TWVudSgpKSB7CiAg ICAgICAgICAgICBjcmVhdGVNZW51KG1fZm9jdXNlZElucHV0Lm5hbWUpOworICAgICAgICAgICAg Ly8gVHVybiBvZmYgYXV0b2NvbXBsZXRlIHRvIGF2b2lkIHNob3dpbmcgdGhlIGJyb3dzZXIncyBk cm9wZG93biBtZW51LgogICAgICAgICAgICAgbV9mb2N1c2VkSW5wdXQuc2V0QXR0cmlidXRlKCdh dXRvY29tcGxldGUnLCAnb2ZmJyk7CiAgICAgICAgICAgICBtX2ZvY3VzZWRJbnB1dC5hZGRFdmVu dExpc3RlbmVyKCdrZXl1cCcsIGhhbmRsZUtleVVwLCBmYWxzZSk7CiAgICAgICAgICAgICBtX2Zv Y3VzZWRJbnB1dC5hZGRFdmVudExpc3RlbmVyKCdrZXlkb3duJywgaGFuZGxlS2V5RG93biwgZmFs c2UpOwpAQCAtMzc5LDYgKzM4MCwxMCBAQCBXZWJLaXRDb21taXR0ZXJzID0gKGZ1bmN0aW9uKCkg ewogICAgICAgICAgICAgICAgIG1fcHJlZml4ID0gbnVsbDsKICAgICAgICAgICAgICAgICBtX3Nl bGVjdGVkSW5kZXggPSAwOwogICAgICAgICAgICAgfSwgZmFsc2UpOworICAgICAgICAgICAgLy8g VHVybiBvbiBhdXRvY29tcGxldGUgb24gc3VibWl0IHRvIGF2b2lkIGJyZWFraW5nIGF1dG9maWxs IG9uIGJhY2svZm9yd2FyZCBuYXZpZ2F0aW9uLgorICAgICAgICAgICAgbV9mb2N1c2VkSW5wdXQu Zm9ybS5hZGRFdmVudExpc3RlbmVyKCJzdWJtaXQiLCBmdW5jdGlvbigpIHsKKyAgICAgICAgICAg ICAgICBtX2ZvY3VzZWRJbnB1dC5zZXRBdHRyaWJ1dGUoImF1dG9jb21wbGV0ZSIsICJvbiIpOwor ICAgICAgICAgICAgfSwgZmFsc2UpOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICB1cGRh dGVNZW51KCk7Cg==