47456 2010-10-09 13:56:52 -0700 Exception in committers-autocomplete in Firefox 2010-10-09 21:17:21 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap webkit-unassigned abarth commit-queue oldest_to_newest 292192 0 ap 2010-10-09 13:56:52 -0700 Steps to reproduce: open any b.w.o bug in Firefox. Not sure if you need to be logged in. Missing last argument in addEventListener at line 387. 292240 1 abarth 2010-10-09 19:43:01 -0700 Should be an easy patch. 292242 2 70383 abarth 2010-10-09 19:47:57 -0700 Created attachment 70383 Patch 292246 3 70383 ap 2010-10-09 20:45:05 -0700 Comment on attachment 70383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70383&action=review > BugsSite/ChangeLog:10 > + Remove dependency on a WebKit-only quirk. IMHO, this quirk is bad for > + the long-term health of the web, but that's a discussion for another > + patch. This has been discussed before. Requiring that useless arguments are passed explicitly is also not super great. 292249 4 70383 commit-queue 2010-10-09 21:17:16 -0700 Comment on attachment 70383 Patch Clearing flags on attachment: 70383 Committed r69464: <http://trac.webkit.org/changeset/69464> 292250 5 commit-queue 2010-10-09 21:17:21 -0700 All reviewed patches have been landed. Closing bug. 70383 2010-10-09 19:47:57 -0700 2010-10-09 21:17:16 -0700 Patch bug-47456-20101009194756.patch text/plain 2390 abarth SW5kZXg6IEJ1Z3NTaXRlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBCdWdzU2l0ZS9DaGFuZ2VM b2cJKHJldmlzaW9uIDY5NDYzKQorKysgQnVnc1NpdGUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkp CkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMDkgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0 Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF eGNlcHRpb24gaW4gY29tbWl0dGVycy1hdXRvY29tcGxldGUgaW4gRmlyZWZveAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc0NTYKKworICAgICAgICBS ZW1vdmUgZGVwZW5kZW5jeSBvbiBhIFdlYktpdC1vbmx5IHF1aXJrLiAgSU1ITywgdGhpcyBxdWly ayBpcyBiYWQgZm9yCisgICAgICAgIHRoZSBsb25nLXRlcm0gaGVhbHRoIG9mIHRoZSB3ZWIsIGJ1 dCB0aGF0J3MgYSBkaXNjdXNzaW9uIGZvciBhbm90aGVyCisgICAgICAgIHBhdGNoLgorCisgICAg ICAgICogY29tbWl0dGVycy1hdXRvY29tcGxldGUuanM6CisKIDIwMTAtMTAtMDggIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBPbGl2ZXIgSHVu dC4KSW5kZXg6IEJ1Z3NTaXRlL2NvbW1pdHRlcnMtYXV0b2NvbXBsZXRlLmpzCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIEJ1Z3NTaXRlL2NvbW1pdHRlcnMtYXV0b2NvbXBsZXRlLmpzCShyZXZpc2lvbiA2OTQ2MykK KysrIEJ1Z3NTaXRlL2NvbW1pdHRlcnMtYXV0b2NvbXBsZXRlLmpzCSh3b3JraW5nIGNvcHkpCkBA IC0yNzcsMTIgKzI3NywxMiBAQCBXZWJLaXRDb21taXR0ZXJzID0gKGZ1bmN0aW9uKCkgewogICAg ICAgICAgICAgbWVudS5hZGRFdmVudExpc3RlbmVyKCdtb3VzZWRvd24nLCBmdW5jdGlvbihlKSB7 CiAgICAgICAgICAgICAgICAgc2VsZWN0SXRlbShnZXRJbmRleChlLnRhcmdldCkpOwogICAgICAg ICAgICAgICAgIGUucHJldmVudERlZmF1bHQoKTsKLSAgICAgICAgICAgIH0pOworICAgICAgICAg ICAgfSwgZmFsc2UpOwogCiAgICAgICAgICAgICBtZW51LmFkZEV2ZW50TGlzdGVuZXIoJ21vdXNl dXAnLCBmdW5jdGlvbihlKSB7CiAgICAgICAgICAgICAgICAgaWYgKG1fc2VsZWN0ZWRJbmRleCA9 PSBnZXRJbmRleChlLnRhcmdldCkpCiAgICAgICAgICAgICAgICAgICAgIGluc2VydFNlbGVjdGVk SXRlbSgpOwotICAgICAgICAgICAgfSk7CisgICAgICAgICAgICB9LCBmYWxzZSk7CiAgICAgICAg ICAgICAKICAgICAgICAgICAgIG1fbWVudXNbbmFtZV0gPSBtZW51OwogICAgICAgICB9CkBAIC0z NzIsMTMgKzM3MiwxMyBAQCBXZWJLaXRDb21taXR0ZXJzID0gKGZ1bmN0aW9uKCkgewogICAgICAg ICBpZiAoIWdldE1lbnUoKSkgewogICAgICAgICAgICAgY3JlYXRlTWVudShtX2ZvY3VzZWRJbnB1 dC5uYW1lKTsKICAgICAgICAgICAgIG1fZm9jdXNlZElucHV0LnNldEF0dHJpYnV0ZSgnYXV0b2Nv bXBsZXRlJywgJ29mZicpOwotICAgICAgICAgICAgbV9mb2N1c2VkSW5wdXQuYWRkRXZlbnRMaXN0 ZW5lcigna2V5dXAnLCBoYW5kbGVLZXlVcCk7Ci0gICAgICAgICAgICBtX2ZvY3VzZWRJbnB1dC5h ZGRFdmVudExpc3RlbmVyKCdrZXlkb3duJywgaGFuZGxlS2V5RG93bik7CisgICAgICAgICAgICBt X2ZvY3VzZWRJbnB1dC5hZGRFdmVudExpc3RlbmVyKCdrZXl1cCcsIGhhbmRsZUtleVVwLCBmYWxz ZSk7CisgICAgICAgICAgICBtX2ZvY3VzZWRJbnB1dC5hZGRFdmVudExpc3RlbmVyKCdrZXlkb3du JywgaGFuZGxlS2V5RG93biwgZmFsc2UpOwogICAgICAgICAgICAgbV9mb2N1c2VkSW5wdXQuYWRk RXZlbnRMaXN0ZW5lcignYmx1cicsIGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgICAgIHNob3dN ZW51KGZhbHNlKTsKICAgICAgICAgICAgICAgICBtX3ByZWZpeCA9IG51bGw7CiAgICAgICAgICAg ICAgICAgbV9zZWxlY3RlZEluZGV4ID0gMDsKLSAgICAgICAgICAgIH0pOworICAgICAgICAgICAg fSwgZmFsc2UpOwogICAgICAgICB9CiAgICAgICAgIAogICAgICAgICB1cGRhdGVNZW51KCk7CkBA IC0zOTEsNyArMzkxLDcgQEAgV2ViS2l0Q29tbWl0dGVycyA9IChmdW5jdGlvbigpIHsKICAgICAg ICAgICAgICAgICBicmVhazsKICAgICAgICAgICAgIH0KICAgICAgICAgfQotICAgIH0pOworICAg IH0sIGZhbHNlKTsKIAogICAgIFdlYktpdENvbW1pdHRlcnMuZ2V0Q29tbWl0dGVycyhmdW5jdGlv biAoY29tbWl0dGVycykgewogICAgICAgICBtX2NvbW1pdHRlcnMgPSBjb21taXR0ZXJzOwo=