47455 2010-10-09 13:07:18 -0700 [Qt] Compile fails when building qtwebkit with the "--v8" option... 2010-10-14 12:23:07 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 adawit webkit-unassigned commit-queue oldest_to_newest 292167 0 adawit 2010-10-09 13:07:18 -0700 Because of the following #include sequence in the generated webkit v8 source files: V8Proxy.h -> PlatformBridge.h -> npapi.h -> Xlib.h -> X.h That sequence leads to the word "None" being defined as #ifndef None #define None 0L /* universal null resource or null atom */ #endif in X.h. Unfortunately that leads to the "None" in "v8::None" enum values being changed to v8::0L by the gcc preprocessor... 292168 1 70366 adawit 2010-10-09 13:09:29 -0700 Created attachment 70366 Proposed patch to fix compile issue... 292173 2 70366 kling 2010-10-09 13:20:44 -0700 Comment on attachment 70366 Proposed patch to fix compile issue... View in context: https://bugs.webkit.org/attachment.cgi?id=70366&action=review > WebCore/platform/qt/PlatformBridge.h:80 > class NPObject; > +class NPP; Snag this from ChromiumBridge.h instead: typedef struct NPObject NPObject; typedef struct _NPP NPP_t; typedef NPP_t* NPP; 292174 3 70368 adawit 2010-10-09 13:20:48 -0700 Created attachment 70368 Proposed patch [Update 1]... 292177 4 70368 kling 2010-10-09 13:24:09 -0700 Comment on attachment 70368 Proposed patch [Update 1]... r=me 294273 5 70368 commit-queue 2010-10-14 12:22:58 -0700 Comment on attachment 70368 Proposed patch [Update 1]... Clearing flags on attachment: 70368 Committed r69791: <http://trac.webkit.org/changeset/69791> 294274 6 commit-queue 2010-10-14 12:23:07 -0700 All reviewed patches have been landed. Closing bug. 70366 2010-10-09 13:09:29 -0700 2010-10-09 13:20:48 -0700 Proposed patch to fix compile issue... bug_47455_fix_compile_with_v8_engine.patch text/plain 923 adawit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjBlYjA5Ny4uNTdmYTE4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMC0wOSAgRGF3aXQgQWxlbWF5 ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGNvbXBpbGUgZXJyb3Igd2hlbiBidWxkaW5nIHdlYmtpdCdzIFF0 IHBvcnQgdXNpbmcgdGhlICItLXY4IiBvcHRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQ1NQorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxh dGZvcm1CcmlkZ2UuaDoKKwogMjAxMC0xMC0wMiAgRGF3aXQgQWxlbWF5ZWh1ICA8YWRhd2l0QGtk ZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1CcmlkZ2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0v cXQvUGxhdGZvcm1CcmlkZ2UuaAppbmRleCA5MThlMTM5Li5lNDQxMTE2IDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtQnJpZGdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9xdC9QbGF0Zm9ybUJyaWRnZS5oCkBAIC0yNyw3ICsyNyw2IEBACiAjZGVmaW5lIFBsYXRmb3Jt QnJpZGdlX2gKIAogI2luY2x1ZGUgIktVUkwuaCIKLSNpbmNsdWRlICJucGFwaS5oIgogI2luY2x1 ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CkBAIC03OCw2 ICs3Nyw3IEBACiAKIAogY2xhc3MgTlBPYmplY3Q7CitjbGFzcyBOUFA7CiAKIG5hbWVzcGFjZSBX ZWJDb3JlIHsKIAo= 70368 2010-10-09 13:20:48 -0700 2010-10-14 12:22:58 -0700 Proposed patch [Update 1]... bug_47455_fix_compile_with_v8_engine.patch text/plain 1049 adawit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjBlYjA5Ny4uNTdmYTE4NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxMC0xMC0wOSAgRGF3aXQgQWxlbWF5 ZWh1ICA8YWRhd2l0QGtkZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgRml4IGNvbXBpbGUgZXJyb3Igd2hlbiBidWxkaW5nIHdlYmtpdCdzIFF0 IHBvcnQgdXNpbmcgdGhlICItLXY4IiBvcHRpb24uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQ1NQorCisgICAgICAgICogcGxhdGZvcm0vcXQvUGxh dGZvcm1CcmlkZ2UuaDoKKwogMjAxMC0xMC0wMiAgRGF3aXQgQWxlbWF5ZWh1ICA8YWRhd2l0QGtk ZS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkKZGlmZiAtLWdpdCBh L1dlYkNvcmUvcGxhdGZvcm0vcXQvUGxhdGZvcm1CcmlkZ2UuaCBiL1dlYkNvcmUvcGxhdGZvcm0v cXQvUGxhdGZvcm1CcmlkZ2UuaAppbmRleCA5MThlMTM5Li5lNDc4ZDhmIDEwMDY0NAotLS0gYS9X ZWJDb3JlL3BsYXRmb3JtL3F0L1BsYXRmb3JtQnJpZGdlLmgKKysrIGIvV2ViQ29yZS9wbGF0Zm9y bS9xdC9QbGF0Zm9ybUJyaWRnZS5oCkBAIC0yNyw3ICsyNyw2IEBACiAjZGVmaW5lIFBsYXRmb3Jt QnJpZGdlX2gKIAogI2luY2x1ZGUgIktVUkwuaCIKLSNpbmNsdWRlICJucGFwaS5oIgogI2luY2x1 ZGUgIlBsYXRmb3JtU3RyaW5nLmgiCiAKICNpbmNsdWRlIDx3dGYvVmVjdG9yLmg+CkBAIC03Nyw3 ICs3Niw5IEBACiAgICBzdGF0aWNfY2FzdDxzaXplX3Q+KCEoc2l6ZW9mKGEpICUgc2l6ZW9mKCoo YSkpKSkpCiAKIAotY2xhc3MgTlBPYmplY3Q7Cit0eXBlZGVmIHN0cnVjdCBOUE9iamVjdCBOUE9i amVjdDsKK3R5cGVkZWYgc3RydWN0IF9OUFAgTlBQX3Q7Cit0eXBlZGVmIE5QUF90KiBOUFA7CiAK IG5hbWVzcGFjZSBXZWJDb3JlIHsKIAo=