47439 2010-10-08 16:33:46 -0700 Add Private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue 2010-10-11 14:21:48 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 jberlin jberlin aroben jberlin sam oldest_to_newest 291950 0 jberlin 2010-10-08 16:33:46 -0700 This is the counterpart to https://bugs.webkit.org/show_bug.cgi?id=47390 (Add Private API for creating a WebKit1 WebSerializedJSValue from the internal representation of a WebKit2 WebSerializedScriptValue). <rdar://problem/8525419> 292590 1 70459 jberlin 2010-10-11 11:46:39 -0700 Created attachment 70459 Adds the private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue 292632 2 70459 darin 2010-10-11 13:39:00 -0700 Comment on attachment 70459 Adds the private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue View in context: https://bugs.webkit.org/attachment.cgi?id=70459&action=review > WebKit2/Shared/API/c/WKSerializedScriptValue.cpp:47 > + RefPtr<WebSerializedScriptValue> serializedValue = WebSerializedScriptValue::create(reinterpret_cast<WebCore::SerializedScriptValue*>(internalRepresentation)); This can be a static_cast rather than a reinterpret_cast. 292636 3 jberlin 2010-10-11 13:50:21 -0700 (In reply to comment #2) > (From update of attachment 70459 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=70459&action=review > > > WebKit2/Shared/API/c/WKSerializedScriptValue.cpp:47 > > + RefPtr<WebSerializedScriptValue> serializedValue = WebSerializedScriptValue::create(reinterpret_cast<WebCore::SerializedScriptValue*>(internalRepresentation)); > > This can be a static_cast rather than a reinterpret_cast. Done. Thanks for the review! Jessie 292637 4 jberlin 2010-10-11 13:58:01 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 70459 [details] [details]) > > View in context: https://bugs.webkit.org/attachment.cgi?id=70459&action=review > > > > > WebKit2/Shared/API/c/WKSerializedScriptValue.cpp:47 > > > + RefPtr<WebSerializedScriptValue> serializedValue = WebSerializedScriptValue::create(reinterpret_cast<WebCore::SerializedScriptValue*>(internalRepresentation)); > > > > This can be a static_cast rather than a reinterpret_cast. > > Done. > > Thanks for the review! > > Jessie I also changed the signature on the window side to be [local] HRESULT getInternalRepresentation([out, retval] void** internalRepresentation); so that it would actually return the value. 292652 5 70459 jberlin 2010-10-11 14:21:37 -0700 Comment on attachment 70459 Adds the private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue Committed in r69524 http://trac.webkit.org/changeset/69524 70459 2010-10-11 11:46:39 -0700 2010-10-11 14:21:37 -0700 Adds the private API for creating a WebKit2 WebSerializedScriptValue from the internal representation of a WebKit1 WebSerializedJSValue addSPISerializedScriptValueOtherDirection.patch text/plain 6598 jberlin SW5kZXg6IFdlYktpdDIvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdDIvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTUwNSkKKysrIFdlYktpdDIvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMTEgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQGFwcGxl LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBB ZGQgUHJpdmF0ZSBBUEkgZm9yIGNyZWF0aW5nIGEgV2ViS2l0MiBXZWJTZXJpYWxpemVkU2NyaXB0 VmFsdWUgZnJvbSB0aGUgaW50ZXJuYWwKKyAgICAgICAgcmVwcmVzZW50YXRpb24gb2YgYSBXZWJL aXQxIFdlYlNlcmlhbGl6ZWRKU1ZhbHVlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9NDc0MzkKKworICAgICAgICAqIFNoYXJlZC9BUEkvYy9XS1Nlcmlh bGl6ZWRTY3JpcHRWYWx1ZS5jcHA6CisgICAgICAgIChXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZUNy ZWF0ZVdpdGhJbnRlcm5hbFJlcHJlc2VudGF0aW9uKToKKyAgICAgICAgVXNlIHRoZSBleGlzdGlu ZyBXZWJTZXJpYWxpemVkU2NyaXB0VmFsdWUgY29uc3RydWN0b3IgdGhhdCB0YWtlcyBhIHBvaW50 ZXIgdG8gdGhlIGludGVybmFsCisgICAgICAgIHJlcHJlc2VudGF0aW9uIChhIFdlYkNvcmU6OlNl cmlhbGl6ZWRTY3JpcHRWYWx1ZSkuCisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLU2VyaWFsaXpl ZFNjcmlwdFZhbHVlUHJpdmF0ZS5oOgorCiAyMDEwLTEwLTExICBTYW0gV2VpbmlnICA8c2FtQHdl YmtpdC5vcmc+CiAKICAgICAgICAgVHJ5IHRvIGZpeCB0aGUgTWFjIHJlbGVhc2UgYnVpbGQuCklu ZGV4OiBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZS5jcHAKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTZXJpYWxpemVkU2NyaXB0VmFsdWUu Y3BwCShyZXZpc2lvbiA2OTUwNSkKKysrIFdlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2VyaWFsaXpl ZFNjcmlwdFZhbHVlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDIsNiArNDIsMTIgQEAgV0tTZXJp YWxpemVkU2NyaXB0VmFsdWVSZWYgV0tTZXJpYWxpemVkUwogICAgIHJldHVybiB0b0FQSShzZXJp YWxpemVkVmFsdWUucmVsZWFzZSgpLmxlYWtSZWYoKSk7CiB9CiAKK1dLU2VyaWFsaXplZFNjcmlw dFZhbHVlUmVmIFdLU2VyaWFsaXplZFNjcmlwdFZhbHVlQ3JlYXRlV2l0aEludGVybmFsUmVwcmVz ZW50YXRpb24odm9pZCogaW50ZXJuYWxSZXByZXNlbnRhdGlvbikKK3sKKyAgICBSZWZQdHI8V2Vi U2VyaWFsaXplZFNjcmlwdFZhbHVlPiBzZXJpYWxpemVkVmFsdWUgPSBXZWJTZXJpYWxpemVkU2Ny aXB0VmFsdWU6OmNyZWF0ZShyZWludGVycHJldF9jYXN0PFdlYkNvcmU6OlNlcmlhbGl6ZWRTY3Jp cHRWYWx1ZSo+KGludGVybmFsUmVwcmVzZW50YXRpb24pKTsKKyAgICByZXR1cm4gdG9BUEkoc2Vy aWFsaXplZFZhbHVlLnJlbGVhc2UoKS5sZWFrUmVmKCkpOworfQorCiBKU1ZhbHVlUmVmIFdLU2Vy aWFsaXplZFNjcmlwdFZhbHVlRGVzZXJpYWxpemUoV0tTZXJpYWxpemVkU2NyaXB0VmFsdWVSZWYg c2NyaXB0VmFsdWVSZWYsIEpTQ29udGV4dFJlZiBjb250ZXh0UmVmLCBKU1ZhbHVlUmVmKiBleGNl cHRpb24pCiB7CiAgICAgcmV0dXJuIHRvSW1wbChzY3JpcHRWYWx1ZVJlZiktPmRlc2VyaWFsaXpl KGNvbnRleHRSZWYsIGV4Y2VwdGlvbik7CkluZGV4OiBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1Nl cmlhbGl6ZWRTY3JpcHRWYWx1ZVByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQyL1NoYXJl ZC9BUEkvYy9XS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVByaXZhdGUuaAkocmV2aXNpb24gNjk1MDUp CisrKyBXZWJLaXQyL1NoYXJlZC9BUEkvYy9XS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVByaXZhdGUu aAkod29ya2luZyBjb3B5KQpAQCAtMzMsNiArMzMsNyBAQCBleHRlcm4gIkMiIHsKICNlbmRpZgog CiBXS19FWFBPUlQgdm9pZCogV0tTZXJpYWxpemVkU2NyaXB0VmFsdWVHZXRJbnRlcm5hbFJlcHJl c2VudGF0aW9uKFdLU2VyaWFsaXplZFNjcmlwdFZhbHVlUmVmIHNjcmlwdFZhbHVlUmVmKTsKK1dL X0VYUE9SVCBXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1ZVJlZiBXS1NlcmlhbGl6ZWRTY3JpcHRWYWx1 ZUNyZWF0ZVdpdGhJbnRlcm5hbFJlcHJlc2VudGF0aW9uKHZvaWQqKTsKIAogI2lmZGVmIF9fY3Bs dXNwbHVzCiB9CkluZGV4OiBXZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJL aXQvbWFjL0NoYW5nZUxvZwkocmV2aXNpb24gNjk1MDUpCisrKyBXZWJLaXQvbWFjL0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDEwLTEwLTExICBKZXNzaWUgQmVy bGluICA8amJlcmxpbkBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgQWRkIFByaXZhdGUgQVBJIGZvciBjcmVhdGluZyBhIFdlYktpdDIg V2ViU2VyaWFsaXplZFNjcmlwdFZhbHVlIGZyb20gdGhlIGludGVybmFsCisgICAgICAgIHJlcHJl c2VudGF0aW9uIG9mIGEgV2ViS2l0MSBXZWJTZXJpYWxpemVkSlNWYWx1ZS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDM5CisKKyAgICAgICAgKiBX ZWJWaWV3L1dlYlNlcmlhbGl6ZWRKU1ZhbHVlLm1tOgorICAgICAgICAoLVtXZWJTZXJpYWxpemVk SlNWYWx1ZSBpbnRlcm5hbFJlcHJlc2VudGF0aW9uXSk6CisgICAgICAgICogV2ViVmlldy9XZWJT ZXJpYWxpemVkSlNWYWx1ZVByaXZhdGUuaDoKKwogMjAxMC0xMC0wNyAgSmVzc2llIEJlcmxpbiAg PGpiZXJsaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCklu ZGV4OiBXZWJLaXQvbWFjL1dlYlZpZXcvV2ViU2VyaWFsaXplZEpTVmFsdWUubW0KPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gV2ViS2l0L21hYy9XZWJWaWV3L1dlYlNlcmlhbGl6ZWRKU1ZhbHVlLm1tCShyZXZpc2lv biA2OTUwNSkKKysrIFdlYktpdC9tYWMvV2ViVmlldy9XZWJTZXJpYWxpemVkSlNWYWx1ZS5tbQko d29ya2luZyBjb3B5KQpAQCAtMTAzLDUgKzEwMywxMiBAQCAtICh2b2lkKWRlYWxsb2MKICAgICBb c3VwZXIgZGVhbGxvY107CiB9CiAKKy0gKHZvaWQqKWludGVybmFsUmVwcmVzZW50YXRpb24KK3sK KyAgICBpZiAoIV9wcml2YXRlKQorICAgICAgICByZXR1cm4gMDsKKyAgICByZXR1cm4gX3ByaXZh dGUtPnZhbHVlLmdldCgpOworfQorCiBAZW5kCiAKSW5kZXg6IFdlYktpdC9tYWMvV2ViVmlldy9X ZWJTZXJpYWxpemVkSlNWYWx1ZVByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFjL1dl YlZpZXcvV2ViU2VyaWFsaXplZEpTVmFsdWVQcml2YXRlLmgJKHJldmlzaW9uIDY5NTA1KQorKysg V2ViS2l0L21hYy9XZWJWaWV3L1dlYlNlcmlhbGl6ZWRKU1ZhbHVlUHJpdmF0ZS5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMCw0ICszMCw1IEBACiAKIEBpbnRlcmZhY2UgV2ViU2VyaWFsaXplZEpTVmFs dWUoV2ViUHJpdmF0ZSkKIC0gKGlkKWluaXRXaXRoSW50ZXJuYWxSZXByZXNlbnRhdGlvbjoodm9p ZCopaW50ZXJuYWxSZXByZXNlbmF0YXRpb247CistICh2b2lkKilpbnRlcm5hbFJlcHJlc2VudGF0 aW9uOwogQGVuZApJbmRleDogV2ViS2l0L3dpbi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi S2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDY5NTA1KQorKysgV2ViS2l0L3dpbi9DaGFuZ2VM b2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0xMSAgSmVzc2llIEJl cmxpbiAgPGpiZXJsaW5AYXBwbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBQcml2YXRlIEFQSSBmb3IgY3JlYXRpbmcgYSBXZWJLaXQy IFdlYlNlcmlhbGl6ZWRTY3JpcHRWYWx1ZSBmcm9tIHRoZSBpbnRlcm5hbAorICAgICAgICByZXBy ZXNlbnRhdGlvbiBvZiBhIFdlYktpdDEgV2ViU2VyaWFsaXplZEpTVmFsdWUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQzOQorCisgICAgICAgICog SW50ZXJmYWNlcy9JV2ViU2VyaWFsaXplZEpTVmFsdWVQcml2YXRlLmlkbDoKKyAgICAgICAgQmVj YXVzZSBpdCBpcyB0YWtpbmcgYSB2b2lkKiogcGFyYW1ldGVyLCBnZXRJbnRlcm5hbFJlcHJlc2Vu dGF0aW9uIG11c3QgYmUgZGVjbGFyZWQgW2xvY2FsXS4KKworICAgICAgICAqIFdlYlNlcmlhbGl6 ZWRKU1ZhbHVlLmNwcDoKKyAgICAgICAgKFdlYlNlcmlhbGl6ZWRKU1ZhbHVlOjpnZXRJbnRlcm5h bFJlcHJlc2VudGF0aW9uKToKKyAgICAgICAgKiBXZWJTZXJpYWxpemVkSlNWYWx1ZS5oOgorCiAy MDEwLTEwLTA3ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkBhcHBsZS5jb20+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYktpdC93aW4vV2ViU2VyaWFsaXplZEpT VmFsdWUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViU2VyaWFsaXplZEpTVmFsdWUu Y3BwCShyZXZpc2lvbiA2OTUwNSkKKysrIFdlYktpdC93aW4vV2ViU2VyaWFsaXplZEpTVmFsdWUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsMyArMTE3LDEzIEBAIEhSRVNVTFQgV2ViU2VyaWFs aXplZEpTVmFsdWU6OnNldEludGVybmEKIAogICAgIHJldHVybiBTX09LOwogfQorCitIUkVTVUxU IFdlYlNlcmlhbGl6ZWRKU1ZhbHVlOjpnZXRJbnRlcm5hbFJlcHJlc2VudGF0aW9uKHZvaWQqKiBp bnRlcm5hbFJlcHJlc2VudGF0aW9uKQoreworICAgIGlmICghbV92YWx1ZSkKKyAgICAgICAgcmV0 dXJuIEVfUE9JTlRFUjsKKworICAgICppbnRlcm5hbFJlcHJlc2VudGF0aW9uID0gbV92YWx1ZS5n ZXQoKTsKKyAgICByZXR1cm4gU19PSzsKK30KKwpJbmRleDogV2ViS2l0L3dpbi9XZWJTZXJpYWxp emVkSlNWYWx1ZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC93aW4vV2ViU2VyaWFsaXplZEpTVmFs dWUuaAkocmV2aXNpb24gNjk1MDUpCisrKyBXZWJLaXQvd2luL1dlYlNlcmlhbGl6ZWRKU1ZhbHVl LmgJKHdvcmtpbmcgY29weSkKQEAgLTQ0LDYgKzQ0LDcgQEAgcHVibGljOgogICAgIHZpcnR1YWwg SFJFU1VMVCBTVERNRVRIT0RDQUxMVFlQRSBzZXJpYWxpemUoSlNDb250ZXh0UmVmLCBKU1ZhbHVl UmVmIHZhbHVlLCBKU1ZhbHVlUmVmKiBleGNlcHRpb24pOwogICAgIHZpcnR1YWwgSFJFU1VMVCBT VERNRVRIT0RDQUxMVFlQRSBkZXNlcmlhbGl6ZShKU0NvbnRleHRSZWYsIEpTVmFsdWVSZWYqIHJl c3VsdCk7CiAgICAgdmlydHVhbCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIHNldEludGVybmFs UmVwcmVzZW50YXRpb24odm9pZCogaW50ZXJuYWxSZXByZXNlbnRhdGlvbik7CisgICAgdmlydHVh bCBIUkVTVUxUIFNURE1FVEhPRENBTExUWVBFIGdldEludGVybmFsUmVwcmVzZW50YXRpb24odm9p ZCoqIGludGVybmFsUmVwcmVzZW50YXRpb24pOwogCiBwcml2YXRlOgogICAgIFdlYlNlcmlhbGl6 ZWRKU1ZhbHVlKCk7CkluZGV4OiBXZWJLaXQvd2luL0ludGVyZmFjZXMvSVdlYlNlcmlhbGl6ZWRK U1ZhbHVlUHJpdmF0ZS5pZGwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3dpbi9JbnRlcmZhY2VzL0lX ZWJTZXJpYWxpemVkSlNWYWx1ZVByaXZhdGUuaWRsCShyZXZpc2lvbiA2OTUwNSkKKysrIFdlYktp dC93aW4vSW50ZXJmYWNlcy9JV2ViU2VyaWFsaXplZEpTVmFsdWVQcml2YXRlLmlkbAkod29ya2lu ZyBjb3B5KQpAQCAtNDEsNCArNDEsNSBAQCBpbXBvcnQgIm9jaWRsLmlkbCI7CiBpbnRlcmZhY2Ug SVdlYlNlcmlhbGl6ZWRKU1ZhbHVlUHJpdmF0ZSA6IElVbmtub3duCiB7CiAgICAgW2xvY2FsXSBI UkVTVUxUIHNldEludGVybmFsUmVwcmVzZW50YXRpb24oW2luXSB2b2lkKiBpbnRlcm5hbFJlcHJl c2VudGF0aW9uKTsKKyAgICBbbG9jYWxdIEhSRVNVTFQgZ2V0SW50ZXJuYWxSZXByZXNlbnRhdGlv bihbb3V0XSB2b2lkKiogaW50ZXJuYWxSZXByZXNlbnRhdGlvbik7CiB9Cg==