47431 2010-10-08 14:35:54 -0700 <a ping> tests are slow 2010-10-10 12:46:33 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 mihaip mihaip commit-queue japhet oldest_to_newest 291869 0 mihaip 2010-10-08 14:35:54 -0700 <a ping> tests are slow/flaky 291879 1 70291 mihaip 2010-10-08 14:42:13 -0700 Created attachment 70291 Patch 291960 2 70291 commit-queue 2010-10-08 16:49:24 -0700 Comment on attachment 70291 Patch Rejecting patch 70291 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: Files=14, Tests=304, 1 wallclock secs ( 0.72 cusr + 0.17 csys = 0.89 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21521 test cases. http/tests/navigation/image-load-in-unload-handler.html -> failed Exiting early after 1 failures. 20813 tests run. 515.26s total testing time 20812 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4312001 292099 3 mihaip 2010-10-09 05:48:42 -0700 image-load-in-unload-handler.html may be flaky, trying again. 292102 4 70291 commit-queue 2010-10-09 06:20:16 -0700 Comment on attachment 70291 Patch Rejecting patch 70291 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: Tests=304, 1 wallclock secs ( 0.64 cusr + 0.13 csys = 0.77 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Users/abarth/git/webkit-queue/LayoutTests Testing 21522 test cases. http/tests/navigation/image-load-in-unload-handler.html -> failed Exiting early after 1 failures. 20814 tests run. 482.52s total testing time 20813 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4278006 292124 5 mihaip 2010-10-09 08:44:29 -0700 Guess it is my fault, that test uses the check-ping.php scrip too. Will investigate. 292131 6 70353 mihaip 2010-10-09 09:34:52 -0700 Created attachment 70353 Patch The change to not have check-ping.php return with a Refresh header caused a race condition in image-load-in-unload-handler.html; this should fix that. 292360 7 70353 commit-queue 2010-10-10 12:46:26 -0700 Comment on attachment 70353 Patch Clearing flags on attachment: 70353 Committed r69469: <http://trac.webkit.org/changeset/69469> 292361 8 commit-queue 2010-10-10 12:46:33 -0700 All reviewed patches have been landed. Closing bug. 70291 2010-10-08 14:42:13 -0700 2010-10-09 09:33:53 -0700 Patch bug-47431-20101008174211.patch text/plain 1866 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMTQ4NzkzYjFiZWJjMjFjNzNhMzhhMjFhYWM4ZTVjNDFlZWE5ZjQyLi5jNThmMGY5 YTI2MmNmOGQyYjExMTZjNTIzOTIyNzcwOTdjN2MyOTVkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAK KzIwMTAtMTAtMDggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPGEgcGluZz4gdGVz dHMgYXJlIHNsb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ3NDMxCisgICAgICAgIAorICAgICAgICBUaGUgcGluZyB0ZXN0cyBzaG93ZWQgdXAgYXMg YmVpbmcgZmxha3kgaW4gQWRhbSBCYXJ0aCdzIGVtYWlsOyB0aGlzCisgICAgICAgIG1pZ2h0IGp1 c3QgYmUgZHVlIHRvIHRoZW0gYmVpbmcgb24gdGhlIHNsb3cgc2lkZSBkdWUgdG8gdGhlIDEgc2Vj b25kCisgICAgICAgIHJlZnJlc2ggaW4gY2hlY2stcGluZy5waHAuIFdlIGNhbiBpbnN0ZWFkIHN3 aXRjaCB0byB1c2luZyBmaWxlX2V4aXN0cworICAgICAgICBpbiBhIGxvb3AgaWYgd2UgaW52YWxp ZGF0ZSB0aGUgZmlsZSBzdGF0dXMgY2FjaGUuIFJ1bm5pbmcgdGhlIHRocmVlCisgICAgICAgIHBp bmcgdGVzdHMgd2l0aCAtLWl0ZXJhdGlvbnM9MTAgbm93IHRha2VzIDQgc2Vjb25kcyBpbnN0ZWFk IG9mIDIzLgorCisgICAgICAgICogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9jaGVj ay1waW5nLnBocDoKKwogMjAxMC0xMC0wNyAgQWxiZXJ0IEouIFdvbmcgIDxhandvbmdAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1bV0gVW5yZXZpZXdlZC4gTmV3IGJhc2VsaW5lcywg YW5kIGV4cGVjdGF0aW9ucyB1cGRhdGVzLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90 ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9jaGVjay1waW5nLnBocCBiL0xheW91dFRlc3RzL2h0 dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJjZXMvY2hlY2stcGluZy5waHAKaW5kZXggYTBmMmRk NzczYjczZDQ1MGVjNGMwNzRkMTU4ZGYwNTQzMDM4NTM3Ny4uOGIxYmIwMjMzOGFmYmYyYWFmOTlk NzRiMzVmNzdiODNhZDEwYTBlNSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9u YXZpZ2F0aW9uL3Jlc291cmNlcy9jaGVjay1waW5nLnBocAorKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL2NoZWNrLXBpbmcucGhwCkBAIC0xLDExICsxLDgg QEAKIDw/cGhwCi1pZiAoIWZpbGVfZXhpc3RzKCJwaW5nLnR4dCIpKSB7Ci0gICAgJHBhZ2UgPSAk X1NFUlZFUlsnUEhQX1NFTEYnXTsKLSAgICAvLyBUaGlzIHJlZnJlc2ggaGVhZGVyIGlzIHVuZm9y dHVuYXRlLCBidXQgaWYgdGhlIGZpbGUgZG9lc24ndAotICAgIC8vIGV4aXN0IHdoZW4gdGhpcyBw aHAgc2NyaXB0IHN0YXJ0cyBydW5uaW5nLCBpdCB3b24ndCBub3RpY2UKLSAgICAvLyBpdHMgY3Jl YXRpb24gZXZlbiBpZiB3ZSBzbGVlcCBhbmQgY2hlY2sgYWdhaW4uCi0gICAgaGVhZGVyKCJSZWZy ZXNoOiAxOyB1cmw9JHBhZ2UiKTsKLSAgICByZXR1cm47Cit3aGlsZSAoIWZpbGVfZXhpc3RzKCJw aW5nLnR4dCIpKSB7CisgICAgdXNsZWVwKDEwMDAwKTsKKyAgICAvLyBmaWxlX2V4aXN0cygpIGNh Y2hlcyByZXN1bHRzLCB3ZSB3YW50IHRvIGludmFsaWRhdGUgdGhlIGNhY2hlLgorICAgIGNsZWFy c3RhdGNhY2hlKCk7CiB9CiAKIGVjaG8gIjxodG1sPjxib2R5PlxuIjsK 70353 2010-10-09 09:34:52 -0700 2010-10-10 12:46:26 -0700 Patch bug-47431-20101009174211.patch text/plain 3729 mihaip ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjMTQ4NzkzYjFiZWJjMjFjNzNhMzhhMjFhYWM4ZTVjNDFlZWE5ZjQyLi5lMmNhZDc5 ZWJmMmFkNzM0OWYxOTdhYmEwNzhmOTFhYzZkZGZkMTA2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAK KzIwMTAtMTAtMDggIE1paGFpIFBhcnBhcml0YSAgPG1paGFpcEBjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgPGEgcGluZz4gdGVz dHMgYXJlIHNsb3cKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTQ3NDMxCisgICAgICAgIAorICAgICAgICBUaGUgcGluZyB0ZXN0cyBzaG93ZWQgdXAgYXMg YmVpbmcgZmxha3kgaW4gQWRhbSBCYXJ0aCdzIGVtYWlsOyB0aGlzCisgICAgICAgIG1pZ2h0IGp1 c3QgYmUgZHVlIHRvIHRoZW0gYmVpbmcgb24gdGhlIHNsb3cgc2lkZSBkdWUgdG8gdGhlIDEgc2Vj b25kCisgICAgICAgIHJlZnJlc2ggaW4gY2hlY2stcGluZy5waHAuIFdlIGNhbiBpbnN0ZWFkIHN3 aXRjaCB0byB1c2luZyBmaWxlX2V4aXN0cworICAgICAgICBpbiBhIGxvb3AgaWYgd2UgaW52YWxp ZGF0ZSB0aGUgZmlsZSBzdGF0dXMgY2FjaGUuIFJ1bm5pbmcgdGhlIHRocmVlCisgICAgICAgIHBp bmcgdGVzdHMgd2l0aCAtLWl0ZXJhdGlvbnM9MTAgbm93IHRha2VzIDQgc2Vjb25kcyBpbnN0ZWFk IG9mIDIzLgorICAgICAgICAKKyAgICAgICAgVGhpcyBzdXJmYWNlcyBhIHJhY2UgY29uZGl0aW9u IGluIGltYWdlLWxvYWQtaW4tdW5sb2FkLWhhbmRsZXIuaHRtbAorICAgICAgICAod2UgZG9uJ3Qg c3RhcnQgc2VuZGluZyBkYXRhIHRpbGwgd2UgZ2V0IHRoZSBwaW5nLCBidXQgdW5sb2FkIGhhbmRs ZXJzCisgICAgICAgICh3aGVyZSB0aGUgcGluZyBpcyBzZW50KSBhcmVuJ3QgcnVuIHRpbGwgd2Ug c3RhcnQgZ2V0dGluZyBkYXRhKS4gRml4ZWQKKyAgICAgICAgYnkgYWRkaW5nIGEgZHVtbXkgcGFn ZSBpbiBiZXR3ZWVuLgorCisgICAgICAgICogaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNl cy9jaGVjay1waW5nLnBocDoKKyAgICAgICAgKiBodHRwL3Rlc3RzL25hdmlnYXRpb24vaW1hZ2Ut bG9hZC1pbi11bmxvYWQtaGFuZGxlci5odG1sOgorICAgICAgICAqIGh0dHAvdGVzdHMvbmF2aWdh dGlvbi9yZXNvdXJjZXMvcGluZy1yZWRpcmVjdC5odG1sOiBBZGRlZC4KKwogMjAxMC0xMC0wNyAg QWxiZXJ0IEouIFdvbmcgIDxhandvbmdAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFtDaHJvbWl1 bV0gVW5yZXZpZXdlZC4gTmV3IGJhc2VsaW5lcywgYW5kIGV4cGVjdGF0aW9ucyB1cGRhdGVzLgpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL2ltYWdlLWxvYWQt aW4tdW5sb2FkLWhhbmRsZXIuaHRtbCBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlv bi9pbWFnZS1sb2FkLWluLXVubG9hZC1oYW5kbGVyLmh0bWwKaW5kZXggY2ViZDI1ODAzZjE3MzQ3 YTMzY2FhYmFmZmMxNjg5NzUwYmQ1YjM2Yi4uNGVhOGUwMzRiNzg2Zjc0ZTU1NzMyZWRjMzRjNGY3 NjlmNDk3OTUwOCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9u L2ltYWdlLWxvYWQtaW4tdW5sb2FkLWhhbmRsZXIuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL25hdmlnYXRpb24vaW1hZ2UtbG9hZC1pbi11bmxvYWQtaGFuZGxlci5odG1sCkBAIC0x Myw3ICsxMywxMyBAQCBmdW5jdGlvbiB0ZXN0KCkgewogICAgICAgICB0ZXN0Q2FsbGVkID0gdHJ1 ZTsKICAgICAgICAgcmV0dXJuOwogICAgIH0KLSAgICBsb2NhdGlvbi5hc3NpZ24oInJlc291cmNl cy9jaGVjay1waW5nLnBocCIpOworICAgIC8vIFdlIGNhbid0IGdvIHRvIGNoZWNrLXBpbmcucGhw IGRpcmVjdGx5LCBzaW5jZSB0aGF0IGRvZXNuJ3Qgc3RhcnQgc2VuZGluZworICAgIC8vIGEgcmVz cG9uc2UgdW50aWwgdGhlIHBpbmcgZGF0YSBpcyBkZXRlY3RlZCwgYnV0IHVubG9hZCBoYW5kbGVy cyAod2hlcmUKKyAgICAvLyB3ZSBzZW5kIHRoZSBwaW5nKSBhcmUgb25seSBydW4gb25jZSB3ZSd2 ZSBiZWd1biByZWNlaXZpbmcgZGF0YSBmcm9tIHRoZQorICAgIC8vIHBhZ2UgYmVpbmcgbmF2aWdh dGVkIHRvLiBJbnN0ZWFkLCB3ZSBnbyB0aHJvdWdoIGEgZHVtbXkgcmVkaXJlY3QgcGFnZSwKKyAg ICAvLyB0byBtYWtlIHN1cmUgdGhhdCB0aGUgb251bmxvYWQgaGFuZGxlciBoYXMgcnVuIGJlZm9y ZSB3ZSBnZXQgdG8gCisgICAgLy8gY2hlY2stcGluZy5waHAuCisgICAgbG9jYXRpb24uYXNzaWdu KCJyZXNvdXJjZXMvcGluZy1yZWRpcmVjdC5odG1sIik7CiB9CiAKIGZ1bmN0aW9uIHBpbmcoKSB7 CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2Vz L2NoZWNrLXBpbmcucGhwIGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291 cmNlcy9jaGVjay1waW5nLnBocAppbmRleCBhMGYyZGQ3NzNiNzNkNDUwZWM0YzA3NGQxNThkZjA1 NDMwMzg1Mzc3Li44YjFiYjAyMzM4YWZiZjJhYWY5OWQ3NGIzNWY3N2I4M2FkMTBhMGU1IDEwMDY0 NAotLS0gYS9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL2NoZWNr LXBpbmcucGhwCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZXNvdXJj ZXMvY2hlY2stcGluZy5waHAKQEAgLTEsMTEgKzEsOCBAQAogPD9waHAKLWlmICghZmlsZV9leGlz dHMoInBpbmcudHh0IikpIHsKLSAgICAkcGFnZSA9ICRfU0VSVkVSWydQSFBfU0VMRiddOwotICAg IC8vIFRoaXMgcmVmcmVzaCBoZWFkZXIgaXMgdW5mb3J0dW5hdGUsIGJ1dCBpZiB0aGUgZmlsZSBk b2Vzbid0Ci0gICAgLy8gZXhpc3Qgd2hlbiB0aGlzIHBocCBzY3JpcHQgc3RhcnRzIHJ1bm5pbmcs IGl0IHdvbid0IG5vdGljZQotICAgIC8vIGl0cyBjcmVhdGlvbiBldmVuIGlmIHdlIHNsZWVwIGFu ZCBjaGVjayBhZ2Fpbi4KLSAgICBoZWFkZXIoIlJlZnJlc2g6IDE7IHVybD0kcGFnZSIpOwotICAg IHJldHVybjsKK3doaWxlICghZmlsZV9leGlzdHMoInBpbmcudHh0IikpIHsKKyAgICB1c2xlZXAo MTAwMDApOworICAgIC8vIGZpbGVfZXhpc3RzKCkgY2FjaGVzIHJlc3VsdHMsIHdlIHdhbnQgdG8g aW52YWxpZGF0ZSB0aGUgY2FjaGUuCisgICAgY2xlYXJzdGF0Y2FjaGUoKTsKIH0KIAogZWNobyAi PGh0bWw+PGJvZHk+XG4iOwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZp Z2F0aW9uL3Jlc291cmNlcy9waW5nLXJlZGlyZWN0Lmh0bWwgYi9MYXlvdXRUZXN0cy9odHRwL3Rl c3RzL25hdmlnYXRpb24vcmVzb3VyY2VzL3BpbmctcmVkaXJlY3QuaHRtbApuZXcgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45 NjljOTY3ZDViYzUwZDkzZDU0MTBlN2IyMTZjOTE5ZTMwNWQyOGJmCi0tLSAvZGV2L251bGwKKysr IGIvTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9uYXZpZ2F0aW9uL3Jlc291cmNlcy9waW5nLXJlZGly ZWN0Lmh0bWwKQEAgLTAsMCArMSwzIEBACis8c2NyaXB0PgorbG9jYXRpb24uaHJlZiA9ICdjaGVj ay1waW5nLnBocCc7Cis8L3NjcmlwdD4K