47427 2010-10-08 11:52:31 -0700 [Qt] build error in WebKit/qt/Api/qwebpage.cpp in Qt 4.7.0 2010-11-08 18:16:01 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Major --- 1 pierre.rossi benjamin benjamin commit-queue forummails oldest_to_newest 291789 0 pierre.rossi 2010-10-08 11:52:31 -0700 This bug report is copied from http://bugreports.qt.nokia.com/browse/QTWEBKIT-281. ---Original report--- I'm trying to compile Qt 4.7.0 and its failing on this: ../WebKit/qt/Api/qwebpage.cpp: In member function 'void QWebPagePrivate::touchEvent(QTouchEvent*)': ../WebKit/qt/Api/qwebpage.cpp:1571: error: 'class WebCore::EventHandler' has no member named 'handleTouchEvent' ../WebKit/qt/Api/qwebpage.cpp:1571: error: invalid use of undefined type 'struct WebCore::PlatformTouchEvent' page/EventHandler.h:62: error: forward declaration of 'struct WebCore::PlatformTouchEvent' Can you tell me what I can do to get around it? I was searching out on the web and see that there has been some changes to qwebpage.cpp today. So maybe there is already a patch for this? Thanks! ---Comment--- I'm also getting a compile error for webkit/JavaScriptCore/interpreter/Interpreter.cpp: interpreter/Interpreter.cpp(2992): error: in "goto *expr", expr must have type "void *" NEXT_INSTRUCTION(); 291790 1 benjamin 2010-10-08 11:54:38 -0700 Looks like a bug in your compiler. I have no problem building 4.7.0. 305360 2 forummails 2010-11-05 10:42:19 -0700 When compiling qt 4.7.0 webkit has not been build. I ran into the same issue, when starting make in src/3rdparty/webkit. Compiler used: $ g++ --version g++ (Debian 4.3.2-1.1) 4.3.2 Copyright (C) 2008 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. What compilers are recommended for building the qt webkit? 305800 3 forummails 2010-11-06 11:39:42 -0700 WebKit/qt/Api/qwebpage.ccp 1571: bool accepted = frame->eventHandler()->handleTouchEvent(PlatformTouchEvent(event)); ^^^ Method is only available, if marco TOUCH_EVENTS is available, see WebCore/page/EventHandler.h 209: #if ENABLE(TOUCH_EVENTS) bool handleTouchEvent(const PlatformTouchEvent&); #endif For my understanding, my compiler is correctly complaining, when TOUCH_EVENTS is not set: ../WebKit/qt/Api/qwebpage.cpp:1571: error: 'class WebCore::EventHandler' has no member named 'handleTouchEvent' 306051 4 benjamin 2010-11-08 01:05:47 -0800 (In reply to comment #2) > What compilers are recommended for building the qt webkit? GCC >= 4.2 should do fine. (In reply to comment #3) > For my understanding, my compiler is correctly complaining, when TOUCH_EVENTS is not set: > ../WebKit/qt/Api/qwebpage.cpp:1571: error: 'class WebCore::EventHandler' has no member named 'handleTouchEvent' I will testthe missing guards for touch events. However, with Qt, TOUCH_EVENTS should always be defined (we don't support versions prior to 4.6). Have you disabled TOUCH_EVENTS manually? 306057 5 73226 benjamin 2010-11-08 01:36:23 -0800 Created attachment 73226 Patch Add the missing guard to the Qt port. In the patch: +#else + event->ignore(); The call to ignore() is mandatory because touch event are accepted by default. 306066 6 73226 kling 2010-11-08 03:12:31 -0800 Comment on attachment 73226 Patch r=me 306109 7 forummails 2010-11-08 07:26:14 -0800 (In reply to comment #4) > However, with Qt, TOUCH_EVENTS should always be defined (we don't support versions prior to 4.6). Have you disabled TOUCH_EVENTS manually? Not intentionally. I only did: .../qt-everywhere-opensource-src-4.7.0 $ ./configure -plugin-sql-mysql -release -prefix /opt/qt47/ -nomake tools -nomake examples -nomake demos -nomake docs -nomake translations -make libs -webkit This did not enable TOUCH_EVENTS for me (missing lib?). Too bad, I can't find logs from configure run. Thanks for the patch. 306537 8 73226 commit-queue 2010-11-08 18:15:56 -0800 Comment on attachment 73226 Patch Clearing flags on attachment: 73226 Committed r71593: <http://trac.webkit.org/changeset/71593> 306538 9 commit-queue 2010-11-08 18:16:01 -0800 All reviewed patches have been landed. Closing bug. 73226 2010-11-08 01:36:23 -0800 2010-11-08 18:15:56 -0800 Patch 47427.diff text/plain 1408 benjamin ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x d2VicGFnZS5jcHAKaW5kZXggYTZjYTY1YS4uYTcxNmI1NSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0 L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEz MTEsNiArMTMxMSw3IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjphZGp1c3RQb2ludEZvckNsaWNr aW5nKFFHcmFwaGljc1NjZW5lTW91c2VFdmVudCogZXYpCiAKIGJvb2wgUVdlYlBhZ2VQcml2YXRl Ojp0b3VjaEV2ZW50KFFUb3VjaEV2ZW50KiBldmVudCkKIHsKKyNpZiBFTkFCTEUoVE9VQ0hfRVZF TlRTKQogICAgIFdlYkNvcmU6OkZyYW1lKiBmcmFtZSA9IFFXZWJGcmFtZVByaXZhdGU6OmNvcmUo bWFpbkZyYW1lKTsKICAgICBpZiAoIWZyYW1lLT52aWV3KCkpCiAgICAgICAgIHJldHVybiBmYWxz ZTsKQEAgLTEzMjAsNiArMTMyMSwxMCBAQCBib29sIFFXZWJQYWdlUHJpdmF0ZTo6dG91Y2hFdmVu dChRVG91Y2hFdmVudCogZXZlbnQpCiAKICAgICAvLyBSZXR1cm4gd2hldGhlciB0aGUgZGVmYXVs dCBhY3Rpb24gd2FzIGNhbmNlbGxlZCBpbiB0aGUgSlMgZXZlbnQgaGFuZGxlcgogICAgIHJldHVy biBmcmFtZS0+ZXZlbnRIYW5kbGVyKCktPmhhbmRsZVRvdWNoRXZlbnQoUGxhdGZvcm1Ub3VjaEV2 ZW50KGV2ZW50KSk7CisjZWxzZQorICAgIGV2ZW50LT5pZ25vcmUoKTsKKyAgICByZXR1cm4gZmFs c2U7CisjZW5kaWYKIH0KIAogLyohCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIv V2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCA4NzJlYWQxLi42NmI5MTNhIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx NiBAQAorMjAxMC0xMS0wOCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9r aWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gYnVpbGQgZXJyb3IgaW4gV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAgaW4gUXQgNC43 LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDI3 CisKKyAgICAgICAgQWRkIGEgbWlzc2luZyBndWFyZCBpbiBvcmRlciB0byBiZSBhYmxlIHRvIGNv bXBpbGUgd2hlbgorICAgICAgICBFTkFCTEUoVE9VQ0hfRVZFTlRTKSBpcyBub3QgZGVmaW5lZC4K KworICAgICAgICAqIEFwaS9xd2VicGFnZS5jcHA6CisgICAgICAgIChRV2ViUGFnZVByaXZhdGU6 OnRvdWNoRXZlbnQpOgorCiAyMDEwLTExLTA3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBTZWlkZWwuCg==