47418 2010-10-08 09:06:36 -0700 Make PluginView inherit from PluginViewBase. 2010-10-21 13:34:37 -0700 1 1 1 Unclassified WebKit Plug-ins 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 35524 1 girish webkit-unassigned ademar andersca girish oldest_to_newest 291687 0 girish 2010-10-08 09:06:36 -0700 As part of #35524, I am implementing AC for NPAPI plugins. The AC code requires plugins to derive from PluginViewBase. 291692 1 70257 girish 2010-10-08 09:10:15 -0700 Created attachment 70257 Make PluginView inherit from PluginViewBase 291811 2 girish 2010-10-08 12:38:58 -0700 You can find rest of the patch series here - http://gitorious.org/~girish/webkit/girishs-webkit/commits/plugins_ac_35524 292524 3 girish 2010-10-11 10:15:16 -0700 I see that Page::privateBrowsingStateChanged could do with some fixing, do you want me to do that as part of this change? 292616 4 andersca 2010-10-11 12:43:40 -0700 (In reply to comment #3) > I see that Page::privateBrowsingStateChanged could do with some fixing, do you want me to do that as part of this change? Yes, that would be great! I'll r- the patch. 292640 5 70465 girish 2010-10-11 13:59:03 -0700 Created attachment 70465 Take2 293121 6 girish 2010-10-12 14:36:07 -0700 Anders, can you review this please? 293136 7 70465 andersca 2010-10-12 15:12:25 -0700 Comment on attachment 70465 Take2 Looks good. 293256 8 girish 2010-10-12 21:13:01 -0700 Landed in http://trac.webkit.org/changeset/69635. 297607 9 ademar 2010-10-21 13:34:37 -0700 Removing bug 39121 (qtwebkit-2.1 release critical meta bug) from the list of blockers because this change won't be integrated into qtwebkit-2.1 without the other changes related to bug 35524, which already blocks bug 39121 70257 2010-10-08 09:10:15 -0700 2010-10-11 13:59:03 -0700 Make PluginView inherit from PluginViewBase pluginviewbase.patch text/plain 2612 girish Y29tbWl0IGI3YTM2NTg5Y2EwN2RjOWEyNDA1NmQwMTRjNDIzNjRkYjg2NjJiOTcKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgRnJpIE9j dCA4IDIxOjM0OjU5IDIwMTAgKzA1MzAKCiAgICAyMDEwLTEwLTA4ICBHaXJpc2ggUmFtYWtyaXNo bmFuICA8Z2lyaXNoQGZvcndhcmRiaWFzLmluPgogICAgCiAgICAgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgogICAgCiAgICAgICAgICAgIE1ha2UgUGx1Z2luVmlldyBpbmhlcml0 IGZyb20gUGx1Z2luVmlld0Jhc2UuCiAgICAKICAgICAgICAgICAgVGhpcyBjaGFuZ2UgaXMgYSBw cmVjdXJzb3IgdG8gYWRkaW5nIGFjY2VsZXJhdGVkIGNvbXBvc2l0aW5nIHN1cHBvcnQKICAgICAg ICAgICAgZm9yIE5QQVBJIHBsdWdpbnMuCiAgICAKICAgICAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3NDE4CiAgICAKICAgICAgICAgICAgKiBwbHVnaW5z L1BsdWdpblZpZXcuaDoKICAgICAgICAgICAgKiBwbHVnaW5zL1BsdWdpblZpZXdCYXNlLmg6CiAg ICAgICAgICAgIChXZWJDb3JlOjpQbHVnaW5WaWV3QmFzZTo6UGx1Z2luVmlld0Jhc2UpOgoKZGlm ZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzY3 MTU3Mi4uZTk5OTBiYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwyMCBAQAogMjAxMC0xMC0wOCAgR2lyaXNoIFJhbWFrcmlz aG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNYWtlIFBsdWdpblZpZXcgaW5oZXJpdCBmcm9tIFBsdWdp blZpZXdCYXNlLgorCisgICAgICAgIFRoaXMgY2hhbmdlIGlzIGEgcHJlY3Vyc29yIHRvIGFkZGlu ZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBzdXBwb3J0CisgICAgICAgIGZvciBOUEFQSSBwbHVn aW5zLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NzQxOAorCisgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3Lmg6CisgICAgICAgICogcGx1Z2lu cy9QbHVnaW5WaWV3QmFzZS5oOgorICAgICAgICAoV2ViQ29yZTo6UGx1Z2luVmlld0Jhc2U6OlBs dWdpblZpZXdCYXNlKToKKworMjAxMC0xMC0wOCAgR2lyaXNoIFJhbWFrcmlzaG5hbiAgPGdpcmlz aEBmb3J3YXJkYmlhcy5pbj4KKwogICAgICAgICBSZXZpZXdlZCBieSBBbmRyZWFzIEtsaW5nLgog CiAgICAgICAgIFtRdF0gVXNlIGNvbnN0QmVnaW4gYW5kIGNvbnN0RW5kIHdoZW4gdXNpbmcgY29u c3QgaXRlcmF0b3JzCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oIGIv V2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXcuaAppbmRleCBhNjE3ODVjLi5mNWVlMTY4IDEwMDY0 NAotLS0gYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCisrKyBiL1dlYkNvcmUvcGx1Z2lu cy9QbHVnaW5WaWV3LmgKQEAgLTMyLDkgKzMyLDkgQEAKICNpbmNsdWRlICJIYWx0YWJsZVBsdWdp bi5oIgogI2luY2x1ZGUgIkludFJlY3QuaCIKICNpbmNsdWRlICJNZWRpYUNhblN0YXJ0TGlzdGVu ZXIuaCIKKyNpbmNsdWRlICJQbHVnaW5WaWV3QmFzZS5oIgogI2luY2x1ZGUgIlJlc291cmNlUmVx dWVzdC5oIgogI2luY2x1ZGUgIlRpbWVyLmgiCi0jaW5jbHVkZSAiV2lkZ2V0LmgiCiAjaW5jbHVk ZSA8d3RmL0hhc2hNYXAuaD4KICNpbmNsdWRlIDx3dGYvSGFzaFNldC5oPgogI2luY2x1ZGUgPHd0 Zi9Pd25QdHIuaD4KQEAgLTEyMCw3ICsxMjAsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAgICAg ICAgIHZpcnR1YWwgdm9pZCBkaWRGYWlsKGNvbnN0IFJlc291cmNlRXJyb3ImKSA9IDA7CiAgICAg fTsKIAotICAgIGNsYXNzIFBsdWdpblZpZXcgOiBwdWJsaWMgV2lkZ2V0CisgICAgY2xhc3MgUGx1 Z2luVmlldyA6IHB1YmxpYyBQbHVnaW5WaWV3QmFzZQogI2lmIEVOQUJMRShORVRTQ0FQRV9QTFVH SU5fQVBJKQogICAgICAgICAgICAgICAgICAgICAgLCBwcml2YXRlIFBsdWdpblN0cmVhbUNsaWVu dAogI2VuZGlmCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlld0Jhc2UuaCBi L1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3QmFzZS5oCmluZGV4IDU4Y2VmZmEuLjhkYzY2N2Eg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3QmFzZS5oCisrKyBiL1dlYkNv cmUvcGx1Z2lucy9QbHVnaW5WaWV3QmFzZS5oCkBAIC00OCw3ICs0OCw3IEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIHZvaWQgcHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkKGJvb2wpIHsgfQogCiBw cm90ZWN0ZWQ6Ci0gICAgUGx1Z2luVmlld0Jhc2UoUGxhdGZvcm1XaWRnZXQgd2lkZ2V0KSA6IFdp ZGdldCh3aWRnZXQpIHsgfQorICAgIFBsdWdpblZpZXdCYXNlKFBsYXRmb3JtV2lkZ2V0IHdpZGdl dCA9IDApIDogV2lkZ2V0KHdpZGdldCkgeyB9CiAgICAgCiBwcml2YXRlOgogICAgIHZpcnR1YWwg Ym9vbCBpc1BsdWdpblZpZXdCYXNlKCkgY29uc3QgeyByZXR1cm4gdHJ1ZTsgfQo= 70465 2010-10-11 13:59:03 -0700 2010-10-12 15:12:25 -0700 Take2 pluginviewbase text/plain 4216 girish Y29tbWl0IDlkNWJmMzlkNmE0MTQxNGI3MGExNDRmYmE1OTI0NWFhMWJmNWM0NTEKQXV0aG9yOiBH aXJpc2ggUmFtYWtyaXNobmFuIDxnaXJpc2hAZm9yd2FyZGJpYXMuaW4+CkRhdGU6ICAgVHVlIE9j dCAxMiAwMjoxNjoyMyAyMDEwICswNTMwCgogICAgMjAxMC0xMC0xMSAgR2lyaXNoIFJhbWFrcmlz aG5hbiAgPGdpcmlzaEBmb3J3YXJkYmlhcy5pbj4KICAgIAogICAgICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KICAgIAogICAgICAgICAgICBNYWtlIFBsdWdpblZpZXcgaW5oZXJp dCBmcm9tIFBsdWdpblZpZXdCYXNlLgogICAgCiAgICAgICAgICAgIFRoaXMgY2hhbmdlIGlzIGEg cHJlY3Vyc29yIHRvIGFkZGluZyBhY2NlbGVyYXRlZCBjb21wb3NpdGluZyBzdXBwb3J0CiAgICAg ICAgICAgIGZvciBOUEFQSSBwbHVnaW5zLgogICAgCiAgICAgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzQxOAogICAgCiAgICAgICAgICAgICogcGFnZS9Q YWdlLmNwcDoKICAgICAgICAgICAgKFdlYkNvcmU6OlBhZ2U6OnByaXZhdGVCcm93c2luZ1N0YXRl Q2hhbmdlZCk6CiAgICAgICAgICAgICogcGx1Z2lucy9QbHVnaW5WaWV3Lmg6CiAgICAgICAgICAg ICogcGx1Z2lucy9QbHVnaW5WaWV3QmFzZS5oOgogICAgICAgICAgICAoV2ViQ29yZTo6UGx1Z2lu Vmlld0Jhc2U6OlBsdWdpblZpZXdCYXNlKToKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGExZjA4MjUuLmM0MWQ1OGQgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAg QEAKKzIwMTAtMTAtMTEgIEdpcmlzaCBSYW1ha3Jpc2huYW4gIDxnaXJpc2hAZm9yd2FyZGJpYXMu aW4+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFr ZSBQbHVnaW5WaWV3IGluaGVyaXQgZnJvbSBQbHVnaW5WaWV3QmFzZS4KKworICAgICAgICBUaGlz IGNoYW5nZSBpcyBhIHByZWN1cnNvciB0byBhZGRpbmcgYWNjZWxlcmF0ZWQgY29tcG9zaXRpbmcg c3VwcG9ydAorICAgICAgICBmb3IgTlBBUEkgcGx1Z2lucy4KKworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDc0MTgKKworICAgICAgICAqIHBhZ2UvUGFn ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpQYWdlOjpwcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5n ZWQpOgorICAgICAgICAqIHBsdWdpbnMvUGx1Z2luVmlldy5oOgorICAgICAgICAqIHBsdWdpbnMv UGx1Z2luVmlld0Jhc2UuaDoKKyAgICAgICAgKFdlYkNvcmU6OlBsdWdpblZpZXdCYXNlOjpQbHVn aW5WaWV3QmFzZSk6CisKIDIwMTAtMTAtMTEgIEJyZW50IEZ1bGdoYW0gIDxiZnVsZ2hhbUB3ZWJr aXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luQ2Fpcm8gYnVpbGQgZml4ZXMuCmRpZmYg LS1naXQgYS9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAgYi9XZWJDb3JlL3BhZ2UvUGFnZS5jcHAKaW5k ZXggZTE1NDk2OC4uZTM4NjU3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCisr KyBiL1dlYkNvcmUvcGFnZS9QYWdlLmNwcApAQCAtODU2LDggKzg1Niw2IEBAIHZvaWQgUGFnZTo6 cHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkKCkKIAogICAgIC8vIENvbGxlY3QgdGhlIFBsdWdp blZpZXdzIGluIHRvIGEgdmVjdG9yIHRvIGVuc3VyZSB0aGF0IGFjdGlvbiB0aGUgcGx1Zy1pbiB0 YWtlcwogICAgIC8vIGZyb20gYmVsb3cgcHJpdmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkIGRvZXMg bm90IGFmZmVjdCB0aGVpciBsaWZldGltZS4KLSAgICAvLyBGSVhNRTogV2hlbiBQbHVnaW5WaWV3 QmFzZSBhbmQgUGx1Z2luVmlldyBhcmUgbWVyZ2VkIHdlIGRvbid0IG5lZWQgdGhpcyBleHRyYSBW ZWN0b3IuCi0gICAgVmVjdG9yPFJlZlB0cjxQbHVnaW5WaWV3PiwgMzI+IHBsdWdpblZpZXdzOwog ICAgIFZlY3RvcjxSZWZQdHI8UGx1Z2luVmlld0Jhc2U+LCAzMj4gcGx1Z2luVmlld0Jhc2VzOwog ICAgIGZvciAoRnJhbWUqIGZyYW1lID0gbWFpbkZyYW1lKCk7IGZyYW1lOyBmcmFtZSA9IGZyYW1l LT50cmVlKCktPnRyYXZlcnNlTmV4dCgpKSB7CiAgICAgICAgIEZyYW1lVmlldyogdmlldyA9IGZy YW1lLT52aWV3KCk7CkBAIC04NzAsMTUgKzg2OCwxMSBAQCB2b2lkIFBhZ2U6OnByaXZhdGVCcm93 c2luZ1N0YXRlQ2hhbmdlZCgpCiAgICAgICAgIEhhc2hTZXQ8UmVmUHRyPFdpZGdldD4gPjo6Y29u c3RfaXRlcmF0b3IgZW5kID0gY2hpbGRyZW4tPmVuZCgpOwogICAgICAgICBmb3IgKEhhc2hTZXQ8 UmVmUHRyPFdpZGdldD4gPjo6Y29uc3RfaXRlcmF0b3IgaXQgPSBjaGlsZHJlbi0+YmVnaW4oKTsg aXQgIT0gZW5kOyArK2l0KSB7CiAgICAgICAgICAgICBXaWRnZXQqIHdpZGdldCA9ICgqaXQpLmdl dCgpOwotICAgICAgICAgICAgaWYgKHdpZGdldC0+aXNQbHVnaW5WaWV3KCkpCi0gICAgICAgICAg ICAgICAgcGx1Z2luVmlld3MuYXBwZW5kKHN0YXRpY19jYXN0PFBsdWdpblZpZXcqPih3aWRnZXQp KTsKICAgICAgICAgICAgIGlmICh3aWRnZXQtPmlzUGx1Z2luVmlld0Jhc2UoKSkKICAgICAgICAg ICAgICAgICBwbHVnaW5WaWV3QmFzZXMuYXBwZW5kKHN0YXRpY19jYXN0PFBsdWdpblZpZXdCYXNl Kj4od2lkZ2V0KSk7CiAgICAgICAgIH0KICAgICB9CiAKLSAgICBmb3IgKHNpemVfdCBpID0gMDsg aSA8IHBsdWdpblZpZXdzLnNpemUoKTsgKytpKQotICAgICAgICBwbHVnaW5WaWV3c1tpXS0+cHJp dmF0ZUJyb3dzaW5nU3RhdGVDaGFuZ2VkKHByaXZhdGVCcm93c2luZ0VuYWJsZWQpOwogICAgIGZv ciAoc2l6ZV90IGkgPSAwOyBpIDwgcGx1Z2luVmlld0Jhc2VzLnNpemUoKTsgKytpKQogICAgICAg ICBwbHVnaW5WaWV3QmFzZXNbaV0tPnByaXZhdGVCcm93c2luZ1N0YXRlQ2hhbmdlZChwcml2YXRl QnJvd3NpbmdFbmFibGVkKTsKIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5W aWV3LmggYi9XZWJDb3JlL3BsdWdpbnMvUGx1Z2luVmlldy5oCmluZGV4IDk2ZGJhNjguLmUzN2Ri ZGIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3LmgKKysrIGIvV2ViQ29y ZS9wbHVnaW5zL1BsdWdpblZpZXcuaApAQCAtMzIsOSArMzIsOSBAQAogI2luY2x1ZGUgIkhhbHRh YmxlUGx1Z2luLmgiCiAjaW5jbHVkZSAiSW50UmVjdC5oIgogI2luY2x1ZGUgIk1lZGlhQ2FuU3Rh cnRMaXN0ZW5lci5oIgorI2luY2x1ZGUgIlBsdWdpblZpZXdCYXNlLmgiCiAjaW5jbHVkZSAiUmVz b3VyY2VSZXF1ZXN0LmgiCiAjaW5jbHVkZSAiVGltZXIuaCIKLSNpbmNsdWRlICJXaWRnZXQuaCIK ICNpbmNsdWRlIDx3dGYvSGFzaE1hcC5oPgogI2luY2x1ZGUgPHd0Zi9IYXNoU2V0Lmg+CiAjaW5j bHVkZSA8d3RmL093blB0ci5oPgpAQCAtMTIwLDcgKzEyMCw3IEBAIG5hbWVzcGFjZSBXZWJDb3Jl IHsKICAgICAgICAgdmlydHVhbCB2b2lkIGRpZEZhaWwoY29uc3QgUmVzb3VyY2VFcnJvciYpID0g MDsKICAgICB9OwogCi0gICAgY2xhc3MgUGx1Z2luVmlldyA6IHB1YmxpYyBXaWRnZXQKKyAgICBj bGFzcyBQbHVnaW5WaWV3IDogcHVibGljIFBsdWdpblZpZXdCYXNlCiAjaWYgRU5BQkxFKE5FVFND QVBFX1BMVUdJTl9BUEkpCiAgICAgICAgICAgICAgICAgICAgICAsIHByaXZhdGUgUGx1Z2luU3Ry ZWFtQ2xpZW50CiAjZW5kaWYKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGx1Z2lucy9QbHVnaW5WaWV3 QmFzZS5oIGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdCYXNlLmgKaW5kZXggNThjZWZmYS4u OGRjNjY3YSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdCYXNlLmgKKysr IGIvV2ViQ29yZS9wbHVnaW5zL1BsdWdpblZpZXdCYXNlLmgKQEAgLTQ4LDcgKzQ4LDcgQEAgcHVi bGljOgogICAgIHZpcnR1YWwgdm9pZCBwcml2YXRlQnJvd3NpbmdTdGF0ZUNoYW5nZWQoYm9vbCkg eyB9CiAKIHByb3RlY3RlZDoKLSAgICBQbHVnaW5WaWV3QmFzZShQbGF0Zm9ybVdpZGdldCB3aWRn ZXQpIDogV2lkZ2V0KHdpZGdldCkgeyB9CisgICAgUGx1Z2luVmlld0Jhc2UoUGxhdGZvcm1XaWRn ZXQgd2lkZ2V0ID0gMCkgOiBXaWRnZXQod2lkZ2V0KSB7IH0KICAgICAKIHByaXZhdGU6CiAgICAg dmlydHVhbCBib29sIGlzUGx1Z2luVmlld0Jhc2UoKSBjb25zdCB7IHJldHVybiB0cnVlOyB9Cg==