47395 2010-10-07 20:03:29 -0700 [EFL] Implement pageRect() function 2010-10-13 05:11:09 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 47084 0 gyuyoung.kim webkit-unassigned antognolli+webkit commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 291418 0 gyuyoung.kim 2010-10-07 20:03:29 -0700 I understand that the pageRect returns layout size. I implement it using frameRect() of WidgetEfl.cpp. 291419 1 70197 gyuyoung.kim 2010-10-07 20:08:14 -0700 Created attachment 70197 Patch 291425 2 gyuyoung.kim 2010-10-07 20:23:55 -0700 This patch passes to EWS for EFL port. :-) - http://webkit-commit-queue.appspot.com/ - http://webkit-commit-queue.appspot.com/queue-status/efl-ews 291430 3 tonikitoo 2010-10-07 21:02:44 -0700 For Qt, it was implement as the viewport size: 113 FloatRect ChromeClientQt::pageRect() 114 { 115 if (!m_webPage) 116 return FloatRect(); 117 return FloatRect(QRectF(QPointF(0, 0), m_webPage->viewportSize())); 118 } although it seems like gtk returns the "page" size as well: 113 FloatRect ChromeClientQt::pageRect() 114 { 115 if (!m_webPage) 116 return FloatRect(); 117 return FloatRect(QRectF(QPointF(0, 0), m_webPage->viewportSize())); 118 } They are missing consistency(?) 291431 4 70199 gyuyoung.kim 2010-10-07 21:09:07 -0700 Created attachment 70199 Patch I understand that QT port is using frameRect() as well as this patch. So, I also use the frameRect(). The frameRect() returns frameview size. QSize QWebPage::viewportSize() const { if (d->mainFrame && d->mainFrame->d->frame->view()) return d->mainFrame->d->frame->view()->frameRect().size(); return d->viewportSize; } And, I add null checking code. 291440 5 70199 commit-queue 2010-10-07 21:43:43 -0700 Comment on attachment 70199 Patch Clearing flags on attachment: 70199 Committed r69376: <http://trac.webkit.org/changeset/69376> 291441 6 commit-queue 2010-10-07 21:43:49 -0700 All reviewed patches have been landed. Closing bug. 70197 2010-10-07 20:08:14 -0700 2010-10-07 21:09:07 -0700 Patch patch-pagerect.txt text/plain 2398 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggNWI0MjMwZC4uNzU5N2JjOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0wNyAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEltcGxlbWVudCBwYWdlUmVj dCgpIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NzM5NQorCisgICAgICAgIEltcGxlbWVudCBwYWdlUmVjdCgpIGluIENocm9tZUNsaWVu dEVmbCB1c2luZyBmcmFtZVJlY3QoKS4KKworICAgICAgICAqIENNYWtlTGlzdHNFZmwudHh0Ogor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWVDbGllbnRFZmw6OnBhZ2VSZWN0KToKKyAgICAgICAgKiBld2svZXdrX3By aXZhdGUuaDoKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdf cGFnZV9yZWN0X2dldCk6IEFkZGVkLgorCiAyMDEwLTEwLTA2ICBSeXVhbiBDaG9pICA8cnl1YW4u Y2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3Bw IGIvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCmluZGV4IDFm MWMxZWMuLmZlYzViOTQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50RWZsLmNwcAorKysgYi9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEVmbC5jcHAKQEAgLTExOCw4ICsxMTgsNyBAQCB2b2lkIENocm9tZUNsaWVudEVmbDo6c2V0 V2luZG93UmVjdChjb25zdCBGbG9hdFJlY3QmIHJlY3QpCiAKIEZsb2F0UmVjdCBDaHJvbWVDbGll bnRFZmw6OnBhZ2VSZWN0KCkKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBG bG9hdFJlY3QoKTsKKyAgICByZXR1cm4gZXdrX3ZpZXdfcGFnZV9yZWN0X2dldChtX3ZpZXcpOwog fQogCiBmbG9hdCBDaHJvbWVDbGllbnRFZmw6OnNjYWxlRmFjdG9yKCkKZGlmZiAtLWdpdCBhL1dl YktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmggYi9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5o CmluZGV4IDViODliOGMuLjE4NWE3ZTEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3a19w cml2YXRlLmgKKysrIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUuaApAQCAtMTUyLDYgKzE1 Miw4IEBAIEVpbmFfQm9vbCBld2tfdmlld19uYXZpZ2F0aW9uX3BvbGljeV9kZWNpc2lvbihFdmFz X09iamVjdCogbywgRXdrX0ZyYW1lX1Jlc291cmNlCiAKIHZvaWQgZXdrX3ZpZXdfY29udGVudHNf c2l6ZV9jaGFuZ2VkKEV2YXNfT2JqZWN0ICpvLCBFdmFzX0Nvb3JkIHcsIEV2YXNfQ29vcmQgaCk7 CiAKK1dlYkNvcmU6OkZsb2F0UmVjdCBld2tfdmlld19wYWdlX3JlY3RfZ2V0KEV2YXNfT2JqZWN0 ICpvKTsKKwogI2lmZGVmIF9fY3BsdXNwbHVzCiAKIH0KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwv ZXdrL2V3a192aWV3LmNwcCBiL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAppbmRleCBmNzJh OWU3Li5hZjQwZjkzIDEwMDY0NAotLS0gYS9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKKysr IGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCkBAIC00MjI0LDMgKzQyMjQsMjAgQEAgdm9p ZCBld2tfdmlld19jb250ZW50c19zaXplX2NoYW5nZWQoRXZhc19PYmplY3QgKm8sIGludCB3LCBp bnQgaCkKICAgICBpZiAoIXNkLT5hcGktPmNvbnRlbnRzX3Jlc2l6ZShzZCwgdywgaCkpCiAgICAg ICAgIEVSUigiZmFpbGVkIHRvIHJlc2l6ZSBjb250ZW50cyB0byAlZHglZCIsIHcsIGgpOwogfQor CisvKioKKyAqIEBpbnRlcm5hbAorICogR2V0cyBwYWdlIHNpemUgZnJvbSBmcmFtZXZpZXcuIAor ICoKKyAqIEBwYXJhbSBvIHZpZXcuCisgKgorICogQHJldHVybiBwYWdlIHNpemUuCisgKi8KK1dl YkNvcmU6OkZsb2F0UmVjdCBld2tfdmlld19wYWdlX3JlY3RfZ2V0KEV2YXNfT2JqZWN0ICpvKQor eworICAgIEVXS19WSUVXX1NEX0dFVChvLCBzZCk7CisgICAgRVdLX1ZJRVdfUFJJVl9HRVQoc2Qs IHByaXYpOworCisgICAgV2ViQ29yZTo6RnJhbWUqIG1haW5fZnJhbWUgPSBwcml2LT5wYWdlLT5t YWluRnJhbWUoKTsKKyAgICByZXR1cm4gbWFpbl9mcmFtZS0+dmlldygpLT5mcmFtZVJlY3QoKTsK K30gCg== 70199 2010-10-07 21:09:07 -0700 2010-10-07 21:43:43 -0700 Patch patch-pagerect.txt text/plain 2448 gyuyoung.kim ZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvQ2hhbmdlTG9nIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK aW5kZXggNWI0MjMwZC4uNzU5N2JjOSAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2VmbC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0wNyAg R3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEltcGxlbWVudCBwYWdlUmVj dCgpIGZ1bmN0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD00NzM5NQorCisgICAgICAgIEltcGxlbWVudCBwYWdlUmVjdCgpIGluIENocm9tZUNsaWVu dEVmbCB1c2luZyBmcmFtZVJlY3QoKS4KKworICAgICAgICAqIENNYWtlTGlzdHNFZmwudHh0Ogor ICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0Nocm9tZUNsaWVudEVmbC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpDaHJvbWVDbGllbnRFZmw6OnBhZ2VSZWN0KToKKyAgICAgICAgKiBld2svZXdrX3By aXZhdGUuaDoKKyAgICAgICAgKiBld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAoZXdrX3ZpZXdf cGFnZV9yZWN0X2dldCk6IEFkZGVkLgorCiAyMDEwLTEwLTA2ICBSeXVhbiBDaG9pICA8cnl1YW4u Y2hvaUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBbnRvbmlvIEdvbWVzLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3Bw IGIvV2ViS2l0L2VmbC9XZWJDb3JlU3VwcG9ydC9DaHJvbWVDbGllbnRFZmwuY3BwCmluZGV4IDFm MWMxZWMuLjAxZjIxMzEgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvV2ViQ29yZVN1cHBvcnQvQ2hy b21lQ2xpZW50RWZsLmNwcAorKysgYi9XZWJLaXQvZWZsL1dlYkNvcmVTdXBwb3J0L0Nocm9tZUNs aWVudEVmbC5jcHAKQEAgLTExOCw4ICsxMTgsMTAgQEAgdm9pZCBDaHJvbWVDbGllbnRFZmw6OnNl dFdpbmRvd1JlY3QoY29uc3QgRmxvYXRSZWN0JiByZWN0KQogCiBGbG9hdFJlY3QgQ2hyb21lQ2xp ZW50RWZsOjpwYWdlUmVjdCgpCiB7Ci0gICAgbm90SW1wbGVtZW50ZWQoKTsKLSAgICByZXR1cm4g RmxvYXRSZWN0KCk7CisgICAgaWYgKCFtX3ZpZXcpCisgICAgICAgIHJldHVybiBGbG9hdFJlY3Qo KTsKKworICAgIHJldHVybiBld2tfdmlld19wYWdlX3JlY3RfZ2V0KG1fdmlldyk7CiB9CiAKIGZs b2F0IENocm9tZUNsaWVudEVmbDo6c2NhbGVGYWN0b3IoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Vm bC9ld2svZXdrX3ByaXZhdGUuaCBiL1dlYktpdC9lZmwvZXdrL2V3a19wcml2YXRlLmgKaW5kZXgg NWI4OWI4Yy4uMTg1YTdlMSAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9ld2svZXdrX3ByaXZhdGUu aAorKysgYi9XZWJLaXQvZWZsL2V3ay9ld2tfcHJpdmF0ZS5oCkBAIC0xNTIsNiArMTUyLDggQEAg RWluYV9Cb29sIGV3a192aWV3X25hdmlnYXRpb25fcG9saWN5X2RlY2lzaW9uKEV2YXNfT2JqZWN0 KiBvLCBFd2tfRnJhbWVfUmVzb3VyY2UKIAogdm9pZCBld2tfdmlld19jb250ZW50c19zaXplX2No YW5nZWQoRXZhc19PYmplY3QgKm8sIEV2YXNfQ29vcmQgdywgRXZhc19Db29yZCBoKTsKIAorV2Vi Q29yZTo6RmxvYXRSZWN0IGV3a192aWV3X3BhZ2VfcmVjdF9nZXQoRXZhc19PYmplY3QgKm8pOwor CiAjaWZkZWYgX19jcGx1c3BsdXMKIAogfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2VmbC9ld2svZXdr X3ZpZXcuY3BwIGIvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCmluZGV4IGY3MmE5ZTcuLmFm NDBmOTMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3a192aWV3LmNwcAorKysgYi9XZWJL aXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKQEAgLTQyMjQsMyArNDIyNCwyMCBAQCB2b2lkIGV3a192 aWV3X2NvbnRlbnRzX3NpemVfY2hhbmdlZChFdmFzX09iamVjdCAqbywgaW50IHcsIGludCBoKQog ICAgIGlmICghc2QtPmFwaS0+Y29udGVudHNfcmVzaXplKHNkLCB3LCBoKSkKICAgICAgICAgRVJS KCJmYWlsZWQgdG8gcmVzaXplIGNvbnRlbnRzIHRvICVkeCVkIiwgdywgaCk7CiB9CisKKy8qKgor ICogQGludGVybmFsCisgKiBHZXRzIHBhZ2Ugc2l6ZSBmcm9tIGZyYW1ldmlldy4gCisgKgorICog QHBhcmFtIG8gdmlldy4KKyAqCisgKiBAcmV0dXJuIHBhZ2Ugc2l6ZS4KKyAqLworV2ViQ29yZTo6 RmxvYXRSZWN0IGV3a192aWV3X3BhZ2VfcmVjdF9nZXQoRXZhc19PYmplY3QgKm8pCit7CisgICAg RVdLX1ZJRVdfU0RfR0VUKG8sIHNkKTsKKyAgICBFV0tfVklFV19QUklWX0dFVChzZCwgcHJpdik7 CisKKyAgICBXZWJDb3JlOjpGcmFtZSogbWFpbl9mcmFtZSA9IHByaXYtPnBhZ2UtPm1haW5GcmFt ZSgpOworICAgIHJldHVybiBtYWluX2ZyYW1lLT52aWV3KCktPmZyYW1lUmVjdCgpOworfSAK