47385 2010-10-07 17:10:01 -0700 Copy mesa lib into DumpRenderTree bundle in Mac 2010-10-07 17:55:03 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zmo zmo dglazkov enne kbr tony oldest_to_newest 291336 0 zmo 2010-10-07 17:10:01 -0700 Currently the code assumes mesa lib is there (which isn't), so DumpRenderTree is not using Mesa at the moment in Mac 291337 1 70175 zmo 2010-10-07 17:12:33 -0700 Created attachment 70175 patch 291342 2 70175 tony 2010-10-07 17:24:50 -0700 Comment on attachment 70175 patch View in context: https://bugs.webkit.org/attachment.cgi?id=70175&action=review > WebKit/chromium/WebKit.gyp:810 > + 'target_name': 'mesa', Can you move this target to the OS=="mac" section at the bottom of the file (next to LayoutTestHelper)? > WebKit/chromium/WebKit.gyp:830 > + 'mesa', And this will then move next to the LayoutTestHelper dependencies (around line 895). > WebKit/chromium/WebKit.gyp:-819 > - '<(chromium_src_dir)/third_party/mesa/mesa.gyp:osmesa', Then you can keep this line since win/linux needs it. 291355 3 70180 zmo 2010-10-07 17:44:35 -0700 Created attachment 70180 revised patch: responding to Tony Chang's review Also, I changed the target name from mesa to copy_mesa 291356 4 70180 tony 2010-10-07 17:46:15 -0700 Comment on attachment 70180 revised patch: responding to Tony Chang's review LGTM! 291363 5 zmo 2010-10-07 17:55:03 -0700 Committed r69365: <http://trac.webkit.org/changeset/69365> 70175 2010-10-07 17:12:33 -0700 2010-10-07 17:44:35 -0700 patch mesa.patch text/plain 2020 zmo SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjkzNTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMDcgIFpoZW55 YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDb3B5IG1lc2EgbGliIGludG8gRHVtcFJlbmRlclRyZWUgYnVuZGxl IGluIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDczODUKKworICAgICAgICAqIFdlYktpdC5neXA6CisKIDIwMTAtMTAtMDcgIERhbmllbCBDaGVu ZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFu Zy4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9jaHJvbWl1bS9XZWJLaXQuZ3lwCShyZXZpc2lvbiA2OTMyMykKKysrIFdlYktpdC9jaHJvbWl1 bS9XZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC04MDcsNiArODA3LDE5IEBACiAgICAgICAg ICAgICBdLAogICAgICAgICB9LAogICAgICAgICB7CisgICAgICAgICAgICAndGFyZ2V0X25hbWUn OiAnbWVzYScsCisgICAgICAgICAgICAndHlwZSc6ICdub25lJywKKyAgICAgICAgICAgICdkZXBl bmRlbmNpZXMnOiBbJzwoY2hyb21pdW1fc3JjX2RpcikvdGhpcmRfcGFydHkvbWVzYS9tZXNhLmd5 cDpvc21lc2EnXSwKKyAgICAgICAgICAgICdjb25kaXRpb25zJzogWworICAgICAgICAgICAgICAg IFsnT1M9PSJtYWMiJywgeworICAgICAgICAgICAgICAgICAgICAnY29waWVzJzogW3sKKyAgICAg ICAgICAgICAgICAgICAgICAgICdkZXN0aW5hdGlvbic6ICc8KFBST0RVQ1RfRElSKS9EdW1wUmVu ZGVyVHJlZS5hcHAvQ29udGVudHMvTWFjT1MvJywKKyAgICAgICAgICAgICAgICAgICAgICAgICdm aWxlcyc6IFsnPChQUk9EVUNUX0RJUikvb3NtZXNhLnNvJ10sCisgICAgICAgICAgICAgICAgICAg IH1dLAorICAgICAgICAgICAgICAgIH1dLAorICAgICAgICAgICAgXSwKKyAgICAgICAgfSwKKyAg ICAgICAgewogICAgICAgICAgICAgJ3RhcmdldF9uYW1lJzogJ0R1bXBSZW5kZXJUcmVlJywKICAg ICAgICAgICAgICd0eXBlJzogJ2V4ZWN1dGFibGUnLAogICAgICAgICAgICAgJ21hY19idW5kbGUn OiAxLApAQCAtODE0LDkgKzgyNyw5IEBACiAgICAgICAgICAgICAgICAgJ0ltYWdlRGlmZicsCiAg ICAgICAgICAgICAgICAgJ2luc3BlY3Rvcl9yZXNvdXJjZXMnLAogICAgICAgICAgICAgICAgICd3 ZWJraXQnLAorICAgICAgICAgICAgICAgICdtZXNhJywKICAgICAgICAgICAgICAgICAnLi4vLi4v SmF2YVNjcmlwdENvcmUvSmF2YVNjcmlwdENvcmUuZ3lwL0phdmFTY3JpcHRDb3JlLmd5cDp3dGZf Y29uZmlnJywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0 eS9pY3UvaWN1Lmd5cDppY3V1YycsCi0gICAgICAgICAgICAgICAgJzwoY2hyb21pdW1fc3JjX2Rp cikvdGhpcmRfcGFydHkvbWVzYS9tZXNhLmd5cDpvc21lc2EnLAogICAgICAgICAgICAgICAgICc8 KGNocm9taXVtX3NyY19kaXIpL3dlYmtpdC9zdXBwb3J0L3dlYmtpdF9zdXBwb3J0Lmd5cDpibG9i JywKICAgICAgICAgICAgICAgICAnPChjaHJvbWl1bV9zcmNfZGlyKS93ZWJraXQvc3VwcG9ydC93 ZWJraXRfc3VwcG9ydC5neXA6Y29weV9ucGFwaV9sYXlvdXRfdGVzdF9wbHVnaW4nLAogICAgICAg ICAgICAgICAgICc8KGNocm9taXVtX3NyY19kaXIpL3dlYmtpdC9zdXBwb3J0L3dlYmtpdF9zdXBw b3J0Lmd5cDp3ZWJraXRfc3VwcG9ydCcsCg== 70180 2010-10-07 17:44:35 -0700 2010-10-07 17:46:15 -0700 revised patch: responding to Tony Chang's review mesa.patch text/plain 1620 zmo SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjkzNTYpCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMTAtMDcgIFpoZW55 YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBDb3B5IG1lc2EgbGliIGludG8gRHVtcFJlbmRlclRyZWUgYnVuZGxl IGluIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 NDczODUKKworICAgICAgICAqIFdlYktpdC5neXA6CisKIDIwMTAtMTAtMDcgIERhbmllbCBDaGVu ZyAgPGRjaGVuZ0BjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgVG9ueSBDaGFu Zy4KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9XZWJLaXQuZ3lwCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktp dC9jaHJvbWl1bS9XZWJLaXQuZ3lwCShyZXZpc2lvbiA2OTMyMykKKysrIFdlYktpdC9jaHJvbWl1 bS9XZWJLaXQuZ3lwCSh3b3JraW5nIGNvcHkpCkBAIC04OTIsNyArODkyLDcgQEAKICAgICAgICAg ICAgICAgICAgICAgXSwgIyBhY3Rpb25zCiAgICAgICAgICAgICAgICAgfV0sCiAgICAgICAgICAg ICAgICAgWydPUz09Im1hYyInLCB7Ci0gICAgICAgICAgICAgICAgICAgICdkZXBlbmRlbmNpZXMn OiBbJ0xheW91dFRlc3RIZWxwZXInXSwKKyAgICAgICAgICAgICAgICAgICAgJ2RlcGVuZGVuY2ll cyc6IFsnTGF5b3V0VGVzdEhlbHBlcicsICdjb3B5X21lc2EnXSwKIAogICAgICAgICAgICAgICAg ICAgICAnbWFjX2J1bmRsZV9yZXNvdXJjZXMnOiBbCiAgICAgICAgICAgICAgICAgICAgICAgICAn PChhaGVtX3BhdGgpJywKQEAgLTk2Niw2ICs5NjYsMTUgQEAKICAgICAgICAgICAgICAgICAgICAg ICAgIF0sCiAgICAgICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICAgICAgfSwKKyAgICAg ICAgICAgICAgICB7CisgICAgICAgICAgICAgICAgICAgICd0YXJnZXRfbmFtZSc6ICdjb3B5X21l c2EnLAorICAgICAgICAgICAgICAgICAgICAndHlwZSc6ICdub25lJywKKyAgICAgICAgICAgICAg ICAgICAgJ2RlcGVuZGVuY2llcyc6IFsnPChjaHJvbWl1bV9zcmNfZGlyKS90aGlyZF9wYXJ0eS9t ZXNhL21lc2EuZ3lwOm9zbWVzYSddLAorICAgICAgICAgICAgICAgICAgICAnY29waWVzJzogW3sK KyAgICAgICAgICAgICAgICAgICAgICAgICdkZXN0aW5hdGlvbic6ICc8KFBST0RVQ1RfRElSKS9E dW1wUmVuZGVyVHJlZS5hcHAvQ29udGVudHMvTWFjT1MvJywKKyAgICAgICAgICAgICAgICAgICAg ICAgICdmaWxlcyc6IFsnPChQUk9EVUNUX0RJUikvb3NtZXNhLnNvJ10sCisgICAgICAgICAgICAg ICAgICAgIH1dLAorICAgICAgICAgICAgICAgIH0sCiAgICAgICAgICAgICBdLAogICAgICAgICB9 XSwKICAgICBdLCAjIGNvbmRpdGlvbnMK