47383 2010-10-07 16:04:45 -0700 [EFL] Fix shared timers on EFL port - make them thread safe. 2010-10-07 17:28:49 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 antognolli+webkit antognolli+webkit barbieri commit-queue kenneth leandro lucas.de.marchi tonikitoo oldest_to_newest 291301 0 antognolli+webkit 2010-10-07 16:04:45 -0700 [EFL] Fix shared timers on EFL port - make them thread safe. 291305 1 70165 antognolli+webkit 2010-10-07 16:14:22 -0700 Created attachment 70165 Patch 291308 2 antognolli+webkit 2010-10-07 16:18:48 -0700 As explained in the changelog, this patch makes shared timers thread safe for EFL port. I'm not sure about the function names, maybe would be good to use some namespace on them, since they are not methods from a class? It would be good to get rid of the mutex too, since we just need it when creating the pipe from a thread that is not the main thread. Do you think it's possible to add a function inside ThreadTimers or SharedTimer like initializeSharedTimer (which would be called from the main thread) so we can create the pipe there? 291344 3 70165 commit-queue 2010-10-07 17:28:44 -0700 Comment on attachment 70165 Patch Clearing flags on attachment: 70165 Committed r69358: <http://trac.webkit.org/changeset/69358> 291345 4 commit-queue 2010-10-07 17:28:49 -0700 All reviewed patches have been landed. Closing bug. 70165 2010-10-07 16:14:22 -0700 2010-10-07 17:28:43 -0700 Patch bug-47383-20101007201423.patch text/plain 4097 antognolli+webkit ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MDFjMGUwMmE1MWRiY2JiMWE0YTE1YjUwNTY5ZjVjMDU3ZWRjMjZkMi4uMjNjNTIxNjgzMzYzY2Yy MDVlMDdhMDMwYTZlZTgwMjlhNjNkN2Y5NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyOSBAQAorMjAxMC0xMC0wNyAgUmFm YWVsIEFudG9nbm9sbGkgIDxhbnRvZ25vbGxpQHByb2Z1c2lvbi5tb2JpPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtFRkxdIEZpeCBzaGFyZWQgdGlt ZXJzIG9uIEVGTCBwb3J0IC0gbWFrZSB0aGVtIHRocmVhZCBzYWZlLgorICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDczODMKKworICAgICAgICBVc2luZyBl Y29yZV90aW1lcl9hZGQgdG8gY3JlYXRlIGEgdGltZXIgZnJvbSBhIHRocmVhZCB0aGF0IGlzCisg ICAgICAgIG5vdCB0aGUgbWFpbiB0aHJlYWQgaXNuJ3Qgc2FmZS4gTm93IHdlIGFkZCBhIHBpcGUg dGhhdCBpcyB1c2VkCisgICAgICAgIHRvIHJlcXVlc3QgYSB0aW1lciB0byBiZSBhZGRlZCBpbiB0 aGUgbWFpbiB0aHJlYWQuCisKKyAgICAgICAgSW4gb3JkZXIgdG8gcmVkdWNlIHNvbWUgZGVsYXkg b24gdGltZXJzIHRoYXQgYXJlIGFkZGVkIHdpdGggYQorICAgICAgICB2ZXJ5IHNtYWxsIGludGVy dmFsLCB0aGUgdGltZXIgY2FsbGJhY2sgaXMgY2FsbGVkIGltbWVkaWF0ZWx5CisgICAgICAgIGlm IHRoZSBpbnRlcnZhbCBpcyBzbWFsbGVyIHRoYW4gdGhlIG1haW5sb29wIGZyYW1lIHRpbWUuCisK KyAgICAgICAgTm8gbmV3IGZlYXR1cmVzLCBzbyBubyB0ZXN0cyBhZGRlZC4KKworICAgICAgICAq IHBsYXRmb3JtL2VmbC9TaGFyZWRUaW1lckVmbC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpzZXRT aGFyZWRUaW1lckZpcmVkRnVuY3Rpb24pOgorICAgICAgICAoV2ViQ29yZTo6dGltZXJFdmVudCk6 CisgICAgICAgIChXZWJDb3JlOjpwcm9jZXNzVGltZXJzKToKKyAgICAgICAgKFdlYkNvcmU6OnBp cGVIYW5kbGVyQ2IpOgorICAgICAgICAoV2ViQ29yZTo6c3RvcFNoYXJlZFRpbWVyKToKKyAgICAg ICAgKFdlYkNvcmU6OmFkZE5ld1RpbWVyKToKKyAgICAgICAgKFdlYkNvcmU6OnNldFNoYXJlZFRp bWVyRmlyZVRpbWUpOgorCiAyMDEwLTEwLTA3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1n aXQgYS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9TaGFyZWRUaW1lckVmbC5jcHAgYi9XZWJDb3JlL3Bs YXRmb3JtL2VmbC9TaGFyZWRUaW1lckVmbC5jcHAKaW5kZXggNDM3ZGU2NDY3M2UyYjM1NDk5Yjgx OTAyNzM1MjU2NjBhMTc0ZWM5ZS4uOTkwZDBjODgwNGY3NWE4YzNkODZkYWYwZmVkMTE4ZGE2MGI1 YWY0YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9lZmwvU2hhcmVkVGltZXJFZmwuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZWZsL1NoYXJlZFRpbWVyRWZsLmNwcApAQCAtMzAsNDMg KzMwLDk3IEBACiAjaW5jbHVkZSAiU2hhcmVkVGltZXIuaCIKIAogI2luY2x1ZGUgPEVjb3JlLmg+ CisjaW5jbHVkZSA8cHRocmVhZC5oPgogI2luY2x1ZGUgPHN0ZGlvLmg+CiAjaW5jbHVkZSA8d3Rm L0Fzc2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KKyNpbmNsdWRlIDx3 dGYvTWFpblRocmVhZC5oPgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKLXN0YXRpYyBFY29yZV9U aW1lciAqZ19zaGFyZWRUaW1lciA9IDA7CitzdGF0aWMgcHRocmVhZF9tdXRleF90IHRpbWVyTXV0 ZXggPSBQVEhSRUFEX01VVEVYX0lOSVRJQUxJWkVSOworc3RhdGljIEVjb3JlX1RpbWVyICpfc2hh cmVkVGltZXIgPSAwOworc3RhdGljIEVjb3JlX1BpcGUgKl9waXBlID0gMDsKIAotc3RhdGljIHZv aWQgKCpnX3RpbWVyRnVuY3Rpb24pKCk7CitzdGF0aWMgdm9pZCAoKl90aW1lckZ1bmN0aW9uKSgp OworCitzdHJ1Y3QgdGltZXJPcCB7CisgICAgZG91YmxlIHRpbWU7CisgICAgdW5zaWduZWQgY2hh ciBvcDsgLy8gMCAtIGFkZCBhIHRpbWVyOyAxIC0gZGVsIGEgdGltZXI7Cit9OwogCiB2b2lkIHNl dFNoYXJlZFRpbWVyRmlyZWRGdW5jdGlvbih2b2lkICgqZnVuYykoKSkKIHsKLSAgICBnX3RpbWVy RnVuY3Rpb24gPSBmdW5jOworICAgIF90aW1lckZ1bmN0aW9uID0gZnVuYzsKIH0KIAogc3RhdGlj IEVpbmFfQm9vbCB0aW1lckV2ZW50KHZvaWQqKQogewotICAgIGlmIChnX3RpbWVyRnVuY3Rpb24p Ci0gICAgICAgIGdfdGltZXJGdW5jdGlvbigpOworICAgIGlmIChfdGltZXJGdW5jdGlvbikKKyAg ICAgICAgX3RpbWVyRnVuY3Rpb24oKTsKKworICAgIF9zaGFyZWRUaW1lciA9IDA7CiAKICAgICBy ZXR1cm4gRUNPUkVfQ0FMTEJBQ0tfQ0FOQ0VMOwogfQogCi12b2lkIHN0b3BTaGFyZWRUaW1lcigp Cit2b2lkIHByb2Nlc3NUaW1lcnMoc3RydWN0IHRpbWVyT3AgKnRPcCkKIHsKLSAgICBpZiAoZ19z aGFyZWRUaW1lcikgewotICAgICAgICBlY29yZV90aW1lcl9kZWwoZ19zaGFyZWRUaW1lcik7Ci0g ICAgICAgIGdfc2hhcmVkVGltZXIgPSAwOworICAgIGlmIChfc2hhcmVkVGltZXIpIHsKKyAgICAg ICAgZWNvcmVfdGltZXJfZGVsKF9zaGFyZWRUaW1lcik7CisgICAgICAgIF9zaGFyZWRUaW1lciA9 IDA7CiAgICAgfQorCisgICAgaWYgKHRPcC0+b3AgPT0gMSkKKyAgICAgICAgcmV0dXJuOworCisg ICAgZG91YmxlIGludGVydmFsID0gdE9wLT50aW1lIC0gY3VycmVudFRpbWUoKTsKKworICAgIGlm IChpbnRlcnZhbCA8PSBlY29yZV9hbmltYXRvcl9mcmFtZXRpbWVfZ2V0KCkpIHsKKyAgICAgICAg aWYgKF90aW1lckZ1bmN0aW9uKQorICAgICAgICAgICAgX3RpbWVyRnVuY3Rpb24oKTsKKyAgICAg ICAgcmV0dXJuOworICAgIH0KKworICAgIF9zaGFyZWRUaW1lciA9IGVjb3JlX3RpbWVyX2FkZChp bnRlcnZhbCwgdGltZXJFdmVudCwgMCk7CiB9CiAKLXZvaWQgc2V0U2hhcmVkVGltZXJGaXJlVGlt ZShkb3VibGUgZmlyZVRpbWUpCit2b2lkIHBpcGVIYW5kbGVyQ2Iodm9pZCAqZGF0YSwgdm9pZCAq YnVmZmVyLCB1bnNpZ25lZCBpbnQgbmJ5dGUpCit7CisgICAgQVNTRVJUKG5ieXRlID09IHNpemVv ZihzdHJ1Y3QgdGltZXJPcCkpOworCisgICAgc3RydWN0IHRpbWVyT3AgKnRPcCA9IChzdHJ1Y3Qg dGltZXJPcCAqKWJ1ZmZlcjsKKyAgICBwcm9jZXNzVGltZXJzKHRPcCk7Cit9CisKK3ZvaWQgc3Rv cFNoYXJlZFRpbWVyKCkKIHsKLSAgICBkb3VibGUgaW50ZXJ2YWwgPSBmaXJlVGltZSAtIGN1cnJl bnRUaW1lKCk7CisgICAgc3RydWN0IHRpbWVyT3AgdE9wOworICAgIHB0aHJlYWRfbXV0ZXhfbG9j aygmdGltZXJNdXRleCk7CisgICAgaWYgKCFfcGlwZSkKKyAgICAgICAgX3BpcGUgPSBlY29yZV9w aXBlX2FkZChwaXBlSGFuZGxlckNiLCAwKTsKKyAgICBwdGhyZWFkX211dGV4X3VubG9jaygmdGlt ZXJNdXRleCk7CiAKLSAgICBzdG9wU2hhcmVkVGltZXIoKTsKLSAgICBnX3NoYXJlZFRpbWVyID0g ZWNvcmVfdGltZXJfYWRkKGludGVydmFsLCB0aW1lckV2ZW50LCAwKTsKKyAgICB0T3Aub3AgPSAx OworICAgIGVjb3JlX3BpcGVfd3JpdGUoX3BpcGUsICZ0T3AsIHNpemVvZih0T3ApKTsKK30KKwor dm9pZCBhZGROZXdUaW1lcihkb3VibGUgZmlyZVRpbWUpCit7CisgICAgc3RydWN0IHRpbWVyT3Ag dE9wOworICAgIHB0aHJlYWRfbXV0ZXhfbG9jaygmdGltZXJNdXRleCk7CisgICAgaWYgKCFfcGlw ZSkKKyAgICAgICAgX3BpcGUgPSBlY29yZV9waXBlX2FkZChwaXBlSGFuZGxlckNiLCAwKTsKKyAg ICBwdGhyZWFkX211dGV4X3VubG9jaygmdGltZXJNdXRleCk7CisKKyAgICB0T3AudGltZSA9IGZp cmVUaW1lOworICAgIHRPcC5vcCA9IDA7CisgICAgZWNvcmVfcGlwZV93cml0ZShfcGlwZSwgJnRP cCwgc2l6ZW9mKHRPcCkpOworfQorCit2b2lkIHNldFNoYXJlZFRpbWVyRmlyZVRpbWUoZG91Ymxl IGZpcmVUaW1lKQoreworICAgIGFkZE5ld1RpbWVyKGZpcmVUaW1lKTsKIH0KIAogfQo=