47380 2010-10-07 14:28:54 -0700 [V8] Add FileWriter to active DOM map 2010-10-07 19:03:33 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 44358 1 ericu ericu commit-queue jianli kinuko michaeln oldest_to_newest 291262 0 ericu 2010-10-07 14:28:54 -0700 As in https://bugs.webkit.org/show_bug.cgi?id=47205, it needs to be added in CodeGeneratorV8.pm. However, it's not directly constructable, so it doesn't need the custom constructor. The ref() is done in wrapSlow(), which gets called via FileWriterCallback. 291365 1 70181 ericu 2010-10-07 17:58:42 -0700 Created attachment 70181 One-liner. Hope this works; I haven't created a patch manually on Windows before. 291367 2 70181 jianli 2010-10-07 18:02:06 -0700 Comment on attachment 70181 One-liner. View in context: https://bugs.webkit.org/attachment.cgi?id=70181&action=review > WebCore/ChangeLog:5 > + Add FileWriter to V8 active DOM map Please add "[V8]" prefix to the bug title and also update the ChangeLog. 291376 3 70183 ericu 2010-10-07 18:27:10 -0700 Created attachment 70183 Fixed ChangeLog and bug title. 291390 4 70183 commit-queue 2010-10-07 19:03:28 -0700 Comment on attachment 70183 Fixed ChangeLog and bug title. Clearing flags on attachment: 70183 Committed r69370: <http://trac.webkit.org/changeset/69370> 291391 5 commit-queue 2010-10-07 19:03:33 -0700 All reviewed patches have been landed. Closing bug. 70181 2010-10-07 17:58:42 -0700 2010-10-07 18:27:10 -0700 One-liner. v8ado.patch text/plain 1019 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTM0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMDcgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIEFk ZCBGaWxlV3JpdGVyIHRvIFY4IGFjdGl2ZSBET00gbWFwCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzM4MAorCisgICAgICAgIEl0J3MgYW4gQWN0aXZl RE9NT2JqZWN0OyBpdCBuZWVkcyB0byBiZSBpbiB0aGUgbWFwLgorCisgICAgICAgICogYmluZGlu Z3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG06CisKIDIwMTAtMTAtMDcgIERhdmlkIEh5YXR0 ICA8aHlhdHRAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcuCklu ZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0JKHJldmlz aW9uIDY5MzQyKQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5w bQkod29ya2luZyBjb3B5KQpAQCAtMjU1Niw2ICsyNTU2LDcgQEAKICAgICByZXR1cm4gMSBpZiAk dHlwZSBlcSAiU2hhcmVkV29ya2VyIjsKICAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiSURCUmVx dWVzdCI7CiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIkZpbGVSZWFkZXIiOworICAgIHJldHVy biAxIGlmICR0eXBlIGVxICJGaWxlV3JpdGVyIjsKICAgICByZXR1cm4gMDsKIH0KIAo= 70183 2010-10-07 18:27:10 -0700 2010-10-07 19:03:28 -0700 Fixed ChangeLog and bug title. v8ado.patch text/plain 1021 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTM0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMTAtMDcgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKQorCisgICAgICAgIFtW OF0gQWRkIEZpbGVXcml0ZXIgdG8gYWN0aXZlIERPTSBtYXAKKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MzgwCisKKyAgICAgICAgSXQncyBhbiBBY3Rp dmVET01PYmplY3Q7IGl0IG5lZWRzIHRvIGJlIGluIHRoZSBtYXAuCisKKyAgICAgICAgKiBiaW5k aW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbToKKwogMjAxMC0xMC0wNyAgRGF2aWQgSHlh dHQgIDxoeWF0dEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4K SW5kZXg6IFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkocmV2 aXNpb24gNjkzNDIpCisrKyBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4 LnBtCSh3b3JraW5nIGNvcHkpCkBAIC0yNTU2LDYgKzI1NTYsNyBAQAogICAgIHJldHVybiAxIGlm ICR0eXBlIGVxICJTaGFyZWRXb3JrZXIiOwogICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJJREJS ZXF1ZXN0IjsKICAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiRmlsZVJlYWRlciI7CisgICAgcmV0 dXJuIDEgaWYgJHR5cGUgZXEgIkZpbGVXcml0ZXIiOwogICAgIHJldHVybiAwOwogfQogCg==