<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>47349</bug_id>
          
          <creation_ts>2010-10-07 07:17:23 -0700</creation_ts>
          <short_desc>[Qt] Turn on building WTR</short_desc>
          <delta_ts>2010-10-08 09:16:42 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Balazs Kelemen">kbalazs</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abecsi</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>290985</commentid>
    <comment_count>0</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-07 07:17:23 -0700</bug_when>
    <thetext>WTR build has been stabilized since r69297 (and it&apos;s follow up build-fixes) so we can turn it on.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>290989</commentid>
    <comment_count>1</comment_count>
      <attachid>70084</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-07 07:19:04 -0700</bug_when>
    <thetext>Created attachment 70084
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291000</commentid>
    <comment_count>2</comment_count>
      <attachid>70084</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-07 07:36:08 -0700</bug_when>
    <thetext>Comment on attachment 70084
Patch

Clearing flags on attachment: 70084

Committed r69306: &lt;http://trac.webkit.org/changeset/69306&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291001</commentid>
    <comment_count>3</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-07 07:36:16 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291684</commentid>
    <comment_count>4</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-08 09:03:42 -0700</bug_when>
    <thetext>We have turned it off again while worked on InjectedBundle. Now we have everything in, and WTR is functional: you can give a html file to that (with absolute path) and it will dump that out. Hurray! Turn it on!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291690</commentid>
    <comment_count>5</comment_count>
      <attachid>70256</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-08 09:09:49 -0700</bug_when>
    <thetext>Created attachment 70256
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291694</commentid>
    <comment_count>6</comment_count>
      <attachid>70256</attachid>
    <who name="Csaba Osztrogonác">ossy</who>
    <bug_when>2010-10-08 09:13:33 -0700</bug_when>
    <thetext>Comment on attachment 70256
Patch

Great work, guys! r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291695</commentid>
    <comment_count>7</comment_count>
    <who name="Andras Becsi">abecsi</who>
    <bug_when>2010-10-08 09:15:07 -0700</bug_when>
    <thetext>(In reply to comment #4)
&gt; We have turned it off again while worked on InjectedBundle. Now we have everything in, and WTR is functional: you can give a html file to that (with absolute path) and it will dump that out. Hurray! Turn it on!

Further more WebKitTools/Scripts/run-webkit-tests -2 can also be used to run the layout tests with WTR.
There are still many tests failing, which need investigation, but setting up a bot should be easy now.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291697</commentid>
    <comment_count>8</comment_count>
      <attachid>70256</attachid>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-08 09:16:30 -0700</bug_when>
    <thetext>Comment on attachment 70256
Patch

Clearing flags on attachment: 70256

Committed r69405: &lt;http://trac.webkit.org/changeset/69405&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>291698</commentid>
    <comment_count>9</comment_count>
    <who name="Balazs Kelemen">kbalazs</who>
    <bug_when>2010-10-08 09:16:42 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70084</attachid>
            <date>2010-10-07 07:19:04 -0700</date>
            <delta_ts>2010-10-08 09:09:43 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-47349-20101007161903.patch</filename>
            <type>text/plain</type>
            <size>1234</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4ZGI0MzE3ZjgxMmMxOTgy
ZGI3NGM5ZDE2NDRhNmJlZWNiMmFhZTQ5Li4zYjE4YTM2NDhkZmYzYTY2MWY1MGE0MzFlMzNhMGIz
ZTU5NzNiY2E5IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTIgQEAKKzIwMTAtMTAtMDcgIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g
VHVybiBvbiBidWlsZGluZyBXVFIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTQ3MzQ5CisKKyAgICAgICAgKiBXZWJLaXQucHJvOgorCiAyMDEwLTEwLTA3
ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBS
ZXZpZXdlZCBieSBYYW4gTG9wZXouCmRpZmYgLS1naXQgYS9XZWJLaXQucHJvIGIvV2ViS2l0LnBy
bwppbmRleCAwMmQwMGM5YmRiNWU5NjExZmY5NmUwNTliYTY3Y2JjNGU5ZDMxMWFiLi44OThhNGVj
MDcxYWM3MjMyMTg1MTY1MDgwZTRkOTRlOTcxNDg0ZTdmIDEwMDY0NAotLS0gYS9XZWJLaXQucHJv
CisrKyBiL1dlYktpdC5wcm8KQEAgLTMzLDkgKzMzLDcgQEAgYnVpbGQtcXRzY3JpcHQgewogd2Vi
a2l0MiB7CiAgICAgZXhpc3RzKCQkUFdEL1dlYktpdDIvV2ViUHJvY2Vzcy5wcm8pOiBTVUJESVJT
ICs9IFdlYktpdDIvV2ViUHJvY2Vzcy5wcm8KICAgICBleGlzdHMoJCRQV0QvV2ViS2l0VG9vbHMv
TWluaUJyb3dzZXIvcXQvTWluaUJyb3dzZXIucHJvKTogU1VCRElSUyArPSBXZWJLaXRUb29scy9N
aW5pQnJvd3Nlci9xdC9NaW5pQnJvd3Nlci5wcm8KLQotICAgICMgU3dpdGNoIGl0IG9uIHdoZW4g
dGhlIGJ1aWxkIGhhcyBiZWVuIHN0YWJpbGl6ZWQuCi0gICAgI2V4aXN0cygkJFBXRC9XZWJLaXRU
b29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1dlYktpdFRlc3RSdW5uZXIucHJvKTogU1VCRElSUyAr
PSBXZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1dlYktpdFRlc3RSdW5uZXIucHJvCisg
ICAgZXhpc3RzKCQkUFdEL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvV2ViS2l0VGVz
dFJ1bm5lci5wcm8pOiBTVUJESVJTICs9IFdlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQv
V2ViS2l0VGVzdFJ1bm5lci5wcm8KIH0KIAogc3ltYmlhbiB7Cg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>70256</attachid>
            <date>2010-10-08 09:09:49 -0700</date>
            <delta_ts>2010-10-08 09:16:30 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-47349-20101008180947.patch</filename>
            <type>text/plain</type>
            <size>3110</size>
            <attacher name="Balazs Kelemen">kbalazs</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAxZTJjZWI3ZDFiYWJiMDdh
MGU0ZTNhM2JlMThlMDQ4NWQyNzBkNTE2Li45MDJkOWJlN2RlOGIyZjdkYzg3YzVlNTA0MjJiNTUz
MjcxN2JiZGU2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMg
KzEsMTMgQEAKKzIwMTAtMTAtMDggIEJhbGF6cyBLZWxlbWVuICA8a2JhbGF6c0B3ZWJraXQub3Jn
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0g
VHVybiBvbiBidWlsZGluZyBXVFIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv
d19idWcuY2dpP2lkPTQ3MzQ5CisKKyAgICAgICAgKiBEZXJpdmVkU291cmNlcy5wcm86CisgICAg
ICAgICogV2ViS2l0LnBybzoKKwogMjAxMC0xMC0wNyAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2Vs
eW4udHVyY290dGVAbm9raWEuY29tPiwgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdlYmtpdC5vcmc+
LCBCYWxhenMgS2VsZW1lbiAgPGtiYWxhenNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdl
ZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL0Rlcml2ZWRTb3Vy
Y2VzLnBybyBiL0Rlcml2ZWRTb3VyY2VzLnBybwppbmRleCA3NmNiMzdlNmNiODZlMDMzOGZhMTQ4
MzExNjUyOWM4N2FkNTNhYzVmLi5lZjg4NjMyYTkxN2FkM2Y3ZDc3MzczNTY5OTVjYzRhMjU0OTU2
ZjZjIDEwMDY0NAotLS0gYS9EZXJpdmVkU291cmNlcy5wcm8KKysrIGIvRGVyaXZlZFNvdXJjZXMu
cHJvCkBAIC04LDkgKzgsNyBAQCBTVUJESVJTICs9IFwKIAogd2Via2l0MiB7CiAgICAgU1VCRElS
UyArPSBXZWJLaXQyL0Rlcml2ZWRTb3VyY2VzLnBybwotCi0gICAgIyBVbmNvbW1lbnQgd2hlbiBX
VFIgaXMgcmVhZHkgdXBzdHJlYW0KLSAgICAjU1VCRElSUyArPSBXZWJLaXRUb29scy9XZWJLaXRU
ZXN0UnVubmVyL0Rlcml2ZWRTb3VyY2VzLnBybworICAgIFNVQkRJUlMgKz0gV2ViS2l0VG9vbHMv
V2ViS2l0VGVzdFJ1bm5lci9EZXJpdmVkU291cmNlcy5wcm8KIH0KIAogZm9yKHN1YnBybywgU1VC
RElSUykgewpkaWZmIC0tZ2l0IGEvV2ViS2l0LnBybyBiL1dlYktpdC5wcm8KaW5kZXggNTk1ZmRl
NTEwZjNkYjFhNjE5YWY5NzE4ZjU1ZmFiMGU0NDIyNGRlYi4uMDY5ZTFmMmI4MGQwZmM4OTk0Nzc1
ZTU2NTQwMWI0ZGQzODUxMDA4OSAxMDA2NDQKLS0tIGEvV2ViS2l0LnBybworKysgYi9XZWJLaXQu
cHJvCkBAIC0zMyw4ICszMyw3IEBAIGJ1aWxkLXF0c2NyaXB0IHsKIHdlYmtpdDIgewogICAgIGV4
aXN0cygkJFBXRC9XZWJLaXQyL1dlYlByb2Nlc3MucHJvKTogU1VCRElSUyArPSBXZWJLaXQyL1dl
YlByb2Nlc3MucHJvCiAgICAgZXhpc3RzKCQkUFdEL1dlYktpdFRvb2xzL01pbmlCcm93c2VyL3F0
L01pbmlCcm93c2VyLnBybyk6IFNVQkRJUlMgKz0gV2ViS2l0VG9vbHMvTWluaUJyb3dzZXIvcXQv
TWluaUJyb3dzZXIucHJvCi0gICAgIyBUdXJuIGl0IG9uIGFmdGVyIHRoZSBidWlsZCBoYXMgYmVl
biBzdGFiaWxpemVkLgotICAgICNleGlzdHMoJCRQV0QvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1
bm5lci9xdC9XZWJLaXRUZXN0UnVubmVyLnBybyk6IFNVQkRJUlMgKz0gV2ViS2l0VG9vbHMvV2Vi
S2l0VGVzdFJ1bm5lci9xdC9XZWJLaXRUZXN0UnVubmVyLnBybworICAgIGV4aXN0cygkJFBXRC9X
ZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL1dlYktpdFRlc3RSdW5uZXIucHJvKTogU1VCRElS
UyArPSBXZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL1dlYktpdFRlc3RSdW5uZXIucHJvCiB9
CiAKIHN5bWJpYW4gewpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0
VG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQxZjQyN2I5OTkyNzk5NTNkMjJhMGU4NTZkOWE4NGM2MTlh
Y2M0YTMuLjU3OTNmYjExMmE0ZDgzZjY2MDg3ODUxODNiZTJkNWQwY2QwMDUwMzIgMTAwNjQ0Ci0t
LSBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAg
LTEsNSArMSwxNCBAQAogMjAxMC0xMC0wOCAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtp
dC5vcmc+CiAKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg
W1F0XSBUdXJuIG9uIGJ1aWxkaW5nIFdUUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y
Zy9zaG93X2J1Zy5jZ2k/aWQ9NDczNDkKKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5w
bToKKworMjAxMC0xMC0wOCAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisK
ICAgICAgICAgUmV2aWV3ZWQgYnkgQW5kcmVhcyBLbGluZy4KIAogICAgICAgICBbUXRdIFRlc3RD
b250cm9sbGVyIG5lZWRzIGl0cyBwbGF0Zm9ybSBkZXBlbmRlbnQgbWV0aG9kcwpkaWZmIC0tZ2l0
IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0
cy93ZWJraXRkaXJzLnBtCmluZGV4IDQ4ZGFkY2JmMjU5ZjYzMmM2MWFjN2RmNGU5NmJiMzJhNDIw
Y2JiMGYuLmY4YjUwMzVkY2YzZmZlOTJjN2FjOTI1MzhiYzgzZWZmNDEzNDIzOTkgMTAwNjQ0Ci0t
LSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9XZWJLaXRUb29scy9T
Y3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE1MzAsOSArMTUzMCw3IEBAIHN1YiBidWlsZFFNYWtl
UHJvamVjdCgkQCkKICAgICBteSBAc3ViZGlycyA9ICgiSmF2YVNjcmlwdENvcmUiLCAiV2ViQ29y
ZSIsICJXZWJLaXQvcXQvQXBpIik7CiAgICAgaWYgKGdyZXAgeyAkXyBlcSAiQ09ORklHKz13ZWJr
aXQyIn0gQGJ1aWxkQXJncykgewogICAgICAgICBwdXNoIEBzdWJkaXJzLCAiV2ViS2l0MiI7Ci0K
LSAgICAgICAgIyBVbmNvbW1lbnQgd2hlbiBXVFIgaXMgcmVhZHkgdXBzdHJlYW0KLSAgICAgICAg
I3B1c2ggQHN1YmRpcnMsICJXZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyIjsKKyAgICAgICAg
cHVzaCBAc3ViZGlycywgIldlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIiOwogICAgIH0KIAog
ICAgIGZvciBteSAkc3ViZGlyIChAc3ViZGlycykgewo=
</data>

          </attachment>
      

    </bug>

</bugzilla>