47348 2010-10-07 07:17:12 -0700 Update behaviour of href when document base URI is changed after href attribute has been set 2012-11-18 22:58:48 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED DUPLICATE 98184 P2 Normal --- 47665 46982 1 steveblock webkit-unassigned abarth ap arv brettw steveblock yael oldest_to_newest 290984 0 steveblock 2010-10-07 07:17:12 -0700 When href attributes are set from JavaScript, the href's URL is not correctly re-based when the document's base URL is changed. The problem is that when an href attribute is set, the href is updated to the absolute URL that is the result of resolving against the current base URL. When the base URL is updated and the href is re-resolved, the result is the same absolute URL. See, for example, HTMLAnchorElement::setSearch(). If the initial href is relative, it should remain relative after the attribute is set, so it can be correctly resolved against the new base URL. 290993 1 70088 steveblock 2010-10-07 07:21:30 -0700 Created attachment 70088 Test case 292878 2 steveblock 2010-10-12 00:45:40 -0700 If somebody could confirm that this is indeed a bug and that we want to fix it, I'll provide a patch. 292974 3 abarth 2010-10-12 09:46:13 -0700 Can you provide a matrix of how other browsers behave on this test? That will let us figure out what behavior we'd like to adopt. 293372 4 steveblock 2010-10-13 05:48:10 -0700 I tried this on Chrome, Safari, FF 4 (FF 3 does not support updating the document base) and IE 8. All pass the first part of the test ... debug("Base case, rebase URL without attribute having been set"); base.href = "http://old_base/"; a.href = "foo?query"; shouldBe("a.href", "'http://old_base/foo?query'"); base.href = "http://new_base/"; shouldBe("a.href", "'http://new_base/foo?query'"); PASS a.href is http://old_base/foo?query PASS a.href is http://new_base/foo?query All fail the second part of the test in the same way - the href is not rebased ... debug("Rebase URL where search attribute has been set"); base.href = "http://old_base/"; a.href = "foo"; a.search = "query"; shouldBe("a.href", "'http://old_base/foo?query'"); base.href = "http://new_base/"; shouldBe("a.href", "'http://new_base/foo?query'"); PASS a.href is http://old_base/foo?query FAIL a.href should be http://new_base/foo?query, was http://old_base/foo?query I don't see anything in the spec - http://dev.w3.org/html5/spec/urls.html - which suggests that setting an attribute should make the href absolute and therefore not subject to changes to the document base URI. 293453 5 abarth 2010-10-13 09:32:18 -0700 > I tried this on Chrome, Safari, FF 4 (FF 3 does not support updating the document base) and IE 8. So, from these results, it looks like all the browsers already behave in the same way? It sounds like we shouldn't change anything then. > I don't see anything in the spec - http://dev.w3.org/html5/spec/urls.html - which suggests that setting an attribute should make the href absolute and therefore not subject to changes to the document base URI. That part of the spec needs a lot of love. Fixing that spec is on my list of thing to do. It seems like the right thing to here is to land these tests to document our behavior and update the spec to say what all the browsers do. 293455 6 steveblock 2010-10-13 09:35:51 -0700 > So, from these results, it looks like all the browsers already behave in the > same way? Correct. > It seems like the right thing to here is to land these tests to document our > behavior and update the spec to say what all the browsers do. OK, will do. 294058 7 steveblock 2010-10-14 05:17:40 -0700 This bug now tracks updating our behaviour to match the spec, once it's been fixed. The current behaviour will be documented through tests added in Bug 47665. 733732 8 arv 2012-10-03 08:36:37 -0700 Based on the tests for bug 47665, if a.search is set then the href should be "locked" to the current base. This contradicts comment 4: debug("Rebase URL where search attribute has been set"); base.href = "http://old_base/"; a.href = "foo"; a.search = "query"; shouldBe("a.href", "'http://old_base/foo?query'"); base.href = "http://new_base/"; shouldBe("a.href", "'http://new_base/foo?query'"); *** This bug has been marked as a duplicate of bug 98184 *** 770370 9 steveblock 2012-11-18 22:58:48 -0800 I don't think there's a contradiction. The test case attached to the bug tests for the 'obvious' behavior, where the URL is re-based whether or not href attributes are set. It is this test case to which the results in #4 refer. The tests in Bug 47665 were added later, after Adam suggested we keep the existing behavior (where the URL is not re-based if href attributes are set) and add tests to document this. 70088 2010-10-07 07:21:30 -0700 2010-10-07 07:21:30 -0700 Test case href-attribute-rebase.txt text/plain 1884 steveblock SW5kZXg6IExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxBbmNob3JFbGVtZW50L3NldC1ocmVmLWF0 dHJpYnV0ZS1yZWJhc2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9I VE1MQW5jaG9yRWxlbWVudC9zZXQtaHJlZi1hdHRyaWJ1dGUtcmViYXNlLmh0bWwJKHJldmlzaW9u IDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9zZXQtaHJlZi1h dHRyaWJ1dGUtcmViYXNlLmh0bWwJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEsMTMgQEAKKzwhRE9D VFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFREIEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+ Cis8bGluayByZWw9InN0eWxlc2hlZXQiIGhyZWY9Ii4uLy4uL2pzL3Jlc291cmNlcy9qcy10ZXN0 LXN0eWxlLmNzcyI+Cis8c2NyaXB0IHNyYz0iLi4vLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJl LmpzIj48L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorPHAgaWQ9ImRlc2NyaXB0aW9uIj48L3A+ Cis8ZGl2IGlkPSJjb25zb2xlIj48L2Rpdj4KKzxzY3JpcHQgc3JjPSJzY3JpcHQtdGVzdHMvc2V0 LWhyZWYtYXR0cmlidXRlLXJlYmFzZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4v anMvcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+ CkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9zY3JpcHQtdGVz dHMvc2V0LWhyZWYtYXR0cmlidXRlLXJlYmFzZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2RvbS9IVE1MQW5jaG9yRWxlbWVudC9zY3JpcHQtdGVzdHMvc2V0LWhyZWYtYXR0cmli dXRlLXJlYmFzZS5qcwkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2Zhc3QvZG9tL0hUTUxB bmNob3JFbGVtZW50L3NjcmlwdC10ZXN0cy9zZXQtaHJlZi1hdHRyaWJ1dGUtcmViYXNlLmpzCShy ZXZpc2lvbiAwKQpAQCAtMCwwICsxLDIyIEBACitkZXNjcmlwdGlvbignVGVzdHMgaG93IHNldHRp bmcgaHJlZiBhdHRyaWJ1dGVzIGFmZmVjdHMgc2V0dGluZyBhIG5ldyBiYXNlIGZvciB0aGUgVVJM LicpOworCit2YXIgYSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2EnKTsKK3ZhciBiYXNlID0g ZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnYmFzZScpOworZG9jdW1lbnQuaGVhZC5hcHBlbmRDaGls ZChiYXNlKTsKKworZGVidWcoIkJhc2UgY2FzZSwgcmViYXNlIFVSTCB3aXRob3V0IGF0dHJpYnV0 ZSBoYXZpbmcgYmVlbiBzZXQiKTsKK2Jhc2UuaHJlZiA9ICJodHRwOi8vb2xkX2Jhc2UvIjsKK2Eu aHJlZiA9ICJmb28/cXVlcnkiOworc2hvdWxkQmUoImEuaHJlZiIsICInaHR0cDovL29sZF9iYXNl L2Zvbz9xdWVyeSciKTsKK2Jhc2UuaHJlZiA9ICJodHRwOi8vbmV3X2Jhc2UvIjsKK3Nob3VsZEJl KCJhLmhyZWYiLCAiJ2h0dHA6Ly9uZXdfYmFzZS9mb28/cXVlcnknIik7CisKK2RlYnVnKCJSZWJh c2UgVVJMIHdoZXJlIHNlYXJjaCBhdHRyaWJ1dGUgaGFzIGJlZW4gc2V0Iik7CitiYXNlLmhyZWYg PSAiaHR0cDovL29sZF9iYXNlLyI7CithLmhyZWYgPSAiZm9vIjsKK2Euc2VhcmNoID0gInF1ZXJ5 IjsKK3Nob3VsZEJlKCJhLmhyZWYiLCAiJ2h0dHA6Ly9vbGRfYmFzZS9mb28/cXVlcnknIik7Citi YXNlLmhyZWYgPSAiaHR0cDovL25ld19iYXNlLyI7CitzaG91bGRCZSgiYS5ocmVmIiwgIidodHRw Oi8vbmV3X2Jhc2UvZm9vP3F1ZXJ5JyIpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1 ZTsK