47337 2010-10-07 03:27:36 -0700 [Qt] Watchdog timer implementation for WTR 2010-10-07 07:44:38 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 kbalazs webkit-unassigned webkit.review.bot oldest_to_newest 290905 0 kbalazs 2010-10-07 03:27:36 -0700 We need our implementation of the watchdog timer that looks out for timeout. 290992 1 70087 kbalazs 2010-10-07 07:20:43 -0700 Created attachment 70087 proposed patch 290994 2 webkit.review.bot 2010-10-07 07:22:19 -0700 Attachment 70087 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKitTools/WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:27: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 291006 3 70087 kbalazs 2010-10-07 07:44:29 -0700 Comment on attachment 70087 proposed patch Clearing flags on attachment: 70087 Committed r69307: <http://trac.webkit.org/changeset/69307> 291007 4 kbalazs 2010-10-07 07:44:38 -0700 All reviewed patches have been landed. Closing bug. 70087 2010-10-07 07:20:43 -0700 2010-10-07 07:44:29 -0700 proposed patch 0001-Qt-Watchdog-timer-implementation-for-WTR.patch text/plain 5636 kbalazs RnJvbSBjYzQ5ZWVlOWIyMDc0NGYwZTE4YWZkMTNiZWE3OGJkNWM1ZjgyNTViIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBCYWxhenMgS2VsZW1lbiA8a2JhbGF6c0B3ZWJraXQub3JnPgpE YXRlOiBUaHUsIDcgT2N0IDIwMTAgMTI6NTE6MjkgKzAyMDAKU3ViamVjdDogW1BBVENIXSBbUXRd IFdhdGNoZG9nIHRpbWVyIGltcGxlbWVudGF0aW9uIGZvciBXVFIKCi0tLQogV2ViS2l0VG9vbHMv Q2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE4ICsrKysrCiAuLi4v SW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaCAgICAgICAgICB8ICAgMTcgKysr LS0KIC4uLi9JbmplY3RlZEJ1bmRsZS9xdC9MYXlvdXRUZXN0Q29udHJvbGxlclF0LmNwcCAgIHwg ICA3NCArKysrKysrKysrKysrKysrKysrKwogMyBmaWxlcyBjaGFuZ2VkLCAxMDMgaW5zZXJ0aW9u cygrKSwgNiBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBXZWJLaXRUb29scy9XZWJL aXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3Bw CgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nIGIvV2ViS2l0VG9vbHMvQ2hhbmdl TG9nCmluZGV4IGViY2RmNDguLmE0ZTAzZWEgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL0NoYW5n ZUxvZworKysgYi9XZWJLaXRUb29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAxMC0x MC0wNyAgQmFsYXpzIEtlbGVtZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBXYXRjaGRvZyB0aW1lciBp bXBsZW1lbnRhdGlvbiBmb3IgV1RSCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00NzMzNworCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9JbmplY3Rl ZEJ1bmRsZS9MYXlvdXRUZXN0Q29udHJvbGxlci5oOiBGYWN0b3Igb3V0CisgICAgICAgIHRoZSBk ZWZpbml0aW9uIG9mIHRoZSB0aW1lciB0eXBlIHRvIGEgdHlwZWRlZi4KKyAgICAgICAgKiBXZWJL aXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3Bw OiBBZGRlZC4KKyAgICAgICAgVGltZXIgaW1wbGVtZW50YXRpb24gd2l0aCBRVGltZXIgYW5kIGEg aGVscGVyIFFPYmplY3QgY2xhc3MuCisgICAgICAgIChXVFI6OldhdGNoZG9nVGltZXJIZWxwZXI6 Omluc3RhbmNlKToKKyAgICAgICAgKFdUUjo6V2F0Y2hkb2dUaW1lckhlbHBlcjo6dGltZXJGaXJl ZCk6CisgICAgICAgIChXVFI6OldhdGNoZG9nVGltZXJIZWxwZXI6OldhdGNoZG9nVGltZXJIZWxw ZXIpOgorICAgICAgICAoV1RSOjpMYXlvdXRUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFs aXplKToKKyAgICAgICAgKFdUUjo6TGF5b3V0VGVzdENvbnRyb2xsZXI6OmludmFsaWRhdGVXYWl0 VG9EdW1wV2F0Y2hkb2dUaW1lcik6CisgICAgICAgIChXVFI6OkxheW91dFRlc3RDb250cm9sbGVy Ojppbml0aWFsaXplV2FpdFRvRHVtcFdhdGNoZG9nVGltZXJJZk5lZWRlZCk6CisKIDIwMTAtMTAt MDYgIENocmlzIEd1aWxsb3J5ICA8Y2hyaXMuZ3VpbGxvcnlAZ29vZ2xlLmNvbT4KIAogICAgICAg ICBSZXZpZXdlZCBieSBDaHJpcyBGbGVpemFjaC4KZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRyb2xsZXIuaCBiL1dl YktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvTGF5b3V0VGVzdENvbnRy b2xsZXIuaAppbmRleCA2YWUyMGQ4Li5jODkyYmEwIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9X ZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0xheW91dFRlc3RDb250cm9sbGVyLmgKKysr IGIvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9MYXlvdXRUZXN0 Q29udHJvbGxlci5oCkBAIC0yOCw5ICsyOCwxOCBAQAogCiAjaW5jbHVkZSAiSlNXcmFwcGFibGUu aCIKICNpbmNsdWRlIDxKYXZhU2NyaXB0Q29yZS9KU1JldGFpblB0ci5oPgorI2luY2x1ZGUgPHN0 cmluZz4KICNpbmNsdWRlIDx3dGYvUGFzc1JlZlB0ci5oPgorCisjaWYgUExBVEZPUk0oTUFDKQog I2luY2x1ZGUgPHd0Zi9SZXRhaW5QdHIuaD4KLSNpbmNsdWRlIDxzdHJpbmc+Cit0eXBlZGVmIFJl dGFpblB0cjxDRlJ1bkxvb3BUaW1lclJlZj4gUGxhdGZvcm1UaW1lclJlZjsKKyNlbGlmIFBMQVRG T1JNKFdJTikKK3R5cGVkZWYgVUlOVF9QVFIgUGxhdGZvcm1UaW1lclJlZjsKKyNlbGlmIFBMQVRG T1JNKFFUKQorI2luY2x1ZGUgPFFUaW1lcj4KK3R5cGVkZWYgUVRpbWVyIFBsYXRmb3JtVGltZXJS ZWY7CisjZW5kaWYKIAogbmFtZXNwYWNlIFdUUiB7CiAKQEAgLTEyNCwxMSArMTMzLDcgQEAgcHJp dmF0ZToKICAgICBib29sIG1fdGVzdFJlcGFpbnQ7CiAgICAgYm9vbCBtX3Rlc3RSZXBhaW50U3dl ZXBIb3Jpem9udGFsbHk7CiAKLSNpZiBQTEFURk9STShNQUMpCi0gICAgUmV0YWluUHRyPENGUnVu TG9vcFRpbWVyUmVmPiBtX3dhaXRUb0R1bXBXYXRjaGRvZ1RpbWVyOwotI2VsaWYgUExBVEZPUk0o V0lOKQotICAgIFVJTlRfUFRSIG1fd2FpdFRvRHVtcFdhdGNoZG9nVGltZXI7Ci0jZW5kaWYKKyAg ICBQbGF0Zm9ybVRpbWVyUmVmIG1fd2FpdFRvRHVtcFdhdGNoZG9nVGltZXI7CiB9OwogCiB9IC8v IG5hbWVzcGFjZSBXVFIKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvcXQvTGF5b3V0VGVzdENvbnRyb2xsZXJRdC5jcHAgYi9XZWJLaXRUb29s cy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL3F0L0xheW91dFRlc3RDb250cm9sbGVy UXQuY3BwCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLmI1MTUzMjYKLS0tIC9k ZXYvbnVsbAorKysgYi9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxl L3F0L0xheW91dFRlc3RDb250cm9sbGVyUXQuY3BwCkBAIC0wLDAgKzEsNzQgQEAKKy8qCisgKiBD b3B5cmlnaHQgKEMpIDIwMTAgQXBwbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICogQ29w eXJpZ2h0IChDKSAyMDEwIFVuaXZlcnNpdHkgb2YgU3plZ2VkLiBBbGwgcmlnaHRzIHJlc2VydmVk LgorICoKKyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9y bXMsIHdpdGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3Zp ZGVkIHRoYXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zCisgKiBhcmUgbWV0OgorICogMS4gUmVk aXN0cmlidXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmln aHQKKyAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dp bmcgZGlzY2xhaW1lci4KKyAqIDIuIFJlZGlzdHJpYnV0aW9ucyBpbiBiaW5hcnkgZm9ybSBtdXN0 IHJlcHJvZHVjZSB0aGUgYWJvdmUgY29weXJpZ2h0CisgKiAgICBub3RpY2UsIHRoaXMgbGlzdCBv ZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIgaW4gdGhlCisgKiAgICBk b2N1bWVudGF0aW9uIGFuZC9vciBvdGhlciBtYXRlcmlhbHMgcHJvdmlkZWQgd2l0aCB0aGUgZGlz dHJpYnV0aW9uLgorICoKKyAqIFRISVMgU09GVFdBUkUgSVMgUFJPVklERUQgQlkgQVBQTEUgSU5D LiBBTkQgSVRTIENPTlRSSUJVVE9SUyBgYEFTIElTJycKKyAqIEFORCBBTlkgRVhQUkVTUyBPUiBJ TVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLAorICogVEhF IElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SIEEg UEFSVElDVUxBUgorICogUFVSUE9TRSBBUkUgRElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwg QVBQTEUgSU5DLiBPUiBJVFMgQ09OVFJJQlVUT1JTCisgKiBCRSBMSUFCTEUgRk9SIEFOWSBESVJF Q1QsIElORElSRUNULCBJTkNJREVOVEFMLCBTUEVDSUFMLCBFWEVNUExBUlksIE9SCisgKiBDT05T RVFVRU5USUFMIERBTUFHRVMgKElOQ0xVRElORywgQlVUIE5PVCBMSU1JVEVEIFRPLCBQUk9DVVJF TUVOVCBPRgorICogU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9TUyBPRiBVU0UsIERB VEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTCisgKiBJTlRFUlJVUFRJT04pIEhPV0VWRVIgQ0FV U0VEIEFORCBPTiBBTlkgVEhFT1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTgorICogQ09OVFJB Q1QsIFNUUklDVCBMSUFCSUxJVFksIE9SIFRPUlQgKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9U SEVSV0lTRSkKKyAqIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBPRiBUSElTIFNP RlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YKKyAqIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERB TUFHRS4KKyAqLworCisjaW5jbHVkZSAiTGF5b3V0VGVzdENvbnRyb2xsZXIuaCIKKworI2luY2x1 ZGUgIkluamVjdGVkQnVuZGxlLmgiCisjaW5jbHVkZSA8UU9iamVjdD4KKworbmFtZXNwYWNlIFdU UiB7CisKK2NsYXNzIFdhdGNoZG9nVGltZXJIZWxwZXIgOiBwdWJsaWMgUU9iamVjdCB7CisgICAg UV9PQkpFQ1QKKworcHVibGljOgorICAgIHN0YXRpYyBXYXRjaGRvZ1RpbWVySGVscGVyKiBpbnN0 YW5jZSgpCisgICAgeworICAgICAgICBzdGF0aWMgV2F0Y2hkb2dUaW1lckhlbHBlciogdGhlSW5z dGFuY2UgPSBuZXcgV2F0Y2hkb2dUaW1lckhlbHBlcjsKKyAgICAgICAgcmV0dXJuIHRoZUluc3Rh bmNlOworICAgIH0KKworcHVibGljIHNsb3RzOgorICAgIHZvaWQgdGltZXJGaXJlZCgpCisgICAg eworICAgICAgICBJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkubGF5b3V0VGVzdENvbnRyb2xsZXIo KS0+d2FpdFRvRHVtcFdhdGNoZG9nVGltZXJGaXJlZCgpOworICAgIH0KKworcHJpdmF0ZToKKyAg ICBXYXRjaGRvZ1RpbWVySGVscGVyKCkge30KK307CisKK3ZvaWQgTGF5b3V0VGVzdENvbnRyb2xs ZXI6OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCit7CisgICAgUU9iamVjdDo6Y29ubmVjdCgmbV93YWl0 VG9EdW1wV2F0Y2hkb2dUaW1lciwgU0lHTkFMKHRpbWVvdXQoKSksIFdhdGNoZG9nVGltZXJIZWxw ZXI6Omluc3RhbmNlKCksIFNMT1QodGltZXJGaXJlZCgpKSk7Cit9CisKK3ZvaWQgTGF5b3V0VGVz dENvbnRyb2xsZXI6OmludmFsaWRhdGVXYWl0VG9EdW1wV2F0Y2hkb2dUaW1lcigpCit7CisgICAg bV93YWl0VG9EdW1wV2F0Y2hkb2dUaW1lci5zdG9wKCk7Cit9CisKK3ZvaWQgTGF5b3V0VGVzdENv bnRyb2xsZXI6OmluaXRpYWxpemVXYWl0VG9EdW1wV2F0Y2hkb2dUaW1lcklmTmVlZGVkKCkKK3sK KyAgICBpZiAobV93YWl0VG9EdW1wV2F0Y2hkb2dUaW1lci5pc0FjdGl2ZSgpKQorICAgICAgICBy ZXR1cm47CisKKyAgICBtX3dhaXRUb0R1bXBXYXRjaGRvZ1RpbWVyLnN0YXJ0KHdhaXRUb0R1bXBX YXRjaGRvZ1RpbWVySW50ZXJ2YWwgKiAxMDAwKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV1RSCisK KyNpbmNsdWRlICJMYXlvdXRUZXN0Q29udHJvbGxlclF0Lm1vYyIKLS0gCjEuNi41Cgo=