47335 2010-10-07 02:47:40 -0700 Move user stylesheet test into platform independent directory 2010-12-13 11:19:57 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 paroga paroga abarth commit-queue ddkilzer eric mitz ossy pfeldman webkit.review.bot oldest_to_newest 290892 0 paroga 2010-10-07 02:47:40 -0700 see patch 290895 1 70062 paroga 2010-10-07 02:53:54 -0700 Created attachment 70062 Patch 320962 2 70062 eric 2010-12-13 00:38:39 -0800 Comment on attachment 70062 Patch LGTM! 320992 3 70062 webkit.review.bot 2010-12-13 02:00:46 -0800 Comment on attachment 70062 Patch Clearing flags on attachment: 70062 Committed r73893: <http://trac.webkit.org/changeset/73893> 320993 4 webkit.review.bot 2010-12-13 02:00:51 -0800 All reviewed patches have been landed. Closing bug. 321023 5 webkit.review.bot 2010-12-13 03:42:52 -0800 http://trac.webkit.org/changeset/73893 might have broken Qt Linux Release The following tests are not passing: fast/loader/user-stylesheet-fast-path.html 321029 6 ossy 2010-12-13 03:53:20 -0800 (In reply to comment #5) > http://trac.webkit.org/changeset/73893 might have broken Qt Linux Release > The following tests are not passing: > fast/loader/user-stylesheet-fast-path.html New bug filed on it: https://bugs.webkit.org/show_bug.cgi?id=50911 321258 7 eric 2010-12-13 11:11:26 -0800 pfeldman believes this broken on Chromium: http://code.google.com/p/chromium/issues/detail?id=66686 At least I think. i can't tell from that bug. 321266 8 eric 2010-12-13 11:18:36 -0800 Given the number of platforms this appears to fail on, we may wish to roll this out. Patrick? 321268 9 paroga 2010-12-13 11:19:57 -0800 (In reply to comment #8) > Given the number of platforms this appears to fail on, we may wish to roll this out. Patrick? I think we should add it to the different skip lists istead of rolling out. 70062 2010-10-07 02:53:54 -0700 2010-12-13 02:00:46 -0800 Patch bug-47335.patch text/plain 6912 paroga SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDY5MjgyKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMTAtMDcgIFBhdHJpY2sgR2Fuc3RlcmVy ICA8cGFyb2dhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgTW92ZSB1c2VyIHN0eWxlc2hlZXQgdGVzdCBpbnRvIHBsYXRmb3JtIGlu ZGVwZW5kZW50IGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDczMzUKKworICAgICAgICBUaGVyZSBpcyBub3RoaW5nIHBsYXRmb3JtIHNw ZWNpZmljIGluIHRoZSB0ZXN0LCBzbyBtb3ZlIGl0IG91dCBvZiB0aGUgbWFjIGRpcmVjdG9yeS4K KworICAgICAgICAqIGZhc3QvbG9hZGVyL3VzZXItc3R5bGVzaGVldC1mYXN0LXBhdGgtZXhwZWN0 ZWQudHh0OiBDb3BpZWQgZnJvbSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9sb2FkZXIv dXNlci1zdHlsZXNoZWV0LWZhc3QtcGF0aC1leHBlY3RlZC50eHQuCisgICAgICAgICogZmFzdC9s b2FkZXIvdXNlci1zdHlsZXNoZWV0LWZhc3QtcGF0aC5odG1sOiBDb3BpZWQgZnJvbSBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9sb2FkZXIvdXNlci1zdHlsZXNoZWV0LWZhc3QtcGF0aC5o dG1sLgorICAgICAgICAqIHBsYXRmb3JtL21hYy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQt ZmFzdC1wYXRoLWV4cGVjdGVkLnR4dDogUmVtb3ZlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMv ZmFzdC9sb2FkZXIvdXNlci1zdHlsZXNoZWV0LWZhc3QtcGF0aC5odG1sOiBSZW1vdmVkLgorCiAy MDEwLTEwLTA2ICBBbmRyZWFzIEtsaW5nICA8YW5kcmVhcy5rbGluZ0Bub2tpYS5jb20+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcy9SZW5kZXJQYXRoL1JlbmRlclNWR1BhdGgvCkluZGV4OiBMYXlv dXRUZXN0cy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQtZmFzdC1wYXRoLWV4cGVjdGVkLnR4 dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQt ZmFzdC1wYXRoLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNjkyODIpCShmcm9tIExheW91dFRlc3Rz L3BsYXRmb3JtL21hYy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQtZmFzdC1wYXRoLWV4cGVj dGVkLnR4dDo2OTI4MikKKysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3VzZXItc3R5bGVzaGVl dC1mYXN0LXBhdGgtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMTAgQEAK K1RoaXMgdGVzdHMgdGhhdCB3aGVuIHRoZSB1c2VyIHN0eWxlIHNoZWV0IGxvY2F0aW9uIGlzIHNl dCB0byBhIGRhdGE6IFVSTCB3aXRoIGJhc2U2NC1lbmNvZGVkIFVURi04IGRhdGEsIHRoZSBzdHls ZSBzaGVldCBpcyBwcm9jZXNzZWQgc3luY2hyb25vdXNseSwgaW5zdGVhZCBvZiBpbnZva2luZyB0 aGUgYXN5bmNocm9ub3VzIGxvYWRlci4KKworUEFTUyAxMDBweAorUEFTUyAxMTBweAorUEFTUyAx MjBweAorUEFTUyAxMzBweAorUEFTUyAxNDBweAorUEFTUyAxNTBweAorUEFTUyAxNjBweAorCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQtZmFzdC1wYXRoLmh0 bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9sb2FkZXIvdXNlci1zdHlsZXNoZWV0 LWZhc3QtcGF0aC5odG1sCShyZXZpc2lvbiA2OTI4MikJKGZyb20gTGF5b3V0VGVzdHMvcGxhdGZv cm0vbWFjL2Zhc3QvbG9hZGVyL3VzZXItc3R5bGVzaGVldC1mYXN0LXBhdGguaHRtbDo2OTI4MikK KysrIExheW91dFRlc3RzL2Zhc3QvbG9hZGVyL3VzZXItc3R5bGVzaGVldC1mYXN0LXBhdGguaHRt bAkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDMzIEBACis8cD4KKyAgICBUaGlzIHRlc3RzIHRo YXQgd2hlbiB0aGUgdXNlciBzdHlsZSBzaGVldCBsb2NhdGlvbiBpcyBzZXQgdG8gYSBkYXRhOgor ICAgIFVSTCB3aXRoIGJhc2U2NC1lbmNvZGVkIFVURi04IGRhdGEsIHRoZSBzdHlsZSBzaGVldCBp cyBwcm9jZXNzZWQKKyAgICBzeW5jaHJvbm91c2x5LCBpbnN0ZWFkIG9mIGludm9raW5nIHRoZSBh c3luY2hyb25vdXMgbG9hZGVyLgorPC9wPgorPHNjcmlwdD4KKyAgICB2YXIgdGVzdE9iamVjdHMg PSBbCisgICAgICAgIHtyZXN1bHQ6dHJ1ZSwgIHNpemU6IjEwMHB4IiwgdXJsOiJkYXRhOnRleHQv Y3NzO2NoYXJzZXQ9dXRmLTg7YmFzZTY0LFltOWtlU0I3Wm05dWRDMXphWHBsT2lBeE1EQndlSDA9 In0sCisgICAgICAgIHtyZXN1bHQ6dHJ1ZSwgIHNpemU6IjExMHB4IiwgdXJsOmVuY29kZVVSSSgi ZGF0YTp0ZXh0L2NzcztjaGFyc2V0PXV0Zi04O2Jhc2U2NCwgICAgICAgICAgICAgICAgICAgICAg IFltOWtlU0I3Wm05dWRDMXphWHBsT2lBeE1UQndlSDA9ICAgICAgICAgICAgICAgICAgIil9LAor ICAgICAgICB7cmVzdWx0OnRydWUsICBzaXplOiIxMjBweCIsIHVybDplbmNvZGVVUkkoImRhdGE6 dGV4dC9jc3M7Y2hhcnNldD11dGYtODtiYXNlNjQsXG4gXHIgXHQgWW05ayBcdCBlU0I3IFxyIFpt OXVkIFxuIFxuIEMxemFYcCBcciBsT2lBeE0gXHQgakJ3ZUgwPSBcdCBcciBcbiIpfSwKKyAgICAg ICAge3Jlc3VsdDp0cnVlLCAgc2l6ZToiMTMwcHgiLCB1cmw6ZW5jb2RlVVJJKCJkYXRhOnRleHQv Y3NzO2NoYXJzZXQ9dXRmLTg7YmFzZTY0LFx1MDA1OSBcdTAwNkQgXHUwMDM5IFx1MDA2QiBlU0I3 Wm05dWQgQzF6YVhwbE9pQXhNekJ3ZSBcdTAwNDggXHUwMDMwIFx1MDAzRCIpfSwKKyAgICAgICAg e3Jlc3VsdDpmYWxzZSwgc2l6ZToiMTQwcHgiLCB1cmw6ImRhdGE6dGV4dC9jc3M7Y2hhcnNldD11 dGYtODtiYXNlNjQsWW05ayQjZVNCN1ptIzl1ZChDMXphWHApbE9pQXhOREJ3ZUgwPSJ9LAorICAg ICAgICB7cmVzdWx0OmZhbHNlLCBzaXplOiIxNTBweCIsIHVybDoiZGF0YTp0ZXh0L2NzcztjaGFy c2V0PXV0Zi04O2Jhc2U2NCxZbTlrZSUwMFNCN1olMjBtOXVkQzF6XG5cdGFYcGxPI2lBeCUwM05U QnclZUgwPSJ9LAorICAgICAgICB7cmVzdWx0OmZhbHNlLCBzaXplOiIxNjBweCIsIHVybDoiJTUw JTMwJTEwJTAwJTIwJTQwIn0KKyAgICBdOworCisgICAgaWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29u dHJvbGxlcikgeworICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5kdW1wQXNUZXh0KCk7Cisg ICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldFVzZXJTdHlsZVNoZWV0RW5hYmxlZCh0cnVl KTsKKworICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8IHRlc3RPYmplY3RzLmxlbmd0aDsgaSsr KSB7CisgICAgICAgICAgICB2YXIgb2JqID0gdGVzdE9iamVjdHNbaV07CisgICAgICAgICAgICBs YXlvdXRUZXN0Q29udHJvbGxlci5zZXRVc2VyU3R5bGVTaGVldExvY2F0aW9uKG9iai51cmwpOwor CisgICAgICAgICAgICBkb2N1bWVudC5ib2R5Lm9mZnNldFRvcDsKKyAgICAgICAgICAgIHZhciBy ZXN1bHQgPSBnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50LmJvZHkpLmZvbnRTaXplID09IG9iai5z aXplOworICAgICAgICAgICAgZG9jdW1lbnQud3JpdGUoKHJlc3VsdCA9PSBvYmoucmVzdWx0ID8g IlBBU1MiIDogIkZBSUwiKSArICIgIiArIG9iai5zaXplICsgIjxicj4iKTsKKworICAgICAgICAg ICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0VXNlclN0eWxlU2hlZXRMb2NhdGlvbigiIik7Cisg ICAgICAgIH0KKyAgICB9IGVsc2UKKyAgICAgICAgZG9jdW1lbnQud3JpdGUoIlRoaXMgdGVzdCBj YW4gb25seSBiZSBydW4gaW4gRHVtcFJlbmRlclRyZWUuIik7Cis8L3NjcmlwdD4KSW5kZXg6IExh eW91dFRlc3RzL3BsYXRmb3JtL21hYy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQtZmFzdC1w YXRoLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMv ZmFzdC9sb2FkZXIvdXNlci1zdHlsZXNoZWV0LWZhc3QtcGF0aC1leHBlY3RlZC50eHQJKHJldmlz aW9uIDY5MjgyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvbG9hZGVyL3VzZXIt c3R5bGVzaGVldC1mYXN0LXBhdGgtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDEw ICswLDAgQEAKLVRoaXMgdGVzdHMgdGhhdCB3aGVuIHRoZSB1c2VyIHN0eWxlIHNoZWV0IGxvY2F0 aW9uIGlzIHNldCB0byBhIGRhdGE6IFVSTCB3aXRoIGJhc2U2NC1lbmNvZGVkIFVURi04IGRhdGEs IHRoZSBzdHlsZSBzaGVldCBpcyBwcm9jZXNzZWQgc3luY2hyb25vdXNseSwgaW5zdGVhZCBvZiBp bnZva2luZyB0aGUgYXN5bmNocm9ub3VzIGxvYWRlci4KLQotUEFTUyAxMDBweAotUEFTUyAxMTBw eAotUEFTUyAxMjBweAotUEFTUyAxMzBweAotUEFTUyAxNDBweAotUEFTUyAxNTBweAotUEFTUyAx NjBweAotCkluZGV4OiBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMvZmFzdC9sb2FkZXIvdXNlci1z dHlsZXNoZWV0LWZhc3QtcGF0aC5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRm b3JtL21hYy9mYXN0L2xvYWRlci91c2VyLXN0eWxlc2hlZXQtZmFzdC1wYXRoLmh0bWwJKHJldmlz aW9uIDY5MjgyKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Zhc3QvbG9hZGVyL3VzZXIt c3R5bGVzaGVldC1mYXN0LXBhdGguaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSwzMyArMCwwIEBA Ci08cD4KLSAgICBUaGlzIHRlc3RzIHRoYXQgd2hlbiB0aGUgdXNlciBzdHlsZSBzaGVldCBsb2Nh dGlvbiBpcyBzZXQgdG8gYSBkYXRhOgotICAgIFVSTCB3aXRoIGJhc2U2NC1lbmNvZGVkIFVURi04 IGRhdGEsIHRoZSBzdHlsZSBzaGVldCBpcyBwcm9jZXNzZWQKLSAgICBzeW5jaHJvbm91c2x5LCBp bnN0ZWFkIG9mIGludm9raW5nIHRoZSBhc3luY2hyb25vdXMgbG9hZGVyLgotPC9wPgotPHNjcmlw dD4KLSAgICB2YXIgdGVzdE9iamVjdHMgPSBbCi0gICAgICAgIHtyZXN1bHQ6dHJ1ZSwgIHNpemU6 IjEwMHB4IiwgdXJsOiJkYXRhOnRleHQvY3NzO2NoYXJzZXQ9dXRmLTg7YmFzZTY0LFltOWtlU0I3 Wm05dWRDMXphWHBsT2lBeE1EQndlSDA9In0sCi0gICAgICAgIHtyZXN1bHQ6dHJ1ZSwgIHNpemU6 IjExMHB4IiwgdXJsOmVuY29kZVVSSSgiZGF0YTp0ZXh0L2NzcztjaGFyc2V0PXV0Zi04O2Jhc2U2 NCwgICAgICAgICAgICAgICAgICAgICAgIFltOWtlU0I3Wm05dWRDMXphWHBsT2lBeE1UQndlSDA9 ICAgICAgICAgICAgICAgICAgIil9LAotICAgICAgICB7cmVzdWx0OnRydWUsICBzaXplOiIxMjBw eCIsIHVybDplbmNvZGVVUkkoImRhdGE6dGV4dC9jc3M7Y2hhcnNldD11dGYtODtiYXNlNjQsXG4g XHIgXHQgWW05ayBcdCBlU0I3IFxyIFptOXVkIFxuIFxuIEMxemFYcCBcciBsT2lBeE0gXHQgakJ3 ZUgwPSBcdCBcciBcbiIpfSwKLSAgICAgICAge3Jlc3VsdDp0cnVlLCAgc2l6ZToiMTMwcHgiLCB1 cmw6ZW5jb2RlVVJJKCJkYXRhOnRleHQvY3NzO2NoYXJzZXQ9dXRmLTg7YmFzZTY0LFx1MDA1OSBc dTAwNkQgXHUwMDM5IFx1MDA2QiBlU0I3Wm05dWQgQzF6YVhwbE9pQXhNekJ3ZSBcdTAwNDggXHUw MDMwIFx1MDAzRCIpfSwKLSAgICAgICAge3Jlc3VsdDpmYWxzZSwgc2l6ZToiMTQwcHgiLCB1cmw6 ImRhdGE6dGV4dC9jc3M7Y2hhcnNldD11dGYtODtiYXNlNjQsWW05ayQjZVNCN1ptIzl1ZChDMXph WHApbE9pQXhOREJ3ZUgwPSJ9LAotICAgICAgICB7cmVzdWx0OmZhbHNlLCBzaXplOiIxNTBweCIs IHVybDoiZGF0YTp0ZXh0L2NzcztjaGFyc2V0PXV0Zi04O2Jhc2U2NCxZbTlrZSUwMFNCN1olMjBt OXVkQzF6XG5cdGFYcGxPI2lBeCUwM05UQnclZUgwPSJ9LAotICAgICAgICB7cmVzdWx0OmZhbHNl LCBzaXplOiIxNjBweCIsIHVybDoiJTUwJTMwJTEwJTAwJTIwJTQwIn0KLSAgICBdOwotCi0gICAg aWYgKHdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikgewotICAgICAgICBsYXlvdXRUZXN0Q29u dHJvbGxlci5kdW1wQXNUZXh0KCk7Ci0gICAgICAgIGxheW91dFRlc3RDb250cm9sbGVyLnNldFVz ZXJTdHlsZVNoZWV0RW5hYmxlZCh0cnVlKTsKLQotICAgICAgICBmb3IgKHZhciBpID0gMDsgaSA8 IHRlc3RPYmplY3RzLmxlbmd0aDsgaSsrKSB7Ci0gICAgICAgICAgICB2YXIgb2JqID0gdGVzdE9i amVjdHNbaV07Ci0gICAgICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci5zZXRVc2VyU3R5bGVT aGVldExvY2F0aW9uKG9iai51cmwpOwotCi0gICAgICAgICAgICBkb2N1bWVudC5ib2R5Lm9mZnNl dFRvcDsKLSAgICAgICAgICAgIHZhciByZXN1bHQgPSBnZXRDb21wdXRlZFN0eWxlKGRvY3VtZW50 LmJvZHkpLmZvbnRTaXplID09IG9iai5zaXplOwotICAgICAgICAgICAgZG9jdW1lbnQud3JpdGUo KHJlc3VsdCA9PSBvYmoucmVzdWx0ID8gIlBBU1MiIDogIkZBSUwiKSArICIgIiArIG9iai5zaXpl ICsgIjxicj4iKTsKLQotICAgICAgICAgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuc2V0VXNlclN0 eWxlU2hlZXRMb2NhdGlvbigiIik7Ci0gICAgICAgIH0KLSAgICB9IGVsc2UKLSAgICAgICAgZG9j dW1lbnQud3JpdGUoIlRoaXMgdGVzdCBjYW4gb25seSBiZSBydW4gaW4gRHVtcFJlbmRlclRyZWUu Iik7Ci08L3NjcmlwdD4K