47332 2010-10-07 02:22:17 -0700 [GTK] Use gtk_widget_draw() instead of gtk_widget_get_snapshot() in PixelDumpSupportGtk when building with gtk3 2010-10-07 04:58:35 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 290879 0 cgarcia 2010-10-07 02:22:17 -0700 gtk_widget_get_snapshot() has been removed in gtk3, the new method gtk_widget_draw() should be used instead. 290881 1 70058 cgarcia 2010-10-07 02:29:27 -0700 Created attachment 70058 Use gtk_widget_draw() instead of gtk_widget_get_snapshot() 290885 2 70058 xan.lopez 2010-10-07 02:34:30 -0700 Comment on attachment 70058 Use gtk_widget_draw() instead of gtk_widget_get_snapshot() Looks good. 290924 3 70058 commit-queue 2010-10-07 04:58:30 -0700 Comment on attachment 70058 Use gtk_widget_draw() instead of gtk_widget_get_snapshot() Clearing flags on attachment: 70058 Committed r69294: <http://trac.webkit.org/changeset/69294> 290925 4 commit-queue 2010-10-07 04:58:35 -0700 All reviewed patches have been landed. Closing bug. 70058 2010-10-07 02:29:27 -0700 2010-10-07 04:58:30 -0700 Use gtk_widget_draw() instead of gtk_widget_get_snapshot() pixel-dump-draw.diff text/plain 1908 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA0NmNjNzg5Li5mNDJlMTAyIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMTAt MDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtHVEtdIFVzZSBndGtfd2lk Z2V0X2RyYXcoKSBpbnN0ZWFkIG9mIGd0a193aWRnZXRfZ2V0X3NuYXBzaG90KCkgaW4gUGl4ZWxE dW1wU3VwcG9ydEd0ayB3aGVuIGJ1aWxkaW5nIHdpdGggZ3RrMworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDczMzIKKworICAgICAgICAqIER1bXBSZW5k ZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNwcDoKKyAgICAgICAgKGNyZWF0ZUJpdG1h cENvbnRleHRGcm9tV2ViVmlldyk6CisKIDIwMTAtMDktMzAgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdp dCBhL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNw cCBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2d0ay9QaXhlbER1bXBTdXBwb3J0R3RrLmNw cAppbmRleCBmMGY0NjFjLi40MDczNDAzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9EdW1wUmVu ZGVyVHJlZS9ndGsvUGl4ZWxEdW1wU3VwcG9ydEd0ay5jcHAKKysrIGIvV2ViS2l0VG9vbHMvRHVt cFJlbmRlclRyZWUvZ3RrL1BpeGVsRHVtcFN1cHBvcnRHdGsuY3BwCkBAIC0zNiwxNSArMzYsMjQg QEAKIFBhc3NSZWZQdHI8Qml0bWFwQ29udGV4dD4gY3JlYXRlQml0bWFwQ29udGV4dEZyb21XZWJW aWV3KGJvb2wsIGJvb2wsIGJvb2wsIGJvb2wpCiB7CiAgICAgV2ViS2l0V2ViVmlldyogdmlldyA9 IHdlYmtpdF93ZWJfZnJhbWVfZ2V0X3dlYl92aWV3KG1haW5GcmFtZSk7Ci0gICAgR2RrUGl4bWFw KiBwaXhtYXAgPSBndGtfd2lkZ2V0X2dldF9zbmFwc2hvdChHVEtfV0lER0VUKHZpZXcpLCAwKTsK ICAgICBnaW50IHdpZHRoLCBoZWlnaHQ7CisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKKyAgICBH ZGtQaXhtYXAqIHBpeG1hcCA9IGd0a193aWRnZXRfZ2V0X3NuYXBzaG90KEdUS19XSURHRVQodmll dyksIDApOwogICAgIGdka19kcmF3YWJsZV9nZXRfc2l6ZShHREtfRFJBV0FCTEUocGl4bWFwKSwg JndpZHRoLCAmaGVpZ2h0KTsKKyNlbHNlCisgICAgd2lkdGggPSBndGtfd2lkZ2V0X2dldF9hbGxv Y2F0ZWRfd2lkdGgoR1RLX1dJREdFVCh2aWV3KSk7CisgICAgaGVpZ2h0ID0gZ3RrX3dpZGdldF9n ZXRfYWxsb2NhdGVkX2hlaWdodChHVEtfV0lER0VUKHZpZXcpKTsKKyNlbmRpZgogCiAgICAgY2Fp cm9fc3VyZmFjZV90KiBpbWFnZVN1cmZhY2UgPSBjYWlyb19pbWFnZV9zdXJmYWNlX2NyZWF0ZShD QUlST19GT1JNQVRfQVJHQjMyLCB3aWR0aCwgaGVpZ2h0KTsKICAgICBjYWlyb190KiBjb250ZXh0 ID0gY2Fpcm9fY3JlYXRlKGltYWdlU3VyZmFjZSk7CisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIK ICAgICBnZGtfY2Fpcm9fc2V0X3NvdXJjZV9waXhtYXAoY29udGV4dCwgcGl4bWFwLCAwLCAwKTsK ICAgICBjYWlyb19wYWludChjb250ZXh0KTsKICAgICBnX29iamVjdF91bnJlZihwaXhtYXApOwor I2Vsc2UKKyAgICBndGtfd2lkZ2V0X2RyYXcoR1RLX1dJREdFVCh2aWV3KSwgY29udGV4dCk7Cisj ZW5kaWYKIAogICAgIHJldHVybiBCaXRtYXBDb250ZXh0OjpjcmVhdGVCeUFkb3B0aW5nQml0bWFw QW5kQ29udGV4dCgwLCBjb250ZXh0KTsKIH0K