47329 2010-10-07 02:08:42 -0700 Chromium multi-dll build broken due to WebResourceRawHeaders methods lacking WEBKIT_API decl spec 2010-10-07 05:59:55 -0700 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 caseq caseq pfeldman victorw yurys oldest_to_newest 290872 0 caseq 2010-10-07 02:08:42 -0700 WebKit/chromium/public/WebResourceRawHeaders.h misses WEBKIT_API on several methods, which results in methods not being exported from the DLL. This breaks chromium multi-dll build. 290876 1 70055 caseq 2010-10-07 02:16:12 -0700 Created attachment 70055 patch 290932 2 caseq 2010-10-07 05:26:55 -0700 Committed manually r69295: http://trac.webkit.org/changeset/69295 70055 2010-10-07 02:16:12 -0700 2010-10-07 04:38:45 -0700 patch webkitapi.patch text/plain 2998 caseq ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDcwMWE4ZmUuLmYxZGZkZjcgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE5IEBACisyMDEwLTEwLTA3ICBBbmRyZXkgS29zeWFrb3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hyb21p dW0gbXVsdGktZGxsIGJ1aWxkIGJyb2tlbiBkdWUgdG8gV2ViUmVzb3VyY2VSYXdIZWFkZXJzIG1l dGhvZHMgbGFja2luZyBXRUJLSVRfQVBJIGRlY2wgc3BlYworICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDczMjkKKworICAgICAgICAqIHB1YmxpYy9XZWJS ZXNvdXJjZVJhd0hlYWRlcnMuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VSYXdIZWFk ZXJzOjpXZWJSZXNvdXJjZVJhd0hlYWRlcnMpOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJj ZVJhd0hlYWRlcnM6On5XZWJSZXNvdXJjZVJhd0hlYWRlcnMpOgorICAgICAgICAoV2ViS2l0OjpX ZWJSZXNvdXJjZVJhd0hlYWRlcnM6Om9wZXJhdG9yID0pOgorICAgICAgICAqIHNyYy9XZWJSZXNv dXJjZVJhd0hlYWRlcnMuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZVJhd0hlYWRl cnM6OmluaXRpYWxpemUpOgorICAgICAgICAoV2ViS2l0OjpXZWJSZXNvdXJjZVJhd0hlYWRlcnM6 OnJlc2V0KToKKyAgICAgICAgKFdlYktpdDo6V2ViUmVzb3VyY2VSYXdIZWFkZXJzOjphc3NpZ24p OgorCiAyMDEwLTEwLTA2ICBDaHJpcyBHdWlsbG9yeSAgPGNocmlzLmd1aWxsb3J5QGdvb2dsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQ2hyaXMgRmxlaXphY2guCmRpZmYgLS1naXQgYS9X ZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlJlc291cmNlUmF3SGVhZGVycy5oIGIvV2ViS2l0L2No cm9taXVtL3B1YmxpYy9XZWJSZXNvdXJjZVJhd0hlYWRlcnMuaAppbmRleCA5MGNjODE1Li5iOTFl NjhiIDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYlJlc291cmNlUmF3SGVh ZGVycy5oCisrKyBiL1dlYktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViUmVzb3VyY2VSYXdIZWFkZXJz LmgKQEAgLTQ1LDExICs0NSwyMCBAQCBjbGFzcyBXZWJTdHJpbmc7CiAKIGNsYXNzIFdlYlJlc291 cmNlUmF3SGVhZGVycyB7CiBwdWJsaWM6Ci0gICAgV2ViUmVzb3VyY2VSYXdIZWFkZXJzKCk7Ci0g ICAgfldlYlJlc291cmNlUmF3SGVhZGVycygpOworICAgIFdlYlJlc291cmNlUmF3SGVhZGVycygp IHsgaW5pdGlhbGl6ZSgpOyB9CisgICAgfldlYlJlc291cmNlUmF3SGVhZGVycygpIHsgcmVzZXQo KTsgfQorICAgIFdlYlJlc291cmNlUmF3SGVhZGVycyhjb25zdCBXZWJSZXNvdXJjZVJhd0hlYWRl cnMmIHIpIHsgYXNzaWduKHIpOyB9CisgICAgV2ViUmVzb3VyY2VSYXdIZWFkZXJzJiBvcGVyYXRv ciA9KGNvbnN0IFdlYlJlc291cmNlUmF3SGVhZGVycyYgcikKKyAgICB7IAorICAgICAgICBhc3Np Z24ocik7CisgICAgICAgIHJldHVybiAqdGhpczsKKyAgICB9CiAKLSAgICB2b2lkIGFkZFJlcXVl c3RIZWFkZXIoY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBjb25zdCBXZWJTdHJpbmcmIHZhbHVlKTsK LSAgICB2b2lkIGFkZFJlc3BvbnNlSGVhZGVyKGNvbnN0IFdlYlN0cmluZyYgbmFtZSwgY29uc3Qg V2ViU3RyaW5nJiB2YWx1ZSk7CisgICAgV0VCS0lUX0FQSSB2b2lkIGluaXRpYWxpemUoKTsKKyAg ICBXRUJLSVRfQVBJIHZvaWQgcmVzZXQoKTsKKyAgICBXRUJLSVRfQVBJIHZvaWQgYXNzaWduKGNv bnN0IFdlYlJlc291cmNlUmF3SGVhZGVycyYgcik7CisgICAgV0VCS0lUX0FQSSB2b2lkIGFkZFJl cXVlc3RIZWFkZXIoY29uc3QgV2ViU3RyaW5nJiBuYW1lLCBjb25zdCBXZWJTdHJpbmcmIHZhbHVl KTsKKyAgICBXRUJLSVRfQVBJIHZvaWQgYWRkUmVzcG9uc2VIZWFkZXIoY29uc3QgV2ViU3RyaW5n JiBuYW1lLCBjb25zdCBXZWJTdHJpbmcmIHZhbHVlKTsKIAogI2lmIFdFQktJVF9JTVBMRU1FTlRB VElPTgogICAgIFdlYlJlc291cmNlUmF3SGVhZGVycyhXVEY6OlBhc3NSZWZQdHI8V2ViQ29yZTo6 UmVzb3VyY2VSYXdIZWFkZXJzPik7CmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dl YlJlc291cmNlUmF3SGVhZGVycy5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYlJlc291cmNl UmF3SGVhZGVycy5jcHAKaW5kZXggM2E1ZWU5NS4uYjU5N2NlMiAxMDA2NDQKLS0tIGEvV2ViS2l0 L2Nocm9taXVtL3NyYy9XZWJSZXNvdXJjZVJhd0hlYWRlcnMuY3BwCisrKyBiL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViUmVzb3VyY2VSYXdIZWFkZXJzLmNwcApAQCAtNDAsMTYgKzQwLDIxIEBAIHVz aW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2ViS2l0IHsKIAotV2ViUmVzb3Vy Y2VSYXdIZWFkZXJzOjpXZWJSZXNvdXJjZVJhd0hlYWRlcnMoKQordm9pZCBXZWJSZXNvdXJjZVJh d0hlYWRlcnM6OmluaXRpYWxpemUoKQogewogICAgIG1fcHJpdmF0ZSA9IGFkb3B0UmVmKG5ldyBS ZXNvdXJjZVJhd0hlYWRlcnMoKSk7CiB9CiAKLVdlYlJlc291cmNlUmF3SGVhZGVyczo6fldlYlJl c291cmNlUmF3SGVhZGVycygpCit2b2lkIFdlYlJlc291cmNlUmF3SGVhZGVyczo6cmVzZXQoKQog ewogICAgIG1fcHJpdmF0ZS5yZXNldCgpOwogfQogCit2b2lkIFdlYlJlc291cmNlUmF3SGVhZGVy czo6YXNzaWduKGNvbnN0IFdlYlJlc291cmNlUmF3SGVhZGVycyYgcikKK3sKKyAgICBtX3ByaXZh dGUgPSByLm1fcHJpdmF0ZTsKK30KKwogV2ViUmVzb3VyY2VSYXdIZWFkZXJzOjpXZWJSZXNvdXJj ZVJhd0hlYWRlcnMoV1RGOjpQYXNzUmVmUHRyPFdlYkNvcmU6OlJlc291cmNlUmF3SGVhZGVycz4g dmFsdWUpCiB7CiAgICAgbV9wcml2YXRlID0gdmFsdWU7Cg==