47326 2010-10-07 00:37:33 -0700 Use draw signal instead of expose_event in DragClientGtk when building with gtk3 2010-10-07 04:34:48 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 cgarcia webkit-unassigned commit-queue oldest_to_newest 290846 0 cgarcia 2010-10-07 00:37:33 -0700 expose-event has been removed in gtk3, draw should be used instead. 290848 1 70045 cgarcia 2010-10-07 00:47:07 -0700 Created attachment 70045 Patch to use draw signal instead of expose-event in DragClientGtk 290882 2 70045 xan.lopez 2010-10-07 02:31:22 -0700 Comment on attachment 70045 Patch to use draw signal instead of expose-event in DragClientGtk When checking for the clipRect you could just pass NULL since you never use the result, but in the interest of finishing this thing let's go ahead with it. 290916 3 70045 commit-queue 2010-10-07 04:34:43 -0700 Comment on attachment 70045 Patch to use draw signal instead of expose-event in DragClientGtk Clearing flags on attachment: 70045 Committed r69290: <http://trac.webkit.org/changeset/69290> 290917 4 commit-queue 2010-10-07 04:34:48 -0700 All reviewed patches have been landed. Closing bug. 70045 2010-10-07 00:47:07 -0700 2010-10-07 04:34:43 -0700 Patch to use draw signal instead of expose-event in DragClientGtk drag-client-draw.diff text/plain 4841 cgarcia ZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK aW5kZXggYzYwMmFjMS4uNzlhNzMzZCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0wNyAg Q2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gVXNlIGRyYXcgc2lnbmFs IGluc3RlYWQgb2YgZXhwb3NlX2V2ZW50IGluIERyYWdDbGllbnRHdGsgd2hlbiBidWlsZGluZyB3 aXRoIGd0azMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ3MzI2CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6ZHJhZ0ljb25XaW5kb3dEcmF3Q2FsbGJhY2spOgorICAgICAgICAoV2Vi S2l0OjpEcmFnQ2xpZW50OjpEcmFnQ2xpZW50KToKKyAgICAgICAgKFdlYktpdDo6RHJhZ0NsaWVu dDo6fkRyYWdDbGllbnQpOgorICAgICAgICAoV2ViS2l0OjpEcmFnQ2xpZW50OjpzdGFydERyYWcp OgorICAgICAgICAoV2ViS2l0OjpEcmFnQ2xpZW50OjpkcmFnSWNvbldpbmRvd0RyYXcpOgorICAg ICAgICAqIFdlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuaDoKKwogMjAxMC0wOS0yOCAgSmVu biBCcmFpdGh3YWl0ZSAgPGplbm5iQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEbWl0cnkgVGl0b3YuCmRpZmYgLS1naXQgYS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0Ry YWdDbGllbnRHdGsuY3BwIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3Rr LmNwcAppbmRleCBjYzc1ZDM2Li5jMDU1MGEyIDEwMDY0NAotLS0gYS9XZWJLaXQvZ3RrL1dlYkNv cmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBv cnQvRHJhZ0NsaWVudEd0ay5jcHAKQEAgLTQxLDIzICs0MSw0MyBAQCB1c2luZyBuYW1lc3BhY2Ug V2ViQ29yZTsKIAogbmFtZXNwYWNlIFdlYktpdCB7CiAKKyNpZmRlZiBHVEtfQVBJX1ZFUlNJT05f Mgogc3RhdGljIGdib29sZWFuIGRyYWdJY29uV2luZG93RXhwb3NlRXZlbnRDYWxsYmFjayhHdGtX aWRnZXQqIHdpZGdldCwgR2RrRXZlbnRFeHBvc2UqIGV2ZW50LCBEcmFnQ2xpZW50KiBjbGllbnQp CiB7CiAgICAgY2xpZW50LT5kcmFnSWNvbldpbmRvd0V4cG9zZUV2ZW50KHdpZGdldCwgZXZlbnQp OwogICAgIHJldHVybiBUUlVFOwogfQorI2Vsc2UKK3N0YXRpYyBnYm9vbGVhbiBkcmFnSWNvbldp bmRvd0RyYXdDYWxsYmFjayhHdGtXaWRnZXQqIHdpZGdldCwgY2Fpcm9fdCogY3IsIERyYWdDbGll bnQqIGNsaWVudCkKK3sKKyAgICBHZGtSZWN0YW5nbGUgY2xpcFJlY3Q7CisKKyAgICBpZiAoIWdk a19jYWlyb19nZXRfY2xpcF9yZWN0YW5nbGUoY3IsICZjbGlwUmVjdCkpCisgICAgICAgIHJldHVy biBGQUxTRTsKKyAgICBjbGllbnQtPmRyYWdJY29uV2luZG93RHJhdyh3aWRnZXQsIGNyKTsKKyAg ICByZXR1cm4gVFJVRTsKK30KKyNlbmRpZiAvLyBHVEtfQVBJX1ZFUlNJT05fMgogCiBEcmFnQ2xp ZW50OjpEcmFnQ2xpZW50KFdlYktpdFdlYlZpZXcqIHdlYlZpZXcpCiAgICAgOiBtX3dlYlZpZXco d2ViVmlldykKICAgICAsIG1fc3RhcnRQb3MoMCwgMCkKICAgICAsIG1fZHJhZ0ljb25XaW5kb3co Z3RrX3dpbmRvd19uZXcoR1RLX1dJTkRPV19QT1BVUCkpCiB7CisjaWZkZWYgR1RLX0FQSV9WRVJT SU9OXzIKICAgICBnX3NpZ25hbF9jb25uZWN0KG1fZHJhZ0ljb25XaW5kb3cuZ2V0KCksICJleHBv c2UtZXZlbnQiLCBHX0NBTExCQUNLKGRyYWdJY29uV2luZG93RXhwb3NlRXZlbnRDYWxsYmFjayks IHRoaXMpOworI2Vsc2UKKyAgICBnX3NpZ25hbF9jb25uZWN0KG1fZHJhZ0ljb25XaW5kb3cuZ2V0 KCksICJkcmF3IiwgR19DQUxMQkFDSyhkcmFnSWNvbldpbmRvd0RyYXdDYWxsYmFjayksIHRoaXMp OworI2VuZGlmCiB9CiAKIERyYWdDbGllbnQ6On5EcmFnQ2xpZW50KCkKIHsKKyNpZmRlZiBHVEtf QVBJX1ZFUlNJT05fMgogICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5lY3RfYnlfZnVuYyht X2RyYWdJY29uV2luZG93LmdldCgpLCAoZ3BvaW50ZXIpIGRyYWdJY29uV2luZG93RXhwb3NlRXZl bnRDYWxsYmFjaywgdGhpcyk7CisjZWxzZQorICAgIGdfc2lnbmFsX2hhbmRsZXJzX2Rpc2Nvbm5l Y3RfYnlfZnVuYyhtX2RyYWdJY29uV2luZG93LmdldCgpLCAoZ3BvaW50ZXIpIGRyYWdJY29uV2lu ZG93RHJhd0NhbGxiYWNrLCB0aGlzKTsKKyNlbmRpZgogfQogCiB2b2lkIERyYWdDbGllbnQ6Ondp bGxQZXJmb3JtRHJhZ0Rlc3RpbmF0aW9uQWN0aW9uKERyYWdEZXN0aW5hdGlvbkFjdGlvbiwgRHJh Z0RhdGEqKQpAQCAtMTA2LDkgKzEyNiwxNiBAQCB2b2lkIERyYWdDbGllbnQ6OnN0YXJ0RHJhZyhE cmFnSW1hZ2VSZWYgaW1hZ2UsIGNvbnN0IEludFBvaW50JiBkcmFnSW1hZ2VPcmlnaW4sCiAKICAg ICAgICAgaWYgKCFndGtfd2lkZ2V0X2dldF9yZWFsaXplZChtX2RyYWdJY29uV2luZG93LmdldCgp KSkgewogICAgICAgICAgICAgR2RrU2NyZWVuKiBzY3JlZW4gPSBndGtfd2lkZ2V0X2dldF9zY3Jl ZW4obV9kcmFnSWNvbldpbmRvdy5nZXQoKSk7CisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKICAg ICAgICAgICAgIEdka0NvbG9ybWFwKiByZ2JhID0gZ2RrX3NjcmVlbl9nZXRfcmdiYV9jb2xvcm1h cChzY3JlZW4pOwogICAgICAgICAgICAgaWYgKHJnYmEpCiAgICAgICAgICAgICAgICAgZ3RrX3dp ZGdldF9zZXRfY29sb3JtYXAobV9kcmFnSWNvbldpbmRvdy5nZXQoKSwgcmdiYSk7CisjZWxzZQor ICAgICAgICAgICAgR2RrVmlzdWFsKiB2aXN1YWwgPSBnZGtfc2NyZWVuX2dldF9yZ2JhX3Zpc3Vh bChzY3JlZW4pOworICAgICAgICAgICAgaWYgKCF2aXN1YWwpCisgICAgICAgICAgICAgICAgdmlz dWFsID0gZ2RrX3NjcmVlbl9nZXRfc3lzdGVtX3Zpc3VhbChzY3JlZW4pOworICAgICAgICAgICAg Z3RrX3dpZGdldF9zZXRfdmlzdWFsKG1fZHJhZ0ljb25XaW5kb3cuZ2V0KCksIHZpc3VhbCk7Cisj ZW5kaWYgLy8gR1RLX0FQSV9WRVJTSU9OXzIKICAgICAgICAgfQogCiAgICAgICAgIEludFNpemUg b3JpZ2luID0gZXZlbnRQb3MgLSBkcmFnSW1hZ2VPcmlnaW47CkBAIC0xMTcsNyArMTQ0LDcgQEAg dm9pZCBEcmFnQ2xpZW50OjpzdGFydERyYWcoRHJhZ0ltYWdlUmVmIGltYWdlLCBjb25zdCBJbnRQ b2ludCYgZHJhZ0ltYWdlT3JpZ2luLAogICAgIH0gZWxzZQogICAgICAgICBndGtfZHJhZ19zZXRf aWNvbl9kZWZhdWx0KGNvbnRleHQpOwogfQotCisjaWZkZWYgR1RLX0FQSV9WRVJTSU9OXzIKIHZv aWQgRHJhZ0NsaWVudDo6ZHJhZ0ljb25XaW5kb3dFeHBvc2VFdmVudChHdGtXaWRnZXQqIHdpZGdl dCwgR2RrRXZlbnRFeHBvc2UqIGV2ZW50KQogewogICAgIFBsYXRmb3JtUmVmUHRyPGNhaXJvX3Q+ IGNvbnRleHQgPSBhZG9wdFBsYXRmb3JtUmVmKGdka19jYWlyb19jcmVhdGUoZXZlbnQtPndpbmRv dykpOwpAQCAtMTI4LDYgKzE1NSwxNyBAQCB2b2lkIERyYWdDbGllbnQ6OmRyYWdJY29uV2luZG93 RXhwb3NlRXZlbnQoR3RrV2lkZ2V0KiB3aWRnZXQsIEdka0V2ZW50RXhwb3NlKiBldgogICAgIGNh aXJvX3NldF9zb3VyY2Vfc3VyZmFjZShjb250ZXh0LmdldCgpLCBtX2RyYWdJbWFnZS5nZXQoKSwg MCwgMCk7CiAgICAgY2Fpcm9fZmlsbChjb250ZXh0LmdldCgpKTsKIH0KKyNlbHNlCit2b2lkIERy YWdDbGllbnQ6OmRyYWdJY29uV2luZG93RHJhdyhHdGtXaWRnZXQqIHdpZGdldCwgY2Fpcm9fdCog Y3IpCit7CisgICAgY2Fpcm9fcmVjdGFuZ2xlKGNyLCAwLCAwLAorICAgICAgICAgICAgICAgICAg ICBjYWlyb19pbWFnZV9zdXJmYWNlX2dldF93aWR0aChtX2RyYWdJbWFnZS5nZXQoKSksCisgICAg ICAgICAgICAgICAgICAgIGNhaXJvX2ltYWdlX3N1cmZhY2VfZ2V0X2hlaWdodChtX2RyYWdJbWFn ZS5nZXQoKSkpOworICAgIGNhaXJvX3NldF9vcGVyYXRvcihjciwgQ0FJUk9fT1BFUkFUT1JfU09V UkNFKTsKKyAgICBjYWlyb19zZXRfc291cmNlX3N1cmZhY2UoY3IsIG1fZHJhZ0ltYWdlLmdldCgp LCAwLCAwKTsKKyAgICBjYWlyb19maWxsKGNyKTsKK30KKyNlbmRpZiAvLyBHVEtfQVBJX1ZFUlNJ T05fMgogCiBEcmFnSW1hZ2VSZWYgRHJhZ0NsaWVudDo6Y3JlYXRlRHJhZ0ltYWdlRm9yTGluayhL VVJMJiwgY29uc3QgU3RyaW5nJiwgRnJhbWUqKQogewpkaWZmIC0tZ2l0IGEvV2ViS2l0L2d0ay9X ZWJDb3JlU3VwcG9ydC9EcmFnQ2xpZW50R3RrLmggYi9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0 L0RyYWdDbGllbnRHdGsuaAppbmRleCAyYWI3ZTJkLi4zMGFjYmM0IDEwMDY0NAotLS0gYS9XZWJL aXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuaAorKysgYi9XZWJLaXQvZ3RrL1dl YkNvcmVTdXBwb3J0L0RyYWdDbGllbnRHdGsuaApAQCAtNTQsNyArNTQsMTEgQEAgbmFtZXNwYWNl IFdlYktpdCB7CiAKICAgICAgICAgdmlydHVhbCB2b2lkIGRyYWdDb250cm9sbGVyRGVzdHJveWVk KCk7CiAKKyNpZmRlZiBHVEtfQVBJX1ZFUlNJT05fMgogICAgICAgICB2b2lkIGRyYWdJY29uV2lu ZG93RXhwb3NlRXZlbnQoR3RrV2lkZ2V0KiwgR2RrRXZlbnRFeHBvc2UqKTsKKyNlbHNlCisgICAg ICAgIHZvaWQgZHJhZ0ljb25XaW5kb3dEcmF3KEd0a1dpZGdldCosIGNhaXJvX3QqKTsKKyNlbmRp ZgogCiAgICAgcHJpdmF0ZToKICAgICAgICAgV2ViS2l0V2ViVmlldyogbV93ZWJWaWV3Owo=