47315 2010-10-06 16:39:10 -0700 r69181 breaks compilation of WebCore/platform/graphics/filters/FETile.cpp if ENABLE(SVG) is false. 2010-12-20 22:52:13 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 ajwong krit eric kling zimmermann oldest_to_newest 290664 0 ajwong 2010-10-06 16:39:10 -0700 In http://trac.webkit.org/changeset/69181, a reference to SVGImageBufferTools::createImageBuffer was added in FETile::apply(). The problem is FETile::apply()'s body is not controlled by ENABLE(SVG), while the declaration of the namespace and functions in SVGImageBufferTools are. Thus, for builds that have ENABLE(SVG) disabled, this results in a compile error. 290666 1 ajwong 2010-10-06 16:40:06 -0700 Current workaround is to add #if ENABLE(SVG) around the body of FETile::apply() until a better fix can be made. This should fix compilation in the mean time, and the function doesn't work as is anyways. 290671 2 70010 ajwong 2010-10-06 16:44:58 -0700 Created attachment 70010 Disable FETime::apply()'s implement if ENABLE(SVG) is false. 290675 3 70010 kling 2010-10-06 16:47:04 -0700 Comment on attachment 70010 Disable FETime::apply()'s implement if ENABLE(SVG) is false. Yuck, but r=me :] 290833 4 zimmermann 2010-10-06 23:53:38 -0700 Ouch, it's even a layering violation that we're using SVGImageBufferTools from platform/graphics/filters! I'm going to have a look at that today. 290838 5 krit 2010-10-07 00:09:22 -0700 (In reply to comment #4) > Ouch, it's even a layering violation that we're using SVGImageBufferTools from platform/graphics/filters! > I'm going to have a look at that today. Right forgot this too! Maybe we can make some parts more generic in SVGImageBufferTools SVGImageBufferTools::createImageBuffer(tileRect, tileRect, tileImage, DeviceRGB) is not SVG specific IIRC. 321829 6 eric 2010-12-14 01:54:23 -0800 What's the status here? 324830 7 eric 2010-12-20 22:52:13 -0800 r69255. Please use webkit-patch land to land changes so that bugs are closed after landing. 70010 2010-10-06 16:44:58 -0700 2010-10-06 16:47:04 -0700 Disable FETime::apply()'s implement if ENABLE(SVG) is false. disable_fetime_apply_for_no_svg.patch text/plain 1637 ajwong ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODRmNDIyZi4uNzRmZmIyZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0wNiAgQWxiZXJ0IEouIFdv bmcgIDxhandvbmdAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIHI2OTE4MSBicmVha3MgY29tcGlsYXRpb24gb2YgV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFVGlsZS5jcHAgaWYgRU5BQkxFKFNWRykgaXMgZmFs c2UuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzMx NQorCisgICAgICAgIENvbXBpbGUgZml4LiBObyB0ZXN0cy4KKworICAgICAgICAqIHBsYXRmb3Jt L2dyYXBoaWNzL2ZpbHRlcnMvRkVUaWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZFVGlsZTo6 YXBwbHkpOgorCiAyMDEwLTEwLTA2ICBLaW51a28gWWFzdWRhICA8a2ludWtvQGNocm9taXVtLm9y Zz4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXhpbmcgc2NyZXdlZCB1cCBDaGFuZ2VMb2dzLgpk aWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9maWx0ZXJzL0ZFVGlsZS5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVUaWxlLmNwcAppbmRleCBlNDA1 ODBjLi43NDNjZTlmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRl cnMvRkVUaWxlLmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2ZpbHRlcnMvRkVU aWxlLmNwcApAQCAtNTEsNiArNTEsOCBAQCBGbG9hdFJlY3QgRkVUaWxlOjpkZXRlcm1pbmVGaWx0 ZXJQcmltaXRpdmVTdWJyZWdpb24oRmlsdGVyKiBmaWx0ZXIpCiAKIHZvaWQgRkVUaWxlOjphcHBs eShGaWx0ZXIqIGZpbHRlcikKIHsKKy8vIEZJWE1FOiBTZWUgYnVnIDQ3MzE1LiBUaGlzIGlzIGEg aGFjayB0byB3b3JrIGFyb3VuZCBhIGNvbXBpbGUgZmFpbHVyZSwgYnV0IGlzIGluY29ycmVjdCBi ZWhhdmlvciBvdGhlcndpc2UuCisjaWYgRU5BQkxFKFNWRykKICAgICBGaWx0ZXJFZmZlY3QqIGlu ID0gaW5wdXRFZmZlY3QoMCk7CiAgICAgaW4tPmFwcGx5KGZpbHRlcik7CiAgICAgaWYgKCFpbi0+ cmVzdWx0SW1hZ2UoKSkKQEAgLTg3LDYgKzg5LDcgQEAgdm9pZCBGRVRpbGU6OmFwcGx5KEZpbHRl ciogZmlsdGVyKQogICAgIHBhdHRlcm4tPnNldFBhdHRlcm5TcGFjZVRyYW5zZm9ybShwYXR0ZXJu VHJhbnNmb3JtKTsKICAgICBmaWx0ZXJDb250ZXh0LT5zZXRGaWxsUGF0dGVybihwYXR0ZXJuKTsK ICAgICBmaWx0ZXJDb250ZXh0LT5maWxsUmVjdChGbG9hdFJlY3QoRmxvYXRQb2ludCgpLCBhYnNv bHV0ZVBhaW50UmVjdCgpLnNpemUoKSkpOworI2VuZGlmCiB9CiAKIHZvaWQgRkVUaWxlOjpkdW1w KCkKQEAgLTEwNyw0ICsxMTAsMyBAQCBUZXh0U3RyZWFtJiBGRVRpbGU6OmV4dGVybmFsUmVwcmVz ZW50YXRpb24oVGV4dFN0cmVhbSYgdHMsIGludCBpbmRlbnQpIGNvbnN0CiB9IC8vIG5hbWVzcGFj ZSBXZWJDb3JlCiAKICNlbmRpZiAvLyBFTkFCTEUoRklMVEVSUykKLQo=