47313 2010-10-06 16:13:47 -0700 Handle massive input strings to normalizeLineEndingsToCRLF() more gracefully 2010-10-06 22:43:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 cevans cevans commit-queue levin oldest_to_newest 290645 0 cevans 2010-10-06 16:13:47 -0700 Looks like there are integer wrap issues here. The upcoming patch detects pathological conditions and returns the empty string. This mirrors the behaviour of e.g. WebCore::base64Encode(). 290648 1 70004 cevans 2010-10-06 16:17:06 -0700 Created attachment 70004 Patch 290660 2 70004 abarth 2010-10-06 16:37:22 -0700 Comment on attachment 70004 Patch No test? 290669 3 70004 levin 2010-10-06 16:40:59 -0700 Comment on attachment 70004 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=70004&action=review Mr. Barth makes a good observation. Test? > WebCore/ChangeLog:3 > + Reviewed by Reviewed by NOBODY (OOPS!). "Reviewed by Reviewed by" 290673 4 cevans 2010-10-06 16:46:03 -0700 @abarth: I don't think this can be tested without crashing on 32-bit (virtual address space too small). Even on 64-bit, the test would be at best very slow and at worse prone to exhausting physical memory. 290674 5 70012 cevans 2010-10-06 16:46:49 -0700 Created attachment 70012 Patch 290678 6 70012 levin 2010-10-06 16:50:15 -0700 Comment on attachment 70012 Patch Reasonable explanation about the test. 290754 7 70012 commit-queue 2010-10-06 18:46:57 -0700 Comment on attachment 70012 Patch Rejecting patch 70012 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: -dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21468 test cases. http/tests/xmlhttprequest/cross-origin-no-credential-prompt.html -> failed Exiting early after 1 failures. 21325 tests run. 566.99s total testing time WARNING:webkitpy.common.system:Called kill_process with a non-existant pid 90163 21324 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4193122 290781 8 cevans 2010-10-06 20:43:01 -0700 Seems unrelated; retrying. 290789 9 70012 commit-queue 2010-10-06 21:15:51 -0700 Comment on attachment 70012 Patch Rejecting patch 70012 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: 0.90 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21469 test cases. http/tests/xmlhttprequest/failed-auth.html -> failed Exiting early after 1 failures. 21341 tests run. 565.75s total testing time WARNING:webkitpy.common.system:Called kill_process with a non-existant pid 4291 21340 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 34 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4237080 290799 10 levin 2010-10-06 22:15:20 -0700 re cq+, cq-, cq+, cq-, cq+ See defn insanity. 290802 11 cevans 2010-10-06 22:21:12 -0700 Not sure I follow? I can stop if that's what you saying. We're getting good data as to the current flake rate :) 290803 12 levin 2010-10-06 22:23:55 -0700 (In reply to comment #11) > Not sure I follow? I can stop if that's what you saying. > We're getting good data as to the current flake rate :) It was reference to http://www.quotationspage.com/quote/26032.html Meant to be funny that's all. 290812 13 70012 commit-queue 2010-10-06 22:42:22 -0700 Comment on attachment 70012 Patch Clearing flags on attachment: 70012 Committed r69275: <http://trac.webkit.org/changeset/69275> 290813 14 commit-queue 2010-10-06 22:42:28 -0700 All reviewed patches have been landed. Closing bug. 290815 15 cevans 2010-10-06 22:43:46 -0700 A victory for insanity! I never knew that was Einstein... 70004 2010-10-06 16:17:06 -0700 2010-10-06 16:46:49 -0700 Patch 47313_1.diff text/plain 1758 cevans SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTEyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMDYgIENocmlzIEV2YW5zICA8Y2V2YW5zQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MzEzCisK KyAgICAgICAgRml4IGludGVnZXIgZXJyb3JzIHdpdGggZW5vcm1vdXMgaW5wdXQgc3RyaW5ncyB0 byBuZXdsaW5lIG5vcm1hbGl6YXRpb24gQVBJcy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQv TGluZUVuZGluZy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpub3JtYWxpemVMaW5lRW5kaW5nc1Rv Q1JMRik6IHJldHVybiB0aGUgZW1wdHkgc3RyaW5nIHVwb24gaHVnZSBpbnB1dCBzdHJpbmdzLiAo QmVoYXZlcyBzaW1pbGFybHkgdG8gYmFzZTY0RW5jb2RlIG5vdykuCisgICAgICAgIChXZWJDb3Jl Ojpub3JtYWxpemVUb0NST3JMRik6IHVzZSB0aGUgY29ycmVjdCB0eXBlIGZvciBhIHN0cmluZyBs ZW5ndGguCisKIDIwMTAtMTAtMDUgIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNv cmUvcGxhdGZvcm0vdGV4dC9MaW5lRW5kaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3Bs YXRmb3JtL3RleHQvTGluZUVuZGluZy5jcHAJKHJldmlzaW9uIDY5MTIyKQorKysgV2ViQ29yZS9w bGF0Zm9ybS90ZXh0L0xpbmVFbmRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3 IEBACiAvLyBOb3JtYWxpemUgYWxsIGxpbmUtZW5kaW5ncyB0byBDUkxGLgogQ1N0cmluZyBub3Jt YWxpemVMaW5lRW5kaW5nc1RvQ1JMRihjb25zdCBDU3RyaW5nJiBmcm9tKQogewotICAgIHVuc2ln bmVkIG5ld0xlbiA9IDA7CisgICAgc2l6ZV90IG5ld0xlbiA9IDA7CiAgICAgY29uc3QgY2hhciog cCA9IGZyb20uZGF0YSgpOwogICAgIHdoaWxlIChjaGFyIGMgPSAqcCsrKSB7CiAgICAgICAgIGlm IChjID09ICdccicpIHsKQEAgLTU5LDYgKzU5LDggQEAKICAgICB9CiAgICAgaWYgKG5ld0xlbiA9 PSBmcm9tLmxlbmd0aCgpKQogICAgICAgICByZXR1cm4gZnJvbTsKKyAgICBpZiAobmV3TGVuIDwg ZnJvbS5sZW5ndGgoKSkKKyAgICAgICAgcmV0dXJuIENTdHJpbmcoKTsKIAogICAgIC8vIE1ha2Ug YSBjb3B5IG9mIHRoZSBzdHJpbmcuCiAgICAgcCA9IGZyb20uZGF0YSgpOwpAQCAtODcsNyArODks NyBAQAogLy8gTm9ybWFsaXplIGFsbCBsaW5lLWVuZGluZ3MgdG8gQ1Igb3IgTEYuCiBzdGF0aWMg Q1N0cmluZyBub3JtYWxpemVUb0NST3JMRihjb25zdCBDU3RyaW5nJiBmcm9tLCBib29sIHRvQ1Ip CiB7Ci0gICAgdW5zaWduZWQgbmV3TGVuID0gMDsKKyAgICBzaXplX3QgbmV3TGVuID0gMDsKICAg ICBib29sIG5lZWRGaXggPSBmYWxzZTsKICAgICBjb25zdCBjaGFyKiBwID0gZnJvbS5kYXRhKCk7 CiAgICAgY2hhciBmcm9tRW5kaW5nQ2hhciA9IHRvQ1IgPyAnXG4nIDogJ1xyJzsK 70012 2010-10-06 16:46:49 -0700 2010-10-06 22:42:22 -0700 Patch 47313_2.diff text/plain 1746 cevans SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTEyMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAtMDYgIENocmlzIEV2YW5zICA8Y2V2YW5zQGdvb2dsZS5j b20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MzEzCisKKyAgICAgICAgRml4 IGludGVnZXIgZXJyb3JzIHdpdGggZW5vcm1vdXMgaW5wdXQgc3RyaW5ncyB0byBuZXdsaW5lIG5v cm1hbGl6YXRpb24gQVBJcy4KKworICAgICAgICAqIHBsYXRmb3JtL3RleHQvTGluZUVuZGluZy5j cHA6CisgICAgICAgIChXZWJDb3JlOjpub3JtYWxpemVMaW5lRW5kaW5nc1RvQ1JMRik6IHJldHVy biB0aGUgZW1wdHkgc3RyaW5nIHVwb24gaHVnZSBpbnB1dCBzdHJpbmdzLiAoQmVoYXZlcyBzaW1p bGFybHkgdG8gYmFzZTY0RW5jb2RlIG5vdykuCisgICAgICAgIChXZWJDb3JlOjpub3JtYWxpemVU b0NST3JMRik6IHVzZSB0aGUgY29ycmVjdCB0eXBlIGZvciBhIHN0cmluZyBsZW5ndGguCisKIDIw MTAtMTAtMDUgIEtlaXRoIEt5eml2YXQgIDxrZWl0aC5reXppdmF0QG5va2lhLmNvbT4KIAogICAg ICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFubi4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0v dGV4dC9MaW5lRW5kaW5nLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL3RleHQv TGluZUVuZGluZy5jcHAJKHJldmlzaW9uIDY5MTIyKQorKysgV2ViQ29yZS9wbGF0Zm9ybS90ZXh0 L0xpbmVFbmRpbmcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MCw3ICs0MCw3IEBACiAvLyBOb3Jt YWxpemUgYWxsIGxpbmUtZW5kaW5ncyB0byBDUkxGLgogQ1N0cmluZyBub3JtYWxpemVMaW5lRW5k aW5nc1RvQ1JMRihjb25zdCBDU3RyaW5nJiBmcm9tKQogewotICAgIHVuc2lnbmVkIG5ld0xlbiA9 IDA7CisgICAgc2l6ZV90IG5ld0xlbiA9IDA7CiAgICAgY29uc3QgY2hhciogcCA9IGZyb20uZGF0 YSgpOwogICAgIHdoaWxlIChjaGFyIGMgPSAqcCsrKSB7CiAgICAgICAgIGlmIChjID09ICdccicp IHsKQEAgLTU5LDYgKzU5LDggQEAKICAgICB9CiAgICAgaWYgKG5ld0xlbiA9PSBmcm9tLmxlbmd0 aCgpKQogICAgICAgICByZXR1cm4gZnJvbTsKKyAgICBpZiAobmV3TGVuIDwgZnJvbS5sZW5ndGgo KSkKKyAgICAgICAgcmV0dXJuIENTdHJpbmcoKTsKIAogICAgIC8vIE1ha2UgYSBjb3B5IG9mIHRo ZSBzdHJpbmcuCiAgICAgcCA9IGZyb20uZGF0YSgpOwpAQCAtODcsNyArODksNyBAQAogLy8gTm9y bWFsaXplIGFsbCBsaW5lLWVuZGluZ3MgdG8gQ1Igb3IgTEYuCiBzdGF0aWMgQ1N0cmluZyBub3Jt YWxpemVUb0NST3JMRihjb25zdCBDU3RyaW5nJiBmcm9tLCBib29sIHRvQ1IpCiB7Ci0gICAgdW5z aWduZWQgbmV3TGVuID0gMDsKKyAgICBzaXplX3QgbmV3TGVuID0gMDsKICAgICBib29sIG5lZWRG aXggPSBmYWxzZTsKICAgICBjb25zdCBjaGFyKiBwID0gZnJvbS5kYXRhKCk7CiAgICAgY2hhciBm cm9tRW5kaW5nQ2hhciA9IHRvQ1IgPyAnXG4nIDogJ1xyJzsK