<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>47293</bug_id>
          
          <creation_ts>2010-10-06 12:38:56 -0700</creation_ts>
          <short_desc>run-webkit-tests should identify if new failing/passing platform specific results match general expected results</short_desc>
          <delta_ts>2015-02-23 10:42:31 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Joseph Pecoraro">joepeck</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>ddkilzer</cc>
    
    <cc>simon.fraser</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>290522</commentid>
    <comment_count>0</comment_count>
    <who name="Joseph Pecoraro">joepeck</who>
    <bug_when>2010-10-06 12:38:56 -0700</bug_when>
    <thetext>If a platform has expected results for a failing test, and eventually that test starts passing,
it would be great if run-webkit-tests could point out that the new results match the
general, non-platform-specific results.

Example:

  LayoutTests/platform/fake-platform/fast/blah-expected.txt =&gt; &quot;FAIL - not yet supported&quot;
  LayoutTests/fast/blah-expected.txt =&gt; &quot;PASS&quot;

After implementing &quot;blah&quot; and running tests you could see something like:

  Tests where results did not match expected results:
  fast/blah.html	expected | actual | diff | pretty diff | *

  Tests now matching non-platform-specific results:
  fast/blah.html

It would also be helpful if run-webkit-tests pointed out that the results are platform specific
for a dumpAsText() test.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1071242</commentid>
    <comment_count>1</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2015-02-23 10:39:28 -0800</bug_when>
    <thetext>Other possibilities:

- Have run-webkit-tests (with a special flag) not only mark the test as passing for this mode, but also delete the platform-specific result on disk.

- Have run-webkit-tests add a --lint-results switch (or similar) that would (for a given platform) check that its most specific result matches the immediate upstream result and (optionally delete it when that happens).
d</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1071245</commentid>
    <comment_count>2</comment_count>
    <who name="David Kilzer (:ddkilzer)">ddkilzer</who>
    <bug_when>2015-02-23 10:42:31 -0800</bug_when>
    <thetext>Maybe this is just another way of running --new-baseline, though?

See Bug 141913: run-webkit-tests --new-baseline should not write new result (or delete existing result) if upstream results match</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>