47292 2010-10-06 12:15:32 -0700 [chromium] Thumbnail generation asserts on zero alpha values. 2010-10-06 18:26:37 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 0 scheib webkit-unassigned commit-queue kbr nduca scheib vangelis oldest_to_newest 290510 0 scheib 2010-10-06 12:15:32 -0700 [chromium] Thumbnail generation asserts on zero alpha values. 290534 1 69982 scheib 2010-10-06 13:09:51 -0700 Created attachment 69982 Patch 290543 2 69982 vangelis 2010-10-06 13:26:21 -0700 Comment on attachment 69982 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69982&action=review Otherwise, I agree with the proposed fix. > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:288 > + // Alpha channel on Windows is incorrect when Skia uses ClearType, don't write alpha: I found the comment confusing. Did you mean to punctuate differently? How about: Alpha channels on windows is incorrect when rendering text with ClearType. Mask off alpha to maintain proper premultiplied color values in the backbuffer. or something like that? 290555 3 69982 kbr 2010-10-06 13:44:28 -0700 Comment on attachment 69982 Patch r- to address Vangelis's comments. 290559 4 69985 scheib 2010-10-06 13:53:19 -0700 Created attachment 69985 Patch 290563 5 69985 kbr 2010-10-06 13:57:45 -0700 Comment on attachment 69985 Patch OK. 290745 6 69985 commit-queue 2010-10-06 18:26:33 -0700 Comment on attachment 69985 Patch Clearing flags on attachment: 69985 Committed r69266: <http://trac.webkit.org/changeset/69266> 290746 7 commit-queue 2010-10-06 18:26:37 -0700 All reviewed patches have been landed. Closing bug. 69982 2010-10-06 13:09:51 -0700 2010-10-06 13:53:15 -0700 Patch bug-47292-20101006130950.patch text/plain 2228 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTcwNTBjMWU1MGQwNGQ0OTE4NGZiMTc5Y2NmZDIwOTg5NzhlZTY1Ny4uNjk3YzFlYTQ2MTFlYjFk OThmYjVjZWE0NzVlMmU5Mjc0OTUxMDZiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0wNiAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gVGh1bWJuYWlsIGdlbmVyYXRp b24gYXNzZXJ0cyBvbiB6ZXJvIGFscGhhIHZhbHVlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MjkyCisKKyAgICAgICAgVGVzdDogVGVzdGVkIG1h bnVhbGx5IGJ5IHJ1bm5pbmcgZGVidWcgbW9kZSwgYW5kIGFuYWx5emluZyBpbiBQSVguCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJz KToKKwogMjAxMC0xMC0wNiAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJD aHJvbWl1bS5jcHAKaW5kZXggYTRiNmZhYjk0MDM2MWQ4NDhiODIyMjAxMmEzMDVhODc1ZDZmNjI0 ZC4uZGZmZmQwNzlhMDg1Yjc3MmE3ZGZjOGIzNzcxZDIxNGNmNmIwYWJiOSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJl ckNocm9taXVtLmNwcApAQCAtMjg1LDExICsyODUsMTQgQEAgdm9pZCBMYXllclJlbmRlcmVyQ2hy b21pdW06OmRyYXdMYXllcnMoY29uc3QgSW50UmVjdCYgdmlzaWJsZVJlY3QsIGNvbnN0IEludFJl Y3QKICAgICBjb25zdCBDb250ZW50TGF5ZXJDaHJvbWl1bTo6U2hhcmVkVmFsdWVzKiBjb250ZW50 TGF5ZXJWYWx1ZXMgPSBjb250ZW50TGF5ZXJTaGFyZWRWYWx1ZXMoKTsKICAgICB1c2VTaGFkZXIo Y29udGVudExheWVyVmFsdWVzLT5jb250ZW50U2hhZGVyUHJvZ3JhbSgpKTsKICAgICBHTEMobV9j b250ZXh0LCBtX2NvbnRleHQtPnVuaWZvcm0xaShjb250ZW50TGF5ZXJWYWx1ZXMtPnNoYWRlclNh bXBsZXJMb2NhdGlvbigpLCAwKSk7CisgICAgLy8gQWxwaGEgY2hhbm5lbCBvbiBXaW5kb3dzIGlz IGluY29ycmVjdCB3aGVuIFNraWEgdXNlcyBDbGVhclR5cGUsIGRvbid0IHdyaXRlIGFscGhhOgor ICAgIEdMQyhtX2NvbnRleHQsIG1fY29udGV4dC0+Y29sb3JNYXNrKHRydWUsIHRydWUsIHRydWUs IGZhbHNlKSk7CiAgICAgVHJhbnNmb3JtYXRpb25NYXRyaXggbGF5ZXJNYXRyaXg7CiAgICAgbGF5 ZXJNYXRyaXgudHJhbnNsYXRlM2QodmlzaWJsZVJlY3Qud2lkdGgoKSAqIDAuNWYsIHZpc2libGVS ZWN0LmhlaWdodCgpICogMC41ZiwgMCk7CiAgICAgTGF5ZXJDaHJvbWl1bTo6ZHJhd1RleHR1cmVk UXVhZChtX2NvbnRleHQuZ2V0KCksIG1fcHJvamVjdGlvbk1hdHJpeCwgbGF5ZXJNYXRyaXgsCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB2aXNpYmxlUmVjdC53aWR0aCgpLCB2 aXNpYmxlUmVjdC5oZWlnaHQoKSwgMSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgIGNvbnRlbnRMYXllclZhbHVlcy0+c2hhZGVyTWF0cml4TG9jYXRpb24oKSwgY29udGVudExh eWVyVmFsdWVzLT5zaGFkZXJBbHBoYUxvY2F0aW9uKCkpOworICAgIEdMQyhtX2NvbnRleHQsIG1f Y29udGV4dC0+Y29sb3JNYXNrKHRydWUsIHRydWUsIHRydWUsIHRydWUpKTsKIAogICAgIC8vIElm IGN1bGxpbmcgaXMgZW5hYmxlZCB0aGVuIHdlIHdpbGwgY3VsbCB0aGUgYmFja2ZhY2UuCiAgICAg R0xDKG1fY29udGV4dCwgbV9jb250ZXh0LT5jdWxsRmFjZShHcmFwaGljc0NvbnRleHQzRDo6QkFD SykpOwo= 69985 2010-10-06 13:53:19 -0700 2010-10-06 18:26:32 -0700 Patch bug-47292-20101006135318.patch text/plain 2292 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTcwNTBjMWU1MGQwNGQ0OTE4NGZiMTc5Y2NmZDIwOTg5NzhlZTY1Ny4uNjk3YzFlYTQ2MTFlYjFk OThmYjVjZWE0NzVlMmU5Mjc0OTUxMDZiMCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0xMC0wNiAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gVGh1bWJuYWlsIGdlbmVyYXRp b24gYXNzZXJ0cyBvbiB6ZXJvIGFscGhhIHZhbHVlcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MjkyCisKKyAgICAgICAgVGVzdDogVGVzdGVkIG1h bnVhbGx5IGJ5IHJ1bm5pbmcgZGVidWcgbW9kZSwgYW5kIGFuYWx5emluZyBpbiBQSVguCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5ZXJz KToKKwogMjAxMC0xMC0wNiAgQW5kcmFzIEJlY3NpICA8YWJlY3NpQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCmRpZmYgLS1naXQg YS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJD aHJvbWl1bS5jcHAKaW5kZXggYTRiNmZhYjk0MDM2MWQ4NDhiODIyMjAxMmEzMDVhODc1ZDZmNjI0 ZC4uNDExYjQyMDgwZmZlZjZjNDM5YTZmZmE4ZTM5ZjUzYjVkY2ZlNWZmMyAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0u Y3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJl ckNocm9taXVtLmNwcApAQCAtMjg1LDExICsyODUsMTUgQEAgdm9pZCBMYXllclJlbmRlcmVyQ2hy b21pdW06OmRyYXdMYXllcnMoY29uc3QgSW50UmVjdCYgdmlzaWJsZVJlY3QsIGNvbnN0IEludFJl Y3QKICAgICBjb25zdCBDb250ZW50TGF5ZXJDaHJvbWl1bTo6U2hhcmVkVmFsdWVzKiBjb250ZW50 TGF5ZXJWYWx1ZXMgPSBjb250ZW50TGF5ZXJTaGFyZWRWYWx1ZXMoKTsKICAgICB1c2VTaGFkZXIo Y29udGVudExheWVyVmFsdWVzLT5jb250ZW50U2hhZGVyUHJvZ3JhbSgpKTsKICAgICBHTEMobV9j b250ZXh0LCBtX2NvbnRleHQtPnVuaWZvcm0xaShjb250ZW50TGF5ZXJWYWx1ZXMtPnNoYWRlclNh bXBsZXJMb2NhdGlvbigpLCAwKSk7CisgICAgLy8gTWFzayBvdXQgd3JpdGVzIHRvIGFscGhhIGNo YW5uZWw6IENsZWFyVHlwZSB2aWEgU2tpYSByZXN1bHRzIGluIGludmFsaWQKKyAgICAvLyB6ZXJv IGFscGhhIHZhbHVlcyBvbiB0ZXh0IGdseXBocy4gVGhlIHJvb3QgbGF5ZXIgaXMgYWx3YXlzIG9w YXF1ZS4KKyAgICBHTEMobV9jb250ZXh0LCBtX2NvbnRleHQtPmNvbG9yTWFzayh0cnVlLCB0cnVl LCB0cnVlLCBmYWxzZSkpOwogICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IGxheWVyTWF0cml4Owog ICAgIGxheWVyTWF0cml4LnRyYW5zbGF0ZTNkKHZpc2libGVSZWN0LndpZHRoKCkgKiAwLjVmLCB2 aXNpYmxlUmVjdC5oZWlnaHQoKSAqIDAuNWYsIDApOwogICAgIExheWVyQ2hyb21pdW06OmRyYXdU ZXh0dXJlZFF1YWQobV9jb250ZXh0LmdldCgpLCBtX3Byb2plY3Rpb25NYXRyaXgsIGxheWVyTWF0 cml4LAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmlzaWJsZVJlY3Qud2lk dGgoKSwgdmlzaWJsZVJlY3QuaGVpZ2h0KCksIDEsCiAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBjb250ZW50TGF5ZXJWYWx1ZXMtPnNoYWRlck1hdHJpeExvY2F0aW9uKCksIGNv bnRlbnRMYXllclZhbHVlcy0+c2hhZGVyQWxwaGFMb2NhdGlvbigpKTsKKyAgICBHTEMobV9jb250 ZXh0LCBtX2NvbnRleHQtPmNvbG9yTWFzayh0cnVlLCB0cnVlLCB0cnVlLCB0cnVlKSk7CiAKICAg ICAvLyBJZiBjdWxsaW5nIGlzIGVuYWJsZWQgdGhlbiB3ZSB3aWxsIGN1bGwgdGhlIGJhY2tmYWNl LgogICAgIEdMQyhtX2NvbnRleHQsIG1fY29udGV4dC0+Y3VsbEZhY2UoR3JhcGhpY3NDb250ZXh0 M0Q6OkJBQ0spKTsK