47284 2010-10-06 11:14:02 -0700 [Qt] Correct CamelCase of socketSentdata() in SocketStreamHandle 2010-10-06 12:57:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All Linux RESOLVED FIXED Qt P2 Normal --- 1 abecsi abecsi abecsi commit-queue kenneth markus ossy oldest_to_newest 290459 0 abecsi 2010-10-06 11:14:02 -0700 Plenty of layout tests have "QMetaObject::invokeMethod: No such method WebCore::SocketStreamHandlePrivate::socketSentData()" messages in stderr in WebKit2. Correct the CamelCase of the socketSentdata() method to fix these warnings in layout tests. 290463 1 69964 abecsi 2010-10-06 11:17:47 -0700 Created attachment 69964 proposed patch 290469 2 69964 kenneth 2010-10-06 11:21:17 -0700 Comment on attachment 69964 proposed patch Looks fine. Are you certain that socketSentdata() is not called from anywhere today? 290475 3 abecsi 2010-10-06 11:27:59 -0700 (In reply to comment #2) > (From update of attachment 69964 [details]) > Looks fine. Are you certain that socketSentdata() is not called from anywhere today? I grepped the whole source, and it isn't used anywhere else. It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled. 290476 4 abecsi 2010-10-06 11:28:57 -0700 (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 69964 [details] [details]) > > Looks fine. Are you certain that socketSentdata() is not called from anywhere today? > > I grepped the whole source, and it isn't used anywhere else. > It's only supposed to be used by QMetaObject::invokeMethod, but the name is misspelled. ./WebCore/platform/network/qt/SocketStreamHandleQt.cpp:103: QMetaObject::invokeMethod(this, "socketSentData", Qt::QueuedConnection); 290513 5 69964 commit-queue 2010-10-06 12:16:13 -0700 Comment on attachment 69964 proposed patch Clearing flags on attachment: 69964 Committed r69221: <http://trac.webkit.org/changeset/69221> 290514 6 commit-queue 2010-10-06 12:16:18 -0700 All reviewed patches have been landed. Closing bug. 290526 7 69978 scheib 2010-10-06 12:55:33 -0700 Created attachment 69978 Patch 290527 8 69978 scheib 2010-10-06 12:57:31 -0700 Comment on attachment 69978 Patch Sorry for spam on this bug - not certain how I typo-ed the bug number. 69964 2010-10-06 11:17:47 -0700 2010-10-06 12:16:13 -0700 proposed patch patch.diff text/plain 1888 abecsi ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NWExOTY5My4uYjBjYTAxNiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0wNiAgQW5kcmFzIEJlY3Np ICA8YWJlY3NpQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW1F0XSBDb3JyZWN0IENhbWVsQ2FzZSBvZiBzb2NrZXRTZW50ZGF0YSgp IGluIFNvY2tldFN0cmVhbUhhbmRsZVByaXZhdGUgCisgICAgICAgIHRvIGZpeCAiUU1ldGFPYmpl Y3Q6Omludm9rZU1ldGhvZDogTm8gc3VjaCBtZXRob2QiIHdhcm5pbmdzIGluIGxheW91dCB0ZXN0 cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3Mjg0 CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIG5lZWRlZC4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvcXQvU29ja2V0U3RyZWFtSGFuZGxlUHJpdmF0ZS5oOgorICAgICAgICAqIHBsYXRmb3Jt L25ldHdvcmsvcXQvU29ja2V0U3RyZWFtSGFuZGxlUXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 U29ja2V0U3RyZWFtSGFuZGxlUHJpdmF0ZTo6c29ja2V0U2VudERhdGEpOgorCiAyMDEwLTEwLTA2 ICBMdWl6IEFnb3N0aW5pICA8bHVpei5hZ29zdGluaUBvcGVuYm9zc2Eub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0IGEvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1NvY2tldFN0cmVhbUhhbmRsZVByaXZhdGUuaCBiL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9xdC9Tb2NrZXRTdHJlYW1IYW5kbGVQcml2YXRlLmgKaW5k ZXggMjM1ZjFiMS4uZDA3NGY0MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L3F0L1NvY2tldFN0cmVhbUhhbmRsZVByaXZhdGUuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvcXQvU29ja2V0U3RyZWFtSGFuZGxlUHJpdmF0ZS5oCkBAIC01NCw3ICs1NCw3IEBAIHB1 YmxpYyBzbG90czoKICAgICB2b2lkIHNvY2tldFJlYWR5UmVhZCgpOwogICAgIGludCBzZW5kKGNv bnN0IGNoYXIqIGRhdGEsIGludCBsZW4pOwogICAgIHZvaWQgY2xvc2UoKTsKLSAgICB2b2lkIHNv Y2tldFNlbnRkYXRhKCk7CisgICAgdm9pZCBzb2NrZXRTZW50RGF0YSgpOwogICAgIHZvaWQgc29j a2V0Q2xvc2VkKCk7CiAgICAgdm9pZCBzb2NrZXRFcnJvcihRQWJzdHJhY3RTb2NrZXQ6OlNvY2tl dEVycm9yKTsKICAgICB2b2lkIHNvY2tldENsb3NlZENhbGxiYWNrKCk7CmRpZmYgLS1naXQgYS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQvU29ja2V0U3RyZWFtSGFuZGxlUXQuY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9uZXR3b3JrL3F0L1NvY2tldFN0cmVhbUhhbmRsZVF0LmNwcAppbmRleCBj YzUwOGI2Li4xMDU1MGFlIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvcXQv U29ja2V0U3RyZWFtSGFuZGxlUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9x dC9Tb2NrZXRTdHJlYW1IYW5kbGVRdC5jcHAKQEAgLTExMCw3ICsxMTAsNyBAQCB2b2lkIFNvY2tl dFN0cmVhbUhhbmRsZVByaXZhdGU6OmNsb3NlKCkKICAgICAgICAgbV9zb2NrZXQtPmNsb3NlKCk7 CiB9CiAKLXZvaWQgU29ja2V0U3RyZWFtSGFuZGxlUHJpdmF0ZTo6c29ja2V0U2VudGRhdGEoKQor dm9pZCBTb2NrZXRTdHJlYW1IYW5kbGVQcml2YXRlOjpzb2NrZXRTZW50RGF0YSgpCiB7CiAgICAg aWYgKG1fc3RyZWFtSGFuZGxlKQogICAgICAgICBtX3N0cmVhbUhhbmRsZS0+c2VuZFBlbmRpbmdE YXRhKCk7Cg== 69978 2010-10-06 12:55:33 -0700 2010-10-06 12:57:30 -0700 Patch bug-47284-20101006125532.patch text/plain 2229 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTcwNTBjMWU1MGQwNGQ0OTE4NGZiMTc5Y2NmZDIwOTg5NzhlZTY1Ny4uNGE0MjVmN2I2NjhjNjQz MWY3MGM5Mzk2ODI3ZDRjZGIyMmRhNDQ3NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjIwMTAtMTAtMDUgIFZp bmNlbnQgU2NoZWliICA8c2NoZWliQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIFRodW1ibmFpbCBnZW5lcmF0 aW9uIGFzc2VydHMgb24gemVybyBhbHBoYSB2YWx1ZXMuCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzI5MgorCisgICAgICAgIFRlc3Q6IFRlc3RlZCBt YW51YWxseSBieSBydW5uaW5nIGRlYnVnIG1vZGUsIGFuZCBhbmFseXppbmcgaW4gUElYLgorCisg ICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZHJhd0xheWVy cyk6CisKIDIwMTAtMTAtMDYgIEFuZHJhcyBCZWNzaSAgPGFiZWNzaUB3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0 IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21p dW0uY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVy Q2hyb21pdW0uY3BwCmluZGV4IGE0YjZmYWI5NDAzNjFkODQ4YjgyMjIwMTJhMzA1YTg3NWQ2ZjYy NGQuLmRmZmZkMDc5YTA4NWI3NzJhN2RmYzhiMzc3MWQyMTRjZjZiMGFiYjkgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVt LmNwcAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVy ZXJDaHJvbWl1bS5jcHAKQEAgLTI4NSwxMSArMjg1LDE0IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNo cm9taXVtOjpkcmF3TGF5ZXJzKGNvbnN0IEludFJlY3QmIHZpc2libGVSZWN0LCBjb25zdCBJbnRS ZWN0CiAgICAgY29uc3QgQ29udGVudExheWVyQ2hyb21pdW06OlNoYXJlZFZhbHVlcyogY29udGVu dExheWVyVmFsdWVzID0gY29udGVudExheWVyU2hhcmVkVmFsdWVzKCk7CiAgICAgdXNlU2hhZGVy KGNvbnRlbnRMYXllclZhbHVlcy0+Y29udGVudFNoYWRlclByb2dyYW0oKSk7CiAgICAgR0xDKG1f Y29udGV4dCwgbV9jb250ZXh0LT51bmlmb3JtMWkoY29udGVudExheWVyVmFsdWVzLT5zaGFkZXJT YW1wbGVyTG9jYXRpb24oKSwgMCkpOworICAgIC8vIEFscGhhIGNoYW5uZWwgb24gV2luZG93cyBp cyBpbmNvcnJlY3Qgd2hlbiBTa2lhIHVzZXMgQ2xlYXJUeXBlLCBkb24ndCB3cml0ZSBhbHBoYToK KyAgICBHTEMobV9jb250ZXh0LCBtX2NvbnRleHQtPmNvbG9yTWFzayh0cnVlLCB0cnVlLCB0cnVl LCBmYWxzZSkpOwogICAgIFRyYW5zZm9ybWF0aW9uTWF0cml4IGxheWVyTWF0cml4OwogICAgIGxh eWVyTWF0cml4LnRyYW5zbGF0ZTNkKHZpc2libGVSZWN0LndpZHRoKCkgKiAwLjVmLCB2aXNpYmxl UmVjdC5oZWlnaHQoKSAqIDAuNWYsIDApOwogICAgIExheWVyQ2hyb21pdW06OmRyYXdUZXh0dXJl ZFF1YWQobV9jb250ZXh0LmdldCgpLCBtX3Byb2plY3Rpb25NYXRyaXgsIGxheWVyTWF0cml4LAog ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgdmlzaWJsZVJlY3Qud2lkdGgoKSwg dmlzaWJsZVJlY3QuaGVpZ2h0KCksIDEsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBjb250ZW50TGF5ZXJWYWx1ZXMtPnNoYWRlck1hdHJpeExvY2F0aW9uKCksIGNvbnRlbnRM YXllclZhbHVlcy0+c2hhZGVyQWxwaGFMb2NhdGlvbigpKTsKKyAgICBHTEMobV9jb250ZXh0LCBt X2NvbnRleHQtPmNvbG9yTWFzayh0cnVlLCB0cnVlLCB0cnVlLCB0cnVlKSk7CiAKICAgICAvLyBJ ZiBjdWxsaW5nIGlzIGVuYWJsZWQgdGhlbiB3ZSB3aWxsIGN1bGwgdGhlIGJhY2tmYWNlLgogICAg IEdMQyhtX2NvbnRleHQsIG1fY29udGV4dC0+Y3VsbEZhY2UoR3JhcGhpY3NDb250ZXh0M0Q6OkJB Q0spKTsK