47282 2010-10-06 11:06:11 -0700 [CHROMIUM] Crash on failed shader compilation. 2010-10-06 11:23:00 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 senorblanco senorblanco jamesr kbr oldest_to_newest 290448 0 senorblanco 2010-10-06 11:06:11 -0700 [CHR[CHROMIUM] Crash on failed shader compilation. 290450 1 senorblanco 2010-10-06 11:07:59 -0700 When compilation of the canvas2D vertex or fragment shaders fails, we should not crash the renderer. I noticed this when using --enable-accelerated-2d-canvas with --in-process-webgl. While this is an unusual combination, it's probably a good idea to make this robust anyway. 290455 2 69962 senorblanco 2010-10-06 11:10:34 -0700 Created attachment 69962 Patch 290458 3 69962 jamesr 2010-10-06 11:13:17 -0700 Comment on attachment 69962 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69962&action=review Good catch. > WebCore/platform/graphics/gpu/SharedGraphicsContext3D.h:122 > + SharedGraphicsContext3D(PassOwnPtr<GraphicsContext3D> context, PassOwnPtr<SolidFillShader> solidFillShader, PassOwnPtr<TexShader> texShader); nit: don't need to name the params here 290472 4 senorblanco 2010-10-06 11:23:00 -0700 Committed r69215: <http://trac.webkit.org/changeset/69215> 69962 2010-10-06 11:10:34 -0700 2010-10-06 11:13:17 -0700 Patch bug-47282-20101006141030.patch text/plain 3146 senorblanco SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTIxMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMDYgIFN0ZXBoZW4gV2hpdGUgIDxzZW5vcmJsYW5jb0Bj aHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzI4MgorCisgICAg ICAgIFJvYnVzdGlmeSB0aGUgY3JlYXRpb24gb2YgU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QgYWdh aW5zdCBzaGFkZXIKKyAgICAgICAgY29tcGlsYXRpb24gZmFpbHVyZXMuCisKKyAgICAgICAgQ292 ZXJlZCBieSBhbnkgY2FudmFzIDJEIGxheW91dCB0ZXN0LCB3aGVuIG9wZW5lZCBpbiBjaHJvbWUg d2l0aCAKKyAgICAgICAgLS1lbmFibGUtYWNjZWxlcmF0ZWQtMmQtY2FudmFzIC0taW4tcHJvY2Vz cy13ZWJnbC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGlj c0NvbnRleHQzRC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTaGFyZWRHcmFwaGljc0NvbnRleHQz RDo6Y3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OlNoYXJlZEdyYXBoaWNzQ29udGV4dDNEOjpT aGFyZWRHcmFwaGljc0NvbnRleHQzRCk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1 L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmg6CisKIDIwMTAtMTAtMDYgIEx1aXogQWdvc3Rpbmkg IDxsdWl6LmFnb3N0aW5pQG9wZW5ib3NzYS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2Vu bmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4uCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2dwdS9TaGFyZWRHcmFwaGljc0NvbnRleHQzRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuY3BwCShyZXZpc2lv biA2OTIxMikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3B1L1NoYXJlZEdyYXBoaWNz Q29udGV4dDNELmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTUsMTQgKzU1LDIwIEBAIFBhc3NSZWZQ dHI8U2hhcmVkR3JhcGhpY3NDb250ZXh0M0Q+IFNoYXIKICAgICBPd25QdHI8R3JhcGhpY3NDb250 ZXh0M0Q+IGNvbnRleHQgPSBHcmFwaGljc0NvbnRleHQzRDo6Y3JlYXRlKGF0dHIsIGhvc3RXaW5k b3cpOwogICAgIGlmICghY29udGV4dCkKICAgICAgICAgcmV0dXJuIDA7Ci0gICAgcmV0dXJuIGFk b3B0UmVmKG5ldyBTaGFyZWRHcmFwaGljc0NvbnRleHQzRChjb250ZXh0LnJlbGVhc2UoKSkpOwor ICAgIE93blB0cjxTb2xpZEZpbGxTaGFkZXI+IHNvbGlkRmlsbFNoYWRlciA9IFNvbGlkRmlsbFNo YWRlcjo6Y3JlYXRlKGNvbnRleHQuZ2V0KCkpOworICAgIGlmICghc29saWRGaWxsU2hhZGVyKQor ICAgICAgICByZXR1cm4gMDsKKyAgICBPd25QdHI8VGV4U2hhZGVyPiB0ZXhTaGFkZXIgPSBUZXhT aGFkZXI6OmNyZWF0ZShjb250ZXh0LmdldCgpKTsKKyAgICBpZiAoIXRleFNoYWRlcikKKyAgICAg ICAgcmV0dXJuIDA7CisgICAgcmV0dXJuIGFkb3B0UmVmKG5ldyBTaGFyZWRHcmFwaGljc0NvbnRl eHQzRChjb250ZXh0LnJlbGVhc2UoKSwgc29saWRGaWxsU2hhZGVyLnJlbGVhc2UoKSwgdGV4U2hh ZGVyLnJlbGVhc2UoKSkpOwogfQogCi1TaGFyZWRHcmFwaGljc0NvbnRleHQzRDo6U2hhcmVkR3Jh cGhpY3NDb250ZXh0M0QoUGFzc093blB0cjxHcmFwaGljc0NvbnRleHQzRD4gY29udGV4dCkKK1No YXJlZEdyYXBoaWNzQ29udGV4dDNEOjpTaGFyZWRHcmFwaGljc0NvbnRleHQzRChQYXNzT3duUHRy PEdyYXBoaWNzQ29udGV4dDNEPiBjb250ZXh0LCBQYXNzT3duUHRyPFNvbGlkRmlsbFNoYWRlcj4g c29saWRGaWxsU2hhZGVyLCBQYXNzT3duUHRyPFRleFNoYWRlcj4gdGV4U2hhZGVyKQogICAgIDog bV9jb250ZXh0KGNvbnRleHQpCiAgICAgLCBtX3F1YWRWZXJ0aWNlcygwKQotICAgICwgbV9zb2xp ZEZpbGxTaGFkZXIoU29saWRGaWxsU2hhZGVyOjpjcmVhdGUobV9jb250ZXh0LmdldCgpKSkKLSAg ICAsIG1fdGV4U2hhZGVyKFRleFNoYWRlcjo6Y3JlYXRlKG1fY29udGV4dC5nZXQoKSkpCisgICAg LCBtX3NvbGlkRmlsbFNoYWRlcihzb2xpZEZpbGxTaGFkZXIpCisgICAgLCBtX3RleFNoYWRlcih0 ZXhTaGFkZXIpCiB7CiAgICAgYWxsQ29udGV4dHMoKS0+YWRkKHRoaXMpOwogfQpJbmRleDogV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9ncHUvU2hhcmVkR3JhcGhpY3NDb250ZXh0M0QuaAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dwdS9TaGFyZWRHcmFwaGljc0Nv bnRleHQzRC5oCShyZXZpc2lvbiA2OTIxMikKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv Z3B1L1NoYXJlZEdyYXBoaWNzQ29udGV4dDNELmgJKHdvcmtpbmcgY29weSkKQEAgLTExOSw3ICsx MTksNyBAQCBwdWJsaWM6CiAgICAgUGFzc1JlZlB0cjxUZXh0dXJlPiBjcmVhdGVUZXh0dXJlKFRl eHR1cmU6OkZvcm1hdCwgaW50IHdpZHRoLCBpbnQgaGVpZ2h0KTsKIAogcHJpdmF0ZToKLSAgICBl eHBsaWNpdCBTaGFyZWRHcmFwaGljc0NvbnRleHQzRChQYXNzT3duUHRyPEdyYXBoaWNzQ29udGV4 dDNEPiBjb250ZXh0KTsKKyAgICBTaGFyZWRHcmFwaGljc0NvbnRleHQzRChQYXNzT3duUHRyPEdy YXBoaWNzQ29udGV4dDNEPiBjb250ZXh0LCBQYXNzT3duUHRyPFNvbGlkRmlsbFNoYWRlcj4gc29s aWRGaWxsU2hhZGVyLCBQYXNzT3duUHRyPFRleFNoYWRlcj4gdGV4U2hhZGVyKTsKIAogICAgIC8v IFVzZWQgdG8gaW1wbGVtZW50IHJlbW92ZVRleHR1cmVzRm9yKCksIHNlZSB0aGUgY29tbWVudCBh Ym92ZS4KICAgICBzdGF0aWMgSGFzaFNldDxTaGFyZWRHcmFwaGljc0NvbnRleHQzRCo+KiBhbGxD b250ZXh0cygpOwo=