47280 2010-10-06 10:57:31 -0700 [Qt] RunLoop implementation for WTR 2010-10-06 16:28:47 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 45393 1 kbalazs webkit-unassigned abecsi oldest_to_newest 290444 0 kbalazs 2010-10-06 10:57:31 -0700 WTR needs a runloop for being functional. WTR is a little bit tricky because the event loop is allowed to run only while we are in the TestController::runUntil. While we are in the event loop we must check a global variable and stop the loop when it is becoming true. Our friend will be QEventLoop! 290461 1 69963 kbalazs 2010-10-06 11:14:28 -0700 Created attachment 69963 Patch 290465 2 69963 kenneth 2010-10-06 11:20:19 -0700 Comment on attachment 69963 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69963&action=review > WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:38 > +class RunUntilLoop : public QObject { Run until what? a condition? RunSingle? > WebKitTools/WebKitTestRunner/qt/TestControllerQt.cpp:42 > + static void start(bool& done) ah seems to be a condition, I guess RunUntilConditionLoop would be a better name. > WebKitTools/WebKitTestRunner/qt/main.cpp:51 > + m_controller = new WTR::TestController(m_argc, const_cast<const char**>(m_argv)); leaking m_controller? 290593 3 kbalazs 2010-10-06 14:54:45 -0700 > > > WebKitTools/WebKitTestRunner/qt/main.cpp:51 > > + m_controller = new WTR::TestController(m_argc, const_cast<const char**>(m_argv)); > > leaking m_controller? No, it is deleted in the destructor :) 290595 4 kbalazs 2010-10-06 14:56:04 -0700 I will do the renaming before commit. 290599 5 kbalazs 2010-10-06 14:59:03 -0700 Could not be committed before the dependency lands. 290654 6 69963 abecsi 2010-10-06 16:28:39 -0700 Comment on attachment 69963 Patch Clearing flags on attachment: 69963 Committed r69253: <http://trac.webkit.org/changeset/69253> 290655 7 abecsi 2010-10-06 16:28:47 -0700 All reviewed patches have been landed. Closing bug. 69963 2010-10-06 11:14:28 -0700 2010-10-06 16:28:39 -0700 Patch bug-47280-20101006201426.patch text/plain 4507 kbalazs ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxMDU5MDBlZDE0OTE1MjRlMmNhZjdhNzY0NjY5MjZmYTU5NDlmZDdlLi5kMWRkNjJi ODdmMTIxNDNkNzA3M2I4OWY4NmU0MzYxOGFhMjIzN2ZhIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0yLDYgKzIsMzMgQEAK IAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KIAorICAgICAgICBbUXRdIFJ1 bmxvb3AgaW1wbGVtZW50YXRpb24gZm9yIFdUUgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcyODAKKworICAgICAgICAqIFdlYktpdFRlc3RSdW5uZXIv cXQvVGVzdENvbnRyb2xsZXJRdC5jcHA6CisgICAgICAgIEltcGxlbWVudGVkIFRlc3RDb250cm9s bGVyOjpydW5VbnRpbCBieSBhIHRpbWVyRXZlbnQKKyAgICAgICAgYW5kIGEgUUV2ZW50TG9vcC4g V2Ugc3RlcCBpbnRvIHRoZSBldmVudCBsb29wIGZyb20gcnVuVW50aWwuCisgICAgICAgIFdoaWxl IHdlIGFyZSB3YWl0aW5nIGluIHRoZSBsb29wIGEgdGltZXJFdmVudCBpcyBwZXJpb2RpY2FsbHkK KyAgICAgICAgY2hlY2tpbmcgdGhlIHZhbHVlIG9mIHRoZSBjb25kaXRpb24uIE9uY2UgdGhlIGNv bmRpdGlvbiBoYXMKKyAgICAgICAgYmVjb21pbmcgdHJ1ZSB0aGUgdGltZXJFdmVudCB3YWtlcyB1 cyB1cC4KKyAgICAgICAgKFdUUjo6UnVuVW50aWxMb29wOjpzdGFydCk6CisgICAgICAgIChXVFI6 OlJ1blVudGlsTG9vcDo6UnVuVW50aWxMb29wKToKKyAgICAgICAgKFdUUjo6UnVuVW50aWxMb29w OjpydW4pOgorICAgICAgICAoV1RSOjpSdW5VbnRpbExvb3A6OnRpbWVyRXZlbnQpOgorICAgICAg ICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1Jbml0aWFsaXplKToKKyAgICAgICAgKFdU Ujo6VGVzdENvbnRyb2xsZXI6OnJ1blVudGlsKToKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVy L3F0L21haW4uY3BwOgorICAgICAgICBTdGFydCB0aGUgbWFpbiBldmVudCBsb29wIGZpcnN0IGFu ZCBjcmVhdGluZyB0aGUgVGVzdENvbnRyb2xsZXIgbGF0ZXIuCisgICAgICAgIChMYXVuY2hlcjo6 TGF1bmNoZXIpOgorICAgICAgICAoTGF1bmNoZXI6On5MYXVuY2hlcik6CisgICAgICAgIChMYXVu Y2hlcjo6bGF1bmNoKTogQ3JlYXRpbmcgdGhlIFRlc3RDb250cm9sbGVyLgorICAgICAgICAobWFp bik6IFNldHRpbmcgdXAgYSB0aW1lciBmb3IgY2FsbGluZyBMYXVuY2hlcjo6bGF1bmNoIGZyb20K KyAgICAgICAgdGhlIG1haW4gZXZlbnQgbG9vcC4KKworMjAxMC0xMC0wNiAgQmFsYXpzIEtlbGVt ZW4gIDxrYmFsYXpzQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKICAgICAgICAgW1F0XSBBZGQgV2ViS2l0VGVzdFJ1bm5lcidzIGJ1aWxkIGZpbGVz CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NDE1NQog CmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RDb250cm9s bGVyUXQuY3BwIGIvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9UZXN0Q29udHJvbGxl clF0LmNwcAppbmRleCBiNjk3NDcxMDFhZWRjOTdmNTRiM2NhYWMyMjI5YmE5MWJiZWNiZDcwLi4w NTIxOGQwZTBiNzAwNTI2ZjZhZGMxNGQ3NzQ2ZDcxMTQzODkzOGRlIDEwMDY0NAotLS0gYS9XZWJL aXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3F0L1Rlc3RDb250cm9sbGVyUXQuY3BwCisrKyBiL1dl YktpdFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvcXQvVGVzdENvbnRyb2xsZXJRdC5jcHAKQEAgLTI1 LDE4ICsyNSw1OSBAQAogICovCiAKICNpbmNsdWRlICJUZXN0Q29udHJvbGxlci5oIgorCiAjaW5j bHVkZSAiTm90SW1wbGVtZW50ZWQuaCIKKyNpbmNsdWRlIDxRQ29yZUFwcGxpY2F0aW9uPgorI2lu Y2x1ZGUgPFFFdmVudExvb3A+CisjaW5jbHVkZSA8UU9iamVjdD4KIAogbmFtZXNwYWNlIFdUUiB7 CiAKLXZvaWQgVGVzdENvbnRyb2xsZXI6OnJ1blVudGlsKGJvb2wmIGRvbmUpCitzdGF0aWMgY29u c3QgdW5zaWduZWQga1RpbWVySW50ZXJ2YWxNUyA9IDUwOworCitjbGFzcyBSdW5VbnRpbExvb3Ag OiBwdWJsaWMgUU9iamVjdCB7CisgICAgUV9PQkpFQ1QKKworcHVibGljOgorICAgIHN0YXRpYyB2 b2lkIHN0YXJ0KGJvb2wmIGRvbmUpCisgICAgeworICAgICAgICBzdGF0aWMgUnVuVW50aWxMb29w KiBpbnN0YW5jZSA9IG5ldyBSdW5VbnRpbExvb3A7CisgICAgICAgIGluc3RhbmNlLT5ydW4oZG9u ZSk7CisgICAgfQorCitwcml2YXRlOgorICAgIFJ1blVudGlsTG9vcCgpIHt9CisKKyAgICB2b2lk IHJ1bihib29sJiBkb25lKQorICAgIHsKKyAgICAgICAgbV9jb25kaXRpb24gPSAmZG9uZTsKKyAg ICAgICAgbV90aW1lcklEID0gc3RhcnRUaW1lcihrVGltZXJJbnRlcnZhbE1TKTsKKyAgICAgICAg QVNTRVJUKG1fdGltZXJJRCk7CisgICAgICAgIG1fZXZlbnRMb29wLmV4ZWMoUUV2ZW50TG9vcDo6 RXhjbHVkZVVzZXJJbnB1dEV2ZW50cyk7CisgICAgfQorCisgICAgdmlydHVhbCB2b2lkIHRpbWVy RXZlbnQoUVRpbWVyRXZlbnQqKQorICAgIHsKKyAgICAgICAgaWYgKCEqbV9jb25kaXRpb24pCisg ICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAga2lsbFRpbWVyKG1fdGltZXJJRCk7CisgICAg ICAgIG1fZXZlbnRMb29wLmV4aXQoKTsKKyAgICB9CisKKyAgICBRRXZlbnRMb29wIG1fZXZlbnRM b29wOworICAgIGJvb2wqIG1fY29uZGl0aW9uOworICAgIGludCBtX3RpbWVySUQ7Cit9OworCit2 b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUluaXRpYWxpemUoKQogewotICAgIG5vdEltcGxl bWVudGVkKCk7CiB9CiAKLXZvaWQgVGVzdENvbnRyb2xsZXI6OnBsYXRmb3JtSW5pdGlhbGl6ZSgp Cit2b2lkIFRlc3RDb250cm9sbGVyOjpydW5VbnRpbChib29sJiBkb25lKQogewotICAgIG5vdElt cGxlbWVudGVkKCk7CisgICAgUnVuVW50aWxMb29wOjpzdGFydChkb25lKTsKKyAgICBBU1NFUlQo ZG9uZSk7CiB9CiAKIHZvaWQgVGVzdENvbnRyb2xsZXI6OmluaXRpYWxpemVJbmplY3RlZEJ1bmRs ZVBhdGgoKQpAQCAtNTQsNCArOTUsNiBAQCB2b2lkIFRlc3RDb250cm9sbGVyOjpwbGF0Zm9ybUlu aXRpYWxpemVDb250ZXh0KCkKICAgICBub3RJbXBsZW1lbnRlZCgpOwogfQogCisjaW5jbHVkZSAi VGVzdENvbnRyb2xsZXJRdC5tb2MiCisKIH0gLy8gbmFtZXNwYWNlIFdUUgpkaWZmIC0tZ2l0IGEv V2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9tYWluLmNwcCBiL1dlYktpdFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvcXQvbWFpbi5jcHAKaW5kZXggMjUyM2Y1MWIyYjhkYjc0Y2VlMGVlYzA3 ZTExNzk0OGNiMTBmNmZmZi4uNDMxMmEwNTY0OTI5YjYzZjRjMmFlMTJmOThhMDJkMjdjYWYzYmZj NCAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9xdC9tYWluLmNwcAor KysgYi9XZWJLaXRUb29scy9XZWJLaXRUZXN0UnVubmVyL3F0L21haW4uY3BwCkBAIC0yNiw5ICsy Niw0NCBAQAogCiAjaW5jbHVkZSAiVGVzdENvbnRyb2xsZXIuaCIKIAotaW50IG1haW4oaW50IGFy Z2MsIGNvbnN0IGNoYXIqIGFyZ3ZbXSkKLXsKLSAgICBXVFI6OlRlc3RDb250cm9sbGVyIGNvbnRy b2xsZXIoYXJnYywgYXJndik7CisjaW5jbHVkZSA8UUFwcGxpY2F0aW9uPgorI2luY2x1ZGUgPFFP YmplY3Q+CisjaW5jbHVkZSA8UVRpbWVyPgorCitjbGFzcyBMYXVuY2hlciA6IHB1YmxpYyBRT2Jq ZWN0IHsKKyAgICBRX09CSkVDVAorCitwdWJsaWM6CisgICAgTGF1bmNoZXIoaW50IGFyZ2MsIGNo YXIqKiBhcmd2KQorICAgICAgICA6IG1fYXJnYyhhcmdjKQorICAgICAgICAsIG1fYXJndihhcmd2 KQorICAgIHsKKyAgICB9CisKKyAgICB+TGF1bmNoZXIoKQorICAgIHsKKyAgICAgICAgZGVsZXRl IG1fY29udHJvbGxlcjsKKyAgICB9CiAKLSAgICByZXR1cm4gMDsKK3B1YmxpYyBzbG90czoKKyAg ICB2b2lkIGxhdW5jaCgpCisgICAgeworICAgICAgICBtX2NvbnRyb2xsZXIgPSBuZXcgV1RSOjpU ZXN0Q29udHJvbGxlcihtX2FyZ2MsIGNvbnN0X2Nhc3Q8Y29uc3QgY2hhcioqPihtX2FyZ3YpKTsK KyAgICAgICAgUUFwcGxpY2F0aW9uOjpleGl0KCk7CisgICAgfQorCitwcml2YXRlOgorICAgIFdU Ujo6VGVzdENvbnRyb2xsZXIqIG1fY29udHJvbGxlcjsKKyAgICBpbnQgbV9hcmdjOworICAgIGNo YXIqKiBtX2FyZ3Y7Cit9OworCitpbnQgbWFpbihpbnQgYXJnYywgY2hhcioqIGFyZ3YpCit7Cisg ICAgUUFwcGxpY2F0aW9uIGFwcChhcmdjLCBhcmd2KTsKKyAgICBMYXVuY2hlciBsYXVuY2hlcihh cmdjLCBhcmd2KTsKKyAgICBRVGltZXI6OnNpbmdsZVNob3QoMCwgJmxhdW5jaGVyLCBTTE9UKGxh dW5jaCgpKSk7CisgICAgcmV0dXJuIGFwcC5leGVjKCk7OwogfQorCisjaW5jbHVkZSAibWFpbi5t b2MiCg==