47250 2010-10-06 02:17:08 -0700 Web Inspector: test that uncaught exceptions have stack trace when inspector is open 2010-12-20 15:05:22 -0800 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 yurys yurys abarth apavlov bweinstein joepeck keishi loislo pfeldman pmuellr rik timothy yurys oldest_to_newest 290151 0 yurys 2010-10-06 02:17:08 -0700 Web Inspector: test that uncaught exceptions have stack trace when inspector is open 290162 1 69909 yurys 2010-10-06 02:45:09 -0700 Created attachment 69909 Patch 290257 2 69909 yurys 2010-10-06 06:42:29 -0700 Comment on attachment 69909 Patch Clearing flags on attachment: 69909 Committed r69190: <http://trac.webkit.org/changeset/69190> 290258 3 yurys 2010-10-06 06:42:39 -0700 All reviewed patches have been landed. Closing bug. 290371 4 69909 joepeck 2010-10-06 09:39:46 -0700 Comment on attachment 69909 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69909&action=review > LayoutTests/http/tests/inspector/console-tests2.js:29 > \ No newline at end of file Nit: Newline! If you remember next time you update the file =). Nice test. 291889 5 abarth 2010-10-08 14:59:10 -0700 This patch does not have expected results on non-Chromium ports: http://trac.webkit.org/changeset/69190 Can you please add some? kthxsbye 292033 6 joepeck 2010-10-08 20:14:44 -0700 I'm still updating (and would have to build) before I could verify. But the snow leopard bots produced the following results: http://build.webkit.org/results/SnowLeopard%20Intel%20Release%20(Tests)/r69440%20(19029)/inspector/console-uncaught-exception-actual.txt I'm guessing the differences are jsc/v8 related. 292053 7 70342 joepeck 2010-10-08 22:22:47 -0700 Created attachment 70342 [PATCH] General Expected Results Looks like git was smarter than me. I ran and generated the expected results on my snow leopard machine. I checked and noticed gtk's results (added since this landed) were identical and removed them. Git considers it just a file move. That works for me. 292054 8 joepeck 2010-10-08 22:23:43 -0700 I don't have a windows machine to test on, but I assume it should work fine with these results. There aren't any windows platform specific results for inspector tests. 292056 9 joepeck 2010-10-08 22:35:13 -0700 Committed r69441 D LayoutTests/platform/gtk/inspector/console-uncaught-exception-expected.txt A LayoutTests/inspector/console-uncaught-exception-expected.txt M LayoutTests/ChangeLog r69441 = 4bf3c909c6f049dc3bf507926d7b11a66f58b386 http://trac.webkit.org/changeset/69441 324597 10 70342 joepeck 2010-12-20 15:05:22 -0800 Comment on attachment 70342 [PATCH] General Expected Results Removed the cq? flag, since this landed a while ago. 69909 2010-10-06 02:45:09 -0700 2010-10-06 09:39:46 -0700 Patch bug-47250-20101006134506.patch text/plain 4957 yurys ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA3YTZmY2JkMjlhNzAyMGM2OTE1MTgzN2ZhNWQxNjhlOTYzZTMwYmIyLi42NWI1OThj YWI2ZjdlYWY0Zjk5Y2I0Y2JlMDkyOGNiMTFhMzVjOTdiIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMTAtMDYgIFl1cnkgU2VtaWtoYXRza3kgIDx5dXJ5c0BjaHJvbWl1bS5vcmc+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2ViIEluc3BlY3Rv cjogdGVzdCB0aGF0IHVuY2F1Z2h0IGV4Y2VwdGlvbnMgaGF2ZSBzdGFjayB0cmFjZSB3aGVuIGlu c3BlY3RvciBpcyBvcGVuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD00NzI1MAorCisgICAgICAgICogaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS10 ZXN0czIuanM6IEFkZGVkLgorICAgICAgICAoaW5pdGlhbGl6ZV9Db25zb2xlVGVzdC5JbnNwZWN0 b3JUZXN0LmR1bXBDb25zb2xlTWVzc2FnZXMpOgorICAgICAgICAoaW5pdGlhbGl6ZV9Db25zb2xl VGVzdC5JbnNwZWN0b3JUZXN0LmV4cGFuZENvbnNvbGVNZXNzYWdlcyk6CisgICAgICAgIChpbml0 aWFsaXplX0NvbnNvbGVUZXN0KToKKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS11bmNhdWdo dC1leGNlcHRpb24uaHRtbDogQWRkZWQuCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vaW5z cGVjdG9yL2NvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisK IDIwMTAtMTAtMDYgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHRlc3QgZXhwZWN0YXRpb24gdXBkYXRlLgpkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS10ZXN0czIuanMgYi9MYXlvdXRUZXN0 cy9odHRwL3Rlc3RzL2luc3BlY3Rvci9jb25zb2xlLXRlc3RzMi5qcwpuZXcgZmlsZSBtb2RlIDEw MDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4zYWZk OWM5ODY0NDgxN2YxOTFhNjUyYjBiMWJhNzg2M2U0NmNkMWM3Ci0tLSAvZGV2L251bGwKKysrIGIv TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9pbnNwZWN0b3IvY29uc29sZS10ZXN0czIuanMKQEAgLTAs MCArMSwyOCBAQAordmFyIGluaXRpYWxpemVfQ29uc29sZVRlc3QgPSBmdW5jdGlvbigpIHsKKwor SW5zcGVjdG9yVGVzdC5kdW1wQ29uc29sZU1lc3NhZ2VzID0gZnVuY3Rpb24oKQoreworICAgIHZh ciByZXN1bHQgPSBbXTsKKyAgICB2YXIgbWVzc2FnZXMgPSBXZWJJbnNwZWN0b3IuY29uc29sZS5t ZXNzYWdlczsKKyAgICBmb3IgKHZhciBpID0gMDsgaSA8IG1lc3NhZ2VzLmxlbmd0aDsgKytpKSB7 CisgICAgICAgIHZhciBlbGVtZW50ID0gbWVzc2FnZXNbaV0udG9NZXNzYWdlRWxlbWVudCgpOwor ICAgICAgICBJbnNwZWN0b3JUZXN0LmFkZFJlc3VsdChlbGVtZW50LnRleHRDb250ZW50LnJlcGxh Y2UoL1x1MjAwYi9nLCAiIikpOworICAgIH0KKyAgICByZXR1cm4gcmVzdWx0OworfQorCitJbnNw ZWN0b3JUZXN0LmV4cGFuZENvbnNvbGVNZXNzYWdlcyA9IGZ1bmN0aW9uKCkKK3sKKyAgICB2YXIg bWVzc2FnZXMgPSBXZWJJbnNwZWN0b3IuY29uc29sZS5tZXNzYWdlczsKKyAgICBmb3IgKHZhciBp ID0gMDsgaSA8IG1lc3NhZ2VzLmxlbmd0aDsgKytpKSB7CisgICAgICAgIHZhciBlbGVtZW50ID0g bWVzc2FnZXNbaV0udG9NZXNzYWdlRWxlbWVudCgpOworICAgICAgICB2YXIgbm9kZSA9IGVsZW1l bnQ7CisgICAgICAgIHdoaWxlIChub2RlKSB7CisgICAgICAgICAgICBpZiAobm9kZS50cmVlRWxl bWVudEZvclRlc3QpCisgICAgICAgICAgICAgICAgbm9kZS50cmVlRWxlbWVudEZvclRlc3QuZXhw YW5kKCk7CisgICAgICAgICAgICBub2RlID0gbm9kZS50cmF2ZXJzZU5leHROb2RlKGVsZW1lbnQp OworICAgICAgICB9CisgICAgfQorfQorCit9ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtdW5jYXVnaHQtZXhjZXB0 aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS11bmNhdWdodC1leGNlcHRp b24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwLi43Yzc1YWQzNDAxOGFlOTMwZTJhYzg2ODI5YTcyMGM2MmYzMjEx MjcyCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtdW5j YXVnaHQtZXhjZXB0aW9uLmh0bWwKQEAgLTAsMCArMSw1NCBAQAorPGh0bWw+Cis8aGVhZD4KKzxz Y3JpcHQgc3JjPSIuLi9odHRwL3Rlc3RzL2luc3BlY3Rvci9pbnNwZWN0b3ItdGVzdDIuanMiPjwv c2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2h0dHAvdGVzdHMvaW5zcGVjdG9yL2NvbnNvbGUtdGVz dHMyLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+CisKK2Z1bmN0aW9uIHRlc3QoKQoreworICAgIElu c3BlY3RvclRlc3QucmVsb2FkUGFnZShmdW5jdGlvbigpIHsKKyAgICAgICAgSW5zcGVjdG9yVGVz dC5leHBhbmRDb25zb2xlTWVzc2FnZXMoKTsKKyAgICAgICAgSW5zcGVjdG9yVGVzdC5kdW1wQ29u c29sZU1lc3NhZ2VzKCk7CisgICAgICAgIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCk7Cisg ICAgfSk7Cit9CisKKword2luZG93LmFkZEV2ZW50TGlzdGVuZXIoImxvYWQiLCBmdW5jdGlvbihl KSB7CisgICAgZnVuY3Rpb24gZigpIHsKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJFeGNlcHRp b24gaW4gJ2xvYWQnIGV2ZW50IGxpc3RlbmVyLiIpCisgICAgfQorICAgIGYoKTsKK30sIGZhbHNl KTsKKworCitzZXRUaW1lb3V0KGZ1bmN0aW9uKCkgeworICAgIGZ1bmN0aW9uIGJhcigpIHsKKyAg ICAgICAgdGhyb3cgbmV3IEVycm9yKCJFeGNlcHRpb24gaW4gc2V0VGltZW91dCBjYWxsYmFjay4i KTsKKyAgICB9CisgICAgYmFyKCk7Cit9LCAwKTsKKworCitmdW5jdGlvbiBhKCkKK3sKKyAgICB0 aHJvdyBuZXcgRXJyb3IoIkV4Y2VwdGlvbiBpbiBpbmxpbmUgc2NyaXB0LiIpCit9CisKK2Z1bmN0 aW9uIGIoKQoreworICAgIGEoKTsKK30KKworYigpOworCis8L3NjcmlwdD4KKzwvaGVhZD4KKwor PGJvZHkgb25sb2FkPSJydW5UZXN0KCkiPgorPHA+CitUZXN0cyB0aGF0IHVuY2F1Z2h0IGV4Y2Vw dGlvbnMgYXJlIGxvZ2dlZCBpbnRvIGNvbnNvbGUuPGEgaHJlZj0iaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MjUwIj5CdWcgNDcyNTAuPC9hPgorPC9wPgorCis8L2Jv ZHk+Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9jaHJvbWl1bS9p bnNwZWN0b3IvY29uc29sZS11bmNhdWdodC1leGNlcHRpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0 VGVzdHMvcGxhdGZvcm0vY2hyb21pdW0vaW5zcGVjdG9yL2NvbnNvbGUtdW5jYXVnaHQtZXhjZXB0 aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDc1NQppbmRleCAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40ZDE5OWYwM2JlY2YxZWFjNDc5M2IxMzFjZmJl NzEyMDRhZTcxNzdjCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vY2hy b21pdW0vaW5zcGVjdG9yL2NvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDEzIEBACitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMzU6IFVuY2F1Z2h0IEVycm9y OiBFeGNlcHRpb24gaW4gaW5saW5lIHNjcmlwdC4NDQorQ09OU09MRSBNRVNTQUdFOiBsaW5lIDE5 OiBVbmNhdWdodCBFcnJvcjogRXhjZXB0aW9uIGluICdsb2FkJyBldmVudCBsaXN0ZW5lci4NDQor Q09OU09MRSBNRVNTQUdFOiBsaW5lIDI3OiBVbmNhdWdodCBFcnJvcjogRXhjZXB0aW9uIGluIHNl dFRpbWVvdXQgY2FsbGJhY2suDQ0KK0NPTlNPTEUgTUVTU0FHRTogbGluZSAzNTogVW5jYXVnaHQg RXJyb3I6IEV4Y2VwdGlvbiBpbiBpbmxpbmUgc2NyaXB0Lg0NCitDT05TT0xFIE1FU1NBR0U6IGxp bmUgMTk6IFVuY2F1Z2h0IEVycm9yOiBFeGNlcHRpb24gaW4gJ2xvYWQnIGV2ZW50IGxpc3RlbmVy Lg0NCitDT05TT0xFIE1FU1NBR0U6IGxpbmUgMjc6IFVuY2F1Z2h0IEVycm9yOiBFeGNlcHRpb24g aW4gc2V0VGltZW91dCBjYWxsYmFjay4NDQorVGVzdHMgdGhhdCB1bmNhdWdodCBleGNlcHRpb25z IGFyZSBsb2dnZWQgaW50byBjb25zb2xlLkJ1ZyA0NzI1MC4NDQorDQ0KK1BhZ2UgcmVsb2FkZWQu DQ0KK2NvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLmh0bWw6MzVVbmNhdWdodCBFcnJvcjogRXhj ZXB0aW9uIGluIGlubGluZSBzY3JpcHQuYWNvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLmh0bWw6 MzViY29uc29sZS11bmNhdWdodC1leGNlcHRpb24uaHRtbDo0MChhbm9ueW1vdXMgZnVuY3Rpb24p Y29uc29sZS11bmNhdWdodC1leGNlcHRpb24uaHRtbDo0Mw0NCitjb25zb2xlLXVuY2F1Z2h0LWV4 Y2VwdGlvbi5odG1sOjE5VW5jYXVnaHQgRXJyb3I6IEV4Y2VwdGlvbiBpbiAnbG9hZCcgZXZlbnQg bGlzdGVuZXIuZmNvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLmh0bWw6MTkoYW5vbnltb3VzIGZ1 bmN0aW9uKWNvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLmh0bWw6MjENDQorY29uc29sZS11bmNh dWdodC1leGNlcHRpb24uaHRtbDoyN1VuY2F1Z2h0IEVycm9yOiBFeGNlcHRpb24gaW4gc2V0VGlt ZW91dCBjYWxsYmFjay5iYXJjb25zb2xlLXVuY2F1Z2h0LWV4Y2VwdGlvbi5odG1sOjI3KGFub255 bW91cyBmdW5jdGlvbiljb25zb2xlLXVuY2F1Z2h0LWV4Y2VwdGlvbi5odG1sOjI5DQ0KKw0NCg== 70342 2010-10-08 22:22:47 -0700 2010-12-20 15:05:22 -0800 [PATCH] General Expected Results test-results.patch text/plain 1150 joepeck ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA4MGU2ZmQ2Li5lNGVjYTc0IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMTAt MDggIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiB0ZXN0IHRo YXQgdW5jYXVnaHQgZXhjZXB0aW9ucyBoYXZlIHN0YWNrIHRyYWNlIHdoZW4gaW5zcGVjdG9yIGlz IG9wZW4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3 MjUwCisKKyAgICAgICAgQ2hlY2sgaW4gZGVmYXVsdCBleHBlY3RlZCByZXN1bHRzIGZvciB0aGUg dGVzdCBhZGRlZCBpbiByNjkxOTA6CisgICAgICAgIGluc3BlY3Rvci9jb25zb2xlLXVuY2F1Z2h0 LWV4Y2VwdGlvbi5odG1sCisKKyAgICAgICAgKiBpbnNwZWN0b3IvY29uc29sZS11bmNhdWdodC1l eGNlcHRpb24tZXhwZWN0ZWQudHh0OiBSZW5hbWVkIGZyb20gTGF5b3V0VGVzdHMvcGxhdGZvcm0v Z3RrL2luc3BlY3Rvci9jb25zb2xlLXVuY2F1Z2h0LWV4Y2VwdGlvbi1leHBlY3RlZC50eHQuCisK IDIwMTAtMTAtMDggIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFNraXAgbW9yZSB0ZXN0cyB3aGljaCBzaG93IGRpZmZlcmVuY2VzIGJldHdlZW4gaTM4 NiBhbmQgeDg2XzY0LiBBbHNvCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsv aW5zcGVjdG9yL2NvbnNvbGUtdW5jYXVnaHQtZXhjZXB0aW9uLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2luc3BlY3Rvci9jb25zb2xlLXVuY2F1Z2h0LWV4Y2VwdGlvbi1leHBlY3RlZC50eHQK c2ltaWxhcml0eSBpbmRleCAxMDAlCnJlbmFtZSBmcm9tIExheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9pbnNwZWN0b3IvY29uc29sZS11bmNhdWdodC1leGNlcHRpb24tZXhwZWN0ZWQudHh0CnJlbmFt ZSB0byBMYXlvdXRUZXN0cy9pbnNwZWN0b3IvY29uc29sZS11bmNhdWdodC1leGNlcHRpb24tZXhw ZWN0ZWQudHh0Cg==