47247 2010-10-05 22:17:10 -0700 [Chromium] WebIDBKeyRange should handle null left/right pointers 2010-10-06 10:21:36 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jorlow jorlow andreip japhet oldest_to_newest 290095 0 jorlow 2010-10-05 22:17:10 -0700 [Chromium] WebIDBKeyRange should handle null left/right pointers 290096 1 69888 jorlow 2010-10-05 22:18:02 -0700 Created attachment 69888 Patch 290351 2 69888 japhet 2010-10-06 09:19:26 -0700 Comment on attachment 69888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review > WebKit/chromium/src/WebIDBKeyRange.cpp:44 > + if (left.type() == WebIDBKey::InvalidType && right.type() == WebIDBKey::InvalidType) Will it ever be the case that only one of these is invalid? LGTM otherwise. 290359 3 69888 jorlow 2010-10-06 09:25:58 -0700 Comment on attachment 69888 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69888&action=review >> WebKit/chromium/src/WebIDBKeyRange.cpp:44 >> + if (left.type() == WebIDBKey::InvalidType && right.type() == WebIDBKey::InvalidType) > > Will it ever be the case that only one of these is invalid? > > LGTM otherwise. Yeah. You can have items that are either left bounded or right bounded (but not both). 290413 4 jorlow 2010-10-06 10:21:36 -0700 Committed r69208: <http://trac.webkit.org/changeset/69208> 69888 2010-10-05 22:18:02 -0700 2010-10-06 09:25:58 -0700 Patch bug-47247-20101006061800.patch text/plain 1976 jorlow ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IGQ4ODRhYjYwYWNkN2Y3YjdmYjcwYTI4MTJhZjA5MGJkNTIzMmJmY2Uu LmE5ZTA1NmM5NTE0NjNlZDBiNDI5NmVlZjdmZTU2MDMzNWZiNmE1YmYgMTAwNjQ0Ci0tLSBhL1dl YktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDEwLTEwLTA1ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtDaHJvbWl1bV0gV2ViSURCS2V5UmFuZ2Ugc2hvdWxkIGhhbmRsZSBudWxsIGxlZnQvcmlnaHQg cG9pbnRlcnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTQ3MjQ3CisKKyAgICAgICAgKiBzcmMvV2ViSURCS2V5UmFuZ2UuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJJREJLZXlSYW5nZTo6YXNzaWduKToKKyAgICAgICAgKFdlYktpdDo6V2ViSURCS2V5 UmFuZ2U6OmxlZnQpOgorICAgICAgICAoV2ViS2l0OjpXZWJJREJLZXlSYW5nZTo6cmlnaHQpOgor ICAgICAgICAoV2ViS2l0OjpXZWJJREJLZXlSYW5nZTo6ZmxhZ3MpOgorCiAyMDEwLTA5LTI5ICBB bHBoYSBMYW0gIDxoY2xhbUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFt ZXMgUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vc3JjL1dlYklEQktleVJh bmdlLmNwcCBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSURCS2V5UmFuZ2UuY3BwCmluZGV4IDRj ZTk0NTIxNjRjZjMxMjVmOWQ4YWYyMmFmZmFiMmEyYTBjMDg3MzIuLjcyMGFmNWZiOTZkYTcxZTkz Yzc5Yjk1ZTEwZDljNjI2ZDM3NjRkN2EgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS9zcmMv V2ViSURCS2V5UmFuZ2UuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS9zcmMvV2ViSURCS2V5UmFu Z2UuY3BwCkBAIC00MSw3ICs0MSwxMCBAQCB2b2lkIFdlYklEQktleVJhbmdlOjphc3NpZ24oY29u c3QgV2ViSURCS2V5UmFuZ2UmIG90aGVyKQogCiB2b2lkIFdlYklEQktleVJhbmdlOjphc3NpZ24o Y29uc3QgV2ViSURCS2V5JiBsZWZ0LCBjb25zdCBXZWJJREJLZXkmIHJpZ2h0LCB1bnNpZ25lZCBz aG9ydCBmbGFncykKIHsKLSAgICBtX3ByaXZhdGUgPSBJREJLZXlSYW5nZTo6Y3JlYXRlKGxlZnQs IHJpZ2h0LCBmbGFncyk7CisgICAgaWYgKGxlZnQudHlwZSgpID09IFdlYklEQktleTo6SW52YWxp ZFR5cGUgJiYgcmlnaHQudHlwZSgpID09IFdlYklEQktleTo6SW52YWxpZFR5cGUpCisgICAgICAg IG1fcHJpdmF0ZSA9IDA7CisgICAgZWxzZQorICAgICAgICBtX3ByaXZhdGUgPSBJREJLZXlSYW5n ZTo6Y3JlYXRlKGxlZnQsIHJpZ2h0LCBmbGFncyk7CiB9CiAKIHZvaWQgV2ViSURCS2V5UmFuZ2U6 OnJlc2V0KCkKQEAgLTUxLDE2ICs1NCwyMiBAQCB2b2lkIFdlYklEQktleVJhbmdlOjpyZXNldCgp CiAKIFdlYklEQktleSBXZWJJREJLZXlSYW5nZTo6bGVmdCgpIGNvbnN0CiB7CisgICAgaWYgKCFt X3ByaXZhdGUuZ2V0KCkpCisgICAgICAgIHJldHVybiBXZWJJREJLZXk6OmNyZWF0ZUludmFsaWQo KTsKICAgICByZXR1cm4gbV9wcml2YXRlLT5sZWZ0KCk7CiB9CiAKIFdlYklEQktleSBXZWJJREJL ZXlSYW5nZTo6cmlnaHQoKSBjb25zdAogeworICAgIGlmICghbV9wcml2YXRlLmdldCgpKQorICAg ICAgICByZXR1cm4gV2ViSURCS2V5OjpjcmVhdGVJbnZhbGlkKCk7CiAgICAgcmV0dXJuIG1fcHJp dmF0ZS0+cmlnaHQoKTsKIH0KIAogdW5zaWduZWQgc2hvcnQgV2ViSURCS2V5UmFuZ2U6OmZsYWdz KCkgY29uc3QKIHsKKyAgICBpZiAoIW1fcHJpdmF0ZS5nZXQoKSkKKyAgICAgICAgcmV0dXJuIDA7 CiAgICAgcmV0dXJuIG1fcHJpdmF0ZS0+ZmxhZ3MoKTsKIH0KIAo=