47242 2010-10-05 19:27:47 -0700 [chromium] DRT assertion w/accel 2D canvas in PlatformContextSkia 2010-10-06 13:22:06 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr webkit-unassigned dpranke jamesr scheib senorblanco vangelis oldest_to_newest 290041 0 kbr 2010-10-05 19:27:47 -0700 fast/canvas/canvas-putImageData.html is failing when run in DRT with --enable-accelerated-compositing --enable-accelerated-2d-canvas due to the following assertion failure: Program received signal SIGSEGV, Segmentation fault. 0x0000000000c331bb in WebCore::PlatformContextSkia::markDirtyRect (this=0x7fffec567900, rect=...) at WebCore/platform/graphics/skia/PlatformContextSkia.cpp:814 814 ASSERT_NOT_REACHED(); (gdb) where #0 0x0000000000c331bb in WebCore::PlatformContextSkia::markDirtyRect (this=0x7fffec567900, rect=...) at WebCore/platform/graphics/skia/PlatformContextSkia.cpp:814 #1 0x0000000000c2aa23 in WebCore::GraphicsContext::markDirtyRect (this=0x7ffff7e92560, rect=...) at WebCore/platform/graphics/skia/GraphicsContextSkia.cpp:1257 #2 0x00000000005f252b in WebCore::CanvasRenderingContext2D::didDraw (this=0x7fffec510420, r=..., options=0) at WebCore/html/canvas/CanvasRenderingContext2D.cpp:1495 #3 0x00000000005f2fb3 in WebCore::CanvasRenderingContext2D::putImageData (this=0x7fffec510420, data=0x7fffec5c85c0, dx=0, dy=0, dirtyX=0, dirtyY=0, dirtyWidth=100, dirtyHeight=100, ec=@0x7fffffffbeac) at WebCore/html/canvas/CanvasRenderingContext2D.cpp:1626 #4 0x00000000005f2bf5 in WebCore::CanvasRenderingContext2D::putImageData (this=0x7fffec510420, data=0x7fffec5c85c0, dx=0, dy=0, ec=@0x7fffffffbeac) at WebCore/html/canvas/CanvasRenderingContext2D.cpp:1585 ... m_backingStoreState is None at this point. 290051 1 jamesr 2010-10-05 20:03:10 -0700 The issue is we aren't calling prepareForSoftwareDraw() before doing the putImageData. Patch incoming. 290060 2 69879 jamesr 2010-10-05 20:20:52 -0700 Created attachment 69879 Patch 290418 3 senorblanco 2010-10-06 10:28:32 -0700 (In reply to comment #2) > Created an attachment (id=69879) [details] > Patch Looks good, but I'm not a reviewer. 290430 4 69879 kbr 2010-10-06 10:39:13 -0700 Comment on attachment 69879 Patch Looks good to me. 290541 5 jamesr 2010-10-06 13:22:06 -0700 Committed r69227: <http://trac.webkit.org/changeset/69227> 69879 2010-10-05 20:20:52 -0700 2010-10-06 10:39:13 -0700 Patch bug-47242-20101005202051.patch text/plain 1567 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWZkZTU2OTNhNDY0MzAxZjRlZGI3Nzk0MjViMjMwYjhkMzAxM2I4YS4uMjExNDJhZDU0MjVjODQx ZGU0NTU3ZDI3NmIzOTA5OTUzYmFkY2UxYiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0wNSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gRFJUIGFzc2VydGlvbiB3L2Fj Y2VsIDJEIGNhbnZhcyBpbiBQbGF0Zm9ybUNvbnRleHRTa2lhCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00NzI0MgorCisgICAgICAgIENhbGwgUGxhdGZv cm1Db250ZXh0U2tpYTo6cHJlcGFyZUZvclNvZnR3YXJlRHJhdyBiZWZvcmUgZG9pbmcgcHV0SW1h Z2VEYXRhCisgICAgICAgIHNpbmNlIHRoYXQgY2FsbCBtdXRhdGVzIHRoZSBzb2Z0d2FyZSBiYWNr aW5nIHN0b3JlLgorCisgICAgICAgIFRlc3Q6IGZhc3QvY2FudmFzL2NhbnZhcy1wdXRJbWFnZURh dGEuaHRtbAorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNr aWEuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SW1hZ2VCdWZmZXI6OnB1dFVubXVsdGlwbGllZElt YWdlRGF0YSk6CisKIDIwMTAtMTAtMDUgIEZhZHkgU2FtdWVsICA8ZnNhbXVlbEBjaHJvbWl1bS5v cmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3NraWEvSW1hZ2VCdWZmZXJTa2lhLmNwcCBiL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3Mvc2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCmluZGV4IDJiZTdkYzU3 YTYyZjBjMDgyMjlhYjdjY2I5MjNhYjFhZDIxNzVmNjUuLmU4MTZmODU3N2VmNmYzMDI3YzcyMWNi MDlkN2MyMWZkNzcyMWViYzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv c2tpYS9JbWFnZUJ1ZmZlclNraWEuY3BwCkBAIC0yOTAsNiArMjkwLDcgQEAgdm9pZCBwdXRJbWFn ZURhdGEoSW1hZ2VEYXRhKiYgc291cmNlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBjb25z dCBJbnRQb2ludCYKIAogdm9pZCBJbWFnZUJ1ZmZlcjo6cHV0VW5tdWx0aXBsaWVkSW1hZ2VEYXRh KEltYWdlRGF0YSogc291cmNlLCBjb25zdCBJbnRSZWN0JiBzb3VyY2VSZWN0LCBjb25zdCBJbnRQ b2ludCYgZGVzdFBvaW50KQogeworICAgIGNvbnRleHQoKS0+cGxhdGZvcm1Db250ZXh0KCktPnBy ZXBhcmVGb3JTb2Z0d2FyZURyYXcoKTsKICAgICBwdXRJbWFnZURhdGE8VW5tdWx0aXBsaWVkPihz b3VyY2UsIHNvdXJjZVJlY3QsIGRlc3RQb2ludCwgKmNvbnRleHQoKS0+cGxhdGZvcm1Db250ZXh0 KCktPmJpdG1hcCgpLCBtX3NpemUpOwogfQogCg==