47241 2010-10-05 19:24:00 -0700 [chromium] DRT crash in fast/canvas tests w/accel 2D canvas due to NULL DrawingBuffer 2010-10-11 15:10:15 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr jamesr dpranke jamesr scheib senorblanco vangelis oldest_to_newest 290040 0 kbr 2010-10-05 19:24:00 -0700 The following test cases in fast/canvas are failing in DRT when run with --enable-accelerated-compositing --enable-accelerated-2d-canvas due to a NULL m_drawingBuffer in CanvasRenderingContext2D. The reason is that drawingContext() is NULL when the CanvasRenderingContext2D is created, so the drawing buffer is never initialized. fast/canvas/access-zero-sized-canvas.html fast/canvas/canvas-skia-excessive-size.html fast/canvas/toDataURL-noData.html 290063 1 69880 jamesr 2010-10-05 20:31:00 -0700 Created attachment 69880 Patch 290065 2 jamesr 2010-10-05 20:32:19 -0700 Patch flips around the logic so we don't touch m_context3d or m_drawingBuffer if there's no drawingContext(), which makes sense since if there is no drawingBuffer() we won't be doing any software draws either. This also means that <canvas> elements that are zero sized or excessively large will not get composited layers since canvas layers are only set if CanvasRenderingContext2D::isAccelerated() is true which checks m_context3d. 290423 3 69880 senorblanco 2010-10-06 10:32:48 -0700 Comment on attachment 69880 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69880&action=review Looks good. > WebCore/html/canvas/CanvasRenderingContext2D.cpp:171 > + if (m_context3D) { Nit: Could use && and a single if (although it'd probably need more parens around the =; your call). 290428 4 69880 kbr 2010-10-06 10:38:05 -0700 Comment on attachment 69880 Patch Looks fine to me. 292685 5 69880 jamesr 2010-10-11 15:04:21 -0700 Comment on attachment 69880 Patch I thought this had already landed - whoops! 292689 6 69880 jamesr 2010-10-11 15:10:10 -0700 Comment on attachment 69880 Patch Clearing flags on attachment: 69880 Committed r69529: <http://trac.webkit.org/changeset/69529> 292691 7 jamesr 2010-10-11 15:10:15 -0700 All reviewed patches have been landed. Closing bug. 69880 2010-10-05 20:31:00 -0700 2010-10-11 15:10:10 -0700 Patch bug-47241-20101005203059.patch text/plain 2673 jamesr ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWZkZTU2OTNhNDY0MzAxZjRlZGI3Nzk0MjViMjMwYjhkMzAxM2I4YS4uMmFlNzMxYzg4MzQxYzM5 OTdhNDIxNDJiYmYzNjJiM2UyNjRkYTZlMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxMC0xMC0wNSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gRFJUIGNyYXNoIGluIGZhc3Qv Y2FudmFzIHRlc3RzIHcvYWNjZWwgMkQgY2FudmFzIGR1ZSB0byBOVUxMIERyYXdpbmdCdWZmZXIK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MjQxCisK KyAgICAgICAgQXZvaWQgaW5pdGlhbGl6aW5nIGFjY2VsZXJhdGVkIGdyYXBoaWNzIG9iamVjdHMg b24gQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJECisgICAgICAgIGlmIHRoZXJlIGlzIG5vIGRyYXdp bmdDb250ZXh0IGFzc29jaWF0ZWQgd2l0aCB0aGUgY2FudmFzLgorCisgICAgICAgIFRlc3Q6IGZh c3QvY2FudmFzL2FjY2Vzcy16ZXJvLXNpemVkLWNhbnZhcy5odG1sCisgICAgICAgICAgICAgIGZh c3QvY2FudmFzL2NhbnZhcy1za2lhLWV4Y2Vzc2l2ZS1zaXplLmh0bWwKKyAgICAgICAgICAgICAg ZmFzdC9jYW52YXMvdG9EYXRhVVJMLW5vRGF0YS5odG1sCisgICAgICAgIHdpdGggLS1hY2NlbGVy YXRlZC1jb21wb3NpdGluZyBhbmQgLS1hY2NlbGVyYXRlZC0yZC1jYW52YXMKKworICAgICAgICAq IGh0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQyRC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyRCk6 CisgICAgICAgIChXZWJDb3JlOjpDYW52YXNSZW5kZXJpbmdDb250ZXh0MkQ6OnJlc2V0KToKKwog MjAxMC0xMC0wNSAgRmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9jYW52 YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcCBiL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2Fu dmFzUmVuZGVyaW5nQ29udGV4dDJELmNwcAppbmRleCBlYmVmNTA3ZTFmN2MwOWNmYTE1NDc2OTIy NWQ5MTRhNjc0ZTQ3NjdkLi41ZjRiNGI3YWUyNWFkMDM5NGFkZGY0ZTZiYmU4MzZiMTQwMjAyYjJh IDEwMDY0NAotLS0gYS9XZWJDb3JlL2h0bWwvY2FudmFzL0NhbnZhc1JlbmRlcmluZ0NvbnRleHQy RC5jcHAKKysrIGIvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkQu Y3BwCkBAIC0xMjgsOSArMTI4LDkgQEAgQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEOjpDYW52YXNS ZW5kZXJpbmdDb250ZXh0MkQoSFRNTENhbnZhc0VsZW1lbnQqIGNhbnZhcywgYm8KICAgICAgICAg cmV0dXJuOwogICAgIGlmICghcC0+c2V0dGluZ3MoKS0+YWNjZWxlcmF0ZWQyZENhbnZhc0VuYWJs ZWQoKSkKICAgICAgICAgcmV0dXJuOwotICAgIG1fY29udGV4dDNEID0gcC0+c2hhcmVkR3JhcGhp Y3NDb250ZXh0M0QoKTsKLSAgICBpZiAobV9jb250ZXh0M0QpIHsKLSAgICAgICAgaWYgKEdyYXBo aWNzQ29udGV4dCogYyA9IGRyYXdpbmdDb250ZXh0KCkpIHsKKyAgICBpZiAoR3JhcGhpY3NDb250 ZXh0KiBjID0gZHJhd2luZ0NvbnRleHQoKSkgeworICAgICAgICBtX2NvbnRleHQzRCA9IHAtPnNo YXJlZEdyYXBoaWNzQ29udGV4dDNEKCk7CisgICAgICAgIGlmIChtX2NvbnRleHQzRCkgewogICAg ICAgICAgICAgbV9kcmF3aW5nQnVmZmVyID0gRHJhd2luZ0J1ZmZlcjo6Y3JlYXRlKG1fY29udGV4 dDNELmdldCgpLCBJbnRTaXplKGNhbnZhcy0+d2lkdGgoKSwgY2FudmFzLT5oZWlnaHQoKSkpOwog ICAgICAgICAgICAgYy0+c2V0U2hhcmVkR3JhcGhpY3NDb250ZXh0M0QobV9jb250ZXh0M0QuZ2V0 KCksIG1fZHJhd2luZ0J1ZmZlci5nZXQoKSwgSW50U2l6ZShjYW52YXMtPndpZHRoKCksIGNhbnZh cy0+aGVpZ2h0KCkpKTsKICAgICAgICAgfQpAQCAtMTY3LDggKzE2Nyw4IEBAIHZvaWQgQ2FudmFz UmVuZGVyaW5nQ29udGV4dDJEOjpyZXNldCgpCiAgICAgbV9zdGF0ZVN0YWNrLmZpcnN0KCkgPSBT dGF0ZSgpOwogICAgIG1fcGF0aC5jbGVhcigpOwogI2lmIEVOQUJMRShBQ0NFTEVSQVRFRF8yRF9D QU5WQVMpCi0gICAgaWYgKG1fY29udGV4dDNEKSB7Ci0gICAgICAgIGlmIChHcmFwaGljc0NvbnRl eHQqIGMgPSBkcmF3aW5nQ29udGV4dCgpKSB7CisgICAgaWYgKEdyYXBoaWNzQ29udGV4dCogYyA9 IGRyYXdpbmdDb250ZXh0KCkpIHsKKyAgICAgICAgaWYgKG1fY29udGV4dDNEKSB7CiAgICAgICAg ICAgICBtX2RyYXdpbmdCdWZmZXItPnJlc2V0KEludFNpemUoY2FudmFzKCktPndpZHRoKCksIGNh bnZhcygpLT5oZWlnaHQoKSkpOwogICAgICAgICAgICAgYy0+c2V0U2hhcmVkR3JhcGhpY3NDb250 ZXh0M0QobV9jb250ZXh0M0QuZ2V0KCksIG1fZHJhd2luZ0J1ZmZlci5nZXQoKSwgSW50U2l6ZShj YW52YXMoKS0+d2lkdGgoKSwgY2FudmFzKCktPmhlaWdodCgpKSk7CiAgICAgICAgIH0K