47234 2010-10-05 17:48:02 -0700 [BREWMP] Translate key code in PlatformKeyboardEvent with IKeysMapping 2010-10-05 20:58:33 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Other RESOLVED FIXED P2 Normal --- 33564 0 maniagoon webkit-unassigned commit-queue skyul oldest_to_newest 290000 0 maniagoon 2010-10-05 17:48:02 -0700 Brew MP devices have a variey of key configurations and use modifiers to input capital letters, symbols and special characters. Use IKeysMapping to translate key code. 290001 1 69871 maniagoon 2010-10-05 17:50:26 -0700 Created attachment 69871 Patch 290012 2 skyul 2010-10-05 18:07:30 -0700 IKeysMapping maps an AVK key code and modifier combination to the intended character. For example, AVK_RALT + 'e' becomes 1 and AVK_LSHIFT + 'a' becomes 'A' in a certain device. Because kep mappings are different among devices, we need IKeysMapping abstraction. 290030 3 69871 tkent 2010-10-05 18:35:55 -0700 Comment on attachment 69871 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69871&action=review > WebCore/platform/brew/PlatformKeyboardEventBrew.cpp:160 > + if ((m_type == Char) && modifiers) { nit: Checking "m_type" and checking "type" are mixed in the constructor. It's confusing. 290079 4 69871 commit-queue 2010-10-05 20:58:28 -0700 Comment on attachment 69871 Patch Clearing flags on attachment: 69871 Committed r69175: <http://trac.webkit.org/changeset/69175> 290080 5 commit-queue 2010-10-05 20:58:33 -0700 All reviewed patches have been landed. Closing bug. 69871 2010-10-05 17:50:26 -0700 2010-10-05 20:58:28 -0700 Patch mapping.patch text/plain 3314 maniagoon SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTE2MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMDUgIEt5dXN1biBLaW0gIDxtYW5pYWdvb25AY29tcGFu eTEwMC5uZXQ+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgW0JSRVdNUF0gVHJhbnNsYXRlIGtleSBjb2RlIGluIFBsYXRmb3JtS2V5Ym9hcmRFdmVudCB3 aXRoIElLZXlzTWFwcGluZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9NDcyMzQKKworICAgICAgICBCcmV3IE1QIGRldmljZXMgaGF2ZSBhIHZhcmlleSBv ZiBrZXkgY29uZmlndXJhdGlvbnMgYW5kIHVzZSBtb2RpZmllcnMgdG8KKyAgICAgICAgaW5wdXQg Y2FwaXRhbCBsZXR0ZXJzLCBzeW1ib2xzIGFuZCBzcGVjaWFsIGNoYXJhY3RlcnMuIFVzZSBJS2V5 c01hcHBpbmcgdG8gdHJhbnNsYXRlIGtleSBjb2RlLgorCisgICAgICAgICogcGxhdGZvcm0vYnJl dy9QbGF0Zm9ybUtleWJvYXJkRXZlbnRCcmV3LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlBsYXRm b3JtS2V5Ym9hcmRFdmVudDo6UGxhdGZvcm1LZXlib2FyZEV2ZW50KToKKwogMjAxMC0xMC0wNSAg RmFkeSBTYW11ZWwgIDxmc2FtdWVsQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vYnJldy9QbGF0Zm9ybUtleWJv YXJkRXZlbnRCcmV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2JyZXcvUGxh dGZvcm1LZXlib2FyZEV2ZW50QnJldy5jcHAJKHJldmlzaW9uIDY5MTYyKQorKysgV2ViQ29yZS9w bGF0Zm9ybS9icmV3L1BsYXRmb3JtS2V5Ym9hcmRFdmVudEJyZXcuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0zMCw5ICszMCwxNCBAQAogI2luY2x1ZGUgIldpbmRvd3NLZXlib2FyZENvZGVzLmgiCiAK ICNpbmNsdWRlIDxBRUVFdmVudC5oPgorI2luY2x1ZGUgPEFFRUlLZXlzTWFwcGluZy5oPgorI2lu Y2x1ZGUgPEFFRUtleXNNYXBwaW5nLmJpZD4KICNpbmNsdWRlIDxBRUVTdGREZWYuaD4KICNpbmNs dWRlIDxBRUVWQ29kZXMuaD4KIAorI2luY2x1ZGUgPHd0Zi9icmV3L1JlZlB0ckJyZXcuaD4KKyNp bmNsdWRlIDx3dGYvYnJldy9TaGVsbEJyZXcuaD4KKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBz dGF0aWMgU3RyaW5nIGtleUlkZW50aWZpZXJGb3JCcmV3S2V5Q29kZSh1aW50MTYga2V5Q29kZSkK QEAgLTE0OCwxOCArMTUzLDI1IEBAIHN0YXRpYyBpbmxpbmUgU3RyaW5nIHNpbmdsZUNoYXJhY3Rl clN0cmkKIAogUGxhdGZvcm1LZXlib2FyZEV2ZW50OjpQbGF0Zm9ybUtleWJvYXJkRXZlbnQoQUVF RXZlbnQgZXZlbnQsIHVpbnQxNiBjb2RlLCB1aW50MzIgbW9kaWZpZXJzLCBUeXBlIHR5cGUpCiAg ICAgOiBtX3R5cGUodHlwZSkKLSAgICAsIG1fdGV4dCgodHlwZSA9PSBDaGFyKSA/IHNpbmdsZUNo YXJhY3RlclN0cmluZyhjb2RlKSA6IFN0cmluZygpKQotICAgICwgbV91bm1vZGlmaWVkVGV4dCgo dHlwZSA9PSBDaGFyKSA/IHNpbmdsZUNoYXJhY3RlclN0cmluZyhjb2RlKSA6IFN0cmluZygpKQot ICAgICwgbV9rZXlJZGVudGlmaWVyKCh0eXBlID09IENoYXIpID8gU3RyaW5nKCkgOiBrZXlJZGVu dGlmaWVyRm9yQnJld0tleUNvZGUoY29kZSkpCi0gICAgLCBtX2F1dG9SZXBlYXQobW9kaWZpZXJz ICYgS0JfQVVUT1JFUEVBVCkKLSAgICAsIG1fd2luZG93c1ZpcnR1YWxLZXlDb2RlKCh0eXBlID09 IFJhd0tleURvd24gfHwgdHlwZSA9PSBLZXlVcCkgPyB3aW5kb3dzS2V5Q29kZUZvcktleUV2ZW50 KGNvZGUpIDogMCkKLSAgICAsIG1fbmF0aXZlVmlydHVhbEtleUNvZGUoY29kZSkKICAgICAsIG1f aXNLZXlwYWQoZmFsc2UpCi0gICAgLCBtX3NoaWZ0S2V5KG1vZGlmaWVycyAmIChLQl9MU0hJRlQg fCBLQl9SU0hJRlQpKQotICAgICwgbV9jdHJsS2V5KG1vZGlmaWVycyAmIChLQl9MQ1RSTCB8IEtC X1JDVFJMKSkKLSAgICAsIG1fYWx0S2V5KG1vZGlmaWVycyAmIChLQl9MQUxUIHwgS0JfUkFMVCkp CiAgICAgLCBtX21ldGFLZXkoZmFsc2UpCisgICAgLCBtX3dpbmRvd3NWaXJ0dWFsS2V5Q29kZSgo dHlwZSA9PSBSYXdLZXlEb3duIHx8IHR5cGUgPT0gS2V5VXApID8gd2luZG93c0tleUNvZGVGb3JL ZXlFdmVudChjb2RlKSA6IDApCiB7CisgICAgaWYgKChtX3R5cGUgPT0gQ2hhcikgJiYgbW9kaWZp ZXJzKSB7CisgICAgICAgIFBsYXRmb3JtUmVmUHRyPElLZXlzTWFwcGluZz4ga2V5c01hcHBpbmcg PSBjcmVhdGVSZWZQdHJJbnN0YW5jZTxJS2V5c01hcHBpbmc+KEFFRUNMU0lEX0tleXNNYXBwaW5n KTsKKyAgICAgICAgaW50IHJlc3VsdCA9IElLZXlzTWFwcGluZ19HZXRNYXBwaW5nKGtleXNNYXBw aW5nLmdldCgpLCBjb2RlLCBtb2RpZmllcnMsIHJlaW50ZXJwcmV0X2Nhc3Q8QUVDSEFSKj4oJmNv ZGUpKTsKKyAgICAgICAgaWYgKHJlc3VsdCA9PSBBRUVfU1VDQ0VTUykgLy8gUmVzZXQgdGhlIG1v ZGlmaWVyIHdoZW4ga2V5IGNvZGUgaXMgc3VjY2Vzc2Z1bGx5IG1hcHBlZC4KKyAgICAgICAgICAg IG1vZGlmaWVycyA9IDA7CisgICAgfQorCisgICAgbV90ZXh0ID0gKHR5cGUgPT0gQ2hhcikgPyBz aW5nbGVDaGFyYWN0ZXJTdHJpbmcoY29kZSkgOiBTdHJpbmcoKTsKKyAgICBtX3VubW9kaWZpZWRU ZXh0ID0gKHR5cGUgPT0gQ2hhcikgPyBzaW5nbGVDaGFyYWN0ZXJTdHJpbmcoY29kZSkgOiBTdHJp bmcoKTsKKyAgICBtX2tleUlkZW50aWZpZXIgPSAodHlwZSA9PSBDaGFyKSA/IFN0cmluZygpIDog a2V5SWRlbnRpZmllckZvckJyZXdLZXlDb2RlKGNvZGUpOworICAgIG1fbmF0aXZlVmlydHVhbEtl eUNvZGUgPSBjb2RlOworICAgIG1fYXV0b1JlcGVhdCA9IG1vZGlmaWVycyAmIEtCX0FVVE9SRVBF QVQ7CisgICAgbV9zaGlmdEtleSA9IG1vZGlmaWVycyAmIChLQl9MU0hJRlQgfCBLQl9SU0hJRlQp OworICAgIG1fY3RybEtleSA9IG1vZGlmaWVycyAmIChLQl9MQ1RSTCB8IEtCX1JDVFJMKTsKKyAg ICBtX2FsdEtleSA9IG1vZGlmaWVycyAmIChLQl9MQUxUIHwgS0JfUkFMVCk7CiB9CiAKIHZvaWQg UGxhdGZvcm1LZXlib2FyZEV2ZW50OjpkaXNhbWJpZ3VhdGVLZXlEb3duRXZlbnQoVHlwZSB0eXBl LCBib29sKQo=