47228 2010-10-05 16:28:40 -0700 fix the link to the expected image on windows 2010-10-05 20:39:06 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony tony commit-queue dpranke oldest_to_newest 289965 0 tony 2010-10-05 16:28:40 -0700 fix the link to the expected image on windows 289966 1 69864 tony 2010-10-05 16:29:22 -0700 Created attachment 69864 Patch 289967 2 tony 2010-10-05 16:30:17 -0700 The link in the results.html file always results in a broken image on Windows. 289971 3 69864 dpranke 2010-10-05 16:47:25 -0700 Comment on attachment 69864 Patch patch LGTM. 290050 4 69864 dpranke 2010-10-05 19:59:36 -0700 Comment on attachment 69864 Patch hmm ... looks like another case where some sort of integration test would be useful to verify that we are actually writing the file and it's showing up properly. Otherwise, LGTM (after the fact ...) 290067 5 69864 commit-queue 2010-10-05 20:39:02 -0700 Comment on attachment 69864 Patch Clearing flags on attachment: 69864 Committed r69171: <http://trac.webkit.org/changeset/69171> 290068 6 commit-queue 2010-10-05 20:39:06 -0700 All reviewed patches have been landed. Closing bug. 69864 2010-10-05 16:29:22 -0700 2010-10-05 20:39:01 -0700 Patch bug-47228-20101005162932.patch text/plain 1805 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkNmQ1YTFmNjljOGVlMjA0MDVhMmI0YmVkNTM2YzY4NDRjMDdkNzA3Li44NzQ5MjYx YTJiZDRmMjU0MGVlOTMyNmU4OTM1NjYwYjJhMzljYjczIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTYgQEAK IDIwMTAtMTAtMDUgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBmaXggdGhlIGxpbmsgdG8gdGhl IGV4cGVjdGVkIGltYWdlIG9uIHdpbmRvd3MKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTQ3MjI4CisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy90ZXN0X3R5cGVzL3Rlc3RfdHlwZV9iYXNlLnB5OiBPbgorICAgICAgICAgICAg d2luZG93cywgdGhlIGZpbGUgbXVzdCBiZSBvcGVuZWQgaW4gYmluYXJ5IG1vZGUgd2hlbiB3cml0 aW5nCisgICAgICAgICAgICBiaW5hcnkgZGF0YS4KKworMjAxMC0xMC0wNSAgVG9ueSBDaGFuZyAg PHRvbnlAY2hyb21pdW0ub3JnPgorCiAgICAgICAgIFVucmV2aWV3ZWQsIG1ha2Ugc2h1dGlsLnJt dHJlZSBtb3JlIHJlc2lsaWFudCB0byBlcnJvcnMKICAgICAgICAgc2luY2Ugd2luZG93cyB3YXMg cmFpc2luZyBXaW5kb3dzRXJyb3I6IFRoZSBwcm9jZXNzIGNhbm5vdCBhY2Nlc3MgdGhlIGZpbGUg YmVjYXVzZSBpdAogICAgICAgICBpcyBiZWluZyB1c2VkIGJ5IGFub3RoZXIgcHJvY2Vzcy4KZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3Rlc3Rf dHlwZXMvdGVzdF90eXBlX2Jhc2UucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xh eW91dF90ZXN0cy90ZXN0X3R5cGVzL3Rlc3RfdHlwZV9iYXNlLnB5CmluZGV4IDNhNmU5MmI3ZDUz M2JjOTA2MGU5NDg5MGQ0NDJjMzVhMTJjZWNjYmIuLmRjYzY0YTM1YjMzOWRmOTg4MGFhYzA1Mzhm N2U4NTU5NzI1ODBiMTMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv bGF5b3V0X3Rlc3RzL3Rlc3RfdHlwZXMvdGVzdF90eXBlX2Jhc2UucHkKKysrIGIvV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvdGVzdF90eXBlcy90ZXN0X3R5cGVfYmFz ZS5weQpAQCAtMTYxLDcgKzE2MSwxMCBAQCBjbGFzcyBUZXN0VHlwZUJhc2Uob2JqZWN0KToKICAg ICBkZWYgX3dyaXRlX2ludG9fZmlsZV9hdF9wYXRoKHNlbGYsIGZpbGVfcGF0aCwgY29udGVudHMs IGVuY29kaW5nKToKICAgICAgICAgIiIiVGhpcyBtZXRob2QgYXNzdW1lcyB0aGF0IGJ5dGVfYXJy YXkgaXMgYWxyZWFkeSBlbmNvZGVkCiAgICAgICAgIGludG8gdGhlIHJpZ2h0IGZvcm1hdC4iIiIK LSAgICAgICAgd2l0aCBjb2RlY3Mub3BlbihmaWxlX3BhdGgsICJ3IiwgZW5jb2Rpbmc9ZW5jb2Rp bmcpIGFzIGZpbGU6CisgICAgICAgIG9wZW5fbW9kZSA9ICd3JworICAgICAgICBpZiBlbmNvZGlu ZyBpcyBOb25lOgorICAgICAgICAgICAgb3Blbl9tb2RlID0gJ3crYicKKyAgICAgICAgd2l0aCBj b2RlY3Mub3BlbihmaWxlX3BhdGgsIG9wZW5fbW9kZSwgZW5jb2Rpbmc9ZW5jb2RpbmcpIGFzIGZp bGU6CiAgICAgICAgICAgICBmaWxlLndyaXRlKGNvbnRlbnRzKQogCiAgICAgZGVmIHdyaXRlX291 dHB1dF9maWxlcyhzZWxmLCBmaWxlbmFtZSwgZmlsZV90eXBlLAo=