47216 2010-10-05 14:48:50 -0700 [chromium] Implement layerTreeAsText in DumpRenderTree 2010-10-05 16:00:50 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr kbr dpranke enne fishd jamesr tkent vangelis oldest_to_newest 289903 0 kbr 2010-10-05 14:48:50 -0700 Several of the compositing layout tests rely on LayoutTestController.layerTreeAsText(), which is not currently implemented in DumpRenderTree. 289905 1 69850 kbr 2010-10-05 14:52:58 -0700 Created attachment 69850 Patch From the ChangeLog: Plumbed Frame::layerTreeAsText through Chromium's WebKit API to make it callable from DumpRenderTree. No new tests; verified with existing compositor layout tests. 289909 2 69850 tony 2010-10-05 15:00:21 -0700 Comment on attachment 69850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review > WebKit/chromium/public/WebFrame.h:554 > + virtual WebString layerTreeAsText() const = 0; Nit: Please document this method with a comment. 289912 3 kbr 2010-10-05 15:08:47 -0700 (In reply to comment #2) > (From update of attachment 69850 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review > > > WebKit/chromium/public/WebFrame.h:554 > > + virtual WebString layerTreeAsText() const = 0; > > Nit: Please document this method with a comment. Will add comment during landing. 289913 4 kbr 2010-10-05 15:11:52 -0700 Committed r69151: <http://trac.webkit.org/changeset/69151> 289937 5 69850 fishd 2010-10-05 15:45:57 -0700 Comment on attachment 69850 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review >>> WebKit/chromium/public/WebFrame.h:554 >>> + virtual WebString layerTreeAsText() const = 0; >> >> Nit: Please document this method with a comment. > > Will add comment during landing. nit: please preserve the new line before the "protected:" label 289950 6 kbr 2010-10-05 16:00:50 -0700 (In reply to comment #5) > (From update of attachment 69850 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69850&action=review > > >>> WebKit/chromium/public/WebFrame.h:554 > >>> + virtual WebString layerTreeAsText() const = 0; > >> > >> Nit: Please document this method with a comment. > > > > Will add comment during landing. > > nit: please preserve the new line before the "protected:" label Newline re-added in r69157. 69850 2010-10-05 14:52:58 -0700 2010-10-05 15:45:57 -0700 Patch layer-tree-as-text.patch text/plain 5454 kbr SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2No cm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNjkxNTApCisrKyBXZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAtMDUgIEtlbm5l dGggUnVzc2VsbCAgPGtickBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gSW1wbGVtZW50IGxheWVyVHJlZUFzVGV4 dCBpbiBEdW1wUmVuZGVyVHJlZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9NDcyMTYKKworICAgICAgICBQbHVtYmVkIEZyYW1lOjpsYXllclRyZWVBc1Rl eHQgdGhyb3VnaCBDaHJvbWl1bSdzIFdlYktpdCBBUEkgdG8KKyAgICAgICAgbWFrZSBpdCBjYWxs YWJsZSBmcm9tIER1bXBSZW5kZXJUcmVlLgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgdmVyaWZp ZWQgd2l0aCBleGlzdGluZyBjb21wb3NpdG9yIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIHB1 YmxpYy9XZWJGcmFtZS5oOgorICAgICAgICAqIHNyYy9XZWJGcmFtZUltcGwuY3BwOgorICAgICAg ICAoV2ViS2l0OjpXZWJGcmFtZUltcGw6OmxheWVyVHJlZUFzVGV4dCk6CisgICAgICAgICogc3Jj L1dlYkZyYW1lSW1wbC5oOgorCiAyMDEwLTEwLTA1ICBBbmRyZXcgV2lsc29uICA8YXR3aWxzb25A Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFuZHJlYXMgS2xpbmcuCkluZGV4 OiBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkZyYW1lLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJGcmFtZS5oCShyZXZpc2lvbiA2OTE0MykKKysrIFdlYktpdC9j aHJvbWl1bS9wdWJsaWMvV2ViRnJhbWUuaAkod29ya2luZyBjb3B5KQpAQCAtNTUwLDYgKzU1MCw4 IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgcGF1c2VTVkdBbmltYXRpb24oY29uc3QgV2Vi U3RyaW5nJiBhbmltYXRpb25JZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ZG91YmxlIHRpbWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdl YlN0cmluZyYgZWxlbWVudElkKSA9IDA7CisKKyAgICB2aXJ0dWFsIFdlYlN0cmluZyBsYXllclRy ZWVBc1RleHQoKSBjb25zdCA9IDA7CiBwcm90ZWN0ZWQ6CiAgICAgfldlYkZyYW1lKCkgeyB9CiB9 OwpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJGcmFtZUltcGwuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViRnJhbWVJbXBsLmNwcAkocmV2aXNpb24gNjkxNDMp CisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE3NzAsNiArMTc3MCwxMyBAQCBib29sIFdlYkZyYW1lSW1wbDo6cGF1c2VTVkdBbmltYXRp b24oY29uCiAjZW5kaWYKIH0KIAorV2ViU3RyaW5nIFdlYkZyYW1lSW1wbDo6bGF5ZXJUcmVlQXNU ZXh0KCkgY29uc3QKK3sKKyAgICBpZiAoIW1fZnJhbWUpCisgICAgICAgIHJldHVybiBXZWJTdHJp bmcoKTsKKyAgICByZXR1cm4gV2ViU3RyaW5nKG1fZnJhbWUtPmxheWVyVHJlZUFzVGV4dCgpKTsK K30KKwogLy8gV2ViRnJhbWVJbXBsIHB1YmxpYyAtLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIAogUGFzc1JlZlB0cjxXZWJGcmFtZUltcGw+ IFdlYkZyYW1lSW1wbDo6Y3JlYXRlKFdlYkZyYW1lQ2xpZW50KiBjbGllbnQpCkluZGV4OiBXZWJL aXQvY2hyb21pdW0vc3JjL1dlYkZyYW1lSW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViRnJhbWVJbXBsLmgJKHJldmlzaW9uIDY5MTQzKQorKysgV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJGcmFtZUltcGwuaAkod29ya2luZyBjb3B5KQpAQCAtMTkwLDYgKzE5MCw3IEBA IHB1YmxpYzoKICAgICB2aXJ0dWFsIGJvb2wgcGF1c2VTVkdBbmltYXRpb24oY29uc3QgV2ViU3Ry aW5nJiBhbmltYXRpb25JZCwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZG91 YmxlIHRpbWUsCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0IFdlYlN0 cmluZyYgZWxlbWVudElkKTsKKyAgICB2aXJ0dWFsIFdlYlN0cmluZyBsYXllclRyZWVBc1RleHQo KSBjb25zdDsKIAogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFdlYkZyYW1lSW1wbD4gY3JlYXRlKFdl YkZyYW1lQ2xpZW50KiBjbGllbnQpOwogICAgIH5XZWJGcmFtZUltcGwoKTsKSW5kZXg6IFdlYktp dFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDY5MTUwKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMjAgQEAKKzIwMTAtMTAtMDUgIEtlbm5ldGggUnVzc2VsbCAgPGtickBnb29nbGUu Y29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gSW1wbGVtZW50IGxheWVyVHJlZUFzVGV4dCBpbiBEdW1wUmVuZGVyVHJlZQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcyMTYKKworICAg ICAgICBQbHVtYmVkIEZyYW1lOjpsYXllclRyZWVBc1RleHQgdGhyb3VnaCBDaHJvbWl1bSdzIFdl YktpdCBBUEkgdG8KKyAgICAgICAgbWFrZSBpdCBjYWxsYWJsZSBmcm9tIER1bXBSZW5kZXJUcmVl LgorCisgICAgICAgIE5vIG5ldyB0ZXN0czsgdmVyaWZpZWQgd2l0aCBleGlzdGluZyBjb21wb3Np dG9yIGxheW91dCB0ZXN0cy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xh eW91dFRlc3RDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjpM YXlvdXRUZXN0Q29udHJvbGxlcik6CisgICAgICAgIChMYXlvdXRUZXN0Q29udHJvbGxlcjo6bGF5 ZXJUcmVlQXNUZXh0KToKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRU ZXN0Q29udHJvbGxlci5oOgorCiAyMDEwLTEwLTA1ICBCcmVudCBGdWxnaGFtICA8YmZ1bGdoYW1A d2Via2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGNvcnJlY3Rpb24uCkluZGV4 OiBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJvbGxl ci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0v TGF5b3V0VGVzdENvbnRyb2xsZXIuY3BwCShyZXZpc2lvbiA2OTEyMikKKysrIFdlYktpdFRvb2xz L0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL0xheW91dFRlc3RDb250cm9sbGVyLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTA2LDYgKzEwNiw3IEBAIExheW91dFRlc3RDb250cm9sbGVyOjpMYXlvdXRU ZXN0Q29udHJvbGwKICAgICBiaW5kTWV0aG9kKCJmb3JjZVJlZFNlbGVjdGlvbkNvbG9ycyIsICZM YXlvdXRUZXN0Q29udHJvbGxlcjo6Zm9yY2VSZWRTZWxlY3Rpb25Db2xvcnMpOwogICAgIGJpbmRN ZXRob2QoImdyYW50RGVza3RvcE5vdGlmaWNhdGlvblBlcm1pc3Npb24iLCAmTGF5b3V0VGVzdENv bnRyb2xsZXI6OmdyYW50RGVza3RvcE5vdGlmaWNhdGlvblBlcm1pc3Npb24pOwogICAgIGJpbmRN ZXRob2QoImlzQ29tbWFuZEVuYWJsZWQiLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6OmlzQ29tbWFu ZEVuYWJsZWQpOworICAgIGJpbmRNZXRob2QoImxheWVyVHJlZUFzVGV4dCIsICZMYXlvdXRUZXN0 Q29udHJvbGxlcjo6bGF5ZXJUcmVlQXNUZXh0KTsKICAgICBiaW5kTWV0aG9kKCJtYXJrZXJUZXh0 Rm9yTGlzdEl0ZW0iLCAmTGF5b3V0VGVzdENvbnRyb2xsZXI6Om1hcmtlclRleHRGb3JMaXN0SXRl bSk7CiAgICAgYmluZE1ldGhvZCgibm90aWZ5RG9uZSIsICZMYXlvdXRUZXN0Q29udHJvbGxlcjo6 bm90aWZ5RG9uZSk7CiAgICAgYmluZE1ldGhvZCgibnVtYmVyT2ZBY3RpdmVBbmltYXRpb25zIiwg JkxheW91dFRlc3RDb250cm9sbGVyOjpudW1iZXJPZkFjdGl2ZUFuaW1hdGlvbnMpOwpAQCAtMTUz Nyw2ICsxNTM4LDExIEBAIFdlYktpdDo6V2ViU3BlZWNoSW5wdXRDb250cm9sbGVyKiBMYXlvdXQK ICAgICByZXR1cm4gbV9zcGVlY2hJbnB1dENvbnRyb2xsZXJNb2NrLmdldCgpOwogfQogCit2b2lk IExheW91dFRlc3RDb250cm9sbGVyOjpsYXllclRyZWVBc1RleHQoY29uc3QgQ3BwQXJndW1lbnRM aXN0JiBhcmdzLCBDcHBWYXJpYW50KiByZXN1bHQpCit7CisgICAgcmVzdWx0LT5zZXQobV9zaGVs bC0+d2ViVmlldygpLT5tYWluRnJhbWUoKS0+bGF5ZXJUcmVlQXNUZXh0KCkudXRmOCgpKTsKK30K Kwogdm9pZCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bWFya2VyVGV4dEZvckxpc3RJdGVtKGNvbnN0 IENwcEFyZ3VtZW50TGlzdCYgYXJncywgQ3BwVmFyaWFudCogcmVzdWx0KQogewogICAgIFdlYkVs ZW1lbnQgZWxlbWVudDsKSW5kZXg6IFdlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVt L0xheW91dFRlc3RDb250cm9sbGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvRHVtcFJl bmRlclRyZWUvY2hyb21pdW0vTGF5b3V0VGVzdENvbnRyb2xsZXIuaAkocmV2aXNpb24gNjkxMjIp CisrKyBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9MYXlvdXRUZXN0Q29udHJv bGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC0zMjUsNiArMzI1LDggQEAgcHVibGljOgogICAgIC8v IFNwZWVjaCBpbnB1dCByZWxhdGVkIGZ1bmN0aW9ucy4KICAgICB2b2lkIHNldE1vY2tTcGVlY2hJ bnB1dFJlc3VsdChjb25zdCBDcHBBcmd1bWVudExpc3QmLCBDcHBWYXJpYW50Kik7CiAKKyAgICB2 b2lkIGxheWVyVHJlZUFzVGV4dChjb25zdCBDcHBBcmd1bWVudExpc3QmIGFyZ3MsIENwcFZhcmlh bnQqIHJlc3VsdCk7CisKICAgICB2b2lkIG1hcmtlclRleHRGb3JMaXN0SXRlbShjb25zdCBDcHBB cmd1bWVudExpc3QmLCBDcHBWYXJpYW50Kik7CiAKIHB1YmxpYzoK