47205 2010-10-05 13:34:43 -0700 [V8] Add FileReader to active DOM map 2010-10-05 14:41:25 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 jianli webkit-unassigned ericu oldest_to_newest 289842 0 jianli 2010-10-05 13:34:43 -0700 We need to add FileReader to active DOM map in V8 bindings such that it will not be GC-ed when it is still active. This is needed to fix the Chromium bug: http://code.google.com/p/chromium/issues/detail?id=56997 289854 1 69835 jianli 2010-10-05 13:46:19 -0700 Created attachment 69835 Proposed Patch 289868 2 69835 japhet 2010-10-05 14:03:51 -0700 Comment on attachment 69835 Proposed Patch Please also add this file to Android.v8bindings.mk and WebCore.pro before submitting. 289898 3 jianli 2010-10-05 14:41:25 -0700 Commited as http://trac.webkit.org/changeset/69148. Add the new file to Android.v8bindings.mk. I do not add it to WebCore.pro since it seems not to be using V8 bindings. 69835 2010-10-05 13:46:19 -0700 2010-10-05 14:03:51 -0700 Proposed Patch 47205 text/plain 5249 jianli ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZTcxYzkyYi4uM2NhYzk4OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0xMC0wNSAgSmlhbiBMaSAgPGpp YW5saUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgW1Y4XSBBZGQgRmlsZVJlYWRlciB0byBhY3RpdmUgRE9NIG1hcAorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcyMDUKKworICAgICAg ICBXZSBuZWVkIHRvIGhhdmUgYSBjdXN0b20gRmlsZVJlYWRlciBWOCBjb25zdHJ1Y3RvciBpbiBv cmRlciB0byBhZGQgb2JqZWN0CisgICAgICAgIGludG8gYWN0aXZlIERPTSBtYXAgdG8gcHJldmVu dCBpdCBmcm9tIEdDLWVkIHdoZW4gaXQgaXMgc3RpbGwgaW4tdXNlLgorCisgICAgICAgICogV2Vi Q29yZS5neXBpOgorICAgICAgICAqIGJpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBt OgorICAgICAgICAqIGJpbmRpbmdzL3Y4L2N1c3RvbS9WOEZpbGVSZWFkZXJDdXN0b20uY3BwOiBB ZGRlZC4KKyAgICAgICAgKFdlYkNvcmU6OlY4RmlsZVJlYWRlcjo6Y29uc3RydWN0b3JDYWxsYmFj ayk6CisgICAgICAgICogZmlsZWFwaS9GaWxlUmVhZGVyLmlkbDoKKwogMjAxMC0xMC0wNSAgS2lt bW8gS2lubnVuZW4gIDxraW1tby50Lmtpbm51bmVuQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUv V2ViQ29yZS5neXBpIGIvV2ViQ29yZS9XZWJDb3JlLmd5cGkKaW5kZXggMTI4OTUwNy4uZWM2MmFi NiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9XZWJDb3JlLmd5cGkKKysrIGIvV2ViQ29yZS9XZWJDb3Jl Lmd5cGkKQEAgLTczMyw2ICs3MzMsNyBAQAogICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1c3Rv bS9WOEFycmF5QnVmZmVyQ3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3Vz dG9tL1Y4SW50OEFycmF5Q3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3MvdjgvY3Vz dG9tL1Y4SW50MzJBcnJheUN1c3RvbS5jcHAnLAorICAgICAgICAgICAgJ2JpbmRpbmdzL3Y4L2N1 c3RvbS9WOEZpbGVSZWFkZXJDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92OC9j dXN0b20vVjhGbG9hdDMyQXJyYXlDdXN0b20uY3BwJywKICAgICAgICAgICAgICdiaW5kaW5ncy92 OC9jdXN0b20vVjhJbnQxNkFycmF5Q3VzdG9tLmNwcCcsCiAgICAgICAgICAgICAnYmluZGluZ3Mv djgvY3VzdG9tL1Y4VWludDhBcnJheUN1c3RvbS5jcHAnLApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2Ny aXB0cy9Db2RlR2VuZXJhdG9yVjgucG0KaW5kZXggMzM1M2YwZi4uNDUyNGQyYiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQorKysgYi9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVyYXRvclY4LnBtCkBAIC0yNTU1LDYgKzI1NTUs NyBAQCBzdWIgSXNBY3RpdmVEb21UeXBlCiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldvcmtl ciI7CiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIlNoYXJlZFdvcmtlciI7CiAgICAgcmV0dXJu IDEgaWYgJHR5cGUgZXEgIklEQlJlcXVlc3QiOworICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJG aWxlUmVhZGVyIjsKICAgICByZXR1cm4gMDsKIH0KIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5k aW5ncy92OC9jdXN0b20vVjhGaWxlUmVhZGVyQ3VzdG9tLmNwcCBiL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4RmlsZVJlYWRlckN1c3RvbS5jcHAKbmV3IGZpbGUgbW9kZSAxMDA3NTUKaW5k ZXggMDAwMDAwMC4uNWY0ZmI1NwotLS0gL2Rldi9udWxsCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mv djgvY3VzdG9tL1Y4RmlsZVJlYWRlckN1c3RvbS5jcHAKQEAgLTAsMCArMSw2MCBAQAorLyoKKyAq IENvcHlyaWdodCAoQykgMjAxMCBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgorICoK KyAqIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdp dGggb3Igd2l0aG91dAorICogbW9kaWZpY2F0aW9uLCBhcmUgcGVybWl0dGVkIHByb3ZpZGVkIHRo YXQgdGhlIGZvbGxvd2luZyBjb25kaXRpb25zIGFyZQorICogbWV0OgorICoKKyAqICAgICAqIFJl ZGlzdHJpYnV0aW9ucyBvZiBzb3VyY2UgY29kZSBtdXN0IHJldGFpbiB0aGUgYWJvdmUgY29weXJp Z2h0CisgKiBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25zIGFuZCB0aGUgZm9sbG93aW5n IGRpc2NsYWltZXIuCisgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVz dCByZXByb2R1Y2UgdGhlIGFib3ZlCisgKiBjb3B5cmlnaHQgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyCisgKiBpbiB0aGUgZG9jdW1l bnRhdGlvbiBhbmQvb3Igb3RoZXIgbWF0ZXJpYWxzIHByb3ZpZGVkIHdpdGggdGhlCisgKiBkaXN0 cmlidXRpb24uCisgKiAgICAgKiBOZWl0aGVyIHRoZSBuYW1lIG9mIEdvb2dsZSBJbmMuIG5vciB0 aGUgbmFtZXMgb2YgaXRzCisgKiBjb250cmlidXRvcnMgbWF5IGJlIHVzZWQgdG8gZW5kb3JzZSBv ciBwcm9tb3RlIHByb2R1Y3RzIGRlcml2ZWQgZnJvbQorICogdGhpcyBzb2Z0d2FyZSB3aXRob3V0 IHNwZWNpZmljIHByaW9yIHdyaXR0ZW4gcGVybWlzc2lvbi4KKyAqCisgKiBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCisg KiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO RywgQlVUIE5PVAorICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCisgKiBBIFBBUlRJQ1VMQVIgUFVSUE9TRSBBUkUg RElTQ0xBSU1FRC4gSU4gTk8gRVZFTlQgU0hBTEwgVEhFIENPUFlSSUdIVAorICogT1dORVIgT1Ig Q09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5U QUwsCisgKiBTUEVDSUFMLCBFWEVNUExBUlksIE9SIENPTlNFUVVFTlRJQUwgREFNQUdFUyAoSU5D TFVESU5HLCBCVVQgTk9UCisgKiBMSU1JVEVEIFRPLCBQUk9DVVJFTUVOVCBPRiBTVUJTVElUVVRF IEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwKKyAqIERBVEEsIE9SIFBST0ZJVFM7IE9S IEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorICogVEhF T1JZIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05UUkFDVCwgU1RSSUNUIExJQUJJTElUWSwg T1IgVE9SVAorICogKElOQ0xVRElORyBORUdMSUdFTkNFIE9SIE9USEVSV0lTRSkgQVJJU0lORyBJ TiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCisgKiBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFE VklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0ggREFNQUdFLgorICovCisKKyNpbmNsdWRl ICJjb25maWcuaCIKKyNpbmNsdWRlICJWOEZpbGVSZWFkZXIuaCIKKworI2luY2x1ZGUgIlNjcmlw dEV4ZWN1dGlvbkNvbnRleHQuaCIKKyNpbmNsdWRlICJWOEJpbmRpbmcuaCIKKworbmFtZXNwYWNl IFdlYkNvcmUgeworCit2ODo6SGFuZGxlPHY4OjpWYWx1ZT4gVjhGaWxlUmVhZGVyOjpjb25zdHJ1 Y3RvckNhbGxiYWNrKGNvbnN0IHY4OjpBcmd1bWVudHMmIGFyZ3MpCit7CisgICAgSU5DX1NUQVRT KCJET00uRmlsZVJlYWRlci5Db25zdHJ1Y3RvciIpOworCisgICAgaWYgKCFhcmdzLklzQ29uc3Ry dWN0Q2FsbCgpKQorICAgICAgICByZXR1cm4gdGhyb3dFcnJvcigiRE9NIG9iamVjdCBjb25zdHJ1 Y3RvciBjYW5ub3QgYmUgY2FsbGVkIGFzIGEgZnVuY3Rpb24uIiwgVjhQcm94eTo6VHlwZUVycm9y KTsKKworICAgIC8vIEV4cGVjdCBubyBwYXJhbWV0ZXJzLgorICAgIC8vIEFsbG9jYXRlIGEgRmls ZVJlYWRlciBvYmplY3QgYXMgaXRzIGludGVybmFsIGZpZWxkLgorICAgIFNjcmlwdEV4ZWN1dGlv bkNvbnRleHQqIGNvbnRleHQgPSBnZXRTY3JpcHRFeGVjdXRpb25Db250ZXh0KCk7CisgICAgaWYg KCFjb250ZXh0KQorICAgICAgICByZXR1cm4gdGhyb3dFcnJvcigiRmlsZVJlYWRlciBjb25zdHJ1 Y3RvcidzIGFzc29jaWF0ZWQgY29udGV4dCBpcyBub3QgYXZhaWxhYmxlIiwgVjhQcm94eTo6UmVm ZXJlbmNlRXJyb3IpOworICAgIFJlZlB0cjxGaWxlUmVhZGVyPiBmaWxlUmVhZGVyID0gRmlsZVJl YWRlcjo6Y3JlYXRlKGNvbnRleHQpOworICAgIFY4RE9NV3JhcHBlcjo6c2V0RE9NV3JhcHBlcihh cmdzLkhvbGRlcigpLCAmaW5mbywgZmlsZVJlYWRlci5nZXQoKSk7CisKKyAgICAvLyBBZGQgb2Jq ZWN0IHRvIHRoZSB3cmFwcGVyIG1hcC4KKyAgICBmaWxlUmVhZGVyLT5yZWYoKTsKKyAgICBWOERP TVdyYXBwZXI6OnNldEpTV3JhcHBlckZvckFjdGl2ZURPTU9iamVjdChmaWxlUmVhZGVyLmdldCgp LCB2ODo6UGVyc2lzdGVudDx2ODo6T2JqZWN0Pjo6TmV3KGFyZ3MuSG9sZGVyKCkpKTsKKyAgICBy ZXR1cm4gYXJncy5Ib2xkZXIoKTsKK30KKworfSAvLyBuYW1lc3BhY2UgV2ViQ29yZQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9maWxlYXBpL0ZpbGVSZWFkZXIuaWRsIGIvV2ViQ29yZS9maWxlYXBpL0Zp bGVSZWFkZXIuaWRsCmluZGV4IGIzNmU5ZDMuLjcyM2QyNDIgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv ZmlsZWFwaS9GaWxlUmVhZGVyLmlkbAorKysgYi9XZWJDb3JlL2ZpbGVhcGkvRmlsZVJlYWRlci5p ZGwKQEAgLTM0LDcgKzM0LDggQEAgbW9kdWxlIGh0bWwgewogICAgICAgICBDYW5CZUNvbnN0cnVj dGVkLAogICAgICAgICBDYWxsV2l0aD1TY3JpcHRFeGVjdXRpb25Db250ZXh0LAogICAgICAgICBF dmVudFRhcmdldCwKLSAgICAgICAgTm9TdGF0aWNUYWJsZXMKKyAgICAgICAgTm9TdGF0aWNUYWJs ZXMsCisgICAgICAgIFY4Q3VzdG9tQ29uc3RydWN0b3IKICAgICBdIEZpbGVSZWFkZXIgewogICAg ICAgICAvLyByZWFkeSBzdGF0ZXMKICAgICAgICAgY29uc3QgdW5zaWduZWQgc2hvcnQgRU1QVFkg PSAwOwo=