47193 2010-10-05 10:28:34 -0700 [chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer 2010-10-05 13:59:33 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 scheib scheib commit-queue kbr vangelis oldest_to_newest 289721 0 scheib 2010-10-05 10:28:34 -0700 [chromium] 51304 GPU compositor resorts to "slow" text rendering for base page layer 289729 1 69806 scheib 2010-10-05 10:34:31 -0700 Created attachment 69806 Patch 289757 2 69806 vangelis 2010-10-05 11:12:50 -0700 Comment on attachment 69806 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69806&action=review I think an inline comment about blending would help us remember why it's done the way it is. Otherwise looks good! > WebCore/platform/graphics/chromium/LayerRendererChromium.cpp:206 > + GLC(m_context, m_context->disable(GraphicsContext3D::BLEND)); Can you please add a comment here saying that we need to render the root layer without blending to get subpixel antialised text displaying correctly? That way we won't forget why we need to flip blending on and off. 289778 3 69818 scheib 2010-10-05 11:38:58 -0700 Created attachment 69818 Patch 289810 4 69818 kbr 2010-10-05 12:25:21 -0700 Comment on attachment 69818 Patch Looks fine to me; confirmed with Vincent offline that CSS 3D tests with translucent layers continue to render correctly. 289861 5 69818 commit-queue 2010-10-05 13:59:28 -0700 Comment on attachment 69818 Patch Clearing flags on attachment: 69818 Committed r69144: <http://trac.webkit.org/changeset/69144> 289862 6 commit-queue 2010-10-05 13:59:33 -0700 All reviewed patches have been landed. Closing bug. 69806 2010-10-05 10:34:31 -0700 2010-10-05 11:38:55 -0700 Patch bug-47193-20101005103430.patch text/plain 2655 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NTEwYjk0NDc3Y2FkNGQyZWJhNzlmY2FlZmM1NGU2OWI2YWE2OGE3NS4uZTcwYzlmYWVjOGE1ODE0 MjNiOGJmY2Y0Njc1OGFmZjY5YjliM2Q1MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0wNSAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gNTEzMDQgR1BVIGNvbXBvc2l0 b3IgcmVzb3J0cyB0byAic2xvdyIgdGV4dCByZW5kZXJpbmcgZm9yIGJhc2UgcGFnZSBsYXllcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcxOTMKKwor ICAgICAgICBUZXN0OiBBY2NlbGVyYXRlZCBjb21wb3NpdG9yIHRlc3QgaW5mcmFzdHJ1Y3R1cmUg c3RpbGwgY29taW5nIG9ubGluZS4gVGVzdGVkIG1hbnVhbGx5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6c2V0Um9vdExheWVyQ2FudmFzU2l6ZSk6 CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OnByZXBhcmVUb0RyYXdM YXllcnMpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5 ZXJzKToKKwogMjAxMC0xMC0wNSAgS3Jpc3RpYW4gTW9uc2VuICA8a3Jpc3RpYW5tQGdvb2dsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU3RldmUgQmxvY2suCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5jcHAg Yi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1 bS5jcHAKaW5kZXggYzQwMzFlNTViNDNiZjY1NzZlNGFjMDdjOWMwZmZmNTYxOWY2ZTdiZC4uM2Fh ODc2ZjNmZDkxNjlhN2VjZDU1MThkYzE2MTU2NTI4Mzk5MzhhMSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwCisr KyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9t aXVtLmNwcApAQCAtMTI3LDcgKzEyNyw2IEBAIHZvaWQgTGF5ZXJSZW5kZXJlckNocm9taXVtOjpz ZXRSb290TGF5ZXJDYW52YXNTaXplKGNvbnN0IEludFNpemUmIHNpemUpCiAgICAgLy8gdGhlIG9s ZCBvbmVzLgogICAgIG1fcm9vdExheWVyQ2FudmFzID0gbmV3IHNraWE6OlBsYXRmb3JtQ2FudmFz KHNpemUud2lkdGgoKSwgc2l6ZS5oZWlnaHQoKSwgZmFsc2UpOwogICAgIG1fcm9vdExheWVyU2tp YUNvbnRleHQgPSBuZXcgUGxhdGZvcm1Db250ZXh0U2tpYShtX3Jvb3RMYXllckNhbnZhcy5nZXQo KSk7Ci0gICAgbV9yb290TGF5ZXJTa2lhQ29udGV4dC0+c2V0RHJhd2luZ1RvSW1hZ2VCdWZmZXIo dHJ1ZSk7CiAgICAgbV9yb290TGF5ZXJHcmFwaGljc0NvbnRleHQgPSBuZXcgR3JhcGhpY3NDb250 ZXh0KHJlaW50ZXJwcmV0X2Nhc3Q8UGxhdGZvcm1HcmFwaGljc0NvbnRleHQqPihtX3Jvb3RMYXll clNraWFDb250ZXh0LmdldCgpKSk7CiAjZWxpZiBQTEFURk9STShDRykKICAgICAvLyBSZWxlYXNl IHRoZSBwcmV2aW91cyBDR0JpdG1hcENvbnRleHQgYmVmb3JlIHJlYWxsb2NhdGluZyB0aGUgYmFj a2luZyBzdG9yZSBhcyBhIHByZWNhdXRpb24uCkBAIC0yMDQsNiArMjAzLDcgQEAgdm9pZCBMYXll clJlbmRlcmVyQ2hyb21pdW06OnByZXBhcmVUb0RyYXdMYXllcnMoY29uc3QgSW50UmVjdCYgdmlz aWJsZVJlY3QsIGNvbnMKICAgICBHTEMobV9jb250ZXh0LCBtX2NvbnRleHQtPmRpc2FibGUoR3Jh cGhpY3NDb250ZXh0M0Q6OkNVTExfRkFDRSkpOwogICAgIEdMQyhtX2NvbnRleHQsIG1fY29udGV4 dC0+ZGVwdGhGdW5jKEdyYXBoaWNzQ29udGV4dDNEOjpMRVFVQUwpKTsKICAgICBHTEMobV9jb250 ZXh0LCBtX2NvbnRleHQtPmNsZWFyU3RlbmNpbCgwKSk7CisgICAgR0xDKG1fY29udGV4dCwgbV9j b250ZXh0LT5kaXNhYmxlKEdyYXBoaWNzQ29udGV4dDNEOjpCTEVORCkpOwogCiAgICAgaWYgKG1f c2Nyb2xsUG9zaXRpb24gPT0gSW50UG9pbnQoLTEsIC0xKSkgewogICAgICAgICBtX3Njcm9sbFBv c2l0aW9uID0gc2Nyb2xsUG9zaXRpb247CkBAIC0zMzEsNiArMzMxLDcgQEAgdm9pZCBMYXllclJl bmRlcmVyQ2hyb21pdW06OmRyYXdMYXllcnMoY29uc3QgSW50UmVjdCYgdmlzaWJsZVJlY3QsIGNv bnN0IEludFJlY3QKICAgICAgICAgZHJhd0xheWVyc1JlY3Vyc2l2ZShzdWJsYXllcnNbaV0uZ2V0 KCksIHNjaXNzb3JSZWN0KTsKIAogICAgIEdMQyhtX2NvbnRleHQsIG1fY29udGV4dC0+ZGlzYWJs ZShHcmFwaGljc0NvbnRleHQzRDo6U0NJU1NPUl9URVNUKSk7CisgICAgR0xDKG1fY29udGV4dCwg bV9jb250ZXh0LT5kaXNhYmxlKEdyYXBoaWNzQ29udGV4dDNEOjpCTEVORCkpOwogfQogCiB2b2lk IExheWVyUmVuZGVyZXJDaHJvbWl1bTo6ZmluaXNoKCkK 69818 2010-10-05 11:38:58 -0700 2010-10-05 13:59:28 -0700 Patch bug-47193-20101005113857.patch text/plain 2765 scheib ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZDYxZjFjMDU5OWUzMmIwMzU5YThkMzljYTU4Mjk0NGNlMjUzNjIwYS4uZmE0ZTk4YWQxNjI0OWZj NGQ4MWExYTZkYzM5MzFiYzE3NzQxNTE2NCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0xMC0wNSAgVmlu Y2VudCBTY2hlaWIgIDxzY2hlaWJAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gNTEzMDQgR1BVIGNvbXBvc2l0 b3IgcmVzb3J0cyB0byAic2xvdyIgdGV4dCByZW5kZXJpbmcgZm9yIGJhc2UgcGFnZSBsYXllcgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9NDcxOTMKKwor ICAgICAgICBUZXN0OiBBY2NlbGVyYXRlZCBjb21wb3NpdG9yIHRlc3QgaW5mcmFzdHJ1Y3R1cmUg c3RpbGwgY29taW5nIG9ubGluZS4gVGVzdGVkIG1hbnVhbGx5LgorCisgICAgICAgICogcGxhdGZv cm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OkxheWVyUmVuZGVyZXJDaHJvbWl1bTo6c2V0Um9vdExheWVyQ2FudmFzU2l6ZSk6 CisgICAgICAgIChXZWJDb3JlOjpMYXllclJlbmRlcmVyQ2hyb21pdW06OnByZXBhcmVUb0RyYXdM YXllcnMpOgorICAgICAgICAoV2ViQ29yZTo6TGF5ZXJSZW5kZXJlckNocm9taXVtOjpkcmF3TGF5 ZXJzKToKKwogMjAxMC0xMC0wNSAgTmF0ZSBDaGFwaW4gIDxqYXBoZXRAY2hyb21pdW0ub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3BwIGIvV2Vi Q29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9MYXllclJlbmRlcmVyQ2hyb21pdW0uY3Bw CmluZGV4IGM0MDMxZTU1YjQzYmY2NTc2ZTRhYzA3YzljMGZmZjU2MTlmNmU3YmQuLmE0YjZmYWI5 NDAzNjFkODQ4YjgyMjIwMTJhMzA1YTg3NWQ2ZjYyNGQgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vTGF5ZXJSZW5kZXJlckNocm9taXVtLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL0xheWVyUmVuZGVyZXJDaHJvbWl1bS5j cHAKQEAgLTEyNyw3ICsxMjcsNiBAQCB2b2lkIExheWVyUmVuZGVyZXJDaHJvbWl1bTo6c2V0Um9v dExheWVyQ2FudmFzU2l6ZShjb25zdCBJbnRTaXplJiBzaXplKQogICAgIC8vIHRoZSBvbGQgb25l cy4KICAgICBtX3Jvb3RMYXllckNhbnZhcyA9IG5ldyBza2lhOjpQbGF0Zm9ybUNhbnZhcyhzaXpl LndpZHRoKCksIHNpemUuaGVpZ2h0KCksIGZhbHNlKTsKICAgICBtX3Jvb3RMYXllclNraWFDb250 ZXh0ID0gbmV3IFBsYXRmb3JtQ29udGV4dFNraWEobV9yb290TGF5ZXJDYW52YXMuZ2V0KCkpOwot ICAgIG1fcm9vdExheWVyU2tpYUNvbnRleHQtPnNldERyYXdpbmdUb0ltYWdlQnVmZmVyKHRydWUp OwogICAgIG1fcm9vdExheWVyR3JhcGhpY3NDb250ZXh0ID0gbmV3IEdyYXBoaWNzQ29udGV4dChy ZWludGVycHJldF9jYXN0PFBsYXRmb3JtR3JhcGhpY3NDb250ZXh0Kj4obV9yb290TGF5ZXJTa2lh Q29udGV4dC5nZXQoKSkpOwogI2VsaWYgUExBVEZPUk0oQ0cpCiAgICAgLy8gUmVsZWFzZSB0aGUg cHJldmlvdXMgQ0dCaXRtYXBDb250ZXh0IGJlZm9yZSByZWFsbG9jYXRpbmcgdGhlIGJhY2tpbmcg c3RvcmUgYXMgYSBwcmVjYXV0aW9uLgpAQCAtMjA0LDYgKzIwMyw4IEBAIHZvaWQgTGF5ZXJSZW5k ZXJlckNocm9taXVtOjpwcmVwYXJlVG9EcmF3TGF5ZXJzKGNvbnN0IEludFJlY3QmIHZpc2libGVS ZWN0LCBjb25zCiAgICAgR0xDKG1fY29udGV4dCwgbV9jb250ZXh0LT5kaXNhYmxlKEdyYXBoaWNz Q29udGV4dDNEOjpDVUxMX0ZBQ0UpKTsKICAgICBHTEMobV9jb250ZXh0LCBtX2NvbnRleHQtPmRl cHRoRnVuYyhHcmFwaGljc0NvbnRleHQzRDo6TEVRVUFMKSk7CiAgICAgR0xDKG1fY29udGV4dCwg bV9jb250ZXh0LT5jbGVhclN0ZW5jaWwoMCkpOworICAgIC8vIEJsZW5kaW5nIGRpc2FibGVkIGJ5 IGRlZmF1bHQuIFJvb3QgbGF5ZXIgYWxwaGEgY2hhbm5lbCBvbiBXaW5kb3dzIGlzIGluY29ycmVj dCB3aGVuIFNraWEgdXNlcyBDbGVhclR5cGUuIAorICAgIEdMQyhtX2NvbnRleHQsIG1fY29udGV4 dC0+ZGlzYWJsZShHcmFwaGljc0NvbnRleHQzRDo6QkxFTkQpKTsgCiAKICAgICBpZiAobV9zY3Jv bGxQb3NpdGlvbiA9PSBJbnRQb2ludCgtMSwgLTEpKSB7CiAgICAgICAgIG1fc2Nyb2xsUG9zaXRp b24gPSBzY3JvbGxQb3NpdGlvbjsKQEAgLTMzMSw2ICszMzIsNyBAQCB2b2lkIExheWVyUmVuZGVy ZXJDaHJvbWl1bTo6ZHJhd0xheWVycyhjb25zdCBJbnRSZWN0JiB2aXNpYmxlUmVjdCwgY29uc3Qg SW50UmVjdAogICAgICAgICBkcmF3TGF5ZXJzUmVjdXJzaXZlKHN1YmxheWVyc1tpXS5nZXQoKSwg c2Npc3NvclJlY3QpOwogCiAgICAgR0xDKG1fY29udGV4dCwgbV9jb250ZXh0LT5kaXNhYmxlKEdy YXBoaWNzQ29udGV4dDNEOjpTQ0lTU09SX1RFU1QpKTsKKyAgICBHTEMobV9jb250ZXh0LCBtX2Nv bnRleHQtPmRpc2FibGUoR3JhcGhpY3NDb250ZXh0M0Q6OkJMRU5EKSk7CiB9CiAKIHZvaWQgTGF5 ZXJSZW5kZXJlckNocm9taXVtOjpmaW5pc2goKQo=