47189 2010-10-05 10:07:26 -0700 Ignore whitespace in base64 decoding of data URL 2010-10-06 10:19:22 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED DUPLICATE 41462 P2 Normal --- 0 skyul webkit-unassigned alp commit-queue oldest_to_newest 289691 0 skyul 2010-10-05 10:07:26 -0700 RFC2397 (The "data" URL scheme) refers to RFC 2045 (MIME) for base64 decoding and RFC 2045 states: All line breaks or other characters not found in Table 1 must be ignored by decoding software. Acid3 test 97 tests this. Pass IgnoreWhitespace to base64Decode function to ignore whitespace in base64 decoding. 289696 1 69803 skyul 2010-10-05 10:09:08 -0700 Created attachment 69803 Patch 290083 2 skyul 2010-10-05 21:06:25 -0700 CC'ing Alp Toker for review. 290397 3 69803 darin 2010-10-06 10:08:22 -0700 Comment on attachment 69803 Patch This helps only the CURL port. We want to move data URL handling out of ResourceHandle entirely and share it between all platforms. 290403 4 69803 commit-queue 2010-10-06 10:11:05 -0700 Comment on attachment 69803 Patch Rejecting patch 69803 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=abarth-cq-sl', 'apply-attachment', '--force-clean', '--non-interactive', '--quiet', 69803]" exit_code: 2 Cleaning working directory Updating working directory Logging in as commit-queue@webkit.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=69803&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=47189&ctype=xml Processing 1 patch from 1 bug. Processing patch 69803 from bug 47189. Failed to run "[u'/Users/abarth/git/webkit-queue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Darin Adler', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/4221115 290407 5 skyul 2010-10-06 10:14:59 -0700 (In reply to comment #3) > (From update of attachment 69803 [details]) > This helps only the CURL port. We want to move data URL handling out of ResourceHandle entirely and share it between all platforms. Yes, I agree. Brew MP http backend (not yet upstreamed) also copied data URL code from the CURL port. 290411 6 skyul 2010-10-06 10:19:22 -0700 Done in bug 41462 *** This bug has been marked as a duplicate of bug 41462 *** 69803 2010-10-05 10:09:08 -0700 2010-10-06 10:11:05 -0700 Patch base64.patch text/plain 1851 skyul SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTEyMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMTAtMDUgIEt3YW5nIFl1bCBTZW8gIDxza3l1bEBjb21wYW55 MTAwLm5ldD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBJZ25vcmUgd2hpdGVzcGFjZSBpbiBiYXNlNjQgZGVjb2Rpbmcgb2YgZGF0YSBVUkwKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTg5CisKKyAgICAg ICAgUkZDMjM5NyAoVGhlICJkYXRhIiBVUkwgc2NoZW1lKSByZWZlcnMgdG8gUkZDIDIwNDUgKE1J TUUpIGZvciBiYXNlNjQgZGVjb2RpbmcKKyAgICAgICAgYW5kIFJGQyAyMDQ1IHN0YXRlczogQWxs IGxpbmUgYnJlYWtzIG9yIG90aGVyIGNoYXJhY3RlcnMgbm90IGZvdW5kIGluIFRhYmxlIDEKKyAg ICAgICAgbXVzdCBiZSBpZ25vcmVkIGJ5IGRlY29kaW5nIHNvZnR3YXJlLiBBY2lkMyB0ZXN0IDk3 IHRlc3RzIHRoaXMuCisKKyAgICAgICAgUGFzcyBJZ25vcmVXaGl0ZXNwYWNlIHRvIGJhc2U2NERl Y29kZSBmdW5jdGlvbiB0byBpZ25vcmUgd2hpdGVzcGFjZSBpbiBiYXNlNjQgZGVjb2RpbmcuCisK KyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OnBhcnNlRGF0YVVybCk6CisKIDIwMTAtMTAtMDUgIENocmlz IEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBE YXJpbiBBZGxlci4KSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNl SGFuZGxlTWFuYWdlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2N1cmwvUmVzb3VyY2VIYW5kbGVNYW5hZ2VyLmNwcAkocmV2aXNpb24gNjkxMTUpCisrKyBXZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZU1hbmFnZXIuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC02MTEsMTAgKzYxMSw5IEBAIHN0YXRpYyB2b2lkIHBhcnNlRGF0YVVybChS ZXNvdXJjZUhhbmRsZSoKICAgICAgICAgcmVzcG9uc2Uuc2V0VGV4dEVuY29kaW5nTmFtZShjaGFy c2V0KTsKICAgICAgICAgY2xpZW50LT5kaWRSZWNlaXZlUmVzcG9uc2UoaGFuZGxlLCByZXNwb25z ZSk7CiAKLSAgICAgICAgLy8gV2ViQ29yZSdzIGRlY29kZXIgZmFpbHMgb24gQWNpZDMgdGVzdCA5 NyAod2hpdGVzcGFjZSkuCiAgICAgICAgIFZlY3RvcjxjaGFyPiBvdXQ7CiAgICAgICAgIENTdHJp bmcgbGF0aW4xID0gZGF0YS5sYXRpbjEoKTsKLSAgICAgICAgaWYgKGJhc2U2NERlY29kZShsYXRp bjEuZGF0YSgpLCBsYXRpbjEubGVuZ3RoKCksIG91dCkgJiYgb3V0LnNpemUoKSA+IDApCisgICAg ICAgIGlmIChiYXNlNjREZWNvZGUobGF0aW4xLmRhdGEoKSwgbGF0aW4xLmxlbmd0aCgpLCBvdXQs IElnbm9yZVdoaXRlc3BhY2UpICYmIG91dC5zaXplKCkgPiAwKQogICAgICAgICAgICAgY2xpZW50 LT5kaWRSZWNlaXZlRGF0YShoYW5kbGUsIG91dC5kYXRhKCksIG91dC5zaXplKCksIDApOwogICAg IH0gZWxzZSB7CiAgICAgICAgIC8vIFdlIGhhdmUgdG8gY29udmVydCB0byBVVEYtMTYgZWFybHkg ZHVlIHRvIGxpbWl0YXRpb25zIGluIEtVUkwK