47179 2010-10-05 08:11:17 -0700 Don't include JavaScriptCore/config.h from command line 2010-10-05 08:54:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 0 kristianm webkit-unassigned commit-queue steveblock oldest_to_newest 289612 0 kristianm 2010-10-05 08:11:17 -0700 JavaScriptCore/config.h were included from WebCorePrefix.h. This is included on the command line, which means it is included before any content in a cpp file. It also violates the rules in WebCorePrefix.h Moving the include to WebCore/config.h, so if one is included both will be. 289613 1 69784 kristianm 2010-10-05 08:14:14 -0700 Created attachment 69784 Proposed patch 289620 2 69784 steveblock 2010-10-05 08:22:35 -0700 Comment on attachment 69784 Proposed patch r=me 289642 3 69784 commit-queue 2010-10-05 08:53:55 -0700 Comment on attachment 69784 Proposed patch Clearing flags on attachment: 69784 Committed r69112: <http://trac.webkit.org/changeset/69112> 289643 4 commit-queue 2010-10-05 08:54:00 -0700 All reviewed patches have been landed. Closing bug. 69784 2010-10-05 08:14:14 -0700 2010-10-05 08:53:55 -0700 Proposed patch patch.txt text/plain 1927 kristianm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTEwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMTAtMDUgIEtyaXN0aWFuIE1vbnNlbiAgPGtyaXN0aWFubUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEluY2x1ZGluZyBKYXZhU2NyaXB0Q29yZS9jb25maWcuaCBmcm9tIFdlYkNvcmUvY29uZmln LmgKKyAgICAgICAgaW5zdGVhZCBvZiBmcm9tIFdlYkNvcmVQcmVmaXguaC4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTc5CisKKyAgICAgICAgTm8g bmV3IHRlc3RzLCBqdXN0IGNoYW5naW5nIHdoZXJlIGZpbGVzIGFyZSBpbmNsdWRlZC4KKworICAg ICAgICAqIFdlYkNvcmVQcmVmaXguaDoKKyAgICAgICAgKiBjb25maWcuaDoKKwogMjAxMC0xMC0w NSAgQWRhbSBSb2JlbiAgPGFyb2JlbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2luZG93cyBsaW5r ZXIgd2FybmluZyBmaXgKSW5kZXg6IFdlYkNvcmUvV2ViQ29yZVByZWZpeC5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvV2ViQ29yZVByZWZpeC5oCShyZXZpc2lvbiA2OTEwMykKKysrIFdlYkNvcmUv V2ViQ29yZVByZWZpeC5oCSh3b3JraW5nIGNvcHkpCkBAIC03MCwxMSArNzAsNiBAQAogI2RlZmlu ZSBQUkVGSVhfRk9SX1dFQkNPUkUgMQogI2RlZmluZSBFWFBPUlQgX19hdHRyaWJ1dGVfXygodmlz aWJpbGl0eSgiZGVmYXVsdCIpKSkKICNlbmRpZgotLy8gQW5kcm9pZCB1c2VzIGEgc2luZ2xlIHNl dCBvZiBpbmNsdWRlIGRpcmVjdG9yaWVzIHdoZW4gYnVpbGRpbmcgV2ViS2l0IGFuZAotLy8gSmF2 YVNjcmlwdENvcmUuIFNpbmNlIFdlYkNvcmUvIGlzIGluY2x1ZGVkIGJlZm9yZSBKYXZhU2NyaXB0 Q29yZS8sIEFuZHJvaWQKLS8vIGluY2x1ZGVzIEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oIGV4cGxp Y2l0bHkgaGVyZSB0byBtYWtlIHN1cmUgaXQgZ2V0cyBwaWNrZWQKLS8vIHVwLgotI2luY2x1ZGUg PEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oPgogI2VuZGlmCiAKICNpZiAhZGVmaW5lZChCVUlMRElO R19CUkVXTVBfXykKSW5kZXg6IFdlYkNvcmUvY29uZmlnLmgKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29y ZS9jb25maWcuaAkocmV2aXNpb24gNjkxMDMpCisrKyBXZWJDb3JlL2NvbmZpZy5oCSh3b3JraW5n IGNvcHkpCkBAIC04MCw2ICs4MCwxMiBAQAogI2VuZGlmIC8qIE9TKFdJTkRPV1MpICovCiAKICNp ZiBQTEFURk9STShBTkRST0lEKQorLy8gQW5kcm9pZCB1c2VzIGEgc2luZ2xlIHNldCBvZiBpbmNs dWRlIGRpcmVjdG9yaWVzIHdoZW4gYnVpbGRpbmcgV2ViS2l0IGFuZAorLy8gSmF2YVNjcmlwdENv cmUuIFNpbmNlIFdlYkNvcmUvIGlzIGluY2x1ZGVkIGJlZm9yZSBKYXZhU2NyaXB0Q29yZS8sIEFu ZHJvaWQKKy8vIGluY2x1ZGVzIEphdmFTY3JpcHRDb3JlL2NvbmZpZy5oIGV4cGxpY2l0bHkgaGVy ZSB0byBtYWtlIHN1cmUgaXQgZ2V0cyBwaWNrZWQKKy8vIHVwLgorI2luY2x1ZGUgPEphdmFTY3Jp cHRDb3JlL2NvbmZpZy5oPgorCiAjZGVmaW5lIFdFQkNPUkVfTkFWSUdBVE9SX1ZFTkRPUiAiR29v Z2xlIEluYy4iCiAvLyBUaGlzIG11c3QgYmUgZGVmaW5lZCBiZWZvcmUgd2UgaW5jbHVkZSBGYXN0 TWFsbG9jLmgsIGJlbG93LgogI2RlZmluZSBVU0VfU1lTVEVNX01BTExPQyAxCg==