47168 2010-10-05 04:35:42 -0700 [Qt] WebKit2 should support focusing 2010-10-08 04:42:47 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 kimmo.t.kinnunen webkit-unassigned commit-queue oldest_to_newest 289535 0 kimmo.t.kinnunen 2010-10-05 04:35:42 -0700 Qt WebKit2 API should support setting and unsetting focus for the QGraphicsWKView. Otherwise input/text areas don't display caret. 289590 1 69781 kimmo.t.kinnunen 2010-10-05 07:21:10 -0700 Created attachment 69781 Patch to set focus and active flags when qgraphicswkitem gets focused. 290818 2 69781 kling 2010-10-06 22:56:40 -0700 Comment on attachment 69781 Patch to set focus and active flags when qgraphicswkitem gets focused. LGTM. 290826 3 69781 commit-queue 2010-10-06 23:26:05 -0700 Comment on attachment 69781 Patch to set focus and active flags when qgraphicswkitem gets focused. Rejecting patch 69781 from commit-queue. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=queues.webkit.org', 'build-and-test', '--no-clean', '--no-update', '--test', '--quiet', '--non-interactive']" exit_code: 2 Last 500 characters of output: l tests successful. Files=14, Tests=304, 1 wallclock secs ( 0.72 cusr + 0.17 csys = 0.89 CPU) Running build-dumprendertree Compiling Java tests make: Nothing to be done for `default'. Running tests from /Projects/CommitQueue/LayoutTests Testing 21469 test cases. java/lc3/JSObject/ToObject-001.html -> failed Exiting early after 1 failures. 17533 tests run. 282.75s total testing time 17532 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 28 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/4255039 291479 4 69781 kimmo.t.kinnunen 2010-10-08 00:25:56 -0700 Comment on attachment 69781 Patch to set focus and active flags when qgraphicswkitem gets focused. can somebody re-cq+ ? I think the cq failure was unrelated to this patch. 291540 5 69781 kling 2010-10-08 03:30:44 -0700 Comment on attachment 69781 Patch to set focus and active flags when qgraphicswkitem gets focused. Let's try that again. 291562 6 69781 commit-queue 2010-10-08 04:42:42 -0700 Comment on attachment 69781 Patch to set focus and active flags when qgraphicswkitem gets focused. Clearing flags on attachment: 69781 Committed r69391: <http://trac.webkit.org/changeset/69391> 291563 7 commit-queue 2010-10-08 04:42:47 -0700 All reviewed patches have been landed. Closing bug. 69781 2010-10-05 07:21:10 -0700 2010-10-08 04:42:42 -0700 Patch to set focus and active flags when qgraphicswkitem gets focused. qtwebkit2-set-focus.patch text/plain 1955 kimmo.t.kinnunen ZGlmZiAtLWdpdCBhL1dlYktpdDIvQ2hhbmdlTG9nIGIvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXgg Zjk0ODViNy4uZTg1NTRmMCAxMDA2NDQKLS0tIGEvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvV2Vi S2l0Mi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxMC0xMC0wNSAgS2ltbW8gS2lubnVu ZW4gIDxraW1tby50Lmtpbm51bmVuQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBOb3RpZnkgV2ViUGFnZSB3aGVuIFFHcmFwaGljc1dL VmlldyBnYWlucyBmb2N1cy4gU2V0IGJvdGgKKyAgICAgICAgYWN0aXZlIGZsYWcgYW5kIGZvY3Vz ZWQgZmxhZywgc2ltaWxhciB0byBRV2ViUGFnZSBiZWhhdmlvci4KKworICAgICAgICBbUXRdIFdl YktpdDIgc2hvdWxkIHN1cHBvcnQgZm9jdXNpbmcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTY4CisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL3F0 L3FncmFwaGljc3drdmlldy5jcHA6CisgICAgICAgIChRR3JhcGhpY3NXS1ZpZXc6OmZvY3VzSW5F dmVudCk6IEFkZGVkLgorICAgICAgICAoUUdyYXBoaWNzV0tWaWV3Ojpmb2N1c091dEV2ZW50KTog QWRkZWQuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaDogQWRk ZWQgZGVjbGFyYXRpb25zLgorCiAyMDEwLTEwLTA0ICBNYXJrIFJvd2UgIDxtcm93ZUBhcHBsZS5j b20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KZGlmZiAtLWdpdCBhL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuY3BwIGIvV2ViS2l0Mi9VSVByb2Nl c3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHAKaW5kZXggODBmY2ViYy4uOTJjNDNjYSAxMDA2 NDQKLS0tIGEvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHAKKysr IGIvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5jcHAKQEAgLTI0OCw2 ICsyNDgsMTggQEAgdm9pZCBRR3JhcGhpY3NXS1ZpZXc6OnRvdWNoRXZlbnQoUVRvdWNoRXZlbnQq IGV2KQogfQogI2VuZGlmCiAKK3ZvaWQgUUdyYXBoaWNzV0tWaWV3Ojpmb2N1c0luRXZlbnQoUUZv Y3VzRXZlbnQqKQoreworICAgIHBhZ2UoKS0+ZC0+cGFnZS0+c2V0QWN0aXZlKHRydWUpOworICAg IHBhZ2UoKS0+ZC0+cGFnZS0+c2V0Rm9jdXNlZCh0cnVlKTsKK30KKwordm9pZCBRR3JhcGhpY3NX S1ZpZXc6OmZvY3VzT3V0RXZlbnQoUUZvY3VzRXZlbnQqKQoreworICAgIHBhZ2UoKS0+ZC0+cGFn ZS0+c2V0Rm9jdXNlZChmYWxzZSk7CisgICAgcGFnZSgpLT5kLT5wYWdlLT5zZXRBY3RpdmUoZmFs c2UpOworfQorCiBRR3JhcGhpY3NXS1ZpZXdQcml2YXRlOjpRR3JhcGhpY3NXS1ZpZXdQcml2YXRl KFFHcmFwaGljc1dLVmlldyogdmlldykKICAgICA6IHEodmlldykKIHsKZGlmZiAtLWdpdCBhL1dl YktpdDIvVUlQcm9jZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaCBiL1dlYktpdDIvVUlQcm9j ZXNzL0FQSS9xdC9xZ3JhcGhpY3N3a3ZpZXcuaAppbmRleCA4NWI0Nzk3Li42NGNlYWE1IDEwMDY0 NAotLS0gYS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvcXQvcWdyYXBoaWNzd2t2aWV3LmgKKysrIGIv V2ViS2l0Mi9VSVByb2Nlc3MvQVBJL3F0L3FncmFwaGljc3drdmlldy5oCkBAIC03Niw2ICs3Niw5 IEBAIHByb3RlY3RlZDoKIAogICAgIFFfU0xPVCB2b2lkIHVwZGF0ZUN1cnNvcihjb25zdCBRQ3Vy c29yJik7CiAKKyAgICB2aXJ0dWFsIHZvaWQgZm9jdXNJbkV2ZW50KFFGb2N1c0V2ZW50Kik7Cisg ICAgdmlydHVhbCB2b2lkIGZvY3VzT3V0RXZlbnQoUUZvY3VzRXZlbnQqKTsKKwogcHJpdmF0ZToK ICAgICBRR3JhcGhpY3NXS1ZpZXdQcml2YXRlKiBkOwogICAgIGZyaWVuZCBjbGFzcyBRR3JhcGhp Y3NXS1ZpZXdQcml2YXRlOwo=