47166 2010-10-05 03:29:48 -0700 querySelectorAll('body>:last-child') does not work unless HTML file ends with 'new-line'. 2010-11-02 12:15:49 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 hayato abarth abarth ap eric hamaji oldest_to_newest 289523 0 69768 hayato 2010-10-05 03:29:48 -0700 Created attachment 69768 test1.html Please see attachment files, test1.html and test2.html. The only difference between them is whether there is a 'new-line' at the end of file or not. - test1.html ends with 'new-line', like '... </html>\n<EOF>' - test2.html does not end with 'new-line', like '.... </html><EOF>'. Open each files, then try the following JavaScript code in JavaScript console. > document.querySelectorAll('body>:last-child') The results differs in test1.html and test2.html: - In test1.html, querySelectorAll returns a correct result, ['<div id="last">last</div>]. - In test2.html, querySelectorAll returns an empty list, [], which is wrong result. This might be a regression because Safari Version 5.0 (6533.16) returns the same correct results for both test1.html and test2.html. 289524 1 69769 hayato 2010-10-05 03:30:27 -0700 Created attachment 69769 test2.html 289818 2 abarth 2010-10-05 12:59:44 -0700 We had trouble with the last-child selector early on when developing the new tree builder. There's some API we need to call on an element when it's received its last child (as I recall). I'll possible we're screwing that up in this case. The newline at the end of the file gets moved to just inside the body element, which might be confusing something. Thanks for the report. I'll take a look. 300886 3 abarth 2010-10-27 22:32:42 -0700 Looking now. 300890 4 72148 abarth 2010-10-27 23:03:52 -0700 Created attachment 72148 Patch 301299 5 72148 eric 2010-10-28 13:41:31 -0700 Comment on attachment 72148 Patch OK. Your test case is really subtle. It should document that it's important to not have a newline at the end. Would probably be clearer if you document.wrote the contnet into an ifram. 301300 6 eric 2010-10-28 13:41:49 -0700 You mentioned there was a spec bug? What's the bug? 301318 7 abarth 2010-10-28 14:00:59 -0700 (In reply to comment #6) > You mentioned there was a spec bug? What's the bug? It's for one of the FIXME cases. It's just a typo in the spec. 303544 8 abarth 2010-11-02 12:15:49 -0700 Committed r71147: <http://trac.webkit.org/changeset/71147> 69768 2010-10-05 03:29:48 -0700 2010-10-05 03:29:48 -0700 test1.html test1.html text/html 208 hayato PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgaHR0cC1lcXVpdj0iY29u dGVudC10eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiIC8+CiAgICA8dGl0 bGU+bGFzdC1jaGlsZCB0ZXN0PC90aXRsZT4KICA8L2hlYWQ+CiAgPGJvZHk+CiAgICA8ZGl2IGlk PSdsYXN0Jz5sYXN0PC9kaXY+CiAgPC9ib2R5Pgo8L2h0bWw+Cg== 69769 2010-10-05 03:30:27 -0700 2010-10-05 03:30:27 -0700 test2.html test2.html text/html 207 hayato PCFET0NUWVBFIGh0bWw+CjxodG1sPgogIDxoZWFkPgogICAgPG1ldGEgaHR0cC1lcXVpdj0iY29u dGVudC10eXBlIiBjb250ZW50PSJ0ZXh0L2h0bWw7IGNoYXJzZXQ9dXRmLTgiIC8+CiAgICA8dGl0 bGU+bGFzdC1jaGlsZCB0ZXN0PC90aXRsZT4KICA8L2hlYWQ+CiAgPGJvZHk+CiAgICA8ZGl2IGlk PSdsYXN0Jz5sYXN0PC9kaXY+CiAgPC9ib2R5Pgo8L2h0bWw+ 72148 2010-10-27 23:03:52 -0700 2010-10-28 13:41:31 -0700 Patch bug-47166-20101027230350.patch text/plain 4144 abarth ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBmM2Y3ZWIzMjg1ZmVmNzNmYjI2NDFiZGU3MTQ0MTQ1YzExOTYwNTZiLi5kN2Y3NGMz NTYwMDkzN2Q1MWU1YjdjMmYxNTAxYzg0NDg5MTc4ZWRmIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAK KzIwMTAtMTAtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBxdWVyeVNlbGVjdG9yQWxsKCdi b2R5PjpsYXN0LWNoaWxkJykgZG9lcyBub3Qgd29yayB1bmxlc3MgSFRNTCBmaWxlIGVuZHMgd2l0 aCAnbmV3LWxpbmUnLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9NDcxNjYKKworICAgICAgICBUZXN0IHRoYXQgOmxhc3QtY2hpbGQgd29ya3Mgd2hlbiB3 ZSBlbmQgdGhlIGRvY3VtZW50IGluIHRoZQorICAgICAgICBBZnRlckFmdGVyQm9keSBzdGF0ZS4K KworICAgICAgICAqIGZhc3QvcGFyc2VyL3BvcC1hbGwtYWZ0ZXItYWZ0ZXItYm9keS1leHBlY3Rl ZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvcGFyc2VyL3BvcC1hbGwtYWZ0ZXItYWZ0ZXIt Ym9keS5odG1sOiBBZGRlZC4KKwogMjAxMC0xMC0yNyAgS2ludWtvIFlhc3VkYSAgPGtpbnVrb0Bj aHJvbWl1bS5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgdXBkYXRpbmcgZHJ0X2V4cGVjdGF0 aW9ucy50eHQuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9wb3AtYWxsLWFm dGVyLWFmdGVyLWJvZHktZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9wYXJzZXIvcG9w LWFsbC1hZnRlci1hZnRlci1ib2R5LWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NApp bmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi44YjAyYmI4MmUw OWFhMzM3OTMyNDUzOWVmMTExN2E4ZDJjOWU3NGJmCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0 VGVzdHMvZmFzdC9wYXJzZXIvcG9wLWFsbC1hZnRlci1hZnRlci1ib2R5LWV4cGVjdGVkLnR4dApA QCAtMCwwICsxLDIgQEAKK0FMRVJUOiBQQVNTCitsYXN0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9mYXN0L3BhcnNlci9wb3AtYWxsLWFmdGVyLWFmdGVyLWJvZHkuaHRtbCBiL0xheW91dFRlc3Rz L2Zhc3QvcGFyc2VyL3BvcC1hbGwtYWZ0ZXItYWZ0ZXItYm9keS5odG1sCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjJi MTEzMjIzY2NkN2JlYmEyYTAwNWVmOWJjYzJhODIwY2I2YjljM2EKLS0tIC9kZXYvbnVsbAorKysg Yi9MYXlvdXRUZXN0cy9mYXN0L3BhcnNlci9wb3AtYWxsLWFmdGVyLWFmdGVyLWJvZHkuaHRtbApA QCAtMCwwICsxLDE5IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorICA8aGVhZD4KKyAgICA8 bWV0YSBodHRwLWVxdWl2PSJjb250ZW50LXR5cGUiIGNvbnRlbnQ9InRleHQvaHRtbDsgY2hhcnNl dD11dGYtOCIgLz4KKyAgICA8dGl0bGU+bGFzdC1jaGlsZCB0ZXN0PC90aXRsZT4KKyAgICA8c2Ny aXB0PgorICAgIGlmICh3aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91 dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKTsKKworICAgIHdpbmRvdy5vbmxvYWQgPSBmdW5j dGlvbigpIHsKKyAgICAgICAgaWYgKGRvY3VtZW50LnF1ZXJ5U2VsZWN0b3JBbGwoJ2JvZHk+Omxh c3QtY2hpbGQnKS5sZW5ndGggPT0gMSkgeworICAgICAgICAgICAgYWxlcnQoJ1BBU1MnKTsKKyAg ICAgICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGFsZXJ0KCdGQUlMJyk7CisgICAgICAgIH0KKyAg ICB9CisgICAgPC9zY3JpcHQ+CisgIDwvaGVhZD4KKyAgPGJvZHk+PGRpdiBpZD0nbGFzdCc+bGFz dDwvZGl2PjwvYm9keT48L2h0bWw+ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiNDViNjVi YzgyMmZlYjI5NzJjNTUzOTg4ZDMzMWY4MDEwZDIyMmI0Li41MTc3NzU0OGEyYjQ5ODI1ZTBhYTdj YjQ0ODE2YmI1NDc5MzNjZTUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9X ZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDEwLTEwLTI3ICBBZGFtIEJhcnRo ICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgcXVlcnlTZWxlY3RvckFsbCgnYm9keT46bGFzdC1jaGlsZCcpIGRvZXMg bm90IHdvcmsgdW5sZXNzIEhUTUwgZmlsZSBlbmRzIHdpdGggJ25ldy1saW5lJy4KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTY2CisKKyAgICAgICAg V2UgbmVlZCB0byBwb3AgYWxsIHRoZSBvcGVuIGVsZW1lbnRzIHdoZW4gd2UgZW5kIHRoZSBkb2N1 bWVudCBpbiB0aGUKKyAgICAgICAgQWZ0ZXJBZnRlckJvZHkgc3RhdGUuCisKKyAgICAgICAgVGVz dDogZmFzdC9wYXJzZXIvcG9wLWFsbC1hZnRlci1hZnRlci1ib2R5Lmh0bWwKKworICAgICAgICAq IGh0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1M VHJlZUJ1aWxkZXI6OnByb2Nlc3NFbmRPZkZpbGUpOgorCiAyMDEwLTEwLTI3ICBFcmljIFVocmhh bmUgIDxlcmljdUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2 aW4uCmRpZmYgLS1naXQgYS9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAg Yi9XZWJDb3JlL2h0bWwvcGFyc2VyL0hUTUxUcmVlQnVpbGRlci5jcHAKaW5kZXggMzEwZmY2MDEy MTNhYTAwYTFjNDA5ZTRkYTk0ZGYyOTE4MDIwYTgxMC4uYzM4NTQzNzUyNDc3OTMzNDQ2NGZkMzQy MWZiYzdlMTVlOGU5YzMwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MVHJl ZUJ1aWxkZXIuY3BwCisrKyBiL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTFRyZWVCdWlsZGVyLmNw cApAQCAtMjU4MCw3ICsyNTgwLDcgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NFbmRP ZkZpbGUoQXRvbWljSFRNTFRva2VuJiB0b2tlbikKICAgICBjYXNlIEFmdGVyQm9keU1vZGU6CiAg ICAgY2FzZSBBZnRlckFmdGVyQm9keU1vZGU6CiAgICAgICAgIEFTU0VSVChpbnNlcnRpb25Nb2Rl KCkgPT0gQWZ0ZXJCb2R5TW9kZSB8fCBpbnNlcnRpb25Nb2RlKCkgPT0gQWZ0ZXJBZnRlckJvZHlN b2RlKTsKLSAgICAgICAgcmV0dXJuOworICAgICAgICBicmVhazsKICAgICBjYXNlIEluSGVhZE5v c2NyaXB0TW9kZToKICAgICAgICAgQVNTRVJUKGluc2VydGlvbk1vZGUoKSA9PSBJbkhlYWROb3Nj cmlwdE1vZGUpOwogICAgICAgICBkZWZhdWx0Rm9ySW5IZWFkTm9zY3JpcHQoKTsKQEAgLTI2MDIs MTEgKzI2MDIsMTEgQEAgdm9pZCBIVE1MVHJlZUJ1aWxkZXI6OnByb2Nlc3NFbmRPZkZpbGUoQXRv bWljSFRNTFRva2VuJiB0b2tlbikKICAgICBjYXNlIEluQ29sdW1uR3JvdXBNb2RlOgogICAgICAg ICBpZiAobV90cmVlLmN1cnJlbnRFbGVtZW50KCkgPT0gbV90cmVlLm9wZW5FbGVtZW50cygpLT5o dG1sRWxlbWVudCgpKSB7CiAgICAgICAgICAgICBBU1NFUlQoaXNQYXJzaW5nRnJhZ21lbnQoKSk7 Ci0gICAgICAgICAgICByZXR1cm47CisgICAgICAgICAgICByZXR1cm47IC8vIEZJWE1FOiBTaG91 bGQgd2UgYnJlYWsgaGVyZSBpbnN0ZWFkIG9mIHJldHVybmluZz8KICAgICAgICAgfQogICAgICAg ICBpZiAoIXByb2Nlc3NDb2xncm91cEVuZFRhZ0ZvckluQ29sdW1uR3JvdXAoKSkgewogICAgICAg ICAgICAgQVNTRVJUKGlzUGFyc2luZ0ZyYWdtZW50KCkpOwotICAgICAgICAgICAgcmV0dXJuOwor ICAgICAgICAgICAgcmV0dXJuOyAvLyBGSVhNRTogU2hvdWxkIHdlIGJyZWFrIGhlcmUgaW5zdGVh ZCBvZiByZXR1cm5pbmc/CiAgICAgICAgIH0KICAgICAgICAgcHJlcGFyZVRvUmVwcm9jZXNzVG9r ZW4oKTsKICAgICAgICAgcHJvY2Vzc0VuZE9mRmlsZSh0b2tlbik7Cg==