47139 2010-10-04 19:20:29 -0700 Relax restrictions on FileWriter::didWrite calls 2010-10-05 13:29:14 -0700 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) All All RESOLVED FIXED P2 Enhancement --- 44358 1 ericu ericu commit-queue kinuko michaeln oldest_to_newest 289355 0 ericu 2010-10-04 19:20:29 -0700 Currently we ASSERT that we'll always receive bytes in a didWrite call, and that we'll always get complete==true if we've gotten all the bytes in our request. This unnecessarily constrains the implementation: if the backend is just reading from the blob until it runs out, it might send the last bytes without knowing that it's done, then send a zero-length completion message. 289356 1 69731 ericu 2010-10-04 19:31:24 -0700 Created attachment 69731 Patch 289358 2 69731 kinuko 2010-10-04 20:04:05 -0700 Comment on attachment 69731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review > WebCore/fileapi/FileWriter.cpp:97 > + ec = INVALID_ACCESS_ERR; INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR? 289361 3 ericu 2010-10-04 20:14:57 -0700 (In reply to comment #2) > (From update of attachment 69731 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review > > > WebCore/fileapi/FileWriter.cpp:97 > > + ec = INVALID_ACCESS_ERR; > > INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR? It's not really an invalid state; you passed in a bad parameter. Perhaps SYNTAX_ERR? We can always suggest that it go into the spec [which currently doesn't talk about how to respond to a null Blob]. 289368 4 69731 kinuko 2010-10-04 20:35:57 -0700 Comment on attachment 69731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review >>> WebCore/fileapi/FileWriter.cpp:97 >>> + ec = INVALID_ACCESS_ERR; >> >> INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR? > > It's not really an invalid state; you passed in a bad parameter. Perhaps SYNTAX_ERR? We can always suggest that it go into the spec [which currently doesn't talk about how to respond to a null Blob]. If we're given null or undefined where we expect Blob, I think TYPE_MISMATCH_ERR would be applicable. 289373 5 ericu 2010-10-04 20:52:39 -0700 (In reply to comment #4) > (From update of attachment 69731 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=69731&action=review > > >>> WebCore/fileapi/FileWriter.cpp:97 > >>> + ec = INVALID_ACCESS_ERR; > >> > >> INVALID_ACCESS_ERR is not defined as a FileError -- maybe INVALID_STATE_ERR? > > > > It's not really an invalid state; you passed in a bad parameter. Perhaps SYNTAX_ERR? We can always suggest that it go into the spec [which currently doesn't talk about how to respond to a null Blob]. > > If we're given null or undefined where we expect Blob, I think TYPE_MISMATCH_ERR would be applicable. Yeah, that sounds good. I'll change it. 289471 6 69731 levin 2010-10-04 23:56:44 -0700 Comment on attachment 69731 Patch Per discussion in bug. Other than that it seems fine. 289738 7 69807 ericu 2010-10-05 10:42:03 -0700 Created attachment 69807 Patch 289837 8 69807 commit-queue 2010-10-05 13:29:09 -0700 Comment on attachment 69807 Patch Clearing flags on attachment: 69807 Committed r69140: <http://trac.webkit.org/changeset/69140> 289838 9 commit-queue 2010-10-05 13:29:14 -0700 All reviewed patches have been landed. Closing bug. 69731 2010-10-04 19:31:24 -0700 2010-10-05 10:42:00 -0700 Patch bug-47139-20101004193122.patch text/plain 2690 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTA1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTAtMDQgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWxheCByZXN0cmljdGlvbnMgb24gRmlsZVdyaXRlcjo6ZGlkV3JpdGUgY2FsbHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTM5CisKKyAgICAgICAg Tm8gbmV3IHRlc3RzOyB0aGV5J3JlIHN0aWxsIHdhaXRpbmcgb24gdGhlIGZpcnN0IGltcGxlbWVu dGF0aW9uLgorCisgICAgICAgICogZmlsZWFwaS9GaWxlV3JpdGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZpbGVXcml0ZXI6OkZpbGVXcml0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6RmlsZVdy aXRlcjo6d3JpdGUpOgorICAgICAgICAoV2ViQ29yZTo6RmlsZVdyaXRlcjo6ZGlkV3JpdGUpOgor ICAgICAgICAqIGZpbGVhcGkvRmlsZVdyaXRlci5oOgorCiAyMDEwLTEwLTA0ICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogV2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0ZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmNwcAkocmV2aXNpb24gNjg5NTIpCisrKyBX ZWJDb3JlL2ZpbGVhcGkvRmlsZVdyaXRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2 LDcgQEAgRmlsZVdyaXRlcjo6RmlsZVdyaXRlcihTY3JpcHRFeGVjdXRpb25DbwogICAgIDogQWN0 aXZlRE9NT2JqZWN0KGNvbnRleHQsIHRoaXMpCiAgICAgLCBtX3JlYWR5U3RhdGUoSU5JVCkKICAg ICAsIG1fcG9zaXRpb24oMCkKKyAgICAsIG1fc3RhcnRlZFdyaXRpbmcoZmFsc2UpCiAgICAgLCBt X2J5dGVzV3JpdHRlbigwKQogICAgICwgbV9ieXRlc1RvV3JpdGUoMCkKICAgICAsIG1fdHJ1bmNh dGVMZW5ndGgoLTEpCkBAIC05Miw4ICs5MywxNCBAQCB2b2lkIEZpbGVXcml0ZXI6OndyaXRlKEJs b2IqIGRhdGEsIEV4Y2VwCiAgICAgICAgIG1fZXJyb3IgPSBGaWxlRXJyb3I6OmNyZWF0ZShlYyk7 CiAgICAgICAgIHJldHVybjsKICAgICB9CisgICAgaWYgKCFkYXRhKSB7CisgICAgICAgIGVjID0g SU5WQUxJRF9BQ0NFU1NfRVJSOworICAgICAgICBtX2Vycm9yID0gRmlsZUVycm9yOjpjcmVhdGUo ZWMpOworICAgICAgICByZXR1cm47CisgICAgfQogCiAgICAgbV9yZWFkeVN0YXRlID0gV1JJVElO RzsKKyAgICBtX3N0YXJ0ZWRXcml0aW5nID0gZmFsc2U7CiAgICAgbV9ieXRlc1dyaXR0ZW4gPSAw OwogICAgIG1fYnl0ZXNUb1dyaXRlID0gZGF0YS0+c2l6ZSgpOwogICAgIG1fd3JpdGVyLT53cml0 ZShtX3Bvc2l0aW9uLCBkYXRhKTsKQEAgLTE0OSwxMyArMTU2LDE0IEBAIHZvaWQgRmlsZVdyaXRl cjo6YWJvcnQoRXhjZXB0aW9uQ29kZSYgZWMKIAogdm9pZCBGaWxlV3JpdGVyOjpkaWRXcml0ZShs b25nIGxvbmcgYnl0ZXMsIGJvb2wgY29tcGxldGUpCiB7Ci0gICAgQVNTRVJUKGJ5dGVzID4gMCk7 CiAgICAgQVNTRVJUKGJ5dGVzICsgbV9ieXRlc1dyaXR0ZW4gPiAwKTsKICAgICBBU1NFUlQoYnl0 ZXMgKyBtX2J5dGVzV3JpdHRlbiA8PSBtX2J5dGVzVG9Xcml0ZSk7Ci0gICAgaWYgKCFtX2J5dGVz V3JpdHRlbikKKyAgICBpZiAoIW1fc3RhcnRlZFdyaXRpbmcpIHsKICAgICAgICAgZmlyZUV2ZW50 KGV2ZW50TmFtZXMoKS53cml0ZXN0YXJ0RXZlbnQpOworICAgICAgICBtX3N0YXJ0ZWRXcml0aW5n ID0gdHJ1ZTsKKyAgICB9CiAgICAgbV9ieXRlc1dyaXR0ZW4gKz0gYnl0ZXM7Ci0gICAgQVNTRVJU KChtX2J5dGVzV3JpdHRlbiA9PSBtX2J5dGVzVG9Xcml0ZSkgPT0gY29tcGxldGUpOworICAgIEFT U0VSVCgobV9ieXRlc1dyaXR0ZW4gPT0gbV9ieXRlc1RvV3JpdGUpIHx8ICFjb21wbGV0ZSk7CiAg ICAgbV9wb3NpdGlvbiArPSBieXRlczsKICAgICBpZiAobV9wb3NpdGlvbiA+IG1fbGVuZ3RoKQog ICAgICAgICBtX2xlbmd0aCA9IG1fcG9zaXRpb247CkluZGV4OiBXZWJDb3JlL2ZpbGVhcGkvRmls ZVdyaXRlci5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmgJKHJl dmlzaW9uIDY4OTUyKQorKysgV2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0ZXIuaAkod29ya2luZyBj b3B5KQpAQCAtMTE5LDYgKzExOSw3IEBAIHByaXZhdGU6CiAgICAgUmVhZHlTdGF0ZSBtX3JlYWR5 U3RhdGU7CiAgICAgbG9uZyBsb25nIG1fcG9zaXRpb247CiAgICAgbG9uZyBsb25nIG1fbGVuZ3Ro OworICAgIGJvb2wgbV9zdGFydGVkV3JpdGluZzsKICAgICBsb25nIGxvbmcgbV9ieXRlc1dyaXR0 ZW47CiAgICAgbG9uZyBsb25nIG1fYnl0ZXNUb1dyaXRlOwogICAgIGxvbmcgbG9uZyBtX3RydW5j YXRlTGVuZ3RoOwo= 69807 2010-10-05 10:42:03 -0700 2010-10-05 13:29:08 -0700 Patch bug-47139-20101005104202.patch text/plain 2689 ericu SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2OTA1NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTggQEAKKzIwMTAtMTAtMDQgIEVyaWMgVWhyaGFuZSAgPGVyaWN1QGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBS ZWxheCByZXN0cmljdGlvbnMgb24gRmlsZVdyaXRlcjo6ZGlkV3JpdGUgY2FsbHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTM5CisKKyAgICAgICAg Tm8gbmV3IHRlc3RzOyB0aGV5J3JlIHN0aWxsIHdhaXRpbmcgb24gdGhlIGZpcnN0IGltcGxlbWVu dGF0aW9uLgorCisgICAgICAgICogZmlsZWFwaS9GaWxlV3JpdGVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZpbGVXcml0ZXI6OkZpbGVXcml0ZXIpOgorICAgICAgICAoV2ViQ29yZTo6RmlsZVdy aXRlcjo6d3JpdGUpOgorICAgICAgICAoV2ViQ29yZTo6RmlsZVdyaXRlcjo6ZGlkV3JpdGUpOgor ICAgICAgICAqIGZpbGVhcGkvRmlsZVdyaXRlci5oOgorCiAyMDEwLTEwLTA0ICBTaW1vbiBGcmFz ZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmlu IEFkbGVyLgpJbmRleDogV2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0ZXIuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvZmlsZWFwaS9GaWxlV3JpdGVyLmNwcAkocmV2aXNpb24gNjg5NTIpCisrKyBX ZWJDb3JlL2ZpbGVhcGkvRmlsZVdyaXRlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQ2LDYgKzQ2 LDcgQEAgRmlsZVdyaXRlcjo6RmlsZVdyaXRlcihTY3JpcHRFeGVjdXRpb25DbwogICAgIDogQWN0 aXZlRE9NT2JqZWN0KGNvbnRleHQsIHRoaXMpCiAgICAgLCBtX3JlYWR5U3RhdGUoSU5JVCkKICAg ICAsIG1fcG9zaXRpb24oMCkKKyAgICAsIG1fc3RhcnRlZFdyaXRpbmcoZmFsc2UpCiAgICAgLCBt X2J5dGVzV3JpdHRlbigwKQogICAgICwgbV9ieXRlc1RvV3JpdGUoMCkKICAgICAsIG1fdHJ1bmNh dGVMZW5ndGgoLTEpCkBAIC05Miw4ICs5MywxNCBAQCB2b2lkIEZpbGVXcml0ZXI6OndyaXRlKEJs b2IqIGRhdGEsIEV4Y2VwCiAgICAgICAgIG1fZXJyb3IgPSBGaWxlRXJyb3I6OmNyZWF0ZShlYyk7 CiAgICAgICAgIHJldHVybjsKICAgICB9CisgICAgaWYgKCFkYXRhKSB7CisgICAgICAgIGVjID0g VFlQRV9NSVNNQVRDSF9FUlI7CisgICAgICAgIG1fZXJyb3IgPSBGaWxlRXJyb3I6OmNyZWF0ZShl Yyk7CisgICAgICAgIHJldHVybjsKKyAgICB9CiAKICAgICBtX3JlYWR5U3RhdGUgPSBXUklUSU5H OworICAgIG1fc3RhcnRlZFdyaXRpbmcgPSBmYWxzZTsKICAgICBtX2J5dGVzV3JpdHRlbiA9IDA7 CiAgICAgbV9ieXRlc1RvV3JpdGUgPSBkYXRhLT5zaXplKCk7CiAgICAgbV93cml0ZXItPndyaXRl KG1fcG9zaXRpb24sIGRhdGEpOwpAQCAtMTQ5LDEzICsxNTYsMTQgQEAgdm9pZCBGaWxlV3JpdGVy OjphYm9ydChFeGNlcHRpb25Db2RlJiBlYwogCiB2b2lkIEZpbGVXcml0ZXI6OmRpZFdyaXRlKGxv bmcgbG9uZyBieXRlcywgYm9vbCBjb21wbGV0ZSkKIHsKLSAgICBBU1NFUlQoYnl0ZXMgPiAwKTsK ICAgICBBU1NFUlQoYnl0ZXMgKyBtX2J5dGVzV3JpdHRlbiA+IDApOwogICAgIEFTU0VSVChieXRl cyArIG1fYnl0ZXNXcml0dGVuIDw9IG1fYnl0ZXNUb1dyaXRlKTsKLSAgICBpZiAoIW1fYnl0ZXNX cml0dGVuKQorICAgIGlmICghbV9zdGFydGVkV3JpdGluZykgewogICAgICAgICBmaXJlRXZlbnQo ZXZlbnROYW1lcygpLndyaXRlc3RhcnRFdmVudCk7CisgICAgICAgIG1fc3RhcnRlZFdyaXRpbmcg PSB0cnVlOworICAgIH0KICAgICBtX2J5dGVzV3JpdHRlbiArPSBieXRlczsKLSAgICBBU1NFUlQo KG1fYnl0ZXNXcml0dGVuID09IG1fYnl0ZXNUb1dyaXRlKSA9PSBjb21wbGV0ZSk7CisgICAgQVNT RVJUKChtX2J5dGVzV3JpdHRlbiA9PSBtX2J5dGVzVG9Xcml0ZSkgfHwgIWNvbXBsZXRlKTsKICAg ICBtX3Bvc2l0aW9uICs9IGJ5dGVzOwogICAgIGlmIChtX3Bvc2l0aW9uID4gbV9sZW5ndGgpCiAg ICAgICAgIG1fbGVuZ3RoID0gbV9wb3NpdGlvbjsKSW5kZXg6IFdlYkNvcmUvZmlsZWFwaS9GaWxl V3JpdGVyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9maWxlYXBpL0ZpbGVXcml0ZXIuaAkocmV2 aXNpb24gNjg5NTIpCisrKyBXZWJDb3JlL2ZpbGVhcGkvRmlsZVdyaXRlci5oCSh3b3JraW5nIGNv cHkpCkBAIC0xMTksNiArMTE5LDcgQEAgcHJpdmF0ZToKICAgICBSZWFkeVN0YXRlIG1fcmVhZHlT dGF0ZTsKICAgICBsb25nIGxvbmcgbV9wb3NpdGlvbjsKICAgICBsb25nIGxvbmcgbV9sZW5ndGg7 CisgICAgYm9vbCBtX3N0YXJ0ZWRXcml0aW5nOwogICAgIGxvbmcgbG9uZyBtX2J5dGVzV3JpdHRl bjsKICAgICBsb25nIGxvbmcgbV9ieXRlc1RvV3JpdGU7CiAgICAgbG9uZyBsb25nIG1fdHJ1bmNh dGVMZW5ndGg7Cg==