47137 2010-10-04 18:20:06 -0700 Notification onclick() events don't act like user gestures 2010-10-05 13:41:34 -0700 1 1 1 Unclassified WebKit WebCore JavaScript 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 atwilson atwilson commit-queue johnnyg yael oldest_to_newest 289337 0 atwilson 2010-10-04 18:20:06 -0700 I am trying to focus a window in the onclick handler for a notification, but it fails because WebKit doesn't think notification.onclick is a user gesture. The problem is that Event::fromUserGesture() is returning false because UserGestureIndicator::processingUserGesture() is returning false. I think the fix is to add a line like this to WebNotification::dispatchClickEvent(): UserGestureIndicator gestureIndicator(DefinitelyProcessingUserGesture); I have a patch locally that does this which I'll try out tomorrow. I can make this change for the qt client also - is there any place else I need to touch? 289672 1 69799 atwilson 2010-10-05 09:45:57 -0700 Created attachment 69799 Updated chromium and qt notification implementations to mark click events as user gestures. 289699 2 yael 2010-10-05 10:10:20 -0700 Thank you for fixing it for Qt. Looks good to me (but I am not a reviewer :-) 289713 3 johnnyg 2010-10-05 10:19:49 -0700 Patch looks good for chromium too (also not a reviewer). 289835 4 69799 kling 2010-10-05 13:21:11 -0700 Comment on attachment 69799 Updated chromium and qt notification implementations to mark click events as user gestures. LGTM, too. Thanks Yael and John! 289850 5 69799 commit-queue 2010-10-05 13:41:29 -0700 Comment on attachment 69799 Updated chromium and qt notification implementations to mark click events as user gestures. Clearing flags on attachment: 69799 Committed r69143: <http://trac.webkit.org/changeset/69143> 289851 6 commit-queue 2010-10-05 13:41:34 -0700 All reviewed patches have been landed. Closing bug. 69799 2010-10-05 09:45:57 -0700 2010-10-05 13:41:29 -0700 Updated chromium and qt notification implementations to mark click events as user gestures. diffs text/plain 3273 atwilson ZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0v Q2hhbmdlTG9nCmluZGV4IDQ0MDIyOTMuLjliYmRkZDggMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsx LDE0IEBACisyMDEwLTEwLTA1ICBBbmRyZXcgV2lsc29uICA8YXR3aWxzb25AY2hyb21pdW0ub3Jn PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vdGlm aWNhdGlvbiBvbmNsaWNrKCkgZXZlbnRzIGRvbid0IGFjdCBsaWtlIHVzZXIgZ2VzdHVyZXMKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTQ3MTM3CisKKyAg ICAgICAgKiBzcmMvV2ViTm90aWZpY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViTm90 aWZpY2F0aW9uOjpkaXNwYXRjaENsaWNrRXZlbnQpOgorICAgICAgICBVc2UgVXNlckdlc3R1cmVJ bmRpY2F0b3IgdG8gbWFrZSBzdXJlIGNsaWNrIGV2ZW50cyBhcmUgdHJlYXRlZCBsaWtlIHVzZXIg Z2VzdHVyZXMuCisKIDIwMTAtMTAtMDEgIFZpY3RvcmlhIEtpcnN0ICA8dnJrQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgSmFtZXMgUm9iaW5zb24uCmRpZmYgLS1naXQgYS9XZWJL aXQvY2hyb21pdW0vc3JjL1dlYk5vdGlmaWNhdGlvbi5jcHAgYi9XZWJLaXQvY2hyb21pdW0vc3Jj L1dlYk5vdGlmaWNhdGlvbi5jcHAKaW5kZXggYmZjMWJlYy4uYzNiMWY1MSAxMDA2NDQKLS0tIGEv V2ViS2l0L2Nocm9taXVtL3NyYy9XZWJOb3RpZmljYXRpb24uY3BwCisrKyBiL1dlYktpdC9jaHJv bWl1bS9zcmMvV2ViTm90aWZpY2F0aW9uLmNwcApAQCAtMzQsNiArMzQsNyBAQAogI2lmIEVOQUJM RShOT1RJRklDQVRJT05TKQogCiAjaW5jbHVkZSAiTm90aWZpY2F0aW9uLmgiCisjaW5jbHVkZSAi VXNlckdlc3R1cmVJbmRpY2F0b3IuaCIKIAogI2luY2x1ZGUgIldlYlN0cmluZy5oIgogI2luY2x1 ZGUgIldlYlRleHREaXJlY3Rpb24uaCIKQEAgLTE0MCw2ICsxNDEsOCBAQCB2b2lkIFdlYk5vdGlm aWNhdGlvbjo6ZGlzcGF0Y2hDbG9zZUV2ZW50KGJvb2wgLyogYnlVc2VyICovKQogCiB2b2lkIFdl Yk5vdGlmaWNhdGlvbjo6ZGlzcGF0Y2hDbGlja0V2ZW50KCkKIHsKKyAgICAvLyBNYWtlIHN1cmUg Y2xpY2tzIG9uIG5vdGlmaWNhdGlvbnMgYXJlIHRyZWF0ZWQgYXMgdXNlciBnZXN0dXJlcy4KKyAg ICBVc2VyR2VzdHVyZUluZGljYXRvciBnZXN0dXJlSW5kaWNhdG9yKERlZmluaXRlbHlQcm9jZXNz aW5nVXNlckdlc3R1cmUpOwogICAgIFJlZlB0cjxFdmVudD4gZXZlbnQgPSBFdmVudDo6Y3JlYXRl KGV2ZW50TmFtZXMoKS5jbGlja0V2ZW50LCBmYWxzZSwgdHJ1ZSk7CiAgICAgbV9wcml2YXRlLT5k aXNwYXRjaEV2ZW50KGV2ZW50LnJlbGVhc2UoKSk7CiB9CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQv Q2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRleCBjZWJmZGMzLi5hYzE5NzNlIDEw MDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxNCBAQAorMjAxMC0xMC0wNSAgQW5kcmV3IFdpbHNvbiAgPGF0d2lsc29uQGNo cm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBOb3RpZmljYXRpb24gb25jbGljaygpIGV2ZW50cyBkb24ndCBhY3QgbGlrZSB1c2VyIGdl c3R1cmVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD00 NzEzNworCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xp ZW50UXQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Tm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50 UXQ6Om5vdGlmaWNhdGlvbkNsaWNrZWQpOgorICAgICAgICBVc2UgVXNlckdlc3R1cmVJbmRpY2F0 b3IgdG8gbWFrZSBzdXJlIGNsaWNrIGV2ZW50cyBhcmUgdHJlYXRlZCBsaWtlIHVzZXIgZ2VzdHVy ZXMuCisKIDIwMTAtMDktMjggIEx1aXogQWdvc3RpbmkgIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgS2VubmV0aCBSb2hkZSBDaHJpc3RpYW5zZW4u CmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2Vu dGVyQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L05vdGlmaWNhdGlvblBy ZXNlbnRlckNsaWVudFF0LmNwcAppbmRleCA3YjMzZDllLi4wMzI0YzBkIDEwMDY0NAotLS0gYS9X ZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50UXQuY3Bw CisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9Ob3RpZmljYXRpb25QcmVzZW50ZXJDbGll bnRRdC5jcHAKQEAgLTQwLDYgKzQwLDcgQEAKICNpbmNsdWRlICJRdFBsYXRmb3JtUGx1Z2luLmgi CiAjaW5jbHVkZSAiU2NyaXB0RXhlY3V0aW9uQ29udGV4dC5oIgogI2luY2x1ZGUgIlNlY3VyaXR5 T3JpZ2luLmgiCisjaW5jbHVkZSAiVXNlckdlc3R1cmVJbmRpY2F0b3IuaCIKIAogI2luY2x1ZGUg InF3ZWJmcmFtZV9wLmgiCiAjaW5jbHVkZSAicXdlYmtpdGdsb2JhbC5oIgpAQCAtMjYyLDggKzI2 MywxMSBAQCB2b2lkIE5vdGlmaWNhdGlvblByZXNlbnRlckNsaWVudFF0OjpjYW5jZWwoTm90aWZp Y2F0aW9uV3JhcHBlciogd3JhcHBlcikKIHZvaWQgTm90aWZpY2F0aW9uUHJlc2VudGVyQ2xpZW50 UXQ6Om5vdGlmaWNhdGlvbkNsaWNrZWQoTm90aWZpY2F0aW9uV3JhcHBlciogd3JhcHBlcikKIHsK ICAgICBOb3RpZmljYXRpb24qIG5vdGlmaWNhdGlvbiA9ICBub3RpZmljYXRpb25Gb3JXcmFwcGVy KHdyYXBwZXIpOwotICAgIGlmIChub3RpZmljYXRpb24pCisgICAgaWYgKG5vdGlmaWNhdGlvbikg eworICAgICAgICAvLyBNYWtlIHN1cmUgY2xpY2tzIG9uIG5vdGlmaWNhdGlvbnMgYXJlIHRyZWF0 ZWQgYXMgdXNlciBnZXN0dXJlcy4KKyAgICAgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgZ2VzdHVy ZUluZGljYXRvcihEZWZpbml0ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlKTsKICAgICAgICAgc2Vu ZEV2ZW50KG5vdGlmaWNhdGlvbiwgZXZlbnROYW1lcygpLmNsaWNrRXZlbnQpOworICAgIH0KIH0K IAogdm9pZCBOb3RpZmljYXRpb25QcmVzZW50ZXJDbGllbnRRdDo6bm90aWZpY2F0aW9uQ2xpY2tl ZChjb25zdCBRU3RyaW5nJiB0aXRsZSkK